Re: [PATCH 4/7] drm/i915: Add timeline barrier support

Chris Wilson
2018-12-14T13:26:42Z

Quoting Tvrtko Ursulin (2018-12-14 12:34:46)
> diff --git a/drivers/gpu/drm/i915/i915_timeline.h b/drivers/gpu/drm/i915/i915_timeline.h
> index ebd71b487220..6ee301f20bab 100644
> --- a/drivers/gpu/drm/i915/i915_timeline.h
> +++ b/drivers/gpu/drm/i915/i915_timeline.h
> @@ -72,6 +72,16 @@ struct i915_timeline {
> */
> u32 global_sync[I915_NUM_ENGINES];
>
> + /**
> + * Barrier provides the ability to serialize ordering between different
> + * timelines.
> + *
> + * Users can call i915_timeline_set_barrier which will make all
> + * subsequent submissions be executed only after this barrier has been

submissions on/to this timeline
then s/this barrier/the barrier/ to avoid repitation of this.

> + * completed.
> + */
> + struct i915_gem_active barrier;
-Chris