✗ Fi.CI.CHECKPATCH: warning for Per context dynamic (sub)slice power-gating (rev10)

Patchwork
2019-01-08T13:33:39Z

== Series Details ==

Series: Per context dynamic (sub)slice power-gating (rev10)
URL : https://patchwork.freedesktop.org/series/48194/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
a76b08127cd7 drm/i915/execlists: Move RPCS setup to context pin
db8cb3bf4b10 drm/i915: Record the sseu configuration per-context & engine
266745f8b96a drm/i915/perf: lock powergating configuration to default when active
6bd9facb9663 drm/i915: Add timeline barrier support
993439fa7f8f drm/i915: Expose RPCS (SSEU) configuration to userspace (Gen11 only)
-:47: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#47:
v2: Fix offset of CTX_R_PWR_CLK_STATE in intel_lr_context_set_sseu() (Lionel)

-:505: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'user->min_eus_per_subslice !=
device->max_eus_per_subslice'
#505: FILE: drivers/gpu/drm/i915/i915_gem_context.c:1171:
+ if ((user->min_eus_per_subslice !=
+ device->max_eus_per_subslice) ||
+ (user->max_eus_per_subslice !=
+ device->max_eus_per_subslice))

-:505: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'user->max_eus_per_subslice !=
device->max_eus_per_subslice'
#505: FILE: drivers/gpu/drm/i915/i915_gem_context.c:1171:
+ if ((user->min_eus_per_subslice !=
+ device->max_eus_per_subslice) ||
+ (user->max_eus_per_subslice !=
+ device->max_eus_per_subslice))

total: 0 errors, 1 warnings, 2 checks, 479 lines checked
c3be906d1b25 drm/i915/icl: Support co-existence between per-context SSEU and OA
ee9008e736df drm/i915/selftests: Context SSEU reconfiguration tests
-:226: WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#226: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:784:
+int

-:408: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#408: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:966:
+ return -EINVAL;
+ } else {

-:415: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#415: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:973:
+
+}

total: 0 errors, 2 warnings, 1 checks, 555 lines checked