From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v5 07/20] drm/dp_mst: Restart last_connected_port_and_mstb() if topology ref fails Date: Thu, 10 Jan 2019 10:16:30 +0100 Message-ID: <20190110091630.GD21184@phenom.ffwll.local> References: <20190109003516.14752-1-lyude@redhat.com> <20190109003516.14752-8-lyude@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190109003516.14752-8-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Nouveau" To: Lyude Paul Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Jerry Zuo , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Daniel Vetter , David Airlie , Harry Wentland , Juston Li List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBKYW4gMDgsIDIwMTkgYXQgMDc6MzU6MDRQTSAtMDUwMCwgTHl1ZGUgUGF1bCB3cm90 ZToKPiBXaGlsZSB0aGlzIGlzbid0IGEgY29tcGxldGUgZml4LCB0aGlzIHdpbGwgaW1wcm92ZSB0 aGUgcmVsaWFiaWxpdHkgb2YKPiBkcm1fZHBfZ2V0X2xhc3RfY29ubmVjdGVkX3BvcnRfYW5kX21z dGIoKSBwcmV0dHkgc2lnbmlmaWNhbnRseSBkdXJpbmcKPiBob3RwbHVnIGV2ZW50cywgc2luY2Ug dGhlcmUncyBhIGNoYW5jZSB0aGF0IHRoZSBpbi1tZW1vcnkgdG9wb2xvZ3kgdHJlZQo+IG1heSBu b3QgYmUgZnVsbHkgdXBkYXRlZCB3aGVuIGRybV9kcF9nZXRfbGFzdF9jb25uZWN0ZWRfcG9ydF9h bmRfbXN0YigpCj4gaXMgY2FsbGVkIGFuZCB0aHVzIG1pZ2h0IGVuZCB1cCBjYXVzaW5nIG91ciBz ZWFyY2ggdG8gZmFpbCBvbiBhbiBtc3RiCj4gd2hvc2UgdG9wb2xvZ3kgcmVmY291bnQgaGFzIHJl YWNoZWQgMCwgYnV0IGhhcyBub3QgeWV0IGJlZW4gcmVtb3ZlZCBmcm9tCj4gaXQncyBwYXJlbnQu Cj4gCj4gSWRlYWxseSwgd2Ugc2hvdWxkIGZ1cnRoZXIgZml4IHRoaXMgcHJvYmxlbSBieSBlbnN1 cmluZyB0aGF0IHdlIGRlYWwKPiB3aXRoIHRoZSBwb3RlbnRpYWwgZm9yIHJhY2luZyB3aXRoIGEg aG90cGx1ZyBldmVudCwgd2hpY2ggd291bGQgbG9vawo+IGxpa2UgdGhpczoKPiAKPiAqIGRybV9k cF9wYXlsb2FkX3NlbmRfbXNnKCkgcmV0cmlldmVzIHRoZSBsYXN0IGxpdmluZyByZWxhdGl2ZSBv ZiBtc3RiCj4gICB3aXRoIGRybV9kcF9nZXRfbGFzdF9jb25uZWN0ZWRfcG9ydF9hbmRfbXN0Yigp Cj4gKiBkcm1fZHBfcGF5bG9hZF9zZW5kX21zZygpIHN0YXJ0cyBidWlsZGluZyBwYXlsb2FkIG1l c3NhZ2UKPiAgIEF0IHRoZSBzYW1lIHRpbWUsIG1zdGIgZ2V0cyB1bnBsdWdnZWQgZnJvbSB0aGUg dG9wb2xvZ3kgYW5kIGlzIG5vCj4gICBsb25nZXIgdGhlIGFjdHVhbCBsYXN0IGxpdmluZyByZWxh dGl2ZSBvZiB0aGUgb3JpZ2luYWwgbXN0Ygo+ICogZHJtX2RwX3BheWxvYWRfc2VuZF9tc2coKSB0 cmllcyBzZW5kaW5nIHRoZSBwYXlsb2FkIG1lc3NhZ2UsIGh1YiB0aW1lcwo+ICAgb3V0Cj4gKiBI dWIgdGltZWQgb3V0LCB3ZSBnaXZlIHVwIGFuZCBydW4gYXdheS1yZXN1bHRpbmcgaW4gdGhlIHBh eWxvYWQgYmVpbmcKPiAgIGxlYWtlZAo+IAo+IFRoaXMgY291bGQgYmUgZml4ZWQgYnkgcmVzdGFy dGluZyB0aGUKPiBkcm1fZHBfZ2V0X2xhc3RfY29ubmVjdGVkX3BvcnRfYW5kX21zdGIoKSBzZWFy Y2ggd2hlbmV2ZXIgd2UgZ2V0IGEKPiB0aW1lb3V0LCBzZW5kaW5nIHRoZSBwYXlsb2FkIHRvIHRo ZSBuZXcgbXN0YiwgdGhlbiByZXBlYXRpbmcgdW50aWwKPiBlaXRoZXIgdGhlIGVudGlyZSB0b3Bv bG9neSBpcyByZW1vdmVkIGZyb20gdGhlIHN5c3RlbSBvcgo+IGRybV9kcF9nZXRfbGFzdF9jb25u ZWN0ZWRfcG9ydF9hbmRfbXN0YigpIGZhaWxzLiBCdXQgc2luY2UgdGhlIGFib3ZlCj4gcmFjZSBj b25kaXRpb24gaXMgbm90IHRlcnJpYmx5IGxpa2VseSwgd2UnbGwgYWRkcmVzcyB0aGF0IGluIGEg bGF0ZXIKPiBwYXRjaCBzZXJpZXMgb25jZSB3ZSd2ZSBpbXByb3ZlZCB0aGUgcmVjb3ZlcnkgaGFu ZGxpbmcgZm9yIFZDUEkKPiBhbGxvY2F0aW9ucyBpbiB0aGUgcmVzdCBvZiB0aGUgRFAgTVNUIGhl bHBlcnMuCj4gCj4gU2lnbmVkLW9mZi1ieTogTHl1ZGUgUGF1bCA8bHl1ZGVAcmVkaGF0LmNvbT4K PiBSZXZpZXdlZC1ieTogSGFycnkgV2VudGxhbmQgPGhhcnJ5LndlbnRsYW5kQGFtZC5jb20+Cj4g Q2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbEBmZndsbC5jaD4KPiBDYzogRGF2aWQgQWlybGllIDxh aXJsaWVkQHJlZGhhdC5jb20+Cj4gQ2M6IEplcnJ5IFp1byA8SmVycnkuWnVvQGFtZC5jb20+Cj4g Q2M6IEp1c3RvbiBMaSA8anVzdG9uLmxpQGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUv ZHJtL2RybV9kcF9tc3RfdG9wb2xvZ3kuYyB8IDU0ICsrKysrKysrKysrKysrKysrKysrKystLS0t LQo+ICAxIGZpbGUgY2hhbmdlZCwgNDQgaW5zZXJ0aW9ucygrKSwgMTAgZGVsZXRpb25zKC0pCj4g Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZHBfbXN0X3RvcG9sb2d5LmMgYi9k cml2ZXJzL2dwdS9kcm0vZHJtX2RwX21zdF90b3BvbG9neS5jCj4gaW5kZXggYzUzY2Y3ZWIxZGJj Li5iYWZjODVmMDg2MDYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9kcF9tc3Rf dG9wb2xvZ3kuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZHBfbXN0X3RvcG9sb2d5LmMK PiBAQCAtMjA0NywyNCArMjA0Nyw1MCBAQCBzdGF0aWMgc3RydWN0IGRybV9kcF9tc3RfcG9ydCAq ZHJtX2RwX2dldF9sYXN0X2Nvbm5lY3RlZF9wb3J0X3RvX21zdGIoc3RydWN0IGRybQo+ICAJcmV0 dXJuIGRybV9kcF9nZXRfbGFzdF9jb25uZWN0ZWRfcG9ydF90b19tc3RiKG1zdGItPnBvcnRfcGFy ZW50LT5wYXJlbnQpOwo+ICB9Cj4gIAo+IC1zdGF0aWMgc3RydWN0IGRybV9kcF9tc3RfYnJhbmNo ICpkcm1fZHBfZ2V0X2xhc3RfY29ubmVjdGVkX3BvcnRfYW5kX21zdGIoc3RydWN0IGRybV9kcF9t c3RfdG9wb2xvZ3lfbWdyICptZ3IsCj4gLQkJCQkJCQkJCSBzdHJ1Y3QgZHJtX2RwX21zdF9icmFu Y2ggKm1zdGIsCj4gLQkJCQkJCQkJCSBpbnQgKnBvcnRfbnVtKQo+ICsvKioKPiArICogZHJtX2Rw X2dldF9sYXN0X2Nvbm5lY3RlZF9wb3J0X2FuZF9tc3RiKCkgLSBGaW5kIHRoZSBsYXN0IGxpdmlu ZyByZWxhdGl2ZXMKPiArICogaW4gYSB0b3BvbG9neSBvZiBhIGdpdmVuIGJyYW5jaCBkZXZpY2UK PiArICogQG1ncjogVGhlIHRvcG9sb2d5IG1hbmFnZXIgdG8gdXNlCj4gKyAqIEBtc3RiOiBUaGUg ZGlzY29ubmVjdGVkIGJyYW5jaCBkZXZpY2UKPiArICogQHBvcnRfbnVtOiBXaGVyZSB0byBzdG9y ZSB0aGUgbnVtYmVyIG9mIHRoZSBsYXN0IGNvbm5lY3RlZCBwb3J0Cj4gKyAqCj4gKyAqIFNlYXJj aGVzIHVwd2FyZHMgaW4gdGhlIHRvcG9sb2d5IHN0YXJ0aW5nIGZyb20gQG1zdGIgdG8gdHJ5IHRv IGZpbmQgdGhlCj4gKyAqIGNsb3Nlc3QgYXZhaWxhYmxlIHBhcmVudCBvZiBAbXN0YiB0aGF0J3Mg c3RpbGwgY29ubmVjdGVkIHRvIHRoZSByZXN0IG9mIHRoZQo+ICsgKiB0b3BvbG9neS4gVGhpcyBj YW4gYmUgdXNlZCBpbiBvcmRlciB0byBwZXJmb3JtIG9wZXJhdGlvbnMgbGlrZSByZWxlYXNpbmcK PiArICogcGF5bG9hZHMsIHdoZXJlIHRoZSBicmFuY2ggZGV2aWNlIHdoaWNoIG93bmVkIHRoZSBw YXlsb2FkIG1heSBubyBsb25nZXIgYmUKPiArICogYXJvdW5kIGFuZCB0aHVzIHdvdWxkIHJlcXVp cmUgdGhhdCB0aGUgcGF5bG9hZCBvbiB0aGUgbGFzdCBsaXZpbmcgcmVsYXRpdmUKPiArICogYmUg ZnJlZWQgaW5zdGVhZC4KPiArICoKPiArICogUmV0dXJuczoKPiArICogVGhlIGxhc3QgY29ubmVj dGVkICZkcm1fZHBfbXN0X2JyYW5jaCBpbiB0aGUgdG9wb2xvZ3kgdGhhdCB3YXMgYSBwYXJlbnQg b2YKPiArICogQG1zdGIsIGlmIHRoZXJlIGlzIG9uZS4KPiArICovCgpTaW5jZSB0aGlzIGlzIGFu IGludGVybmFsIGZ1bmN0aW9uIGFuZCB3ZSBkb24ndCBwdWxsIGl0IGludG8gdGhlIGtlcm5lbGRv Ywp0aGVyZSdzIGEgZ29vZCBjaGFuY2UgdGhlIGRldGFpbHMgd2lsbCBiaXRyb3QgKHNpbmNlIDBk YXkgd29uJ3Qgc3BvdCB3aGVuCmUuZy4gdGhlIGFyZ3VtZW50cyBjaGFuZ2UpLiBJdCdkIGp1c3Qg a2VlcCBhIHNtYWxsIGV4cGxhaW5pbmcgd2h5IHdlIG5lZWQKdG8gZG8gdGhpcyBhbmQgZHJvcCB0 aGUgb3RoZXIgYml0cy4gRWl0aGVyIHdheToKClJldmlld2VkLWJ5OiBEYW5pZWwgVmV0dGVyIDxk YW5pZWwudmV0dGVyQGZmd2xsLmNoPgoKCj4gK3N0YXRpYyBzdHJ1Y3QgZHJtX2RwX21zdF9icmFu Y2ggKgo+ICtkcm1fZHBfZ2V0X2xhc3RfY29ubmVjdGVkX3BvcnRfYW5kX21zdGIoc3RydWN0IGRy bV9kcF9tc3RfdG9wb2xvZ3lfbWdyICptZ3IsCj4gKwkJCQkJc3RydWN0IGRybV9kcF9tc3RfYnJh bmNoICptc3RiLAo+ICsJCQkJCWludCAqcG9ydF9udW0pCj4gIHsKPiAgCXN0cnVjdCBkcm1fZHBf bXN0X2JyYW5jaCAqcm1zdGIgPSBOVUxMOwo+ICAJc3RydWN0IGRybV9kcF9tc3RfcG9ydCAqZm91 bmRfcG9ydDsKPiArCj4gIAltdXRleF9sb2NrKCZtZ3ItPmxvY2spOwo+IC0JaWYgKG1nci0+bXN0 X3ByaW1hcnkpIHsKPiArCWlmICghbWdyLT5tc3RfcHJpbWFyeSkKPiArCQlnb3RvIG91dDsKPiAr Cj4gKwlkbyB7Cj4gIAkJZm91bmRfcG9ydCA9IGRybV9kcF9nZXRfbGFzdF9jb25uZWN0ZWRfcG9y dF90b19tc3RiKG1zdGIpOwo+ICsJCWlmICghZm91bmRfcG9ydCkKPiArCQkJYnJlYWs7Cj4gIAo+ IC0JCWlmIChmb3VuZF9wb3J0KSB7Cj4gKwkJaWYgKGRybV9kcF9tc3RfdG9wb2xvZ3lfdHJ5X2dl dF9tc3RiKGZvdW5kX3BvcnQtPnBhcmVudCkpIHsKPiAgCQkJcm1zdGIgPSBmb3VuZF9wb3J0LT5w YXJlbnQ7Cj4gLQkJCWlmIChkcm1fZHBfbXN0X3RvcG9sb2d5X3RyeV9nZXRfbXN0YihybXN0Yikp Cj4gLQkJCQkqcG9ydF9udW0gPSBmb3VuZF9wb3J0LT5wb3J0X251bTsKPiAtCQkJZWxzZQo+IC0J CQkJcm1zdGIgPSBOVUxMOwo+ICsJCQkqcG9ydF9udW0gPSBmb3VuZF9wb3J0LT5wb3J0X251bTsK PiArCQl9IGVsc2Ugewo+ICsJCQkvKiBTZWFyY2ggYWdhaW4sIHN0YXJ0aW5nIGZyb20gdGhpcyBw YXJlbnQgKi8KPiArCQkJbXN0YiA9IGZvdW5kX3BvcnQtPnBhcmVudDsKPiAgCQl9Cj4gLQl9Cj4g Kwl9IHdoaWxlICghcm1zdGIpOwo+ICtvdXQ6Cj4gIAltdXRleF91bmxvY2soJm1nci0+bG9jayk7 Cj4gIAlyZXR1cm4gcm1zdGI7Cj4gIH0KPiBAQCAtMjExMyw2ICsyMTM5LDE0IEBAIHN0YXRpYyBp bnQgZHJtX2RwX3BheWxvYWRfc2VuZF9tc2coc3RydWN0IGRybV9kcF9tc3RfdG9wb2xvZ3lfbWdy ICptZ3IsCj4gIAo+ICAJZHJtX2RwX3F1ZXVlX2Rvd25fdHgobWdyLCB0eG1zZyk7Cj4gIAo+ICsJ LyoKPiArCSAqIEZJWE1FOiB0aGVyZSBpcyBhIHNtYWxsIGNoYW5jZSB0aGF0IGJldHdlZW4gZ2V0 dGluZyB0aGUgbGFzdAo+ICsJICogY29ubmVjdGVkIG1zdGIgYW5kIHNlbmRpbmcgdGhlIHBheWxv YWQgbWVzc2FnZSwgdGhlIGxhc3QgY29ubmVjdGVkCj4gKwkgKiBtc3RiIGNvdWxkIGFsc28gYmUg cmVtb3ZlZCBmcm9tIHRoZSB0b3BvbG9neS4gSW4gdGhlIGZ1dHVyZSwgdGhpcwo+ICsJICogbmVl ZHMgdG8gYmUgZml4ZWQgYnkgcmVzdGFydGluZyB0aGUKPiArCSAqIGRybV9kcF9nZXRfbGFzdF9j b25uZWN0ZWRfcG9ydF9hbmRfbXN0YigpIHNlYXJjaCBpbiB0aGUgZXZlbnQgb2YgYQo+ICsJICog dGltZW91dCBpZiB0aGUgdG9wb2xvZ3kgaXMgc3RpbGwgY29ubmVjdGVkIHRvIHRoZSBzeXN0ZW0u Cj4gKwkgKi8KPiAgCXJldCA9IGRybV9kcF9tc3Rfd2FpdF90eF9yZXBseShtc3RiLCB0eG1zZyk7 Cj4gIAlpZiAocmV0ID4gMCkgewo+ICAJCWlmICh0eG1zZy0+cmVwbHkucmVwbHlfdHlwZSA9PSAx KQo+IC0tIAo+IDIuMjAuMQo+IAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIs IEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCk5vdXZlYXUgbWFpbGluZyBsaXN0Ck5vdXZl YXVAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vbm91dmVhdQo=