From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v5 17/20] drm/dp_mst: Add some atomic state iterator macros Date: Thu, 10 Jan 2019 10:28:43 +0100 Message-ID: <20190110092843.GG21184@phenom.ffwll.local> References: <20190109003516.14752-1-lyude@redhat.com> <20190109003516.14752-18-lyude@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by gabe.freedesktop.org (Postfix) with ESMTPS id A88306F217 for ; Thu, 10 Jan 2019 09:28:47 +0000 (UTC) Received: by mail-ed1-x543.google.com with SMTP id h50so9619011ede.5 for ; Thu, 10 Jan 2019 01:28:47 -0800 (PST) Content-Disposition: inline In-Reply-To: <20190109003516.14752-18-lyude@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Lyude Paul Cc: nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, Jerry Zuo , dri-devel@lists.freedesktop.org, Daniel Vetter , David Airlie , Harry Wentland List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBKYW4gMDgsIDIwMTkgYXQgMDc6MzU6MTRQTSAtMDUwMCwgTHl1ZGUgUGF1bCB3cm90 ZToKPiBDaGFuZ2VzIHNpbmNlIHY2Ogo+ICAtIE1vdmUgRVhQT1JUX1NZTUJPTCgpIGZvciBkcm1f ZHBfbXN0X3RvcG9sb2d5X3N0YXRlX2Z1bmNzIHRvIHRoaXMKPiAgICBjb21taXQKPiAgLSBEb2N1 bWVudCBfX2RybV9kcF9tc3Rfc3RhdGVfaXRlcl9nZXQoKSBhbmQgbm90ZSB0aGF0IGl0IHNob3Vs ZG4ndCBiZQo+ICAgIGNhbGxlZCBkaXJlY3RseQo+IAo+IFNpZ25lZC1vZmYtYnk6IEx5dWRlIFBh dWwgPGx5dWRlQHJlZGhhdC5jb20+Cj4gUmV2aWV3ZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmll bC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gQ2M6IERhdmlkIEFpcmxpZSA8YWlybGllZEByZWRoYXQuY29t Pgo+IENjOiBKZXJyeSBadW8gPEplcnJ5Llp1b0BhbWQuY29tPgo+IENjOiBIYXJyeSBXZW50bGFu ZCA8aGFycnkud2VudGxhbmRAYW1kLmNvbT4KPiBDYzogSnVzdG9uIExpIDxqdXN0b24ubGlAaW50 ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2RwX21zdF90b3BvbG9neS5jIHwg IDUgKy0KPiAgaW5jbHVkZS9kcm0vZHJtX2RwX21zdF9oZWxwZXIuaCAgICAgICB8IDk2ICsrKysr KysrKysrKysrKysrKysrKysrKysrKwo+ICAyIGZpbGVzIGNoYW5nZWQsIDk5IGluc2VydGlvbnMo KyksIDIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1f ZHBfbXN0X3RvcG9sb2d5LmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2RwX21zdF90b3BvbG9neS5j Cj4gaW5kZXggZWZkOGZhMjlmZmY2Li4zNzAzNzExNDVjZGQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2RybV9kcF9tc3RfdG9wb2xvZ3kuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9k cm1fZHBfbXN0X3RvcG9sb2d5LmMKPiBAQCAtMzUzMCwxMCArMzUzMCwxMSBAQCBzdGF0aWMgdm9p ZCBkcm1fZHBfbXN0X2Rlc3Ryb3lfc3RhdGUoc3RydWN0IGRybV9wcml2YXRlX29iaiAqb2JqLAo+ ICAJa2ZyZWUobXN0X3N0YXRlKTsKPiAgfQo+ICAKPiAtc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1f cHJpdmF0ZV9zdGF0ZV9mdW5jcyBtc3Rfc3RhdGVfZnVuY3MgPSB7Cj4gK2NvbnN0IHN0cnVjdCBk cm1fcHJpdmF0ZV9zdGF0ZV9mdW5jcyBkcm1fZHBfbXN0X3RvcG9sb2d5X3N0YXRlX2Z1bmNzID0g ewo+ICAJLmF0b21pY19kdXBsaWNhdGVfc3RhdGUgPSBkcm1fZHBfbXN0X2R1cGxpY2F0ZV9zdGF0 ZSwKPiAgCS5hdG9taWNfZGVzdHJveV9zdGF0ZSA9IGRybV9kcF9tc3RfZGVzdHJveV9zdGF0ZSwK PiAgfTsKPiArRVhQT1JUX1NZTUJPTChkcm1fZHBfbXN0X3RvcG9sb2d5X3N0YXRlX2Z1bmNzKTsK PiAgCj4gIC8qKgo+ICAgKiBkcm1fYXRvbWljX2dldF9tc3RfdG9wb2xvZ3lfc3RhdGU6IGdldCBN U1QgdG9wb2xvZ3kgc3RhdGUKPiBAQCAtMzYxNyw3ICszNjE4LDcgQEAgaW50IGRybV9kcF9tc3Rf dG9wb2xvZ3lfbWdyX2luaXQoc3RydWN0IGRybV9kcF9tc3RfdG9wb2xvZ3lfbWdyICptZ3IsCj4g IAo+ICAJZHJtX2F0b21pY19wcml2YXRlX29ial9pbml0KGRldiwgJm1nci0+YmFzZSwKPiAgCQkJ CSAgICAmbXN0X3N0YXRlLT5iYXNlLAo+IC0JCQkJICAgICZtc3Rfc3RhdGVfZnVuY3MpOwo+ICsJ CQkJICAgICZkcm1fZHBfbXN0X3RvcG9sb2d5X3N0YXRlX2Z1bmNzKTsKPiAgCj4gIAlyZXR1cm4g MDsKPiAgfQo+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2RybS9kcm1fZHBfbXN0X2hlbHBlci5oIGIv aW5jbHVkZS9kcm0vZHJtX2RwX21zdF9oZWxwZXIuaAo+IGluZGV4IDhlY2E1ZjI5MjQyYy4uNTgx MTYzYzhkN2Q3IDEwMDY0NAo+IC0tLSBhL2luY2x1ZGUvZHJtL2RybV9kcF9tc3RfaGVscGVyLmgK PiArKysgYi9pbmNsdWRlL2RybS9kcm1fZHBfbXN0X2hlbHBlci5oCj4gQEAgLTY1MCw0ICs2NTAs MTAwIEBAIGludCBkcm1fZHBfc2VuZF9wb3dlcl91cGRvd25fcGh5KHN0cnVjdCBkcm1fZHBfbXN0 X3RvcG9sb2d5X21nciAqbWdyLAo+ICB2b2lkIGRybV9kcF9tc3RfZ2V0X3BvcnRfbWFsbG9jKHN0 cnVjdCBkcm1fZHBfbXN0X3BvcnQgKnBvcnQpOwo+ICB2b2lkIGRybV9kcF9tc3RfcHV0X3BvcnRf bWFsbG9jKHN0cnVjdCBkcm1fZHBfbXN0X3BvcnQgKnBvcnQpOwo+ICAKPiArZXh0ZXJuIGNvbnN0 IHN0cnVjdCBkcm1fcHJpdmF0ZV9zdGF0ZV9mdW5jcyBkcm1fZHBfbXN0X3RvcG9sb2d5X3N0YXRl X2Z1bmNzOwo+ICsKPiArLyoqCj4gKyAqIF9fZHJtX2RwX21zdF9zdGF0ZV9pdGVyX2dldCAtIHBy aXZhdGUgYXRvbWljIHN0YXRlIGl0ZXJhdG9yIGZ1bmN0aW9uIGZvcgo+ICsgKiBtYWNyby1pbnRl cm5hbCB1c2UKPiArICogQHN0YXRlOiAmc3RydWN0IGRybV9hdG9taWNfc3RhdGUgcG9pbnRlcgo+ ICsgKiBAbWdyOiBwb2ludGVyIHRvIHRoZSAmc3RydWN0IGRybV9kcF9tc3RfdG9wb2xvZ3lfbWdy IGl0ZXJhdGlvbiBjdXJzb3IKPiArICogQG9sZF9zdGF0ZTogb3B0aW9uYWwgcG9pbnRlciB0byB0 aGUgb2xkICZzdHJ1Y3QgZHJtX2RwX21zdF90b3BvbG9neV9zdGF0ZQo+ICsgKiBpdGVyYXRpb24g Y3Vyc29yCj4gKyAqIEBuZXdfc3RhdGU6IG9wdGlvbmFsIHBvaW50ZXIgdG8gdGhlIG5ldyAmc3Ry dWN0IGRybV9kcF9tc3RfdG9wb2xvZ3lfc3RhdGUKPiArICogaXRlcmF0aW9uIGN1cnNvcgo+ICsg KiBAaTogaW50IGl0ZXJhdGlvbiBjdXJzb3IsIGZvciBtYWNyby1pbnRlcm5hbCB1c2UKPiArICoK PiArICogVXNlZCBieSBmb3JfZWFjaF9vbGRuZXdfbXN0X21ncl9pbl9zdGF0ZSgpLAo+ICsgKiBm b3JfZWFjaF9vbGRfbXN0X21ncl9pbl9zdGF0ZSgpLCBhbmQgZm9yX2VhY2hfbmV3X21zdF9tZ3Jf aW5fc3RhdGUoKS4gRG9uJ3QKPiArICogY2FsbCB0aGlzIGRpcmVjdGx5Lgo+ICsgKgo+ICsgKiBS ZXR1cm5zOgo+ICsgKiBUcnVlIGlmIHRoZSBjdXJyZW50ICZzdHJ1Y3QgZHJtX3ByaXZhdGVfb2Jq IGlzIGEgJnN0cnVjdAo+ICsgKiBkcm1fZHBfbXN0X3RvcG9sb2d5X21nciwgZmFsc2Ugb3RoZXJ3 aXNlLgo+ICsgKi8KPiArc3RhdGljIGlubGluZSBib29sCj4gK19fZHJtX2RwX21zdF9zdGF0ZV9p dGVyX2dldChzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUsCj4gKwkJCSAgICBzdHJ1Y3Qg ZHJtX2RwX21zdF90b3BvbG9neV9tZ3IgKiptZ3IsCj4gKwkJCSAgICBzdHJ1Y3QgZHJtX2RwX21z dF90b3BvbG9neV9zdGF0ZSAqKm9sZF9zdGF0ZSwKPiArCQkJICAgIHN0cnVjdCBkcm1fZHBfbXN0 X3RvcG9sb2d5X3N0YXRlICoqbmV3X3N0YXRlLAo+ICsJCQkgICAgaW50IGkpCj4gK3sKPiArCXN0 cnVjdCBfX2RybV9wcml2YXRlX29ianNfc3RhdGUgKm9ianNfc3RhdGUgPSAmc3RhdGUtPnByaXZh dGVfb2Jqc1tpXTsKPiArCj4gKwlpZiAob2Jqc19zdGF0ZS0+cHRyLT5mdW5jcyAhPSAmZHJtX2Rw X21zdF90b3BvbG9neV9zdGF0ZV9mdW5jcykKPiArCQlyZXR1cm4gZmFsc2U7Cj4gKwo+ICsJKm1n ciA9IHRvX2RwX21zdF90b3BvbG9neV9tZ3Iob2Jqc19zdGF0ZS0+cHRyKTsKPiArCWlmIChvbGRf c3RhdGUpCj4gKwkJKm9sZF9zdGF0ZSA9IHRvX2RwX21zdF90b3BvbG9neV9zdGF0ZShvYmpzX3N0 YXRlLT5vbGRfc3RhdGUpOwo+ICsJaWYgKG5ld19zdGF0ZSkKPiArCQkqbmV3X3N0YXRlID0gdG9f ZHBfbXN0X3RvcG9sb2d5X3N0YXRlKG9ianNfc3RhdGUtPm5ld19zdGF0ZSk7Cj4gKwo+ICsJcmV0 dXJuIHRydWU7Cj4gK30KPiArCj4gKy8qKgo+ICsgKiBmb3JfZWFjaF9vbGRuZXdfbXN0X21ncl9p bl9zdGF0ZSAtIGl0ZXJhdGUgb3ZlciBhbGwgRFAgTVNUIHRvcG9sb2d5Cj4gKyAqIG1hbmFnZXJz IGluIGFuIGF0b21pYyB1cGRhdGUKPiArICogQF9fc3RhdGU6ICZzdHJ1Y3QgZHJtX2F0b21pY19z dGF0ZSBwb2ludGVyCj4gKyAqIEBtZ3I6ICZzdHJ1Y3QgZHJtX2RwX21zdF90b3BvbG9neV9tZ3Ig aXRlcmF0aW9uIGN1cnNvcgo+ICsgKiBAb2xkX3N0YXRlOiAmc3RydWN0IGRybV9kcF9tc3RfdG9w b2xvZ3lfc3RhdGUgaXRlcmF0aW9uIGN1cnNvciBmb3IgdGhlIG9sZAo+ICsgKiBzdGF0ZQo+ICsg KiBAbmV3X3N0YXRlOiAmc3RydWN0IGRybV9kcF9tc3RfdG9wb2xvZ3lfc3RhdGUgaXRlcmF0aW9u IGN1cnNvciBmb3IgdGhlIG5ldwo+ICsgKiBzdGF0ZQo+ICsgKiBAX19pOiBpbnQgaXRlcmF0aW9u IGN1cnNvciwgZm9yIG1hY3JvLWludGVybmFsIHVzZQo+ICsgKgo+ICsgKiBUaGlzIGl0ZXJhdGVz IG92ZXIgYWxsIERSTSBEUCBNU1QgdG9wb2xvZ3kgbWFuYWdlcnMgaW4gYW4gYXRvbWljIHVwZGF0 ZSwKPiArICogdHJhY2tpbmcgYm90aCBvbGQgYW5kIG5ldyBzdGF0ZS4gVGhpcyBpcyB1c2VmdWwg aW4gcGxhY2VzIHdoZXJlIHRoZSBzdGF0ZQo+ICsgKiBkZWx0YSBuZWVkcyB0byBiZSBjb25zaWRl cmVkLCBmb3IgZXhhbXBsZSBpbiBhdG9taWMgY2hlY2sgZnVuY3Rpb25zLgo+ICsgKi8KPiArI2Rl ZmluZSBmb3JfZWFjaF9vbGRuZXdfbXN0X21ncl9pbl9zdGF0ZShfX3N0YXRlLCBtZ3IsIG9sZF9z dGF0ZSwgbmV3X3N0YXRlLCBfX2kpIFwKPiArCWZvciAoKF9faSkgPSAwOyAoX19pKSA8IChfX3N0 YXRlKS0+bnVtX3ByaXZhdGVfb2JqczsgKF9faSkrKykgXAo+ICsJCWZvcl9lYWNoX2lmKF9fZHJt X2RwX21zdF9zdGF0ZV9pdGVyX2dldCgoX19zdGF0ZSksICYobWdyKSwgJihvbGRfc3RhdGUpLCAm KG5ld19zdGF0ZSksIChfX2kpKSkKPiArCj4gKy8qKgo+ICsgKiBmb3JfZWFjaF9vbGRfbXN0X21n cl9pbl9zdGF0ZSAtIGl0ZXJhdGUgb3ZlciBhbGwgRFAgTVNUIHRvcG9sb2d5IG1hbmFnZXJzCj4g KyAqIGluIGFuIGF0b21pYyB1cGRhdGUKPiArICogQF9fc3RhdGU6ICZzdHJ1Y3QgZHJtX2F0b21p Y19zdGF0ZSBwb2ludGVyCj4gKyAqIEBtZ3I6ICZzdHJ1Y3QgZHJtX2RwX21zdF90b3BvbG9neV9t Z3IgaXRlcmF0aW9uIGN1cnNvcgo+ICsgKiBAb2xkX3N0YXRlOiAmc3RydWN0IGRybV9kcF9tc3Rf dG9wb2xvZ3lfc3RhdGUgaXRlcmF0aW9uIGN1cnNvciBmb3IgdGhlIG9sZAo+ICsgKiBzdGF0ZQo+ ICsgKiBAX19pOiBpbnQgaXRlcmF0aW9uIGN1cnNvciwgZm9yIG1hY3JvLWludGVybmFsIHVzZQo+ ICsgKgo+ICsgKiBUaGlzIGl0ZXJhdGVzIG92ZXIgYWxsIERSTSBEUCBNU1QgdG9wb2xvZ3kgbWFu YWdlcnMgaW4gYW4gYXRvbWljIHVwZGF0ZSwKPiArICogdHJhY2tpbmcgb25seSB0aGUgb2xkIHN0 YXRlLiBUaGlzIGlzIHVzZWZ1bCBpbiBkaXNhYmxlIGZ1bmN0aW9ucywgd2hlcmUgd2UKPiArICog bmVlZCB0aGUgb2xkIHN0YXRlIHRoZSBoYXJkd2FyZSBpcyBzdGlsbCBpbi4KPiArICovCj4gKyNk ZWZpbmUgZm9yX2VhY2hfb2xkX21zdF9tZ3JfaW5fc3RhdGUoX19zdGF0ZSwgbWdyLCBvbGRfc3Rh dGUsIF9faSkgXAo+ICsJZm9yICgoX19pKSA9IDA7IChfX2kpIDwgKF9fc3RhdGUpLT5udW1fcHJp dmF0ZV9vYmpzOyAoX19pKSsrKSBcCj4gKwkJZm9yX2VhY2hfaWYoX19kcm1fZHBfbXN0X3N0YXRl X2l0ZXJfZ2V0KChfX3N0YXRlKSwgJihtZ3IpLCAmKG9sZF9zdGF0ZSksIE5VTEwsIChfX2kpKSkK PiArCj4gKy8qKgo+ICsgKiBmb3JfZWFjaF9uZXdfbXN0X21ncl9pbl9zdGF0ZSAtIGl0ZXJhdGUg b3ZlciBhbGwgRFAgTVNUIHRvcG9sb2d5IG1hbmFnZXJzCj4gKyAqIGluIGFuIGF0b21pYyB1cGRh dGUKPiArICogQF9fc3RhdGU6ICZzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSBwb2ludGVyCj4gKyAq IEBtZ3I6ICZzdHJ1Y3QgZHJtX2RwX21zdF90b3BvbG9neV9tZ3IgaXRlcmF0aW9uIGN1cnNvcgo+ ICsgKiBAbmV3X3N0YXRlOiAmc3RydWN0IGRybV9kcF9tc3RfdG9wb2xvZ3lfc3RhdGUgaXRlcmF0 aW9uIGN1cnNvciBmb3IgdGhlIG5ldwo+ICsgKiBzdGF0ZQo+ICsgKiBAX19pOiBpbnQgaXRlcmF0 aW9uIGN1cnNvciwgZm9yIG1hY3JvLWludGVybmFsIHVzZQo+ICsgKgo+ICsgKiBUaGlzIGl0ZXJh dGVzIG92ZXIgYWxsIERSTSBEUCBNU1QgdG9wb2xvZ3kgbWFuYWdlcnMgaW4gYW4gYXRvbWljIHVw ZGF0ZSwKPiArICogdHJhY2tpbmcgb25seSB0aGUgbmV3IHN0YXRlLiBUaGlzIGlzIHVzZWZ1bCBp biBlbmFibGUgZnVuY3Rpb25zLCB3aGVyZSB3ZQo+ICsgKiBuZWVkIHRoZSBuZXcgc3RhdGUgdGhl IGhhcmR3YXJlIHNob3VsZCBiZSBpbiB3aGVuIHRoZSBhdG9taWMgY29tbWl0Cj4gKyAqIG9wZXJh dGlvbiBoYXMgY29tcGxldGVkLgo+ICsgKi8KPiArI2RlZmluZSBmb3JfZWFjaF9uZXdfbXN0X21n cl9pbl9zdGF0ZShfX3N0YXRlLCBtZ3IsIG5ld19zdGF0ZSwgX19pKSBcCj4gKwlmb3IgKChfX2kp ID0gMDsgKF9faSkgPCAoX19zdGF0ZSktPm51bV9wcml2YXRlX29ianM7IChfX2kpKyspIFwKPiAr CQlmb3JfZWFjaF9pZihfX2RybV9kcF9tc3Rfc3RhdGVfaXRlcl9nZXQoKF9fc3RhdGUpLCAmKG1n ciksIE5VTEwsICYobmV3X3N0YXRlKSwgKF9faSkpKQoKU2luY2Ugd2Ugb25seSBuZWVkIHRoaXMg aXRlcmF0b3IgaGVyZSwgYW5kIG9ubHkgaW4gZHJtX2RwX21zdF90b3BvbG9neS5jIEkKdGhpbmsg eW91IGNvdWxkIGFsc28ganVzdCBvcGVuIGNvZGUgdGhlbSBpbiB0aGUgc2luZ2xlIHVzZXIgKGFu ZCB0aGVuCm1heWJlIHNxdWFzaCB0aGF0IGluIHdpdGggb25lKS4gRWl0aGVyIHdheQoKUmV2aWV3 ZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gKwo+ICAjZW5k aWYKPiAtLSAKPiAyLjIwLjEKPiAKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVy LCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK