From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 11/13] drm/i915: Turn off pipe gamma when it's not needed. Date: Thu, 17 Jan 2019 20:48:06 +0200 Message-ID: <20190117184806.GH20097@intel.com> References: <20190111170823.4441-1-ville.syrjala@linux.intel.com> <20190111170823.4441-12-ville.syrjala@linux.intel.com> <20190117184023.GL4563@mdroper-desk.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 87A456E41E for ; Thu, 17 Jan 2019 18:48:10 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190117184023.GL4563@mdroper-desk.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBKYW4gMTcsIDIwMTkgYXQgMTA6NDA6MjNBTSAtMDgwMCwgTWF0dCBSb3BlciB3cm90 ZToKPiBPbiBGcmksIEphbiAxMSwgMjAxOSBhdCAwNzowODoyMVBNICswMjAwLCBWaWxsZSBTeXJq YWxhIHdyb3RlOgo+ID4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4 LmludGVsLmNvbT4KPiA+IAo+ID4gVGhlIHBpcGUgaW50ZXJuYWwgcHJlY2lzaW9uIGlzIGhpZ2hl ciB0aGFuIHdoYXQgd2UgY3VycmVudGx5IHByb2dyYW0gdG8KPiA+IHRoZSBkZWdhbW1hL2dhbW1h IExVVHMuIFdlIGNhbiBnZXQgYSBoaWdoZXIgcXVhbGl0eSBpbWFnZSBieSBieXBhc3NpbmcKPiA+ IHRoZSBMVVRzIHdoZW4gdGhleSdyZSBub3QgbmVlZGVkLiBMZXQncyBkbyB0aGF0Lgo+ID4gCj4g PiBFYWNoIHBsYW5lIGhhcyBpdHMgb3duIGNvbnRyb2wgYml0IGZvciB0aGlzLCBzbyB3ZSBoYXZl IHRvIHVwZGF0ZQo+ID4gYWxsIGFjdGl2ZSBwbGFuZXMuIFRoZSB3YXkgd2UndmUgZG9uZSB0aGlz IHdlIGRvbid0IGFjdHVhbGx5IGhhdmUKPiA+IHRvIHJ1biB0aHJvdWdoIHRoZSB3aG9sZSAuY2hl Y2tfcGxhbmUoKSB0aGluZy4gQW5kIHdlIGFjdHVhbGx5Cj4gPiBkbyB0aGUgLmNvbG9yX2NoZWNr KCkgYWZ0ZXIgLmNoZWNrX3BsYW5lKCkgc28gd2UgY291bGRuJ3QgZXZlbiBkbwo+ID4gdGhhdCB3 aXRob3V0IHNodWZmbGluZyB0aGUgY29kZSBhcm91bmQuCj4gPiAKPiA+IEFkZGl0aW9uYWxseSBv biBwcmUtc2tsIHdlIGhhdmUgdG8gdXBkYXRlIHRoZSBwcmltYXJ5IHBsYW5lIHJlZ2FyZGxlc3MK PiA+IG9mIHdoZXRoZXIgaXQncyBhY3RpdmUgb3Igbm90IG9uIGFjY291bnQgb2YgdGhlIHByaW1h eXIgcGxhbmUgZ2FtbWEKPiAKPiBzL3ByaW1heXIvcHJpbWFyeS8KPiAKPiA+IGVuYWJsZSBiaXQg YWxzbyBhZmZlY3RpbmcgdGhlIHBpcGUgYm90dG9tIGNvbG9yLgo+ID4gCj4gPiBTaWduZWQtb2Zm LWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ID4g LS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY29sb3IuYyB8IDU1ICsrKysrKysr KysrKysrKysrKysrKysrKysrKystLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCA1MyBpbnNlcnRpb25z KCspLCAyIGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfY29sb3IuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NvbG9yLmMK PiA+IGluZGV4IDhkN2VhOTAyYTM0Yi4uYThiNzQyOGE2NGJmIDEwMDY0NAo+ID4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY29sb3IuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfY29sb3IuYwo+ID4gQEAgLTYzMywyNyArNjMzLDc4IEBAIHZvaWQgaW50ZWxf Y29sb3JfY29tbWl0KGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlKQo+ ID4gIAlkZXZfcHJpdi0+ZGlzcGxheS5jb2xvcl9jb21taXQoY3J0Y19zdGF0ZSk7Cj4gPiAgfQo+ ID4gIAo+ID4gK3N0YXRpYyBib29sIG5lZWRfcGxhbmVfdXBkYXRlKHN0cnVjdCBpbnRlbF9wbGFu ZSAqcGxhbmUsCj4gPiArCQkJICAgICAgY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNy dGNfc3RhdGUpCj4gPiArewo+ID4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYg PSB0b19pOTE1KHBsYW5lLT5iYXNlLmRldik7Cj4gPiArCj4gPiArCS8qCj4gPiArCSAqIE9uIHBy ZS1TS0wgdGhlIHBpcGUgZ2FtbWEgZW5hYmxlIGFuZCBwaXBlIGNzYyBlbmFibGUgZm9yCj4gPiAr CSAqIHRoZSBwaXBlIGJvdHRvbSBjb2xvciBhcmUgY29uZmlndXJlZCB2aWEgdGhlIHByaW1hcnkg cGxhbmUuCj4gPiArCSAqIFdlIGhhdmUgdG8gcmVjb25maWd1cmUgdGhhdCBldmVuIGlmIHRoZSBw bGFuZSBpcyBpbmFjdGl2ZS4KPiA+ICsJICovCj4gPiArCXJldHVybiBjcnRjX3N0YXRlLT5hY3Rp dmVfcGxhbmVzICYgQklUKHBsYW5lLT5pZCkgfHwKPiA+ICsJCShJTlRFTF9HRU4oZGV2X3ByaXYp IDwgOSAmJgo+ID4gKwkJIHBsYW5lLT5pZCA9PSBQTEFORV9QUklNQVJZKTsKPiA+ICt9Cj4gPiAr Cj4gPiArc3RhdGljIGludAo+ID4gK2ludGVsX2NvbG9yX2FkZF9hZmZlY3RlZF9wbGFuZXMoc3Ry dWN0IGludGVsX2NydGNfc3RhdGUgKm5ld19jcnRjX3N0YXRlKQo+ID4gK3sKPiA+ICsJc3RydWN0 IGludGVsX2NydGMgKmNydGMgPSB0b19pbnRlbF9jcnRjKG5ld19jcnRjX3N0YXRlLT5iYXNlLmNy dGMpOwo+ID4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGNy dGMtPmJhc2UuZGV2KTsKPiA+ICsJc3RydWN0IGludGVsX2F0b21pY19zdGF0ZSAqc3RhdGUgPQo+ ID4gKwkJdG9faW50ZWxfYXRvbWljX3N0YXRlKG5ld19jcnRjX3N0YXRlLT5iYXNlLnN0YXRlKTsK PiA+ICsJY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKm9sZF9jcnRjX3N0YXRlID0KPiA+ ICsJCWludGVsX2F0b21pY19nZXRfb2xkX2NydGNfc3RhdGUoc3RhdGUsIGNydGMpOwo+ID4gKwlz dHJ1Y3QgaW50ZWxfcGxhbmUgKnBsYW5lOwo+ID4gKwo+ID4gKwlpZiAobmV3X2NydGNfc3RhdGUt PmdhbW1hX2VuYWJsZSA9PSBvbGRfY3J0Y19zdGF0ZS0+Z2FtbWFfZW5hYmxlKQo+ID4gKwkJcmV0 dXJuIDA7Cj4gPiArCj4gPiArCWZvcl9lYWNoX2ludGVsX3BsYW5lX29uX2NydGMoJmRldl9wcml2 LT5kcm0sIGNydGMsIHBsYW5lKSB7Cj4gPiArCQlzdHJ1Y3QgaW50ZWxfcGxhbmVfc3RhdGUgKnBs YW5lX3N0YXRlOwo+ID4gKwo+ID4gKwkJaWYgKCFuZWVkX3BsYW5lX3VwZGF0ZShwbGFuZSwgbmV3 X2NydGNfc3RhdGUpKQo+ID4gKwkJCWNvbnRpbnVlOwo+ID4gKwo+ID4gKwkJcGxhbmVfc3RhdGUg PSBpbnRlbF9hdG9taWNfZ2V0X3BsYW5lX3N0YXRlKHN0YXRlLCBwbGFuZSk7Cj4gPiArCQlpZiAo SVNfRVJSKHBsYW5lX3N0YXRlKSkKPiA+ICsJCQlyZXR1cm4gUFRSX0VSUihwbGFuZV9zdGF0ZSk7 Cj4gPiArCj4gPiArCQluZXdfY3J0Y19zdGF0ZS0+dXBkYXRlX3BsYW5lcyB8PSBCSVQocGxhbmUt PmlkKTsKPiA+ICsJfQo+ID4gKwo+ID4gKwlyZXR1cm4gMDsKPiA+ICt9Cj4gPiArCj4gPiAgaW50 IGludGVsX2NvbG9yX2NoZWNrKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlKQo+ ID4gIHsKPiA+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShj cnRjX3N0YXRlLT5iYXNlLmNydGMtPmRldik7Cj4gPiAgCWNvbnN0IHN0cnVjdCBkcm1fcHJvcGVy dHlfYmxvYiAqZ2FtbWFfbHV0ID0gY3J0Y19zdGF0ZS0+YmFzZS5nYW1tYV9sdXQ7Cj4gPiAgCWNv bnN0IHN0cnVjdCBkcm1fcHJvcGVydHlfYmxvYiAqZGVnYW1tYV9sdXQgPSBjcnRjX3N0YXRlLT5i YXNlLmRlZ2FtbWFfbHV0Owo+ID4gIAlzaXplX3QgZ2FtbWFfbGVuZ3RoLCBkZWdhbW1hX2xlbmd0 aDsKPiA+ICsJaW50IHJldDsKPiA+ICAKPiA+ICAJZGVnYW1tYV9sZW5ndGggPSBJTlRFTF9JTkZP KGRldl9wcml2KS0+Y29sb3IuZGVnYW1tYV9sdXRfc2l6ZTsKPiA+ICAJZ2FtbWFfbGVuZ3RoID0g SU5URUxfSU5GTyhkZXZfcHJpdiktPmNvbG9yLmdhbW1hX2x1dF9zaXplOwo+ID4gIAo+ID4gLQlj cnRjX3N0YXRlLT5nYW1tYV9lbmFibGUgPSB0cnVlOwo+ID4gKwljcnRjX3N0YXRlLT5nYW1tYV9l bmFibGUgPSBnYW1tYV9sdXQgfHwgZGVnYW1tYV9sdXQ7Cj4gPiAgCj4gPiAgCWlmIChJTlRFTF9H RU4oZGV2X3ByaXYpID49IDkgfHwKPiA+ICAJICAgIElTX0JST0FEV0VMTChkZXZfcHJpdikgfHwg SVNfSEFTV0VMTChkZXZfcHJpdikpCj4gPiAgCQljcnRjX3N0YXRlLT5jc2NfZW5hYmxlID0gdHJ1 ZTsKPiA+ICAKPiA+ICsJcmV0ID0gaW50ZWxfY29sb3JfYWRkX2FmZmVjdGVkX3BsYW5lcyhjcnRj X3N0YXRlKTsKPiA+ICsJaWYgKHJldCkKPiA+ICsJCXJldHVybiByZXQ7Cj4gPiArCj4gPiAgCS8q Cj4gPiAgCSAqIFdlIGFsc28gYWxsb3cgbm8gZGVnYW1tYSBsdXQvY3RtIGFuZCBhIGdhbW1hIGx1 dCBhdCB0aGUgbGVnYWN5Cj4gPiAgCSAqIHNpemUgKDI1NiBlbnRyaWVzKS4KPiA+ICAJICovCj4g PiAtCWlmIChjcnRjX3N0YXRlX2lzX2xlZ2FjeV9nYW1tYShjcnRjX3N0YXRlKSkgewo+ID4gKwlp ZiAoIWNydGNfc3RhdGUtPmdhbW1hX2VuYWJsZSB8fAo+ID4gKwkgICAgY3J0Y19zdGF0ZV9pc19s ZWdhY3lfZ2FtbWEoY3J0Y19zdGF0ZSkpIHsKPiA+ICAJCWNydGNfc3RhdGUtPmdhbW1hX21vZGUg PSBHQU1NQV9NT0RFX01PREVfOEJJVDsKPiAKPiBJZiBub25lIG9mIG91ciBwbGFuZXMgYXJlIGFj dHVhbGx5IHVzaW5nIHRoZSBnYW1tYSwgd2hhdCBkb2VzIHN3aXRjaGluZwo+IGJhY2sgdG8gOGJp dCBtb2RlIGRvIGZvciB1cz8KCkhvcGVmaWxseSBub3RoaW5nLiBKdXN0IGEgbWF0dGVyIG9mIHNl bGVjdGluZyBzb21ldGhpbmcgZm9yCmNvbnNpc3RlbmN5LgoKPiAKPiBSZWdhcmRsZXNzLAo+IAo+ IFJldmlld2VkLWJ5OiBNYXR0IFJvcGVyIDxtYXR0aGV3LmQucm9wZXJAaW50ZWwuY29tPgo+IAo+ IAo+ID4gIAkJcmV0dXJuIDA7Cj4gPiAgCX0KPiA+IC0tIAo+ID4gMi4xOS4yCj4gPiAKPiAKPiAt LSAKPiBNYXR0IFJvcGVyCj4gR3JhcGhpY3MgU29mdHdhcmUgRW5naW5lZXIKPiBJb1RHIFBsYXRm b3JtIEVuYWJsaW5nICYgRGV2ZWxvcG1lbnQKPiBJbnRlbCBDb3Jwb3JhdGlvbgo+ICg5MTYpIDM1 Ni0yNzk1CgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=