From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Apply LUT validation checks to platforms more accurately Date: Mon, 28 Jan 2019 22:05:22 +0200 Message-ID: <20190128200522.GV20097@intel.com> References: <20190126012840.18016-1-matthew.d.roper@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id D5F966E518 for ; Mon, 28 Jan 2019 20:05:26 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190126012840.18016-1-matthew.d.roper@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBKYW4gMjUsIDIwMTkgYXQgMDU6Mjg6NDBQTSAtMDgwMCwgTWF0dCBSb3BlciB3cm90 ZToKPiBVc2Ugb2YgdGhlIG5ldyBEUk1fQ09MT1JfTFVUX05PTl9ERUNSRUFTSU5HIHRlc3Qgd2Fz IGEgYml0IG92ZXItemVhbG91czsKPiBpdCBkb2Vzbid0IGFjdHVhbGx5IG5lZWQgdG8gYmUgYXBw bGllZCB0byB0aGUgZGVnYW1tYSBvbiAiYmR3LXN0eWxlIgo+IHBsYXRmb3Jtcy4gIExpa2V3aXNl LCB3ZSBvdmVybG9va2VkIHRoZSBmYWN0IHRoYXQgQ0hWIHNob3VsZCBoYXZlIHRoYXQKPiB0ZXN0 IGFwcGxpZWQgdG8gdGhlIGdhbW1hIExVVCBhcyB3ZWxsIGFzIHRoZSBkZWdhbW1hIExVVC4KPiAK PiBSYXRoZXIgdGhhbiBhZGRpbmcgbW9yZSBjb21wbGljYXRlZCBwbGF0Zm9ybSBjaGVja2luZyB0 bwo+IGludGVsX2NvbG9yX2NoZWNrKCksIGxldCdzIGp1c3Qgc3RvcmUgdGhlIGFwcHJvcHJpYXRl IHNldCBvZiBMVVQKPiB2YWxpZGF0aW9uIGZsYWdzIGZvciBlYWNoIHBsYXRmb3JtIGluIHRoZSBp bnRlbF9kZXZpY2VfaW5mbyBzdHJ1Y3R1cmUuCj4gCj4gRml4ZXM6IDg1ZTJkNjFlNDk3NiAoImRy bS9pOTE1OiBWYWxpZGF0ZSB1c2Vyc3BhY2UtcHJvdmlkZWQgY29sb3IgbWFuYWdlbWVudCBMVVQn cyAodjQpIikKPiBSZWZlcmVuY2VzOiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9hcmNo aXZlcy9pbnRlbC1nZngvMjAxOS1KYW51YXJ5LzE4NzYzNC5odG1sCj4gQ2M6IFZpbGxlIFN5cmrD pGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogTWF0 dCBSb3BlciA8bWF0dGhldy5kLnJvcGVyQGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9wY2kuYyAgICAgICAgICB8IDEwICsrKysrKysrLS0KPiAgZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfY29sb3IuYyAgICAgICB8IDE5ICsrKysrLS0tLS0tLS0tLS0tLS0K PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGV2aWNlX2luZm8uaCB8ICAyICsrCj4gIDMg ZmlsZXMgY2hhbmdlZCwgMTUgaW5zZXJ0aW9ucygrKSwgMTYgZGVsZXRpb25zKC0pCj4gCj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcGNpLmMgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X3BjaS5jCj4gaW5kZXggNDRjMjNhYzYwMzQ3Li4xN2Y1YTYwNWIwYjMgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9wY2kuYwo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfcGNpLmMKPiBAQCAtNjksOSArNjksMTUgQEAKPiAgI2RlZmlu ZSBCRFdfQ09MT1JTIFwKPiAgCS5jb2xvciA9IHsgLmRlZ2FtbWFfbHV0X3NpemUgPSA1MTIsIC5n YW1tYV9sdXRfc2l6ZSA9IDUxMiB9Cj4gICNkZWZpbmUgQ0hWX0NPTE9SUyBcCj4gLQkuY29sb3Ig PSB7IC5kZWdhbW1hX2x1dF9zaXplID0gNjUsIC5nYW1tYV9sdXRfc2l6ZSA9IDI1NyB9Cj4gKwku Y29sb3IgPSB7IC5kZWdhbW1hX2x1dF9zaXplID0gNjUsIC5nYW1tYV9sdXRfc2l6ZSA9IDI1Nywg XAo+ICsJCSAgIC5kZWdhbW1hX2x1dF90ZXN0cyA9IERSTV9DT0xPUl9MVVRfTk9OX0RFQ1JFQVNJ TkcsIFwKPiArCQkgICAuZ2FtbWFfbHV0X3Rlc3RzID0gRFJNX0NPTE9SX0xVVF9OT05fREVDUkVB U0lORywgXAo+ICsJfQo+ICAjZGVmaW5lIEdMS19DT0xPUlMgXAo+IC0JLmNvbG9yID0geyAuZGVn YW1tYV9sdXRfc2l6ZSA9IDAsIC5nYW1tYV9sdXRfc2l6ZSA9IDEwMjQgfQo+ICsJLmNvbG9yID0g eyAuZGVnYW1tYV9sdXRfc2l6ZSA9IDAsIC5nYW1tYV9sdXRfc2l6ZSA9IDEwMjQsIFwKPiArCQkg ICAuZGVnYW1tYV9sdXRfdGVzdHMgPSBEUk1fQ09MT1JfTFVUX05PTl9ERUNSRUFTSU5HIHwgXAo+ ICsJCQkJCURSTV9DT0xPUl9MVVRfRVFVQUxfQ0hBTk5FTFMsIFwKPiArCX0KPiAgCj4gIC8qIEtl ZXAgaW4gZ2VuIGJhc2VkIG9yZGVyLCBhbmQgY2hyb25vbG9naWNhbCBvcmRlciB3aXRoaW4gYSBn ZW4gKi8KPiAgCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NvbG9y LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jb2xvci5jCj4gaW5kZXggYmM3NTg5NjU2 YThmLi5jZDA4ZjU4YjFlNDcgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfY29sb3IuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NvbG9yLmMKPiBA QCAtNjA5LDI0ICs2MDksMTUgQEAgaW50IGludGVsX2NvbG9yX2NoZWNrKHN0cnVjdCBpbnRlbF9j cnRjX3N0YXRlICpjcnRjX3N0YXRlKQo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq ZGV2X3ByaXYgPSB0b19pOTE1KGNydGNfc3RhdGUtPmJhc2UuY3J0Yy0+ZGV2KTsKPiAgCXNpemVf dCBnYW1tYV9sZW5ndGgsIGRlZ2FtbWFfbGVuZ3RoOwo+IC0JdWludDMyX3QgdGVzdHMgPSBEUk1f Q09MT1JfTFVUX05PTl9ERUNSRUFTSU5HOwo+ICsJdTMyIGdhbW1hX3Rlc3RzLCBkZWdhbW1hX3Rl c3RzOwo+ICAKPiAgCWRlZ2FtbWFfbGVuZ3RoID0gSU5URUxfSU5GTyhkZXZfcHJpdiktPmNvbG9y LmRlZ2FtbWFfbHV0X3NpemU7Cj4gIAlnYW1tYV9sZW5ndGggPSBJTlRFTF9JTkZPKGRldl9wcml2 KS0+Y29sb3IuZ2FtbWFfbHV0X3NpemU7Cj4gKwlkZWdhbW1hX3Rlc3RzID0gSU5URUxfSU5GTyhk ZXZfcHJpdiktPmNvbG9yLmRlZ2FtbWFfbHV0X3Rlc3RzOwo+ICsJZ2FtbWFfdGVzdHMgPSBJTlRF TF9JTkZPKGRldl9wcml2KS0+Y29sb3IuZ2FtbWFfbHV0X3Rlc3RzOwo+ICAKPiAtCS8qCj4gLQkg KiBBbGwgb2Ygb3VyIHBsYXRmb3JtcyBtYW5kYXRlIHRoYXQgdGhlIGRlZ2FtbWEgY3VydmUgYmUK PiAtCSAqIG5vbi1kZWNyZWFzaW5nLiAgQWRkaXRpb25hbGx5LCBHTEsgYW5kIGdlbjExIG9ubHkg YWNjZXB0IGEgc2luZ2xlCj4gLQkgKiB2YWx1ZSBmb3IgcmVkLCBncmVlbiwgYW5kIGJsdWUgaW4g dGhlIGRlZ2FtbWEgdGFibGUuICBNYWtlIHN1cmUKPiAtCSAqIHVzZXJzcGFjZSBkaWRuJ3QgdHJ5 IHRvIHBhc3MgdXMgc29tZXRoaW5nIHdlIGNhbid0IGhhbmRsZS4KPiAtCSAqCj4gLQkgKiBXZSBk b24ndCBoYXZlIGFueSBleHRyYSBoYXJkd2FyZSBjb25zdHJhaW50cyBvbiB0aGUgZ2FtbWEgdGFi bGUsCj4gLQkgKiBzbyBubyBuZWVkIHRvIGV4cGxpY2l0bHkgY2hlY2sgaXQuCj4gLQkgKi8KPiAt CWlmIChJU19HRU1JTklMQUtFKGRldl9wcml2KSB8fCBJTlRFTF9HRU4oZGV2X3ByaXYpID49IDEw KQo+IC0JCXRlc3RzIHw9IERSTV9DT0xPUl9MVVRfRVFVQUxfQ0hBTk5FTFM7Cj4gLQo+IC0JaWYg KGRybV9jb2xvcl9sdXRfY2hlY2soY3J0Y19zdGF0ZS0+YmFzZS5kZWdhbW1hX2x1dCwgdGVzdHMp ICE9IDApCj4gKwlpZiAoZHJtX2NvbG9yX2x1dF9jaGVjayhjcnRjX3N0YXRlLT5iYXNlLmRlZ2Ft bWFfbHV0LCBkZWdhbW1hX3Rlc3RzKSB8fAo+ICsJICAgIGRybV9jb2xvcl9sdXRfY2hlY2soY3J0 Y19zdGF0ZS0+YmFzZS5nYW1tYV9sdXQsIGdhbW1hX3Rlc3RzKSkKCldlJ2xsIG5lZWQgdG8gZXhj bHVkZSB0aGUgbGVnYWN5IExVVCBmcm9tIHRoaXMgdGVzdCBzb21laG93LgoKPiAgCQlyZXR1cm4g LUVJTlZBTDsKPiAgCj4gIAkvKgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kZXZpY2VfaW5mby5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGV2aWNlX2lu Zm8uaAo+IGluZGV4IDk1N2M2NTI3Zjc2Yi4uN2JmMDljZWY1OTFhIDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RldmljZV9pbmZvLmgKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kZXZpY2VfaW5mby5oCj4gQEAgLTE4OSw2ICsxODksOCBAQCBzdHJ1 Y3QgaW50ZWxfZGV2aWNlX2luZm8gewo+ICAJc3RydWN0IGNvbG9yX2x1dHMgewo+ICAJCXUxNiBk ZWdhbW1hX2x1dF9zaXplOwo+ICAJCXUxNiBnYW1tYV9sdXRfc2l6ZTsKPiArCQl1MzIgZGVnYW1t YV9sdXRfdGVzdHM7Cj4gKwkJdTMyIGdhbW1hX2x1dF90ZXN0czsKPiAgCX0gY29sb3I7Cj4gIH07 Cj4gIAo+IC0tIAo+IDIuMTQuNQoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbApfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK