From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 3/3] drm/i915: Always allocate VCPI during system resume
Date: Tue, 29 Jan 2019 21:32:24 +0100
Message-ID: <20190129203224.GA3271@phenom.ffwll.local>
References: <20190129183928.26779-1-lyude@redhat.com>
 <20190129183928.26779-4-lyude@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <20190129183928.26779-4-lyude@redhat.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Lyude Paul <lyude@redhat.com>
Cc: David Airlie <airlied@linux.ie>, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rodrigo Vivi <rodrigo.vivi@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

T24gVHVlLCBKYW4gMjksIDIwMTkgYXQgMDE6Mzk6MjdQTSAtMDUwMCwgTHl1ZGUgUGF1bCB3cm90
ZToKPiBTaW5jZSB0aGVyZSdzIGEgY2hhbmNlIE1TVCB0b3BvbG9naWVzIGNhbiBiZSByZW1vdmVk
IHdoaWxlIHRoZSBzeXN0ZW0gaXMKPiBpbiBzdXNwZW5kLCB0aGVyZSdzIGFsc28gYSBjaGFuY2Ug
dGhhdCB0aGUgY29ubmVjdG9ycyBpbiB0aGUgYXRvbWljCj4gc3RhdGUgd2hpY2ggd2UgdHJ5IHRv
IHJlc3RvcmUgb24gc3lzdGVtIHJlc3VtZSB3aWxsIGhhdmUgYmVlbgo+IHVucmVnaXN0ZXJlZCBp
ZiB0aGV5IHdlcmUgcGFydCBvZiBhbiBNU1QgdG9wb2xvZ3kgdGhhdCB3YXMgcmVtb3ZlZAo+IG1p
ZC1zdXNwZW5kLiBJbiBzdWNoIHNpdHVhdGlvbnMsIHdlJ2xsIGN1cnJlbnRseSBza2lwIHJlY2Fs
Y3VsYXRpbmcgdGhlCj4gVkNQSS4gTm9ybWFsbHkgdGhpcyB3b3VsZCBiZSBzYWZlIHNpbmNlIHdl
IGRvbid0IGV4cGVjdCB0byBiZSBhbGxvd2VkIHRvCj4gZW5hYmxlIGRpc3BsYXlzIG9uIHVucmVn
aXN0ZXJlZCBjb25uZWN0aW9ucywgYnV0IHNpbmNlIHdlIG5lZWQgdG8gdHJ5Cj4gb3VyIGJlc3Qg
dG8gcmVzdG9yZSBldmVuIHBhcnRpYWxseSBpbnZhbGlkIGF0b21pYyBzdGF0ZXMgb24gc3lzdGVt
Cj4gcmVzdW1lIHdlIGVuZCB1cCBpbnRyb2R1Y2luZyB0aGUgY2hhbmNlIHRoYXQgd2UgdHJ5IGVu
YWJsaW5nIGEgZGlzcGxheQo+IG9uIGEgbm93LXVucmVnaXN0ZXJlZCBjb25uZWN0b3IuIFRoaXMg
b2YgY291cnNlIHJlc3VsdHMgb24gYSBibG93IHVwCj4gZHVyaW5nIHN5c3RlbSByZXN1bWU6Cj4g
Cj4gWyAxODk0LjE3Nzc4OF0gW2RybTpwaXBlX2NvbmZpZ19lcnIgW2k5MTVdXSAqRVJST1IqIG1p
c21hdGNoIGluIGRwX21fbiAoZXhwZWN0ZWQgdHUgMCBnbWNoIDE3MzAxNTAvODM4ODYwOCBsaW5r
IDI4ODM1OC8xMDQ4NTc2LCBvciB0dSAwIGdtY2ggMC8wIGxpbmsgMC8wLCBmb3VuZCB0dSA2NCwg
Z21jaCAxNzMwMTUwLzgzODg2MDggbGluayAyODgzNTgvMTA0ODU3NikKPiBbIDE4OTQuMTc3Nzk1
XSAtLS0tLS0tLS0tLS1bIGN1dCBoZXJlIF0tLS0tLS0tLS0tLS0KPiBbIDE4OTQuMTc3Nzk5XSBw
aXBlIHN0YXRlIGRvZXNuJ3QgbWF0Y2ghCj4gWyAxODk0LjE3NzkwNV0gV0FSTklORzogQ1BVOiAy
IFBJRDogMTg5NCBhdCBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmM6MTIyOTIg
aW50ZWxfYXRvbWljX2NvbW1pdF90YWlsKzB4ZDVlLzB4ZGQwIFtpOTE1XQo+IFsgMTg5NC4xNzc5
MDldIE1vZHVsZXMgbGlua2VkIGluOiBpOTE1KE8pIGRybV9rbXNfaGVscGVyKE8pIGRybShPKSB2
ZmF0IGZhdCBqb3lkZXYgaVRDT193ZHQgd21pX2Jtb2YgYnR1c2IgYnRydGwgYnRiY20gaW50ZWxf
cmFwbCBidGludGVsIGkyY19hbGdvX2JpdCB4ODZfcGtnX3RlbXBfdGhlcm1hbCBibHVldG9vdGgg
c3lzY29weWFyZWEgY29yZXRlbXAgc3lzZmlsbHJlY3Qgc3lzaW1nYmx0IGNyYzMyX3BjbG11bCBm
Yl9zeXNfZm9wcyB1Y3NpX2FjcGkgcHNtb3VzZSBlY2RoX2dlbmVyaWMgcGNzcGtyIHR5cGVjX3Vj
c2kgaTJjX2k4MDEgdHlwZWMgbWVpX21lIG1laSBpMmNfY29yZSB3bWkgdGhpbmtwYWRfYWNwaSBs
ZWR0cmlnX2F1ZGlvIHNuZCBzb3VuZGNvcmUgcmZraWxsIHRwbV90aXMgdHBtX3Rpc19jb3JlIHZp
ZGVvIHBjY19jcHVmcmVxIHRwbSBhY3BpX3BhZCB1YXMgdXNiX3N0b3JhZ2UgY3JjMzJjX2ludGVs
IG52bWUgc2VyaW9fcmF3IG52bWVfY29yZSB4aGNpX3BjaSB4aGNpX2hjZCBbbGFzdCB1bmxvYWRl
ZDogZHJtXQo+IFsgMTg5NC4xNzc5OTBdIENQVTogMiBQSUQ6IDE4OTQgQ29tbToga3dvcmtlci91
MTY6OCBUYWludGVkOiBHICAgICAgICAgICBPICAgICAgNS4wLjAtcmM0THl1ZGUtVGVzdCsgIzkK
PiBbIDE4OTQuMTc3OTk0XSBIYXJkd2FyZSBuYW1lOiBMRU5PVk8gMjBMOFMyTjgwMC8yMEw4UzJO
ODAwLCBCSU9TIE4yMkVUMzVXICgxLjEyICkgMDQvMDkvMjAxOAo+IFsgMTg5NC4xNzgwMDVdIFdv
cmtxdWV1ZTogZXZlbnRzX3VuYm91bmQgYXN5bmNfcnVuX2VudHJ5X2ZuCj4gWyAxODk0LjE3ODA3
OV0gUklQOiAwMDEwOmludGVsX2F0b21pY19jb21taXRfdGFpbCsweGQ1ZS8weGRkMCBbaTkxNV0K
PiBbIDE4OTQuMTc4MDg1XSBDb2RlOiBiYSAwMSAwMCAwMCAwMCA0YyA4OSA0YyAyNCAxMCBlOCAz
ZCA0NiAwMSAwMCA0YyA4YiA0YyAyNCAxMCBlOSBhNCBmYiBmZiBmZiBlOCBiMiAxOCBiZCBlMCAw
ZiAwYiBlOSBhNSBmZCBmZiBmZiBlOCBhNiAxOCBiZCBlMCA8MGY+IDBiIGU5IGYxIGY5IGZmIGZm
IGU4IDlhIDE4IGJkIGUwIDBmIDBiIDBmIGI2IDQ0IDI0IDE4IGU5IDIzIGY5Cj4gWyAxODk0LjE3
ODA5MF0gUlNQOiAwMDAwOmZmZmZjOTAwMDA1NTNjMDggRUZMQUdTOiAwMDAxMDI4Ngo+IFsgMTg5
NC4xNzgwOTZdIFJBWDogMDAwMDAwMDAwMDAwMDAwMCBSQlg6IGZmZmY4ODg0NTllZGMwMDAgUkNY
OiAwMDAwMDAwMDAwMDAwMDA2Cj4gWyAxODk0LjE3ODEwMV0gUkRYOiAwMDAwMDAwMDAwMDAwMDA3
IFJTSTogZmZmZjg4ODQ1OTFlMmY5MCBSREk6IGZmZmY4ODg0NWUyOTU2OTAKPiBbIDE4OTQuMTc4
MTA1XSBSQlA6IGZmZmY4ODg0NTRlMjcwMDAgUjA4OiAwMDAwMDAwMDAwMDAwMDAwIFIwOTogMDAw
MDAwMDAwMDAwMDAwMAo+IFsgMTg5NC4xNzgxMDhdIFIxMDogMDAwMDAwMDAwMDAwMDAwMCBSMTE6
IDAwMDAwMDAwMDAwMDAwMDAgUjEyOiBmZmZmODg4NDU0ZTIyMDAwCj4gWyAxODk0LjE3ODExMl0g
UjEzOiBmZmZmODg4NDU0ZTIxMDAwIFIxNDogZmZmZjg4ODNjYTY4MDc1MCBSMTU6IGZmZmY4ODgz
Y2E2ODA3NTgKPiBbIDE4OTQuMTc4MTE4XSBGUzogIDAwMDAwMDAwMDAwMDAwMDAoMDAwMCkgR1M6
ZmZmZjg4ODQ1ZTI4MDAwMCgwMDAwKSBrbmxHUzowMDAwMDAwMDAwMDAwMDAwCj4gWyAxODk0LjE3
ODEyM10gQ1M6ICAwMDEwIERTOiAwMDAwIEVTOiAwMDAwIENSMDogMDAwMDAwMDA4MDA1MDAzMwo+
IFsgMTg5NC4xNzgxMjddIENSMjogMDAwMDAwMDAwMDAwMDAwMCBDUjM6IDAwMDAwMDAwMDIyMTQw
MDEgQ1I0OiAwMDAwMDAwMDAwMzYwNmUwCj4gWyAxODk0LjE3ODEzMV0gRFIwOiAwMDAwMDAwMDAw
MDAwMDAwIERSMTogMDAwMDAwMDAwMDAwMDAwMCBEUjI6IDAwMDAwMDAwMDAwMDAwMDAKPiBbIDE4
OTQuMTc4MTM1XSBEUjM6IDAwMDAwMDAwMDAwMDAwMDAgRFI2OiAwMDAwMDAwMGZmZmUwZmYwIERS
NzogMDAwMDAwMDAwMDAwMDQwMAo+IFsgMTg5NC4xNzgxMzldIENhbGwgVHJhY2U6Cj4gWyAxODk0
LjE3ODIyNF0gIGludGVsX2F0b21pY19jb21taXQrMHgyNDAvMHgzMjAgW2k5MTVdCj4gWyAxODk0
LjE3ODI1MV0gIGRybV9hdG9taWNfaGVscGVyX2NvbW1pdF9kdXBsaWNhdGVkX3N0YXRlKzB4Yzkv
MHhlMCBbZHJtX2ttc19oZWxwZXJdCj4gWyAxODk0LjE3ODMyMV0gIF9faW50ZWxfZGlzcGxheV9y
ZXN1bWUrMHg4Mi8weGQwIFtpOTE1XQo+IFsgMTg5NC4xNzgzOTFdICBpbnRlbF9kaXNwbGF5X3Jl
c3VtZSsweGNmLzB4MTIwIFtpOTE1XQo+IFsgMTg5NC4xNzg0NTNdICBpOTE1X2RybV9yZXN1bWUr
MHhiMS8weDEwMCBbaTkxNV0KPiBbIDE4OTQuMTc4NDY1XSAgPyBwY2lfcG1fc3VzcGVuZF9sYXRl
KzB4MzAvMHgzMAo+IFsgMTg5NC4xNzg0NzNdICBkcG1fcnVuX2NhbGxiYWNrKzB4NzAvMHgyMTAK
PiBbIDE4OTQuMTc4NDg0XSAgZGV2aWNlX3Jlc3VtZSsweGFlLzB4MWYwCj4gWyAxODk0LjE3ODQ5
M10gIGFzeW5jX3Jlc3VtZSsweDE5LzB4MzAKPiBbIDE4OTQuMTc4NTAyXSAgYXN5bmNfcnVuX2Vu
dHJ5X2ZuKzB4MzkvMHgxNjAKPiBbIDE4OTQuMTc4NTEzXSAgcHJvY2Vzc19vbmVfd29yaysweDIz
Yy8weDU5MAo+IFsgMTg5NC4xNzg1MjldICB3b3JrZXJfdGhyZWFkKzB4MzAvMHgzODAKPiBbIDE4
OTQuMTc4NTM5XSAgPyByZXNjdWVyX3RocmVhZCsweDM0MC8weDM0MAo+IFsgMTg5NC4xNzg1NDVd
ICBrdGhyZWFkKzB4MTEyLzB4MTMwCj4gWyAxODk0LjE3ODU1Ml0gID8ga3RocmVhZF9jcmVhdGVf
b25fbm9kZSsweDYwLzB4NjAKPiBbIDE4OTQuMTc4NTYzXSAgcmV0X2Zyb21fZm9yaysweDNhLzB4
NTAKPiBbIDE4OTQuMTc4NTgyXSBpcnEgZXZlbnQgc3RhbXA6IDc2NzgyCj4gWyAxODk0LjE3ODU5
MV0gaGFyZGlycXMgbGFzdCAgZW5hYmxlZCBhdCAoNzY3ODEpOiBbPGZmZmZmZmZmODExMmMxMzU+
XSB2cHJpbnRrX2VtaXQrMHgyYzUvMHgyZDAKPiBbIDE4OTQuMTc4NjAwXSBoYXJkaXJxcyBsYXN0
IGRpc2FibGVkIGF0ICg3Njc4Mik6IFs8ZmZmZmZmZmY4MTAwMWFlOD5dIHRyYWNlX2hhcmRpcnFz
X29mZl90aHVuaysweDFhLzB4MWMKPiBbIDE4OTQuMTc4NjA5XSBzb2Z0aXJxcyBsYXN0ICBlbmFi
bGVkIGF0ICg3NjczNCk6IFs8ZmZmZmZmZmY4MWMwMDM1ZD5dIF9fZG9fc29mdGlycSsweDM1ZC8w
eDQxMgo+IFsgMTg5NC4xNzg2MThdIHNvZnRpcnFzIGxhc3QgZGlzYWJsZWQgYXQgKDc2NzI3KTog
WzxmZmZmZmZmZjgxMGJmODMwPl0gaXJxX2V4aXQrMHhlMC8weGYwCj4gWyAxODk0LjE3ODY4N10g
V0FSTklORzogQ1BVOiAyIFBJRDogMTg5NCBhdCBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k
aXNwbGF5LmM6MTIyOTIgaW50ZWxfYXRvbWljX2NvbW1pdF90YWlsKzB4ZDVlLzB4ZGQwIFtpOTE1
XQo+IFsgMTg5NC4xNzg2OTJdIC0tLVsgZW5kIHRyYWNlIDBkZjA4YzBiOWE2NzM3NmUgXS0tLQo+
IAo+IFNvLCBmaXggdGhpcyBieSB1c2luZyB0aGUgbmV3IGRybV9hdG9taWNfc3RhdGUuc3VzcGVu
ZF9vcl9yZXN1bWUgaG9vayBpbgo+IG9yZGVyIHRvIGZvcmNlIHVzIHRvIHJldHJpZXZlIGEgVkNQ
SSBhbGxvY2F0aW9uIHdoZW4gcmVzdG9yaW5nIGEgcGlwZSdzCj4gYXRvbWljIHN0YXRlLiBUaGlz
IGlzIHNhZmUsIHNpbmNlIGRybV9kcF9hdG9taWNfZmluZF92Y3BpX3Nsb3RzKCkgd2lsbAo+IGp1
c3QgcmV0dXJuIHRoZSBWQ1BJIGFsbG9jYXRpb24gd2UgaGFkIHByZS1zdXNwZW5kLgo+IAo+IFNp
Z25lZC1vZmYtYnk6IEx5dWRlIFBhdWwgPGx5dWRlQHJlZGhhdC5jb20+Cj4gQ2M6IERhbmllbCBW
ZXR0ZXIgPGRhbmllbEBmZndsbC5jaD4KPiBGaXhlczogZWNlYWUxNDcyNDY3ICgiZHJtL2RwX21z
dDogU3RhcnQgdHJhY2tpbmcgcGVyLXBvcnQgVkNQSSBhbGxvY2F0aW9ucyIpCj4gLS0tCj4gIGRy
aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwX21zdC5jIHwgOSArKysrKysrLS0KPiAgMSBmaWxl
IGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0
IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBfbXN0LmMgYi9kcml2ZXJzL2dwdS9kcm0v
aTkxNS9pbnRlbF9kcF9tc3QuYwo+IGluZGV4IGNkYjgzZDI5NGNkZC4uMDRjOWExNmZkYzM5IDEw
MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwX21zdC5jCj4gKysrIGIv
ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBfbXN0LmMKPiBAQCAtODAsOCArODAsMTMgQEAg
c3RhdGljIGludCBpbnRlbF9kcF9tc3RfY29tcHV0ZV9jb25maWcoc3RydWN0IGludGVsX2VuY29k
ZXIgKmVuY29kZXIsCj4gIAltc3RfcGJuID0gZHJtX2RwX2NhbGNfcGJuX21vZGUoYWRqdXN0ZWRf
bW9kZS0+Y3J0Y19jbG9jaywgYnBwKTsKPiAgCXBpcGVfY29uZmlnLT5wYm4gPSBtc3RfcGJuOwo+
ICAKPiAtCS8qIFpvbWJpZSBjb25uZWN0b3JzIGNhbid0IGhhdmUgVkNQSSBzbG90cyAqLwo+IC0J
aWYgKCFkcm1fY29ubmVjdG9yX2lzX3VucmVnaXN0ZXJlZChjb25uZWN0b3IpKSB7Cj4gKwkvKgo+
ICsJICogWm9tYmllIGNvbm5lY3RvcnMgY2FuJ3QgaGF2ZSBWQ1BJIHNsb3RzIGFuZCB3b24ndCBi
ZSB0dXJuZWQgb24sCj4gKwkgKiBleGNlcHQgZHVyaW5nIHJlc3VtZSB3aGVyZSB3ZSBtdXN0IG1h
a2Ugc3VyZSB3ZSByZXN0b3JlIHRoZQo+ICsJICogcHJldmlvdXMgVkNQSSBhbGxvY2F0aW9ucwo+
ICsJICovCj4gKwlpZiAoIWRybV9jb25uZWN0b3JfaXNfdW5yZWdpc3RlcmVkKGNvbm5lY3Rvcikg
fHwKCkhtLCBjb3VsZCB3ZSBwdXNoIHRoZSAhZHJtX2Nvbm5lY3Rvcl9pc191bnJlZ2lzdGVyZWQg
Y2hlY2sgaW50bwpkcm1fZHBfYXRvbWljX2ZpbmRfdmNwaV9zbG90cz8gVGhlbiB3ZSBjb3VsZCBh
bHNvIHB1c2ggdGhlCnN0YXRlLT5kdXBsaWNhdGVkIGNoZWNrIHRoZXJlLCBhbmQgdGhlc2Ugc3Bl
Y2lhbCBjYXNlcyB3b3VsZCBiZSBpbiB0aGUKc2FtZSBsaWJyYXJ5LgoKRnJvbSBhIGNvZGUgbG9n
aWMgcG92IGxvb2tzIGNvcnJlY3QgSSB0aGluaywgSSBjb3VsZG4ndCBwb2tlIGFueSBob2xlcyBp
bnQKdGhpcyBpZGVhIGF0IGxlYXN0LiBJIGd1ZXNzIHdlJ2xsIGZpbmQgb3V0IDotKQotRGFuaWVs
Cgo+ICsJICAgIHN0YXRlLT5zdXNwZW5kX29yX3Jlc3VtZSkgewo+ICAJCXNsb3RzID0gZHJtX2Rw
X2F0b21pY19maW5kX3ZjcGlfc2xvdHMoc3RhdGUsCj4gIAkJCQkJCSAgICAgICZpbnRlbF9kcC0+
bXN0X21nciwKPiAgCQkJCQkJICAgICAgcG9ydCwKPiAtLSAKPiAyLjIwLjEKPiAKCi0tIApEYW5p
ZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxv
Zy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK
aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK