From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Roper Subject: Re: [PATCH 4/9] drm/i915: Fix > vs >= mismatch in watermark/ddb calculations Date: Tue, 29 Jan 2019 15:54:42 -0800 Message-ID: <20190129235442.GG8802@mdroper-desk.amr.corp.intel.com> References: <20181221171436.8218-1-ville.syrjala@linux.intel.com> <20181221171436.8218-5-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 73C446E99D for ; Tue, 29 Jan 2019 23:54:43 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20181221171436.8218-5-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBEZWMgMjEsIDIwMTggYXQgMDc6MTQ6MzFQTSArMDIwMCwgVmlsbGUgU3lyamFsYSB3 cm90ZToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu Y29tPgo+IAo+IEJzcGVjIHNheXMgd2UgaGF2ZSB0byByZWplY3QgdGhlIHdhdGVybWFyayBpZiBp dCdzID49IHRoZSBkZGIKPiBhbGxvY2F0aW9uLiBGaXggdGhlIGNvZGUgdG8gcmVqZWN0IHRoZSA9 PSBjYXNlIGFzIGl0IHNob3VsZC4KPiBGb3IgdHJhbnNpdGlvbiB3YXRlcm1hcmtzIHdlIGNhbiBq dXN0IHVzZSA+PSwgZm9yIHRoZSByZXN0Cj4gd2UnbGwgZG8gKzEgd2hlbiBjYWxjdWxhdGluZyB0 aGUgbWluaW11bSBkZGIgYWxsb2NhdGlvbiBzaXplLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFZpbGxl IFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+CgpSZXZpZXdlZC1ieTog TWF0dCBSb3BlciA8bWF0dGhldy5kLnJvcGVyQGludGVsLmNvbT4KCj4gLS0tCj4gIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX3BtLmMgfCAxMCArKysrKy0tLS0tCj4gIDEgZmlsZSBjaGFuZ2Vk LCA1IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9w bS5jCj4gaW5kZXggNTVhMWM1NzdmMDYwLi4zYzVjYmEzMWYwNTUgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX3BtLmMKPiBAQCAtNDM3MSw4ICs0MzcxLDggQEAgc2tsX2FsbG9jYXRlX3BpcGVfZGRi KHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjc3RhdGUsCj4gIAkJCQljb250aW51ZTsKPiAgCj4g IAkJCXdtID0gJmNzdGF0ZS0+d20uc2tsLm9wdGltYWwucGxhbmVzW3BsYW5lX2lkXTsKPiAtCQkJ YmxvY2tzICs9IHdtLT53bVtsZXZlbF0ucGxhbmVfcmVzX2I7Cj4gLQkJCWJsb2NrcyArPSB3bS0+ dXZfd21bbGV2ZWxdLnBsYW5lX3Jlc19iOwo+ICsJCQlibG9ja3MgKz0gd20tPndtW2xldmVsXS5w bGFuZV9yZXNfYiArIDE7Cj4gKwkJCWJsb2NrcyArPSB3bS0+dXZfd21bbGV2ZWxdLnBsYW5lX3Jl c19iICsgMTsKPiAgCQl9Cj4gIAo+ICAJCWlmIChibG9ja3MgPCBhbGxvY19zaXplKSB7Cj4gQEAg LTQ0MTMsNyArNDQxMyw3IEBAIHNrbF9hbGxvY2F0ZV9waXBlX2RkYihzdHJ1Y3QgaW50ZWxfY3J0 Y19zdGF0ZSAqY3N0YXRlLAo+ICAJCWV4dHJhID0gbWluX3QodTE2LCBhbGxvY19zaXplLAo+ICAJ CQkgICAgICBESVY2NF9VNjRfUk9VTkRfVVAoYWxsb2Nfc2l6ZSAqIHJhdGUsCj4gIAkJCQkJCSB0 b3RhbF9kYXRhX3JhdGUpKTsKPiAtCQl0b3RhbFtwbGFuZV9pZF0gPSB3bS0+d21bbGV2ZWxdLnBs YW5lX3Jlc19iICsgZXh0cmE7Cj4gKwkJdG90YWxbcGxhbmVfaWRdID0gd20tPndtW2xldmVsXS5w bGFuZV9yZXNfYiArIDEgKyBleHRyYTsKPiAgCQlhbGxvY19zaXplIC09IGV4dHJhOwo+ICAJCXRv dGFsX2RhdGFfcmF0ZSAtPSByYXRlOwo+ICAKPiBAQCAtNDQyNCw3ICs0NDI0LDcgQEAgc2tsX2Fs bG9jYXRlX3BpcGVfZGRiKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjc3RhdGUsCj4gIAkJZXh0 cmEgPSBtaW5fdCh1MTYsIGFsbG9jX3NpemUsCj4gIAkJCSAgICAgIERJVjY0X1U2NF9ST1VORF9V UChhbGxvY19zaXplICogcmF0ZSwKPiAgCQkJCQkJIHRvdGFsX2RhdGFfcmF0ZSkpOwo+IC0JCXV2 X3RvdGFsW3BsYW5lX2lkXSA9IHdtLT51dl93bVtsZXZlbF0ucGxhbmVfcmVzX2IgKyBleHRyYTsK PiArCQl1dl90b3RhbFtwbGFuZV9pZF0gPSB3bS0+dXZfd21bbGV2ZWxdLnBsYW5lX3Jlc19iICsg MSArIGV4dHJhOwo+ICAJCWFsbG9jX3NpemUgLT0gZXh0cmE7Cj4gIAkJdG90YWxfZGF0YV9yYXRl IC09IHJhdGU7Cj4gIAl9Cj4gQEAgLTQ0NzcsNyArNDQ3Nyw3IEBAIHNrbF9hbGxvY2F0ZV9waXBl X2RkYihzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3N0YXRlLAo+ICAJICovCj4gIAlmb3JfZWFj aF9wbGFuZV9pZF9vbl9jcnRjKGludGVsX2NydGMsIHBsYW5lX2lkKSB7Cj4gIAkJd20gPSAmY3N0 YXRlLT53bS5za2wub3B0aW1hbC5wbGFuZXNbcGxhbmVfaWRdOwo+IC0JCWlmICh3bS0+dHJhbnNf d20ucGxhbmVfcmVzX2IgPiB0b3RhbFtwbGFuZV9pZF0pCj4gKwkJaWYgKHdtLT50cmFuc193bS5w bGFuZV9yZXNfYiA+PSB0b3RhbFtwbGFuZV9pZF0pCj4gIAkJCW1lbXNldCgmd20tPnRyYW5zX3dt LCAwLCBzaXplb2Yod20tPnRyYW5zX3dtKSk7Cj4gIAl9Cj4gIAo+IC0tIAo+IDIuMTkuMgo+IAo+ IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0g Ck1hdHQgUm9wZXIKR3JhcGhpY3MgU29mdHdhcmUgRW5naW5lZXIKSW9URyBQbGF0Zm9ybSBFbmFi bGluZyAmIERldmVsb3BtZW50CkludGVsIENvcnBvcmF0aW9uCig5MTYpIDM1Ni0yNzk1Cl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWls aW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=