From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Apply LUT validation checks to platforms more accurately (v2) Date: Wed, 30 Jan 2019 16:28:47 +0200 Message-ID: <20190130142847.GL20097@intel.com> References: <20190128200522.GV20097@intel.com> <20190130004928.20699-1-matthew.d.roper@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9A42F6E5EB for ; Wed, 30 Jan 2019 14:28:50 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190130004928.20699-1-matthew.d.roper@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBKYW4gMjksIDIwMTkgYXQgMDQ6NDk6MjhQTSAtMDgwMCwgTWF0dCBSb3BlciB3cm90 ZToKPiBVc2Ugb2YgdGhlIG5ldyBEUk1fQ09MT1JfTFVUX05PTl9ERUNSRUFTSU5HIHRlc3Qgd2Fz IGEgYml0IG92ZXItemVhbG91czsKPiBpdCBkb2Vzbid0IGFjdHVhbGx5IG5lZWQgdG8gYmUgYXBw bGllZCB0byB0aGUgZGVnYW1tYSBvbiAiYmR3LXN0eWxlIgo+IHBsYXRmb3Jtcy4gIExpa2V3aXNl LCB3ZSBvdmVybG9va2VkIHRoZSBmYWN0IHRoYXQgQ0hWIHNob3VsZCBoYXZlIHRoYXQKPiB0ZXN0 IGFwcGxpZWQgdG8gdGhlIGdhbW1hIExVVCBhcyB3ZWxsIGFzIHRoZSBkZWdhbW1hIExVVC4KPiAK PiBSYXRoZXIgdGhhbiBhZGRpbmcgbW9yZSBjb21wbGljYXRlZCBwbGF0Zm9ybSBjaGVja2luZyB0 bwo+IGludGVsX2NvbG9yX2NoZWNrKCksIGxldCdzIGp1c3Qgc3RvcmUgdGhlIGFwcHJvcHJpYXRl IHNldCBvZiBMVVQKPiB2YWxpZGF0aW9uIGZsYWdzIGZvciBlYWNoIHBsYXRmb3JtIGluIHRoZSBp bnRlbF9kZXZpY2VfaW5mbyBzdHJ1Y3R1cmUuCj4gCj4gdjI6Cj4gIC0gU2h1ZmZsZSBhcm91bmQg TFVUIHNpemUgdGVzdHMgc28gdGhhdCB0aGUgaGFyZHdhcmUtc3BlY2lmaWMgdGVzdHMKPiAgICB3 b24ndCBiZSBhcHBsaWVkIHRvIGxlZ2FjeSBnYW1tYSB0YWJsZXMuICAoVmlsbGUpCj4gIC0gQWRk IGEgZGVidWcgbWVzc2FnZSBzbyB0aGF0IGl0IHdpbGwgYmUgZWFzaWVyIHRvIHVuZGVyc3RhbmQg d2h5IGFuCj4gICAgYXRvbWljIHRyYW5zYWN0aW9uIGludm9sdmluZyBpbmNvcnJlY3RseS1zaXpl ZCBMVVQncyBnb3QgcmVqZWN0ZWQKPiAgICBieSB0aGUgZHJpdmVyLgo+IAo+IEZpeGVzOiA4NWUy ZDYxZTQ5NzYgKCJkcm0vaTkxNTogVmFsaWRhdGUgdXNlcnNwYWNlLXByb3ZpZGVkIGNvbG9yIG1h bmFnZW1lbnQgTFVUJ3MgKHY0KSIpCj4gUmVmZXJlbmNlczogaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvYXJjaGl2ZXMvaW50ZWwtZ2Z4LzIwMTktSmFudWFyeS8xODc2MzQuaHRtbAo+IENj OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IFNpZ25l ZC1vZmYtYnk6IE1hdHQgUm9wZXIgPG1hdHRoZXcuZC5yb3BlckBpbnRlbC5jb20+Cj4gLS0tCj4g IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcGNpLmMgICAgICAgICAgfCAxMCArKysrLS0KPiAg ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY29sb3IuYyAgICAgICB8IDU4ICsrKysrKysrKysr KysrKystLS0tLS0tLS0tLS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rldmlj ZV9pbmZvLmggfCAgMiArKwo+ICAzIGZpbGVzIGNoYW5nZWQsIDM5IGluc2VydGlvbnMoKyksIDMx IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X3BjaS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9wY2kuYwo+IGluZGV4IDQ0YzIzYWM2 MDM0Ny4uMTdmNWE2MDViMGIzIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfcGNpLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BjaS5jCj4gQEAgLTY5 LDkgKzY5LDE1IEBACj4gICNkZWZpbmUgQkRXX0NPTE9SUyBcCj4gIAkuY29sb3IgPSB7IC5kZWdh bW1hX2x1dF9zaXplID0gNTEyLCAuZ2FtbWFfbHV0X3NpemUgPSA1MTIgfQo+ICAjZGVmaW5lIENI Vl9DT0xPUlMgXAo+IC0JLmNvbG9yID0geyAuZGVnYW1tYV9sdXRfc2l6ZSA9IDY1LCAuZ2FtbWFf bHV0X3NpemUgPSAyNTcgfQo+ICsJLmNvbG9yID0geyAuZGVnYW1tYV9sdXRfc2l6ZSA9IDY1LCAu Z2FtbWFfbHV0X3NpemUgPSAyNTcsIFwKPiArCQkgICAuZGVnYW1tYV9sdXRfdGVzdHMgPSBEUk1f Q09MT1JfTFVUX05PTl9ERUNSRUFTSU5HLCBcCj4gKwkJICAgLmdhbW1hX2x1dF90ZXN0cyA9IERS TV9DT0xPUl9MVVRfTk9OX0RFQ1JFQVNJTkcsIFwKPiArCX0KPiAgI2RlZmluZSBHTEtfQ09MT1JT IFwKPiAtCS5jb2xvciA9IHsgLmRlZ2FtbWFfbHV0X3NpemUgPSAwLCAuZ2FtbWFfbHV0X3NpemUg PSAxMDI0IH0KPiArCS5jb2xvciA9IHsgLmRlZ2FtbWFfbHV0X3NpemUgPSAwLCAuZ2FtbWFfbHV0 X3NpemUgPSAxMDI0LCBcCj4gKwkJICAgLmRlZ2FtbWFfbHV0X3Rlc3RzID0gRFJNX0NPTE9SX0xV VF9OT05fREVDUkVBU0lORyB8IFwKPiArCQkJCQlEUk1fQ09MT1JfTFVUX0VRVUFMX0NIQU5ORUxT LCBcCj4gKwl9Cj4gIAo+ICAvKiBLZWVwIGluIGdlbiBiYXNlZCBvcmRlciwgYW5kIGNocm9ub2xv Z2ljYWwgb3JkZXIgd2l0aGluIGEgZ2VuICovCj4gIAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9jb2xvci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY29s b3IuYwo+IGluZGV4IGJjNzU4OTY1NmE4Zi4uNTliOGE2NDRiMjE4IDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NvbG9yLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9jb2xvci5jCj4gQEAgLTYwNSw0OCArNjA1LDQ4IEBAIHZvaWQgaW50ZWxfY29s b3JfbG9hZF9sdXRzKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlKQo+ICAJZGV2 X3ByaXYtPmRpc3BsYXkubG9hZF9sdXRzKGNydGNfc3RhdGUpOwo+ICB9Cj4gIAo+ICtzdGF0aWMg aW50IGNoZWNrX2x1dF9zaXplKGNvbnN0IHN0cnVjdCBkcm1fcHJvcGVydHlfYmxvYiAqbHV0LCBz aXplX3QgZXhwZWN0ZWQpCj4gK3sKPiArCXNpemVfdCBsZW47CgpJJ2QgcHJvYmFibHkganVzdCB1 c2UgaW50IGhlcmUuIHNpemVfdCBtYWtlcyBtZSB0aGluayBpdCdzIGluIGJ5dGVzIG9yCnNvbWV0 aGluZyBsaWtlIHRoYXQuCgpPdGhlcndpc2UgbGd0bS4gRWl0aGVyIHdheQpSZXZpZXdlZC1ieTog VmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KCj4gKwo+ICsJ aWYgKCFsdXQpCj4gKwkJcmV0dXJuIDA7Cj4gKwo+ICsJbGVuID0gZHJtX2NvbG9yX2x1dF9zaXpl KGx1dCk7Cj4gKwlpZiAobGVuICE9IGV4cGVjdGVkKSB7Cj4gKwkJRFJNX0RFQlVHX0tNUygiSW52 YWxpZCBMVVQgc2l6ZTsgZ290ICVsdSwgZXhwZWN0ZWQgJWx1XG4iLAo+ICsJCQkgICAgICBsZW4s IGV4cGVjdGVkKTsKPiArCQlyZXR1cm4gLUVJTlZBTDsKPiArCX0KPiArCj4gKwlyZXR1cm4gMDsK PiArfQo+ICsKPiAgaW50IGludGVsX2NvbG9yX2NoZWNrKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRl ICpjcnRjX3N0YXRlKQo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYg PSB0b19pOTE1KGNydGNfc3RhdGUtPmJhc2UuY3J0Yy0+ZGV2KTsKPiAgCXNpemVfdCBnYW1tYV9s ZW5ndGgsIGRlZ2FtbWFfbGVuZ3RoOwo+IC0JdWludDMyX3QgdGVzdHMgPSBEUk1fQ09MT1JfTFVU X05PTl9ERUNSRUFTSU5HOwo+ICsJdTMyIGdhbW1hX3Rlc3RzLCBkZWdhbW1hX3Rlc3RzOwo+ICAK PiAgCWRlZ2FtbWFfbGVuZ3RoID0gSU5URUxfSU5GTyhkZXZfcHJpdiktPmNvbG9yLmRlZ2FtbWFf bHV0X3NpemU7Cj4gIAlnYW1tYV9sZW5ndGggPSBJTlRFTF9JTkZPKGRldl9wcml2KS0+Y29sb3Iu Z2FtbWFfbHV0X3NpemU7Cj4gKwlkZWdhbW1hX3Rlc3RzID0gSU5URUxfSU5GTyhkZXZfcHJpdikt PmNvbG9yLmRlZ2FtbWFfbHV0X3Rlc3RzOwo+ICsJZ2FtbWFfdGVzdHMgPSBJTlRFTF9JTkZPKGRl dl9wcml2KS0+Y29sb3IuZ2FtbWFfbHV0X3Rlc3RzOwo+ICAKPiAtCS8qCj4gLQkgKiBBbGwgb2Yg b3VyIHBsYXRmb3JtcyBtYW5kYXRlIHRoYXQgdGhlIGRlZ2FtbWEgY3VydmUgYmUKPiAtCSAqIG5v bi1kZWNyZWFzaW5nLiAgQWRkaXRpb25hbGx5LCBHTEsgYW5kIGdlbjExIG9ubHkgYWNjZXB0IGEg c2luZ2xlCj4gLQkgKiB2YWx1ZSBmb3IgcmVkLCBncmVlbiwgYW5kIGJsdWUgaW4gdGhlIGRlZ2Ft bWEgdGFibGUuICBNYWtlIHN1cmUKPiAtCSAqIHVzZXJzcGFjZSBkaWRuJ3QgdHJ5IHRvIHBhc3Mg dXMgc29tZXRoaW5nIHdlIGNhbid0IGhhbmRsZS4KPiAtCSAqCj4gLQkgKiBXZSBkb24ndCBoYXZl IGFueSBleHRyYSBoYXJkd2FyZSBjb25zdHJhaW50cyBvbiB0aGUgZ2FtbWEgdGFibGUsCj4gLQkg KiBzbyBubyBuZWVkIHRvIGV4cGxpY2l0bHkgY2hlY2sgaXQuCj4gLQkgKi8KPiAtCWlmIChJU19H RU1JTklMQUtFKGRldl9wcml2KSB8fCBJTlRFTF9HRU4oZGV2X3ByaXYpID49IDEwKQo+IC0JCXRl c3RzIHw9IERSTV9DT0xPUl9MVVRfRVFVQUxfQ0hBTk5FTFM7Cj4gKwkvKiBBbHdheXMgYWxsb3cg bGVnYWN5IGdhbW1hIExVVCB3aXRoIG5vIGZ1cnRoZXIgY2hlY2tpbmcuICovCj4gKwlpZiAoY3J0 Y19zdGF0ZV9pc19sZWdhY3lfZ2FtbWEoY3J0Y19zdGF0ZSkpCj4gKwkJcmV0dXJuIDA7Cj4gIAo+ IC0JaWYgKGRybV9jb2xvcl9sdXRfY2hlY2soY3J0Y19zdGF0ZS0+YmFzZS5kZWdhbW1hX2x1dCwg dGVzdHMpICE9IDApCj4gKwlpZiAoY2hlY2tfbHV0X3NpemUoY3J0Y19zdGF0ZS0+YmFzZS5kZWdh bW1hX2x1dCwgZGVnYW1tYV9sZW5ndGgpIHx8Cj4gKwkgICAgY2hlY2tfbHV0X3NpemUoY3J0Y19z dGF0ZS0+YmFzZS5nYW1tYV9sdXQsIGdhbW1hX2xlbmd0aCkpCj4gIAkJcmV0dXJuIC1FSU5WQUw7 Cj4gIAo+IC0JLyoKPiAtCSAqIFdlIGFsbG93IGJvdGggZGVnYW1tYSAmIGdhbW1hIGx1dHMgYXQg dGhlIHJpZ2h0IHNpemUgb3IKPiAtCSAqIE5VTEwuCj4gLQkgKi8KPiAtCWlmICgoIWNydGNfc3Rh dGUtPmJhc2UuZGVnYW1tYV9sdXQgfHwKPiAtCSAgICAgZHJtX2NvbG9yX2x1dF9zaXplKGNydGNf c3RhdGUtPmJhc2UuZGVnYW1tYV9sdXQpID09IGRlZ2FtbWFfbGVuZ3RoKSAmJgo+IC0JICAgICgh Y3J0Y19zdGF0ZS0+YmFzZS5nYW1tYV9sdXQgfHwKPiAtCSAgICAgZHJtX2NvbG9yX2x1dF9zaXpl KGNydGNfc3RhdGUtPmJhc2UuZ2FtbWFfbHV0KSA9PSBnYW1tYV9sZW5ndGgpKQo+IC0JCXJldHVy biAwOwo+ICsJaWYgKGRybV9jb2xvcl9sdXRfY2hlY2soY3J0Y19zdGF0ZS0+YmFzZS5kZWdhbW1h X2x1dCwgZGVnYW1tYV90ZXN0cykgfHwKPiArCSAgICBkcm1fY29sb3JfbHV0X2NoZWNrKGNydGNf c3RhdGUtPmJhc2UuZ2FtbWFfbHV0LCBnYW1tYV90ZXN0cykpCj4gKwkJcmV0dXJuIC1FSU5WQUw7 Cj4gIAo+IC0JLyoKPiAtCSAqIFdlIGFsc28gYWxsb3cgbm8gZGVnYW1tYSBsdXQvY3RtIGFuZCBh IGdhbW1hIGx1dCBhdCB0aGUgbGVnYWN5Cj4gLQkgKiBzaXplICgyNTYgZW50cmllcykuCj4gLQkg Ki8KPiAtCWlmIChjcnRjX3N0YXRlX2lzX2xlZ2FjeV9nYW1tYShjcnRjX3N0YXRlKSkKPiAtCQly ZXR1cm4gMDsKPiAgCj4gLQlyZXR1cm4gLUVJTlZBTDsKPiArCXJldHVybiAwOwo+ICB9Cj4gIAo+ ICB2b2lkIGludGVsX2NvbG9yX2luaXQoc3RydWN0IGludGVsX2NydGMgKmNydGMpCj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RldmljZV9pbmZvLmggYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kZXZpY2VfaW5mby5oCj4gaW5kZXggOTU3YzY1MjdmNzZiLi43 YmYwOWNlZjU5MWEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGV2 aWNlX2luZm8uaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RldmljZV9pbmZv LmgKPiBAQCAtMTg5LDYgKzE4OSw4IEBAIHN0cnVjdCBpbnRlbF9kZXZpY2VfaW5mbyB7Cj4gIAlz dHJ1Y3QgY29sb3JfbHV0cyB7Cj4gIAkJdTE2IGRlZ2FtbWFfbHV0X3NpemU7Cj4gIAkJdTE2IGdh bW1hX2x1dF9zaXplOwo+ICsJCXUzMiBkZWdhbW1hX2x1dF90ZXN0czsKPiArCQl1MzIgZ2FtbWFf bHV0X3Rlc3RzOwo+ICAJfSBjb2xvcjsKPiAgfTsKPiAgCj4gLS0gCj4gMi4xNC41CgotLSAKVmls bGUgU3lyasOkbMOkCkludGVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu dGVsLWdmeAo=