From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v4 8/8] hack: align dumb buffer stride to 4k to allow for gtt remapping Date: Wed, 30 Jan 2019 19:26:37 +0100 Message-ID: <20190130182637.GJ3271@phenom.ffwll.local> References: <20190118152720.24643-9-ville.syrjala@linux.intel.com> <20190118171106.11188-1-ville.syrjala@linux.intel.com> <20190130095415.GC3271@phenom.ffwll.local> <20190130100607.GG3271@phenom.ffwll.local> <20190130153803.GO20097@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by gabe.freedesktop.org (Postfix) with ESMTPS id 97E666EB98 for ; Wed, 30 Jan 2019 18:26:42 +0000 (UTC) Received: by mail-ed1-x542.google.com with SMTP id p6so461652eds.0 for ; Wed, 30 Jan 2019 10:26:42 -0800 (PST) Content-Disposition: inline In-Reply-To: <20190130153803.GO20097@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBKYW4gMzAsIDIwMTkgYXQgMDU6Mzg6MDNQTSArMDIwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIFdlZCwgSmFuIDMwLCAyMDE5IGF0IDExOjA2OjA3QU0gKzAxMDAsIERhbmll bCBWZXR0ZXIgd3JvdGU6Cj4gPiBPbiBXZWQsIEphbiAzMCwgMjAxOSBhdCAxMDo1NDoxNUFNICsw MTAwLCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+ID4gPiBPbiBGcmksIEphbiAxOCwgMjAxOSBhdCAw NzoxMTowNlBNICswMjAwLCBWaWxsZSBTeXJqYWxhIHdyb3RlOgo+ID4gPiA+IEZyb206IFZpbGxl IFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiA+ID4gCj4gPiA+ ID4gdjI6IExlYXZlIHRoZSBzdHJpZGUgYWxvbmUgZm9yIGJ1ZmZlcnMgdGhhdCBsb29rIHRvIGJl IGZvciB0aGUgY3Vyc29yCj4gPiA+ID4gLS0tCj4gPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZ2VtLmMgfCA3ICsrKysrKy0KPiA+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0 aW9ucygrKSwgMSBkZWxldGlvbigtKQo+ID4gPiA+IAo+ID4gPiA+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9n ZW0uYwo+ID4gPiA+IGluZGV4IDFlN2M5NWQwZmVhMS4uYjRiMzQ1MTlhZjgwIDEwMDY0NAo+ID4g PiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiA+ID4gPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gPiA+ID4gQEAgLTc0NSw3ICs3NDUsMTIg QEAgaTkxNV9nZW1fZHVtYl9jcmVhdGUoc3RydWN0IGRybV9maWxlICpmaWxlLAo+ID4gPiA+ICAJ CSAgICAgc3RydWN0IGRybV9tb2RlX2NyZWF0ZV9kdW1iICphcmdzKQo+ID4gPiA+ICB7Cj4gPiA+ ID4gIAkvKiBoYXZlIHRvIHdvcmsgb3V0IHNpemUvcGl0Y2ggYW5kIHJldHVybiB0aGVtICovCj4g PiA+ID4gLQlhcmdzLT5waXRjaCA9IEFMSUdOKGFyZ3MtPndpZHRoICogRElWX1JPVU5EX1VQKGFy Z3MtPmJwcCwgOCksIDY0KTsKPiA+ID4gPiArCWlmIChhcmdzLT5icHAgPT0gMzIgJiYgKGFyZ3Mt PndpZHRoID09IDY0IHx8Cj4gPiA+ID4gKwkJCQlhcmdzLT53aWR0aCA9PSAxMjggfHwKPiA+ID4g PiArCQkJCWFyZ3MtPndpZHRoID09IDI1NikpCj4gPiA+ID4gKwkJYXJncy0+cGl0Y2ggPSBBTElH TihhcmdzLT53aWR0aCAqIERJVl9ST1VORF9VUChhcmdzLT5icHAsIDgpLCA2NCk7Cj4gPiA+ID4g KwllbHNlCj4gPiA+ID4gKwkJYXJncy0+cGl0Y2ggPSBBTElHTihhcmdzLT53aWR0aCAqIERJVl9S T1VORF9VUChhcmdzLT5icHAsIDgpLCA0MDk2KTsKPiA+ID4gCj4gPiA+IFNob3VsZG4ndCB3ZSBj b252ZXJ0IHRoaXMgaW50byBhIG5vbi1oYWNrIGFuZCBqdXN0IGRvIGl0IGFueXRpbWUgdGhlIHBp dGNoCj4gPiA+IGlzIHRvbyB3aWRlIGZvciB0aGUgZGlzcGxheSB0byBoYW5kbGU/Cj4gPiA+IAo+ ID4gPiBPciBhbSBJIG1pc3Npbmcgc29tZXRoaW5nIHNvbWV3aGVyZT8gLW1vZGVzZXR0aW5nIGV0 IGFsbCB3aWxsIGR0cnQKPiA+ID4gYmVjYXVzZSB0aWxpbmcsIGJ1dCB0aGlzIHNob3VsZCBoZWxw IHdpdGggYm9vdCBzcGxhc2hlcyBhbmQgc3R1ZmYgbGlrZQo+ID4gPiB0aGF0IChidXQgdGhvc2Ug dGVuZCB0byBub3QgZG8gc2lkZS1ieS1zaWRlLCBzbyBtYXliZSB0aGF0J3Mgd2h5IHRoZSBnZXQK PiA+ID4gYXdheSB3aXRoIGl0KS4KPiA+IAo+ID4gQ29ycmVjdGlvbjogV2UgbmVlZCB0aGlzLCBh bmQgYmVmb3JlIHdlIHN0YXJ0IGJ1bXBpbmcgdGhlIGxpbWl0cy4gQW55IGR1bWIKPiA+IGJ1ZmZl ciB5b3UgY3JlYXRlICh3aXRoaW4gdGhlIGxpbWl0cykgd2UgbXVzdCBiZSBhYmxlIHRvIHNjYW4g b3V0LiBTbyB3ZQo+ID4gZGVmaW5pdGVseSBuZWVkIHRvIGhhdmUgdGhpcyBmb3Igc3VwZXItYmln IGJ1ZmZlcnMgb24gZ2VuNysuIEV2ZW4gaWYgaXQncwo+ID4gZmFpcmx5IHRoZW9yZXRpY2FsLgo+ IAo+IElzIHRoZXJlIHNvbWUgdXNlcnBzYWNlIHRoYXQgYWN0dWFsbHkgd2FudHMgdG8gY3JlYXRl IGEgaHVnZSBkdW1iCj4gYnVmZmVyIGxpa2UgdGhhdD8KCkdpdmVuIHRoYXQgdGhlIGNvcmUgZHJt X21vZGVfZHVtYl9jcmVhdGUgZG9lc24ndCBjaGVjayBhbnl0aGluZywgSSBndWVzcwpub3QuIFdv dWxkIGJlIGdvb2QgdG8gYWRkLgoKPiBMb29rcyBsaWtlIHdlIGRvbid0IGV2ZW4gY2hlY2sgYWdh aW5zdCB0aGUgbWF4IGZiIGRpbWVuc2lvbnMgaW4KPiBkdW1iX2NyZWF0ZSBzbyB5b3UgY2FuIGNy ZWF0ZSBhbnkgc2l6ZWQgZHVtYiBidWZmZXIgeW91IHdhbnQuCj4gU28gZXZlbiBub3cgdGhlcmUg aXMgbm8gZ3VhcmFudGVlIHRoYXQgdGhlIGFkZGZiIHdpbGwgYWN0dWFsbHkKPiBzdWNjZWVkLgoK V2VsbCB3ZSBkbyB0ZWxsIHVzZXJzcGFjZSB1cCB0byB3aGF0IGxpbWl0IHdlIGV4cGVjdCBpdCB0 byBzdWNjZWVkLCBhbmQKZHVtYl9jcmVhdGUgaXMgc3VwcG9zZWQgdG8gY29tZSB1cCB3aXRoIHRo ZSBjb3JyZWN0IHN0cmlkZS4gSSB0aGluawp0aGVyZSdzIG5vIGdvb2QgcmVhc29uIHRvIGdpdmUg dXNlcnNwYWNlIGEgc3RyaWRlIHRoYXQgZG9lc24ndCB3b3JrIGF0CmFsbCwgYW5kIGl0J3MgZXNz ZW50aWFsbHkgdGhpcyBwYXRjaCwgYnV0IHdpdGggYSBzbGlnaHRseSBkaWZmZXJlbnQgaWYKY29u ZGl0aW9uLgotRGFuaWVsCgo+IAo+ID4gCj4gPiBJIHRoaW5rIHdlIHNob3VsZCBldmVuIGhhdmUg YW4gaWd0IHdoaWNoIGNyZWF0ZXMgYSBtYXggc2l6ZSBidWZmZXIgKHVzaW5nCj4gPiBkdW1iIGNy ZWF0ZSkgYW5kIHRoZW4gbWFrZXMgc3VyZSB3ZSBjYW4gc2NhbiB0aGF0IG91dC4KPiA+IC1EYW5p ZWwKPiA+IAo+ID4gPiAtRGFuaWVsCj4gPiA+IAo+ID4gPiA+ICAJYXJncy0+c2l6ZSA9IGFyZ3Mt PnBpdGNoICogYXJncy0+aGVpZ2h0Owo+ID4gPiA+ICAJcmV0dXJuIGk5MTVfZ2VtX2NyZWF0ZShm aWxlLCB0b19pOTE1KGRldiksCj4gPiA+ID4gIAkJCSAgICAgICBhcmdzLT5zaXplLCAmYXJncy0+ aGFuZGxlKTsKPiA+ID4gPiAtLSAKPiA+ID4gPiAyLjE5LjIKPiA+ID4gPiAKPiA+ID4gPiBfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ID4gPiA+IEludGVs LWdmeCBtYWlsaW5nIGxpc3QKPiA+ID4gPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cj4gPiA+ID4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZngKPiA+ID4gCj4gPiA+IC0tIAo+ID4gPiBEYW5pZWwgVmV0dGVyCj4gPiA+IFNvZnR3 YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgo+ID4gPiBodHRwOi8vYmxvZy5mZndsbC5j aAo+ID4gCj4gPiAtLSAKPiA+IERhbmllbCBWZXR0ZXIKPiA+IFNvZnR3YXJlIEVuZ2luZWVyLCBJ bnRlbCBDb3Jwb3JhdGlvbgo+ID4gaHR0cDovL2Jsb2cuZmZ3bGwuY2gKPiAKPiAtLSAKPiBWaWxs ZSBTeXJqw6Rsw6QKPiBJbnRlbAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIs IEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50 ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=