From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Roper Subject: Re: [PATCH] drm/i915: Apply LUT validation checks to platforms more accurately (v2) Date: Wed, 30 Jan 2019 17:12:49 -0800 Message-ID: <20190131011249.GC10103@mdroper-desk.amr.corp.intel.com> References: <20190128200522.GV20097@intel.com> <20190130004928.20699-1-matthew.d.roper@intel.com> <20190130142847.GL20097@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 37B846E65A for ; Thu, 31 Jan 2019 01:12:50 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190130142847.GL20097@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBKYW4gMzAsIDIwMTkgYXQgMDQ6Mjg6NDdQTSArMDIwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIFR1ZSwgSmFuIDI5LCAyMDE5IGF0IDA0OjQ5OjI4UE0gLTA4MDAsIE1hdHQg Um9wZXIgd3JvdGU6Cj4gPiBVc2Ugb2YgdGhlIG5ldyBEUk1fQ09MT1JfTFVUX05PTl9ERUNSRUFT SU5HIHRlc3Qgd2FzIGEgYml0IG92ZXItemVhbG91czsKPiA+IGl0IGRvZXNuJ3QgYWN0dWFsbHkg bmVlZCB0byBiZSBhcHBsaWVkIHRvIHRoZSBkZWdhbW1hIG9uICJiZHctc3R5bGUiCj4gPiBwbGF0 Zm9ybXMuICBMaWtld2lzZSwgd2Ugb3Zlcmxvb2tlZCB0aGUgZmFjdCB0aGF0IENIViBzaG91bGQg aGF2ZSB0aGF0Cj4gPiB0ZXN0IGFwcGxpZWQgdG8gdGhlIGdhbW1hIExVVCBhcyB3ZWxsIGFzIHRo ZSBkZWdhbW1hIExVVC4KPiA+IAo+ID4gUmF0aGVyIHRoYW4gYWRkaW5nIG1vcmUgY29tcGxpY2F0 ZWQgcGxhdGZvcm0gY2hlY2tpbmcgdG8KPiA+IGludGVsX2NvbG9yX2NoZWNrKCksIGxldCdzIGp1 c3Qgc3RvcmUgdGhlIGFwcHJvcHJpYXRlIHNldCBvZiBMVVQKPiA+IHZhbGlkYXRpb24gZmxhZ3Mg Zm9yIGVhY2ggcGxhdGZvcm0gaW4gdGhlIGludGVsX2RldmljZV9pbmZvIHN0cnVjdHVyZS4KPiA+ IAo+ID4gdjI6Cj4gPiAgLSBTaHVmZmxlIGFyb3VuZCBMVVQgc2l6ZSB0ZXN0cyBzbyB0aGF0IHRo ZSBoYXJkd2FyZS1zcGVjaWZpYyB0ZXN0cwo+ID4gICAgd29uJ3QgYmUgYXBwbGllZCB0byBsZWdh Y3kgZ2FtbWEgdGFibGVzLiAgKFZpbGxlKQo+ID4gIC0gQWRkIGEgZGVidWcgbWVzc2FnZSBzbyB0 aGF0IGl0IHdpbGwgYmUgZWFzaWVyIHRvIHVuZGVyc3RhbmQgd2h5IGFuCj4gPiAgICBhdG9taWMg dHJhbnNhY3Rpb24gaW52b2x2aW5nIGluY29ycmVjdGx5LXNpemVkIExVVCdzIGdvdCByZWplY3Rl ZAo+ID4gICAgYnkgdGhlIGRyaXZlci4KPiA+IAo+ID4gRml4ZXM6IDg1ZTJkNjFlNDk3NiAoImRy bS9pOTE1OiBWYWxpZGF0ZSB1c2Vyc3BhY2UtcHJvdmlkZWQgY29sb3IgbWFuYWdlbWVudCBMVVQn cyAodjQpIikKPiA+IFJlZmVyZW5jZXM6IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL2Fy Y2hpdmVzL2ludGVsLWdmeC8yMDE5LUphbnVhcnkvMTg3NjM0Lmh0bWwKPiA+IENjOiBWaWxsZSBT eXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ID4gU2lnbmVkLW9mZi1i eTogTWF0dCBSb3BlciA8bWF0dGhldy5kLnJvcGVyQGludGVsLmNvbT4KPiA+IC0tLQo+ID4gIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcGNpLmMgICAgICAgICAgfCAxMCArKysrLS0KPiA+ICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jb2xvci5jICAgICAgIHwgNTggKysrKysrKysrKysr KysrKy0tLS0tLS0tLS0tLS0tLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZXZp Y2VfaW5mby5oIHwgIDIgKysKPiA+ICAzIGZpbGVzIGNoYW5nZWQsIDM5IGluc2VydGlvbnMoKyks IDMxIGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9wY2kuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcGNpLmMKPiA+IGluZGV4 IDQ0YzIzYWM2MDM0Ny4uMTdmNWE2MDViMGIzIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9wY2kuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9w Y2kuYwo+ID4gQEAgLTY5LDkgKzY5LDE1IEBACj4gPiAgI2RlZmluZSBCRFdfQ09MT1JTIFwKPiA+ ICAJLmNvbG9yID0geyAuZGVnYW1tYV9sdXRfc2l6ZSA9IDUxMiwgLmdhbW1hX2x1dF9zaXplID0g NTEyIH0KPiA+ICAjZGVmaW5lIENIVl9DT0xPUlMgXAo+ID4gLQkuY29sb3IgPSB7IC5kZWdhbW1h X2x1dF9zaXplID0gNjUsIC5nYW1tYV9sdXRfc2l6ZSA9IDI1NyB9Cj4gPiArCS5jb2xvciA9IHsg LmRlZ2FtbWFfbHV0X3NpemUgPSA2NSwgLmdhbW1hX2x1dF9zaXplID0gMjU3LCBcCj4gPiArCQkg ICAuZGVnYW1tYV9sdXRfdGVzdHMgPSBEUk1fQ09MT1JfTFVUX05PTl9ERUNSRUFTSU5HLCBcCj4g PiArCQkgICAuZ2FtbWFfbHV0X3Rlc3RzID0gRFJNX0NPTE9SX0xVVF9OT05fREVDUkVBU0lORywg XAo+ID4gKwl9Cj4gPiAgI2RlZmluZSBHTEtfQ09MT1JTIFwKPiA+IC0JLmNvbG9yID0geyAuZGVn YW1tYV9sdXRfc2l6ZSA9IDAsIC5nYW1tYV9sdXRfc2l6ZSA9IDEwMjQgfQo+ID4gKwkuY29sb3Ig PSB7IC5kZWdhbW1hX2x1dF9zaXplID0gMCwgLmdhbW1hX2x1dF9zaXplID0gMTAyNCwgXAo+ID4g KwkJICAgLmRlZ2FtbWFfbHV0X3Rlc3RzID0gRFJNX0NPTE9SX0xVVF9OT05fREVDUkVBU0lORyB8 IFwKPiA+ICsJCQkJCURSTV9DT0xPUl9MVVRfRVFVQUxfQ0hBTk5FTFMsIFwKPiA+ICsJfQo+ID4g IAo+ID4gIC8qIEtlZXAgaW4gZ2VuIGJhc2VkIG9yZGVyLCBhbmQgY2hyb25vbG9naWNhbCBvcmRl ciB3aXRoaW4gYSBnZW4gKi8KPiA+ICAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9jb2xvci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY29sb3IuYwo+ ID4gaW5kZXggYmM3NTg5NjU2YThmLi41OWI4YTY0NGIyMTggMTAwNjQ0Cj4gPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jb2xvci5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9jb2xvci5jCj4gPiBAQCAtNjA1LDQ4ICs2MDUsNDggQEAgdm9pZCBpbnRlbF9j b2xvcl9sb2FkX2x1dHMoc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUpCj4gPiAg CWRldl9wcml2LT5kaXNwbGF5LmxvYWRfbHV0cyhjcnRjX3N0YXRlKTsKPiA+ICB9Cj4gPiAgCj4g PiArc3RhdGljIGludCBjaGVja19sdXRfc2l6ZShjb25zdCBzdHJ1Y3QgZHJtX3Byb3BlcnR5X2Js b2IgKmx1dCwgc2l6ZV90IGV4cGVjdGVkKQo+ID4gK3sKPiA+ICsJc2l6ZV90IGxlbjsKPiAKPiBJ J2QgcHJvYmFibHkganVzdCB1c2UgaW50IGhlcmUuIHNpemVfdCBtYWtlcyBtZSB0aGluayBpdCdz IGluIGJ5dGVzIG9yCj4gc29tZXRoaW5nIGxpa2UgdGhhdC4KPiAKPiBPdGhlcndpc2UgbGd0bS4g RWl0aGVyIHdheQo+IFJldmlld2VkLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFA bGludXguaW50ZWwuY29tPgoKU3dpdGNoZWQgdG8gaW50J3MgYW5kIEJBVCBpcyBzdGlsbCBoYXBw eSwgc28gYXBwbGllZCB0byBkaW5xLiAgVGhhbmtzCmZvciB0aGUgcmV2aWV3LgoKCk1hdHQKCj4g Cj4gPiArCj4gPiArCWlmICghbHV0KQo+ID4gKwkJcmV0dXJuIDA7Cj4gPiArCj4gPiArCWxlbiA9 IGRybV9jb2xvcl9sdXRfc2l6ZShsdXQpOwo+ID4gKwlpZiAobGVuICE9IGV4cGVjdGVkKSB7Cj4g PiArCQlEUk1fREVCVUdfS01TKCJJbnZhbGlkIExVVCBzaXplOyBnb3QgJWx1LCBleHBlY3RlZCAl bHVcbiIsCj4gPiArCQkJICAgICAgbGVuLCBleHBlY3RlZCk7Cj4gPiArCQlyZXR1cm4gLUVJTlZB TDsKPiA+ICsJfQo+ID4gKwo+ID4gKwlyZXR1cm4gMDsKPiA+ICt9Cj4gPiArCj4gPiAgaW50IGlu dGVsX2NvbG9yX2NoZWNrKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlKQo+ID4g IHsKPiA+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShjcnRj X3N0YXRlLT5iYXNlLmNydGMtPmRldik7Cj4gPiAgCXNpemVfdCBnYW1tYV9sZW5ndGgsIGRlZ2Ft bWFfbGVuZ3RoOwo+ID4gLQl1aW50MzJfdCB0ZXN0cyA9IERSTV9DT0xPUl9MVVRfTk9OX0RFQ1JF QVNJTkc7Cj4gPiArCXUzMiBnYW1tYV90ZXN0cywgZGVnYW1tYV90ZXN0czsKPiA+ICAKPiA+ICAJ ZGVnYW1tYV9sZW5ndGggPSBJTlRFTF9JTkZPKGRldl9wcml2KS0+Y29sb3IuZGVnYW1tYV9sdXRf c2l6ZTsKPiA+ICAJZ2FtbWFfbGVuZ3RoID0gSU5URUxfSU5GTyhkZXZfcHJpdiktPmNvbG9yLmdh bW1hX2x1dF9zaXplOwo+ID4gKwlkZWdhbW1hX3Rlc3RzID0gSU5URUxfSU5GTyhkZXZfcHJpdikt PmNvbG9yLmRlZ2FtbWFfbHV0X3Rlc3RzOwo+ID4gKwlnYW1tYV90ZXN0cyA9IElOVEVMX0lORk8o ZGV2X3ByaXYpLT5jb2xvci5nYW1tYV9sdXRfdGVzdHM7Cj4gPiAgCj4gPiAtCS8qCj4gPiAtCSAq IEFsbCBvZiBvdXIgcGxhdGZvcm1zIG1hbmRhdGUgdGhhdCB0aGUgZGVnYW1tYSBjdXJ2ZSBiZQo+ ID4gLQkgKiBub24tZGVjcmVhc2luZy4gIEFkZGl0aW9uYWxseSwgR0xLIGFuZCBnZW4xMSBvbmx5 IGFjY2VwdCBhIHNpbmdsZQo+ID4gLQkgKiB2YWx1ZSBmb3IgcmVkLCBncmVlbiwgYW5kIGJsdWUg aW4gdGhlIGRlZ2FtbWEgdGFibGUuICBNYWtlIHN1cmUKPiA+IC0JICogdXNlcnNwYWNlIGRpZG4n dCB0cnkgdG8gcGFzcyB1cyBzb21ldGhpbmcgd2UgY2FuJ3QgaGFuZGxlLgo+ID4gLQkgKgo+ID4g LQkgKiBXZSBkb24ndCBoYXZlIGFueSBleHRyYSBoYXJkd2FyZSBjb25zdHJhaW50cyBvbiB0aGUg Z2FtbWEgdGFibGUsCj4gPiAtCSAqIHNvIG5vIG5lZWQgdG8gZXhwbGljaXRseSBjaGVjayBpdC4K PiA+IC0JICovCj4gPiAtCWlmIChJU19HRU1JTklMQUtFKGRldl9wcml2KSB8fCBJTlRFTF9HRU4o ZGV2X3ByaXYpID49IDEwKQo+ID4gLQkJdGVzdHMgfD0gRFJNX0NPTE9SX0xVVF9FUVVBTF9DSEFO TkVMUzsKPiA+ICsJLyogQWx3YXlzIGFsbG93IGxlZ2FjeSBnYW1tYSBMVVQgd2l0aCBubyBmdXJ0 aGVyIGNoZWNraW5nLiAqLwo+ID4gKwlpZiAoY3J0Y19zdGF0ZV9pc19sZWdhY3lfZ2FtbWEoY3J0 Y19zdGF0ZSkpCj4gPiArCQlyZXR1cm4gMDsKPiA+ICAKPiA+IC0JaWYgKGRybV9jb2xvcl9sdXRf Y2hlY2soY3J0Y19zdGF0ZS0+YmFzZS5kZWdhbW1hX2x1dCwgdGVzdHMpICE9IDApCj4gPiArCWlm IChjaGVja19sdXRfc2l6ZShjcnRjX3N0YXRlLT5iYXNlLmRlZ2FtbWFfbHV0LCBkZWdhbW1hX2xl bmd0aCkgfHwKPiA+ICsJICAgIGNoZWNrX2x1dF9zaXplKGNydGNfc3RhdGUtPmJhc2UuZ2FtbWFf bHV0LCBnYW1tYV9sZW5ndGgpKQo+ID4gIAkJcmV0dXJuIC1FSU5WQUw7Cj4gPiAgCj4gPiAtCS8q Cj4gPiAtCSAqIFdlIGFsbG93IGJvdGggZGVnYW1tYSAmIGdhbW1hIGx1dHMgYXQgdGhlIHJpZ2h0 IHNpemUgb3IKPiA+IC0JICogTlVMTC4KPiA+IC0JICovCj4gPiAtCWlmICgoIWNydGNfc3RhdGUt PmJhc2UuZGVnYW1tYV9sdXQgfHwKPiA+IC0JICAgICBkcm1fY29sb3JfbHV0X3NpemUoY3J0Y19z dGF0ZS0+YmFzZS5kZWdhbW1hX2x1dCkgPT0gZGVnYW1tYV9sZW5ndGgpICYmCj4gPiAtCSAgICAo IWNydGNfc3RhdGUtPmJhc2UuZ2FtbWFfbHV0IHx8Cj4gPiAtCSAgICAgZHJtX2NvbG9yX2x1dF9z aXplKGNydGNfc3RhdGUtPmJhc2UuZ2FtbWFfbHV0KSA9PSBnYW1tYV9sZW5ndGgpKQo+ID4gLQkJ cmV0dXJuIDA7Cj4gPiArCWlmIChkcm1fY29sb3JfbHV0X2NoZWNrKGNydGNfc3RhdGUtPmJhc2Uu ZGVnYW1tYV9sdXQsIGRlZ2FtbWFfdGVzdHMpIHx8Cj4gPiArCSAgICBkcm1fY29sb3JfbHV0X2No ZWNrKGNydGNfc3RhdGUtPmJhc2UuZ2FtbWFfbHV0LCBnYW1tYV90ZXN0cykpCj4gPiArCQlyZXR1 cm4gLUVJTlZBTDsKPiA+ICAKPiA+IC0JLyoKPiA+IC0JICogV2UgYWxzbyBhbGxvdyBubyBkZWdh bW1hIGx1dC9jdG0gYW5kIGEgZ2FtbWEgbHV0IGF0IHRoZSBsZWdhY3kKPiA+IC0JICogc2l6ZSAo MjU2IGVudHJpZXMpLgo+ID4gLQkgKi8KPiA+IC0JaWYgKGNydGNfc3RhdGVfaXNfbGVnYWN5X2dh bW1hKGNydGNfc3RhdGUpKQo+ID4gLQkJcmV0dXJuIDA7Cj4gPiAgCj4gPiAtCXJldHVybiAtRUlO VkFMOwo+ID4gKwlyZXR1cm4gMDsKPiA+ICB9Cj4gPiAgCj4gPiAgdm9pZCBpbnRlbF9jb2xvcl9p bml0KHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjKQo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2RldmljZV9pbmZvLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kZXZpY2VfaW5mby5oCj4gPiBpbmRleCA5NTdjNjUyN2Y3NmIuLjdiZjA5Y2VmNTkxYSAxMDA2 NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RldmljZV9pbmZvLmgKPiA+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RldmljZV9pbmZvLmgKPiA+IEBAIC0x ODksNiArMTg5LDggQEAgc3RydWN0IGludGVsX2RldmljZV9pbmZvIHsKPiA+ICAJc3RydWN0IGNv bG9yX2x1dHMgewo+ID4gIAkJdTE2IGRlZ2FtbWFfbHV0X3NpemU7Cj4gPiAgCQl1MTYgZ2FtbWFf bHV0X3NpemU7Cj4gPiArCQl1MzIgZGVnYW1tYV9sdXRfdGVzdHM7Cj4gPiArCQl1MzIgZ2FtbWFf bHV0X3Rlc3RzOwo+ID4gIAl9IGNvbG9yOwo+ID4gIH07Cj4gPiAgCj4gPiAtLSAKPiA+IDIuMTQu NQo+IAo+IC0tIAo+IFZpbGxlIFN5cmrDpGzDpAo+IEludGVsCgotLSAKTWF0dCBSb3BlcgpHcmFw aGljcyBTb2Z0d2FyZSBFbmdpbmVlcgpJb1RHIFBsYXRmb3JtIEVuYWJsaW5nICYgRGV2ZWxvcG1l bnQKSW50ZWwgQ29ycG9yYXRpb24KKDkxNikgMzU2LTI3OTUKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==