From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915/opregion: rvda is relative from opregion base, not absolute Date: Thu, 31 Jan 2019 10:24:29 +0200 Message-ID: <20190131082429.GV20097@intel.com> References: <20190129133121.32564-1-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6771C6EC12 for ; Thu, 31 Jan 2019 08:24:33 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190129133121.32564-1-jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBKYW4gMjksIDIwMTkgYXQgMDM6MzE6MjFQTSArMDIwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gV2UndmUgc3VwcG9ydGVkIHRoZSBvcHJlZ2lvbiBSVkRBL1JWRFMgZmllbGRzIGZvciBW QlQgc2l6ZSA+PSA2IEtCIHNpbmNlCj4gY29tbWl0IDA0ZWJhYWRiOWYyZCAoImRybS9pOTE1L29w cmVnaW9uOiBoYW5kbGUgVkJUIHNpemVzIGJpZ2dlciB0aGFuIDYKPiBLQiIpLiBUaGF0J3MgdGhy ZWUgeWVhcnMsIGFsbW9zdCB0byB0aGUgZGF0ZS4KPiAKPiBUaGUgaW1wbGVtZW50YXRpb24gd2Fz IGJhc2VkIG9uIHNwZWMgb25seSwgaW4gYW50aWNpcGF0aW9uIG9mIHN5c3RlbXMKPiB3aXRoIGJp ZyBWQlQuIE5vdywgdGhlIHNwZWMgaGFzIGJlZW4gY2hhbmdlZC4gVGhlIFJWREEgaXMgc3VwcG9z ZWQgdG8gYmUKPiByZWxhdGl2ZSBmcm9tIHRoZSBiZWdpbm5pbmcgb2Ygb3ByZWdpb24sIG5vdCBh YnNvbHV0ZSBhZGRyZXNzLgo+IAo+IFRoaXMgaXMgb2J2aW91c2x5IGEgYmFja3dhcmQvZm9yd2Fy ZCBpbmNvbXBhdGlibGUgY2hhbmdlLiBJJ3ZlIGJlZW4gdG9sZAo+IHRoZXJlIGFyZSBubyBzeXN0 ZW1zIG91dCB0aGVyZSB1c2luZyB0aGUgZmllbGQuIEZpbmdlcnMgY3Jvc3NlZC4gVGhpcwo+IHdp bGwgc3RpbGwgYmUgcHJvYmxlbWF0aWMgZm9yIG9sZGVyIGtlcm5lbHMsIGFuZCB3ZSBjYW4gb25s eSB0cnkgdG8KPiBiYWNrcG9ydCB0aGUgZml4Lgo+IAo+IEZpeCB0aGUgZXJyb3IgcGF0aCB3aGls ZSBhdCBpdC4KPiAKPiBGaXhlczogMDRlYmFhZGI5ZjJkICgiZHJtL2k5MTUvb3ByZWdpb246IGhh bmRsZSBWQlQgc2l6ZXMgYmlnZ2VyIHRoYW4gNiBLQiIpCj4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8 dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IEltcmUgRGVhayA8aW1yZS5kZWFr QGludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50 ZWwuY29tPgoKUmV2aWV3ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51 eC5pbnRlbC5jb20+Cgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9vcHJlZ2lv bi5jIHwgMTIgKysrKysrKysrKy0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCsp LCAyIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9vcHJlZ2lvbi5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfb3ByZWdpb24uYwo+ IGluZGV4IDMwYWU5NmM1Yzk3Yy4uMzAzMjRiOTYzZTI0IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX29wcmVnaW9uLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9vcHJlZ2lvbi5jCj4gQEAgLTExOCw3ICsxMTgsNyBAQCBzdHJ1Y3Qgb3ByZWdpb25f YXNsZSB7Cj4gIAl1NjQgZmRzczsKPiAgCXUzMiBmZHNwOwo+ICAJdTMyIHN0YXQ7Cj4gLQl1NjQg cnZkYTsJLyogUGh5c2ljYWwgYWRkcmVzcyBvZiByYXcgdmJ0IGRhdGEgKi8KPiArCXU2NCBydmRh OwkvKiBBZGRyZXNzIG9mIHJhdyB2YnQgZGF0YSwgcmVsYXRpdmUgZnJvbSBvcHJlZ2lvbiAqLwo+ ICAJdTMyIHJ2ZHM7CS8qIFNpemUgb2YgcmF3IHZidCBkYXRhICovCj4gIAl1OCByc3ZkWzU4XTsK PiAgfSBfX3BhY2tlZDsKPiBAQCAtOTU0LDcgKzk1NCwxMyBAQCBpbnQgaW50ZWxfb3ByZWdpb25f c2V0dXAoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAKPiAgCWlmIChvcHJl Z2lvbi0+aGVhZGVyLT5vcHJlZ2lvbl92ZXIgPj0gMiAmJiBvcHJlZ2lvbi0+YXNsZSAmJgo+ICAJ ICAgIG9wcmVnaW9uLT5hc2xlLT5ydmRhICYmIG9wcmVnaW9uLT5hc2xlLT5ydmRzKSB7Cj4gLQkJ b3ByZWdpb24tPnJ2ZGEgPSBtZW1yZW1hcChvcHJlZ2lvbi0+YXNsZS0+cnZkYSwKPiArCQkvKgo+ ICsJCSAqIHJ2ZGEgaXMgdW5zaWduZWQsIHJlbGF0aXZlIGZyb20gb3ByZWdpb24gYmFzZSwgYW5k IHNob3VsZAo+ICsJCSAqIG5ldmVyIHBvaW50IHdpdGhpbiBvcHJlZ2lvbi4KPiArCQkgKi8KPiAr CQlXQVJOX09OKG9wcmVnaW9uLT5hc2xlLT5ydmRhIDwgT1BSRUdJT05fU0laRSk7Cj4gKwo+ICsJ CW9wcmVnaW9uLT5ydmRhID0gbWVtcmVtYXAoYXNscyArIG9wcmVnaW9uLT5hc2xlLT5ydmRhLAo+ ICAJCQkJCSAgb3ByZWdpb24tPmFzbGUtPnJ2ZHMsCj4gIAkJCQkJICBNRU1SRU1BUF9XQik7Cj4g IAkJdmJ0ID0gb3ByZWdpb24tPnJ2ZGE7Cj4gQEAgLTk2Niw2ICs5NzIsOCBAQCBpbnQgaW50ZWxf b3ByZWdpb25fc2V0dXAoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJCQln b3RvIG91dDsKPiAgCQl9IGVsc2Ugewo+ICAJCQlEUk1fREVCVUdfS01TKCJJbnZhbGlkIFZCVCBp biBBQ1BJIE9wUmVnaW9uIChSVkRBKVxuIik7Cj4gKwkJCW1lbXVubWFwKG9wcmVnaW9uLT5ydmRh KTsKPiArCQkJb3ByZWdpb24tPnJ2ZGEgPSBOVUxMOwo+ICAJCX0KPiAgCX0KPiAgCj4gLS0gCj4g Mi4yMC4xCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=