From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2 RESEND 2/2] drm/i915/icl: Implement half float formats Date: Fri, 1 Feb 2019 22:40:00 +0200 Message-ID: <20190201204000.GF20097@intel.com> References: <1549043020-5124-1-git-send-email-kevin.strasser@intel.com> <1549043020-5124-3-git-send-email-kevin.strasser@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1549043020-5124-3-git-send-email-kevin.strasser@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Kevin Strasser Cc: David Airlie , Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Uma Shankar List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBGZWIgMDEsIDIwMTkgYXQgMDk6NDM6NDBBTSAtMDgwMCwgS2V2aW4gU3RyYXNzZXIg d3JvdGU6Cj4gNjQgYnBwIGhhbGYgZmxvYXQgZm9ybWF0cyBhcmUgc3VwcG9ydGVkIG9uIGhkciBw bGFuZXMgb25seSBhbmQgYXJlIHN1YmplY3QKPiB0byB0aGUgZm9sbG93aW5nIHJlc3RyaWN0aW9u czoKPiAgICogOTAvMjcwIHJvdGF0aW9uIG5vdCBzdXBwb3J0ZWQKPiAgICogWWYgVGlsaW5nIG5v dCBzdXBwb3J0ZWQKPiAgICogRnJhbWUgQnVmZmVyIENvbXByZXNzaW9uIG5vdCBzdXBwb3J0ZWQK PiAgICogQ29sb3IgS2V5aW5nIG5vdCBzdXBwb3J0ZWQKPiAKPiB2MjoKPiAtIERyb3AgaGFuZGxp bmcgcGl4ZWwgbm9ybWFsaXplIHJlZ2lzdGVyCj4gLSBEb24ndCB1c2UgaWNsX2lzX2hkcl9wbGFu ZSB0b28gZWFybHkKPiAKPiBTaWduZWQtb2ZmLWJ5OiBLZXZpbiBTdHJhc3NlciA8a2V2aW4uc3Ry YXNzZXJAaW50ZWwuY29tPgo+IENjOiBVbWEgU2hhbmthciA8dW1hLnNoYW5rYXJAaW50ZWwuY29t Pgo+IENjOiBTaGFzaGFuayBTaGFybWEgPHNoYXNoYW5rLnNoYXJtYUBpbnRlbC5jb20+Cj4gQ2M6 IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IERh dmlkIEFpcmxpZSA8YWlybGllZEBsaW51eC5pZT4KPiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVs LnZldHRlckBmZndsbC5jaD4KPiBDYzogZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCAyMiArKysrKysr KysrKysKPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMgIHwgNjcgKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKystLS0tCj4gIDIgZmlsZXMgY2hhbmdlZCwgODMgaW5z ZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz cGxheS5jCj4gaW5kZXggYTZkODk4NS4uZjQxM2NjZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kaXNwbGF5LmMKPiBAQCAtMjY2OCw2ICsyNjY4LDE4IEBAIGludCBza2xfZm9ybWF0X3Rv X2ZvdXJjYyhpbnQgZm9ybWF0LCBib29sIHJnYl9vcmRlciwgYm9vbCBhbHBoYSkKPiAgCQlyZXR1 cm4gRFJNX0ZPUk1BVF9SR0I1NjU7Cj4gIAljYXNlIFBMQU5FX0NUTF9GT1JNQVRfTlYxMjoKPiAg CQlyZXR1cm4gRFJNX0ZPUk1BVF9OVjEyOwo+ICsJY2FzZSBQTEFORV9DVExfRk9STUFUX1hSR0Jf MTYxNjE2MTZGOgo+ICsJCWlmIChyZ2Jfb3JkZXIpIHsKPiArCQkJaWYgKGFscGhhKQo+ICsJCQkJ cmV0dXJuIERSTV9GT1JNQVRfQUJHUjE2MTYxNjE2RjsKPiArCQkJZWxzZQo+ICsJCQkJcmV0dXJu IERSTV9GT1JNQVRfWEJHUjE2MTYxNjE2RjsKPiArCQl9IGVsc2Ugewo+ICsJCQlpZiAoYWxwaGEp Cj4gKwkJCQlyZXR1cm4gRFJNX0ZPUk1BVF9BUkdCMTYxNjE2MTZGOwo+ICsJCQllbHNlCj4gKwkJ CQlyZXR1cm4gRFJNX0ZPUk1BVF9YUkdCMTYxNjE2MTZGOwo+ICsJCX0KPiAgCWRlZmF1bHQ6Cj4g IAljYXNlIFBMQU5FX0NUTF9GT1JNQVRfWFJHQl84ODg4Ogo+ICAJCWlmIChyZ2Jfb3JkZXIpIHsK PiBAQCAtMzU2Niw2ICszNTc4LDEyIEBAIHN0YXRpYyB1MzIgc2tsX3BsYW5lX2N0bF9mb3JtYXQo dTMyIHBpeGVsX2Zvcm1hdCkKPiAgCQlyZXR1cm4gUExBTkVfQ1RMX0ZPUk1BVF9ZVVY0MjIgfCBQ TEFORV9DVExfWVVWNDIyX1ZZVVk7Cj4gIAljYXNlIERSTV9GT1JNQVRfTlYxMjoKPiAgCQlyZXR1 cm4gUExBTkVfQ1RMX0ZPUk1BVF9OVjEyOwo+ICsJY2FzZSBEUk1fRk9STUFUX1hCR1IxNjE2MTYx NkY6Cj4gKwljYXNlIERSTV9GT1JNQVRfQUJHUjE2MTYxNjE2RjoKPiArCQlyZXR1cm4gUExBTkVf Q1RMX0ZPUk1BVF9YUkdCXzE2MTYxNjE2RiB8IFBMQU5FX0NUTF9PUkRFUl9SR0JYOwo+ICsJY2Fz ZSBEUk1fRk9STUFUX1hSR0IxNjE2MTYxNkY6Cj4gKwljYXNlIERSTV9GT1JNQVRfQVJHQjE2MTYx NjE2RjoKPiArCQlyZXR1cm4gUExBTkVfQ1RMX0ZPUk1BVF9YUkdCXzE2MTYxNjE2RjsKPiAgCWRl ZmF1bHQ6Cj4gIAkJTUlTU0lOR19DQVNFKHBpeGVsX2Zvcm1hdCk7Cj4gIAl9Cj4gQEAgLTUwNjks NiArNTA4NywxMCBAQCBzdGF0aWMgaW50IHNrbF91cGRhdGVfc2NhbGVyX3BsYW5lKHN0cnVjdCBp bnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlLAo+ICAJY2FzZSBEUk1fRk9STUFUX1VZVlk6Cj4g IAljYXNlIERSTV9GT1JNQVRfVllVWToKPiAgCWNhc2UgRFJNX0ZPUk1BVF9OVjEyOgo+ICsJY2Fz ZSBEUk1fRk9STUFUX1hCR1IxNjE2MTYxNkY6Cj4gKwljYXNlIERSTV9GT1JNQVRfQUJHUjE2MTYx NjE2RjoKPiArCWNhc2UgRFJNX0ZPUk1BVF9YUkdCMTYxNjE2MTZGOgo+ICsJY2FzZSBEUk1fRk9S TUFUX0FSR0IxNjE2MTYxNkY6Cj4gIAkJYnJlYWs7Cj4gIAlkZWZhdWx0Ogo+ICAJCURSTV9ERUJV R19LTVMoIltQTEFORTolZDolc10gRkI6JWQgdW5zdXBwb3J0ZWQgc2NhbGluZyBmb3JtYXQgMHgl eFxuIiwKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYwo+IGluZGV4IGNkNDJlODEuLjk3 ZjlkMDUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMK PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYwo+IEBAIC0xNDUwLDgg KzE0NTAsNiBAQCBzdGF0aWMgaW50IHNrbF9wbGFuZV9jaGVja19mYihjb25zdCBzdHJ1Y3QgaW50 ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSwKPiAgCQkvKgo+ICAJCSAqIDkwLzI3MCBpcyBub3Qg YWxsb3dlZCB3aXRoIFJHQjY0IDE2OjE2OjE2OjE2IGFuZAo+ICAJCSAqIEluZGV4ZWQgOC1iaXQu IFJHQiAxNi1iaXQgNTo2OjUgaXMgYWxsb3dlZCBnZW4xMSBvbndhcmRzLgo+IC0JCSAqIFRCRDog QWRkIFJHQjY0IGNhc2Ugb25jZSBpdHMgYWRkZWQgaW4gc3VwcG9ydGVkIGZvcm1hdAo+IC0JCSAq IGxpc3QuCj4gIAkJICovCj4gIAkJc3dpdGNoIChmYi0+Zm9ybWF0LT5mb3JtYXQpIHsKPiAgCQlj YXNlIERSTV9GT1JNQVRfUkdCNTY1Ogo+IEBAIC0xNDU5LDYgKzE0NTcsMTAgQEAgc3RhdGljIGlu dCBza2xfcGxhbmVfY2hlY2tfZmIoY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNf c3RhdGUsCj4gIAkJCQlicmVhazsKPiAgCQkJLyogZmFsbCB0aHJvdWdoICovCj4gIAkJY2FzZSBE Uk1fRk9STUFUX0M4Ogo+ICsJCWNhc2UgRFJNX0ZPUk1BVF9YUkdCMTYxNjE2MTZGOgo+ICsJCWNh c2UgRFJNX0ZPUk1BVF9YQkdSMTYxNjE2MTZGOgo+ICsJCWNhc2UgRFJNX0ZPUk1BVF9BUkdCMTYx NjE2MTZGOgo+ICsJCWNhc2UgRFJNX0ZPUk1BVF9BQkdSMTYxNjE2MTZGOgo+ICAJCQlEUk1fREVC VUdfS01TKCJVbnN1cHBvcnRlZCBwaXhlbCBmb3JtYXQgJXMgZm9yIDkwLzI3MCFcbiIsCj4gIAkJ CQkgICAgICBkcm1fZ2V0X2Zvcm1hdF9uYW1lKGZiLT5mb3JtYXQtPmZvcm1hdCwKPiAgCQkJCQkJ CSAgJmZvcm1hdF9uYW1lKSk7Cj4gQEAgLTE3NzQsNiArMTc3Niw0NSBAQCBzdGF0aWMgY29uc3Qg dTMyIHNrbF9wbGFuYXJfZm9ybWF0c1tdID0gewo+ICAJRFJNX0ZPUk1BVF9OVjEyLAo+ICB9Owo+ ICAKPiArc3RhdGljIGNvbnN0IHVpbnQzMl90IGljbF9oZHJfcGxhbmVfZm9ybWF0c1tdID0gewoK UGxlYXNlIHN3aXRjaCB0byB1MzIgJiBjby4gV2UgcmVjZW50bHkgaGFkIGEgbWFzcyBjb252ZXJz aW9uIGluIHRoZQpkcml2ZXIuCgo+ICsJRFJNX0ZPUk1BVF9DOCwKPiArCURSTV9GT1JNQVRfUkdC NTY1LAo+ICsJRFJNX0ZPUk1BVF9YUkdCODg4OCwKPiArCURSTV9GT1JNQVRfWEJHUjg4ODgsCj4g KwlEUk1fRk9STUFUX0FSR0I4ODg4LAo+ICsJRFJNX0ZPUk1BVF9BQkdSODg4OCwKPiArCURSTV9G T1JNQVRfWFJHQjIxMDEwMTAsCj4gKwlEUk1fRk9STUFUX1hCR1IyMTAxMDEwLAoKSSBqdXN0IG5v dGljZWQgdGhhdCBpY2wgc2hvdWxkIGFsc28gc3VwcG9ydCBhbHBoYSBmb3IgMTBicGMuIEJ1dCB0 aGF0J3MKbm90IHJlbGV2YW50IGZvciB0aGlzIHBhdGNoLgoKPiArCURSTV9GT1JNQVRfWFJHQjE2 MTYxNjE2RiwKPiArCURSTV9GT1JNQVRfWEJHUjE2MTYxNjE2RiwKPiArCURSTV9GT1JNQVRfQVJH QjE2MTYxNjE2RiwKPiArCURSTV9GT1JNQVRfQUJHUjE2MTYxNjE2RiwKPiArCURSTV9GT1JNQVRf WVVZViwKPiArCURSTV9GT1JNQVRfWVZZVSwKPiArCURSTV9GT1JNQVRfVVlWWSwKPiArCURSTV9G T1JNQVRfVllVWSwKPiArfTsKPiArCj4gK3N0YXRpYyBjb25zdCB1aW50MzJfdCBpY2xfaGRyX3Bs YW5hcl9mb3JtYXRzW10gPSB7Cj4gKwlEUk1fRk9STUFUX0M4LAo+ICsJRFJNX0ZPUk1BVF9SR0I1 NjUsCj4gKwlEUk1fRk9STUFUX1hSR0I4ODg4LAo+ICsJRFJNX0ZPUk1BVF9YQkdSODg4OCwKPiAr CURSTV9GT1JNQVRfQVJHQjg4ODgsCj4gKwlEUk1fRk9STUFUX0FCR1I4ODg4LAo+ICsJRFJNX0ZP Uk1BVF9YUkdCMjEwMTAxMCwKPiArCURSTV9GT1JNQVRfWEJHUjIxMDEwMTAsCj4gKwlEUk1fRk9S TUFUX1hSR0IxNjE2MTYxNkYsCj4gKwlEUk1fRk9STUFUX1hCR1IxNjE2MTYxNkYsCj4gKwlEUk1f Rk9STUFUX0FSR0IxNjE2MTYxNkYsCj4gKwlEUk1fRk9STUFUX0FCR1IxNjE2MTYxNkYsCj4gKwlE Uk1fRk9STUFUX1lVWVYsCj4gKwlEUk1fRk9STUFUX1lWWVUsCj4gKwlEUk1fRk9STUFUX1VZVlks Cj4gKwlEUk1fRk9STUFUX1ZZVVksCj4gKwlEUk1fRk9STUFUX05WMTIsCj4gK307Cj4gKwo+ICBz dGF0aWMgY29uc3QgdTY0IHNrbF9wbGFuZV9mb3JtYXRfbW9kaWZpZXJzX25vY2NzW10gPSB7Cj4g IAlJOTE1X0ZPUk1BVF9NT0RfWWZfVElMRUQsCj4gIAlJOTE1X0ZPUk1BVF9NT0RfWV9USUxFRCwK PiBAQCAtMTkxNyw2ICsxOTU4LDEwIEBAIHN0YXRpYyBib29sIHNrbF9wbGFuZV9mb3JtYXRfbW9k X3N1cHBvcnRlZChzdHJ1Y3QgZHJtX3BsYW5lICpfcGxhbmUsCj4gIAkJCXJldHVybiB0cnVlOwo+ ICAJCS8qIGZhbGwgdGhyb3VnaCAqLwo+ICAJY2FzZSBEUk1fRk9STUFUX0M4Ogo+ICsJY2FzZSBE Uk1fRk9STUFUX1hCR1IxNjE2MTYxNkY6Cj4gKwljYXNlIERSTV9GT1JNQVRfQUJHUjE2MTYxNjE2 RjoKPiArCWNhc2UgRFJNX0ZPUk1BVF9YUkdCMTYxNjE2MTZGOgo+ICsJY2FzZSBEUk1fRk9STUFU X0FSR0IxNjE2MTYxNkY6Cj4gIAkJaWYgKG1vZGlmaWVyID09IERSTV9GT1JNQVRfTU9EX0xJTkVB UiB8fAo+ICAJCSAgICBtb2RpZmllciA9PSBJOTE1X0ZPUk1BVF9NT0RfWF9USUxFRCB8fAo+ICAJ CSAgICBtb2RpZmllciA9PSBJOTE1X0ZPUk1BVF9NT0RfWV9USUxFRCkKPiBAQCAtMjA1MywxMSAr MjA5OCwyMSBAQCBza2xfdW5pdmVyc2FsX3BsYW5lX2NyZWF0ZShzdHJ1Y3QgZHJtX2k5MTVfcHJp dmF0ZSAqZGV2X3ByaXYsCj4gIAkJcGxhbmUtPnVwZGF0ZV9zbGF2ZSA9IGljbF91cGRhdGVfc2xh dmU7Cj4gIAo+ICAJaWYgKHNrbF9wbGFuZV9oYXNfcGxhbmFyKGRldl9wcml2LCBwaXBlLCBwbGFu ZV9pZCkpIHsKPiAtCQlmb3JtYXRzID0gc2tsX3BsYW5hcl9mb3JtYXRzOwo+IC0JCW51bV9mb3Jt YXRzID0gQVJSQVlfU0laRShza2xfcGxhbmFyX2Zvcm1hdHMpOwo+ICsJCWlmIChJTlRFTF9HRU4o ZGV2X3ByaXYpID4gMTAgJiYgcGxhbmVfaWQgPCBQTEFORV9TUFJJVEUyKSB7Cgppc19oZHJfcGxh bmUoKSBpcyBhcm91bmQgbm93LCBwbGVhc2UgdXNlIGl0LgoKV2l0aCB0aGF0IGFuZCB0aGUgdTMy IHRoaXMgaXMKUmV2aWV3ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51 eC5pbnRlbC5jb20+Cgo+ICsJCQlmb3JtYXRzID0gaWNsX2hkcl9wbGFuYXJfZm9ybWF0czsKPiAr CQkJbnVtX2Zvcm1hdHMgPSBBUlJBWV9TSVpFKGljbF9oZHJfcGxhbmFyX2Zvcm1hdHMpOwo+ICsJ CX0gZWxzZSB7Cj4gKwkJCWZvcm1hdHMgPSBza2xfcGxhbmFyX2Zvcm1hdHM7Cj4gKwkJCW51bV9m b3JtYXRzID0gQVJSQVlfU0laRShza2xfcGxhbmFyX2Zvcm1hdHMpOwo+ICsJCX0KPiAgCX0gZWxz ZSB7Cj4gLQkJZm9ybWF0cyA9IHNrbF9wbGFuZV9mb3JtYXRzOwo+IC0JCW51bV9mb3JtYXRzID0g QVJSQVlfU0laRShza2xfcGxhbmVfZm9ybWF0cyk7Cj4gKwkJaWYgKElOVEVMX0dFTihkZXZfcHJp dikgPiAxMCAmJiBwbGFuZV9pZCA8IFBMQU5FX1NQUklURTIpIHsKPiArCQkJZm9ybWF0cyA9IGlj bF9oZHJfcGxhbmVfZm9ybWF0czsKPiArCQkJbnVtX2Zvcm1hdHMgPSBBUlJBWV9TSVpFKGljbF9o ZHJfcGxhbmVfZm9ybWF0cyk7Cj4gKwkJfSBlbHNlIHsKPiArCQkJZm9ybWF0cyA9IHNrbF9wbGFu ZV9mb3JtYXRzOwo+ICsJCQludW1fZm9ybWF0cyA9IEFSUkFZX1NJWkUoc2tsX3BsYW5lX2Zvcm1h dHMpOwo+ICsJCX0KPiAgCX0KPiAgCj4gIAlwbGFuZS0+aGFzX2NjcyA9IHNrbF9wbGFuZV9oYXNf Y2NzKGRldl9wcml2LCBwaXBlLCBwbGFuZV9pZCk7Cj4gLS0gCj4gMi43LjQKCi0tIApWaWxsZSBT eXJqw6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRl dmVsCg==