Re: [PATCH 1/4] drm/i915: Enable transition watermarks for glk

Rodrigo Vivi
2019-01-31T18:04:36Z

On Thu, Jan 31, 2019 at 09:42:13AM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> We are mistakenly skipping transition watermarks on glk. Fix
> up the condition for glk, and toss in the w/a name from
> the database.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
> drivers/gpu/drm/i915/intel_pm.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index ed9786241307..5ce60faef28c 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -4848,8 +4848,11 @@ static void skl_compute_transition_wm(const struct intel_crtc_state *cstate,
> const u16 trans_amount = 10; /* This is configurable amount */
> u16 wm0_sel_res_b, trans_offset_b, res_blocks;
>
> - /* Transition WM are not recommended by HW team for GEN9 */
> - if (INTEL_GEN(dev_priv) <= 9)
> + /*
> + * WaDisableTWM:skl,kbl,cfl,bxt
> + * Transition WM are not recommended by HW team for GEN9
> + */
> + if (IS_GEN9_BC(dev_priv) || IS_BROXTON(dev_priv))
> return;
>
> /* Transition WM don't make any sense if ipc is disabled */
> --
> 2.19.2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx