From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH v3 3/3] drm/i915/icl: Implement half float
 formats
Date: Wed, 6 Feb 2019 14:43:31 +0200
Message-ID: <20190206124331.GB20097@intel.com>
References: <1549423762-18302-1-git-send-email-kevin.strasser@intel.com>
 <1549423762-18302-4-git-send-email-kevin.strasser@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <1549423762-18302-4-git-send-email-kevin.strasser@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Kevin Strasser <kevin.strasser@intel.com>
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVHVlLCBGZWIgMDUsIDIwMTkgYXQgMDc6Mjk6MjJQTSAtMDgwMCwgS2V2aW4gU3RyYXNzZXIg
d3JvdGU6Cj4gNjQgYnBwIGhhbGYgZmxvYXQgZm9ybWF0cyBhcmUgc3VwcG9ydGVkIG9uIGhkciBw
bGFuZXMgb25seSBhbmQgYXJlIHN1YmplY3QKPiB0byB0aGUgZm9sbG93aW5nIHJlc3RyaWN0aW9u
czoKPiAgICogOTAvMjcwIHJvdGF0aW9uIG5vdCBzdXBwb3J0ZWQKPiAgICogWWYgVGlsaW5nIG5v
dCBzdXBwb3J0ZWQKPiAgICogRnJhbWUgQnVmZmVyIENvbXByZXNzaW9uIG5vdCBzdXBwb3J0ZWQK
PiAgICogQ29sb3IgS2V5aW5nIG5vdCBzdXBwb3J0ZWQKPiAKPiB2MjoKPiAtIERyb3AgaGFuZGxp
bmcgcGl4ZWwgbm9ybWFsaXplIHJlZ2lzdGVyCj4gLSBEb24ndCB1c2UgaWNsX2lzX2hkcl9wbGFu
ZSB0b28gZWFybHkKPiAKPiB2MzoKPiAtIFVzZSByZWZhY3RvcmVkIGljbF9pc19oZHJfcGxhbmUg
KFZpbGxlKQo+IC0gVXNlIHUzMiBpbnN0ZWFkIG9mIHVpbnQzMl90IChWaWxsZSkKPiAKPiBDYzog
VW1hIFNoYW5rYXIgPHVtYS5zaGFua2FyQGludGVsLmNvbT4KPiBDYzogU2hhc2hhbmsgU2hhcm1h
IDxzaGFzaGFuay5zaGFybWFAaW50ZWwuY29tPgo+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxl
LnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IENjOiBEYXZpZCBBaXJsaWUgPGFpcmxpZWRAbGlu
dXguaWU+Cj4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gQ2M6
IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBTaWduZWQtb2ZmLWJ5OiBLZXZpbiBT
dHJhc3NlciA8a2V2aW4uc3RyYXNzZXJAaW50ZWwuY29tPgoKUmV2aWV3ZWQtYnk6IFZpbGxlIFN5
cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cgo+IC0tLQo+ICBkcml2ZXJz
L2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCAyMiArKysrKysrKysrKysKPiAgZHJpdmVy
cy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMgIHwgNjcgKysrKysrKysrKysrKysrKysrKysr
KysrKysrKysrKystLS0tCj4gIDIgZmlsZXMgY2hhbmdlZCwgODMgaW5zZXJ0aW9ucygrKSwgNiBk
ZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf
ZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gaW5kZXgg
MmQ5NjM5ZC4uMTEyNDUwMiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl
bF9kaXNwbGF5LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMK
PiBAQCAtMjY2OCw2ICsyNjY4LDE4IEBAIGludCBza2xfZm9ybWF0X3RvX2ZvdXJjYyhpbnQgZm9y
bWF0LCBib29sIHJnYl9vcmRlciwgYm9vbCBhbHBoYSkKPiAgCQlyZXR1cm4gRFJNX0ZPUk1BVF9S
R0I1NjU7Cj4gIAljYXNlIFBMQU5FX0NUTF9GT1JNQVRfTlYxMjoKPiAgCQlyZXR1cm4gRFJNX0ZP
Uk1BVF9OVjEyOwo+ICsJY2FzZSBQTEFORV9DVExfRk9STUFUX1hSR0JfMTYxNjE2MTZGOgo+ICsJ
CWlmIChyZ2Jfb3JkZXIpIHsKPiArCQkJaWYgKGFscGhhKQo+ICsJCQkJcmV0dXJuIERSTV9GT1JN
QVRfQUJHUjE2MTYxNjE2RjsKPiArCQkJZWxzZQo+ICsJCQkJcmV0dXJuIERSTV9GT1JNQVRfWEJH
UjE2MTYxNjE2RjsKPiArCQl9IGVsc2Ugewo+ICsJCQlpZiAoYWxwaGEpCj4gKwkJCQlyZXR1cm4g
RFJNX0ZPUk1BVF9BUkdCMTYxNjE2MTZGOwo+ICsJCQllbHNlCj4gKwkJCQlyZXR1cm4gRFJNX0ZP
Uk1BVF9YUkdCMTYxNjE2MTZGOwo+ICsJCX0KPiAgCWRlZmF1bHQ6Cj4gIAljYXNlIFBMQU5FX0NU
TF9GT1JNQVRfWFJHQl84ODg4Ogo+ICAJCWlmIChyZ2Jfb3JkZXIpIHsKPiBAQCAtMzU2Niw2ICsz
NTc4LDEyIEBAIHN0YXRpYyB1MzIgc2tsX3BsYW5lX2N0bF9mb3JtYXQodTMyIHBpeGVsX2Zvcm1h
dCkKPiAgCQlyZXR1cm4gUExBTkVfQ1RMX0ZPUk1BVF9ZVVY0MjIgfCBQTEFORV9DVExfWVVWNDIy
X1ZZVVk7Cj4gIAljYXNlIERSTV9GT1JNQVRfTlYxMjoKPiAgCQlyZXR1cm4gUExBTkVfQ1RMX0ZP
Uk1BVF9OVjEyOwo+ICsJY2FzZSBEUk1fRk9STUFUX1hCR1IxNjE2MTYxNkY6Cj4gKwljYXNlIERS
TV9GT1JNQVRfQUJHUjE2MTYxNjE2RjoKPiArCQlyZXR1cm4gUExBTkVfQ1RMX0ZPUk1BVF9YUkdC
XzE2MTYxNjE2RiB8IFBMQU5FX0NUTF9PUkRFUl9SR0JYOwo+ICsJY2FzZSBEUk1fRk9STUFUX1hS
R0IxNjE2MTYxNkY6Cj4gKwljYXNlIERSTV9GT1JNQVRfQVJHQjE2MTYxNjE2RjoKPiArCQlyZXR1
cm4gUExBTkVfQ1RMX0ZPUk1BVF9YUkdCXzE2MTYxNjE2RjsKPiAgCWRlZmF1bHQ6Cj4gIAkJTUlT
U0lOR19DQVNFKHBpeGVsX2Zvcm1hdCk7Cj4gIAl9Cj4gQEAgLTUwOTcsNiArNTExNSwxMCBAQCBz
dGF0aWMgaW50IHNrbF91cGRhdGVfc2NhbGVyX3BsYW5lKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRl
ICpjcnRjX3N0YXRlLAo+ICAJY2FzZSBEUk1fRk9STUFUX1VZVlk6Cj4gIAljYXNlIERSTV9GT1JN
QVRfVllVWToKPiAgCWNhc2UgRFJNX0ZPUk1BVF9OVjEyOgo+ICsJY2FzZSBEUk1fRk9STUFUX1hC
R1IxNjE2MTYxNkY6Cj4gKwljYXNlIERSTV9GT1JNQVRfQUJHUjE2MTYxNjE2RjoKPiArCWNhc2Ug
RFJNX0ZPUk1BVF9YUkdCMTYxNjE2MTZGOgo+ICsJY2FzZSBEUk1fRk9STUFUX0FSR0IxNjE2MTYx
NkY6Cj4gIAkJYnJlYWs7Cj4gIAlkZWZhdWx0Ogo+ICAJCURSTV9ERUJVR19LTVMoIltQTEFORTol
ZDolc10gRkI6JWQgdW5zdXBwb3J0ZWQgc2NhbGluZyBmb3JtYXQgMHgleFxuIiwKPiBkaWZmIC0t
Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMgYi9kcml2ZXJzL2dwdS9k
cm0vaTkxNS9pbnRlbF9zcHJpdGUuYwo+IGluZGV4IDEwYjM3ZTguLjU1ZWU2NzcgMTAwNjQ0Cj4g
LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMKPiArKysgYi9kcml2ZXJz
L2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYwo+IEBAIC0xNDUwLDggKzE0NTAsNiBAQCBzdGF0
aWMgaW50IHNrbF9wbGFuZV9jaGVja19mYihjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAq
Y3J0Y19zdGF0ZSwKPiAgCQkvKgo+ICAJCSAqIDkwLzI3MCBpcyBub3QgYWxsb3dlZCB3aXRoIFJH
QjY0IDE2OjE2OjE2OjE2IGFuZAo+ICAJCSAqIEluZGV4ZWQgOC1iaXQuIFJHQiAxNi1iaXQgNTo2
OjUgaXMgYWxsb3dlZCBnZW4xMSBvbndhcmRzLgo+IC0JCSAqIFRCRDogQWRkIFJHQjY0IGNhc2Ug
b25jZSBpdHMgYWRkZWQgaW4gc3VwcG9ydGVkIGZvcm1hdAo+IC0JCSAqIGxpc3QuCj4gIAkJICov
Cj4gIAkJc3dpdGNoIChmYi0+Zm9ybWF0LT5mb3JtYXQpIHsKPiAgCQljYXNlIERSTV9GT1JNQVRf
UkdCNTY1Ogo+IEBAIC0xNDU5LDYgKzE0NTcsMTAgQEAgc3RhdGljIGludCBza2xfcGxhbmVfY2hl
Y2tfZmIoY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUsCj4gIAkJCQli
cmVhazsKPiAgCQkJLyogZmFsbCB0aHJvdWdoICovCj4gIAkJY2FzZSBEUk1fRk9STUFUX0M4Ogo+
ICsJCWNhc2UgRFJNX0ZPUk1BVF9YUkdCMTYxNjE2MTZGOgo+ICsJCWNhc2UgRFJNX0ZPUk1BVF9Y
QkdSMTYxNjE2MTZGOgo+ICsJCWNhc2UgRFJNX0ZPUk1BVF9BUkdCMTYxNjE2MTZGOgo+ICsJCWNh
c2UgRFJNX0ZPUk1BVF9BQkdSMTYxNjE2MTZGOgo+ICAJCQlEUk1fREVCVUdfS01TKCJVbnN1cHBv
cnRlZCBwaXhlbCBmb3JtYXQgJXMgZm9yIDkwLzI3MCFcbiIsCj4gIAkJCQkgICAgICBkcm1fZ2V0
X2Zvcm1hdF9uYW1lKGZiLT5mb3JtYXQtPmZvcm1hdCwKPiAgCQkJCQkJCSAgJmZvcm1hdF9uYW1l
KSk7Cj4gQEAgLTE3NzQsNiArMTc3Niw0NSBAQCBzdGF0aWMgY29uc3QgdTMyIHNrbF9wbGFuYXJf
Zm9ybWF0c1tdID0gewo+ICAJRFJNX0ZPUk1BVF9OVjEyLAo+ICB9Owo+ICAKPiArc3RhdGljIGNv
bnN0IHUzMiBpY2xfaGRyX3BsYW5lX2Zvcm1hdHNbXSA9IHsKPiArCURSTV9GT1JNQVRfQzgsCj4g
KwlEUk1fRk9STUFUX1JHQjU2NSwKPiArCURSTV9GT1JNQVRfWFJHQjg4ODgsCj4gKwlEUk1fRk9S
TUFUX1hCR1I4ODg4LAo+ICsJRFJNX0ZPUk1BVF9BUkdCODg4OCwKPiArCURSTV9GT1JNQVRfQUJH
Ujg4ODgsCj4gKwlEUk1fRk9STUFUX1hSR0IyMTAxMDEwLAo+ICsJRFJNX0ZPUk1BVF9YQkdSMjEw
MTAxMCwKPiArCURSTV9GT1JNQVRfWFJHQjE2MTYxNjE2RiwKPiArCURSTV9GT1JNQVRfWEJHUjE2
MTYxNjE2RiwKPiArCURSTV9GT1JNQVRfQVJHQjE2MTYxNjE2RiwKPiArCURSTV9GT1JNQVRfQUJH
UjE2MTYxNjE2RiwKPiArCURSTV9GT1JNQVRfWVVZViwKPiArCURSTV9GT1JNQVRfWVZZVSwKPiAr
CURSTV9GT1JNQVRfVVlWWSwKPiArCURSTV9GT1JNQVRfVllVWSwKPiArfTsKPiArCj4gK3N0YXRp
YyBjb25zdCB1MzIgaWNsX2hkcl9wbGFuYXJfZm9ybWF0c1tdID0gewo+ICsJRFJNX0ZPUk1BVF9D
OCwKPiArCURSTV9GT1JNQVRfUkdCNTY1LAo+ICsJRFJNX0ZPUk1BVF9YUkdCODg4OCwKPiArCURS
TV9GT1JNQVRfWEJHUjg4ODgsCj4gKwlEUk1fRk9STUFUX0FSR0I4ODg4LAo+ICsJRFJNX0ZPUk1B
VF9BQkdSODg4OCwKPiArCURSTV9GT1JNQVRfWFJHQjIxMDEwMTAsCj4gKwlEUk1fRk9STUFUX1hC
R1IyMTAxMDEwLAo+ICsJRFJNX0ZPUk1BVF9YUkdCMTYxNjE2MTZGLAo+ICsJRFJNX0ZPUk1BVF9Y
QkdSMTYxNjE2MTZGLAo+ICsJRFJNX0ZPUk1BVF9BUkdCMTYxNjE2MTZGLAo+ICsJRFJNX0ZPUk1B
VF9BQkdSMTYxNjE2MTZGLAo+ICsJRFJNX0ZPUk1BVF9ZVVlWLAo+ICsJRFJNX0ZPUk1BVF9ZVllV
LAo+ICsJRFJNX0ZPUk1BVF9VWVZZLAo+ICsJRFJNX0ZPUk1BVF9WWVVZLAo+ICsJRFJNX0ZPUk1B
VF9OVjEyLAo+ICt9Owo+ICsKPiAgc3RhdGljIGNvbnN0IHU2NCBza2xfcGxhbmVfZm9ybWF0X21v
ZGlmaWVyc19ub2Njc1tdID0gewo+ICAJSTkxNV9GT1JNQVRfTU9EX1lmX1RJTEVELAo+ICAJSTkx
NV9GT1JNQVRfTU9EX1lfVElMRUQsCj4gQEAgLTE5MTcsNiArMTk1OCwxMCBAQCBzdGF0aWMgYm9v
bCBza2xfcGxhbmVfZm9ybWF0X21vZF9zdXBwb3J0ZWQoc3RydWN0IGRybV9wbGFuZSAqX3BsYW5l
LAo+ICAJCQlyZXR1cm4gdHJ1ZTsKPiAgCQkvKiBmYWxsIHRocm91Z2ggKi8KPiAgCWNhc2UgRFJN
X0ZPUk1BVF9DODoKPiArCWNhc2UgRFJNX0ZPUk1BVF9YQkdSMTYxNjE2MTZGOgo+ICsJY2FzZSBE
Uk1fRk9STUFUX0FCR1IxNjE2MTYxNkY6Cj4gKwljYXNlIERSTV9GT1JNQVRfWFJHQjE2MTYxNjE2
RjoKPiArCWNhc2UgRFJNX0ZPUk1BVF9BUkdCMTYxNjE2MTZGOgo+ICAJCWlmIChtb2RpZmllciA9
PSBEUk1fRk9STUFUX01PRF9MSU5FQVIgfHwKPiAgCQkgICAgbW9kaWZpZXIgPT0gSTkxNV9GT1JN
QVRfTU9EX1hfVElMRUQgfHwKPiAgCQkgICAgbW9kaWZpZXIgPT0gSTkxNV9GT1JNQVRfTU9EX1lf
VElMRUQpCj4gQEAgLTIwNTMsMTEgKzIwOTgsMjEgQEAgc2tsX3VuaXZlcnNhbF9wbGFuZV9jcmVh
dGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJCXBsYW5lLT51cGRhdGVf
c2xhdmUgPSBpY2xfdXBkYXRlX3NsYXZlOwo+ICAKPiAgCWlmIChza2xfcGxhbmVfaGFzX3BsYW5h
cihkZXZfcHJpdiwgcGlwZSwgcGxhbmVfaWQpKSB7Cj4gLQkJZm9ybWF0cyA9IHNrbF9wbGFuYXJf
Zm9ybWF0czsKPiAtCQludW1fZm9ybWF0cyA9IEFSUkFZX1NJWkUoc2tsX3BsYW5hcl9mb3JtYXRz
KTsKPiArCQlpZiAoaWNsX2lzX2hkcl9wbGFuZShkZXZfcHJpdiwgcGxhbmVfaWQpKSB7Cj4gKwkJ
CWZvcm1hdHMgPSBpY2xfaGRyX3BsYW5hcl9mb3JtYXRzOwo+ICsJCQludW1fZm9ybWF0cyA9IEFS
UkFZX1NJWkUoaWNsX2hkcl9wbGFuYXJfZm9ybWF0cyk7Cj4gKwkJfSBlbHNlIHsKPiArCQkJZm9y
bWF0cyA9IHNrbF9wbGFuYXJfZm9ybWF0czsKPiArCQkJbnVtX2Zvcm1hdHMgPSBBUlJBWV9TSVpF
KHNrbF9wbGFuYXJfZm9ybWF0cyk7Cj4gKwkJfQo+ICAJfSBlbHNlIHsKPiAtCQlmb3JtYXRzID0g
c2tsX3BsYW5lX2Zvcm1hdHM7Cj4gLQkJbnVtX2Zvcm1hdHMgPSBBUlJBWV9TSVpFKHNrbF9wbGFu
ZV9mb3JtYXRzKTsKPiArCQlpZiAoaWNsX2lzX2hkcl9wbGFuZShkZXZfcHJpdiwgcGxhbmVfaWQp
KSB7Cj4gKwkJCWZvcm1hdHMgPSBpY2xfaGRyX3BsYW5lX2Zvcm1hdHM7Cj4gKwkJCW51bV9mb3Jt
YXRzID0gQVJSQVlfU0laRShpY2xfaGRyX3BsYW5lX2Zvcm1hdHMpOwo+ICsJCX0gZWxzZSB7Cj4g
KwkJCWZvcm1hdHMgPSBza2xfcGxhbmVfZm9ybWF0czsKPiArCQkJbnVtX2Zvcm1hdHMgPSBBUlJB
WV9TSVpFKHNrbF9wbGFuZV9mb3JtYXRzKTsKPiArCQl9Cj4gIAl9Cj4gIAo+ICAJcGxhbmUtPmhh
c19jY3MgPSBza2xfcGxhbmVfaGFzX2NjcyhkZXZfcHJpdiwgcGlwZSwgcGxhbmVfaWQpOwo+IC0t
IAo+IDIuNy40CgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsCl9fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwt
Z2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t
YWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=