From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [Intel-gfx] [PATCH v3 3/3] drm/i915: Don't send hotplug in intel_dp_check_mst_status() Date: Wed, 6 Feb 2019 21:33:20 +0200 Message-ID: <20190206193320.GE20097@intel.com> References: <20190129191001.442-1-lyude@redhat.com> <20190129191001.442-4-lyude@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20190129191001.442-4-lyude@redhat.com> Sender: linux-kernel-owner@vger.kernel.org To: Lyude Paul Cc: intel-gfx@lists.freedesktop.org, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Jan 29, 2019 at 02:10:01PM -0500, Lyude Paul wrote: > This hotplug also isn't needed: drm_dp_mst_topology_mgr_set_mst() > already sends a hotplug on its own from drm_dp_destroy_connector_work() > after destroying connectors in the MST topology. > > Signed-off-by: Lyude Paul > Cc: Imre Deak > Cc: Daniel Vetter Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/intel_dp.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c > index c2399acf177b..f9113c0cdfcd 100644 > --- a/drivers/gpu/drm/i915/intel_dp.c > +++ b/drivers/gpu/drm/i915/intel_dp.c > @@ -4608,12 +4608,10 @@ intel_dp_check_mst_status(struct intel_dp *intel_dp) > > return ret; > } else { > - struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp); > DRM_DEBUG_KMS("failed to get ESI - device may have failed\n"); > intel_dp->is_mst = false; > - drm_dp_mst_topology_mgr_set_mst(&intel_dp->mst_mgr, intel_dp->is_mst); > - /* send a hotplug event */ > - drm_kms_helper_hotplug_event(intel_dig_port->base.base.dev); > + drm_dp_mst_topology_mgr_set_mst(&intel_dp->mst_mgr, > + intel_dp->is_mst); > } > } > return -EINVAL; > -- > 2.20.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel