From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH 2/2] drm/i915: Assert that VED and ISP are power gated Date: Wed, 13 Feb 2019 17:03:46 +0200 Message-ID: <20190213150346.GB11189@ideak-desk.fi.intel.com> References: <20181129175504.3630-1-ville.syrjala@linux.intel.com> <20181129175504.3630-2-ville.syrjala@linux.intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id D44796E2C6 for ; Wed, 13 Feb 2019 15:03:55 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20181129175504.3630-2-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala Cc: intel-gfx@lists.freedesktop.org, Andy Shevchenko , Alan Cox List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBOb3YgMjksIDIwMTggYXQgMDc6NTU6MDRQTSArMDIwMCwgVmlsbGUgU3lyamFsYSB3 cm90ZToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu Y29tPgo+IAo+IEFzIHRoZXJlIGFyZSBubyB1cHN0cmVhbSBkcml2ZXJzIGZvciBWRUQgb3IgSVNQ IGxldCdzIGp1c3QKPiBhc3NlcnQgdGhhdCB0aGV5IGFyZSBwb3dlciBnYXRlZC4gT3RoZXJ3aXNl IHRoZXkgd291bGQKPiBwcmV2ZW50IHMwaXggZW50cnkuCj4gCj4gRm9yIElTUCB0aGlzIGlzIG9u bHkgcmVsZXZhbnQgd2hlbiBpdCBpcyBub3QgZXhwb3NlZCBhcyBhCj4gUENJIGRldmljZSBhbmQg aW5zdGVhZCBpcyBhIHN1Ym9yZGluYXRlIG9mIHRoZSBndW5pdC4gV2hlbgo+IGV4cG9zZWQgYXMg YSBQQ0kgZGV2aWNlIGl0IHdpbGwgYmUgaGFuZGxlZCBieSB0aGUKPiBhdG9taXNwMl9wbSBkcml2 ZXIuCj4gCj4gT24gbXkgVkxWIEZGUkQ4IGJvYXJkIHRoZSBmaXJtd2FyZSBwb3dlciBnYXRlcyBi b3RoIG9mIHRoZXNlCj4gYnkgZGVmYXVsdC4gTGV0J3MgYXNzdW1lIHRoYXQgaXMgYWx3YXlzIHRo ZSBjYXNlIGFuZCBqdXN0Cj4gV0FSTiBpZiB3ZSBldmVyIGVuY291bnRlciBzb21ldGhpbmcgZGlm ZmVyZW50Lgo+IAo+IENjOiBIYW5zIGRlIEdvZWRlIDxoZGVnb2VkZUByZWRoYXQuY29tPgo+IENj OiBBbGFuIENveCA8YWxhbkBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IEFuZHkgU2hldmNoZW5rbyA8 YW5kcml5LnNoZXZjaGVua29AbGludXguaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IFZpbGxl IFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+CgpSZXZpZXdlZC1ieTog SW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9yZWcuaCAgICAgICAgIHwgMjggKysrKysrKysrKysrKysrKysrKysrCj4gIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3J1bnRpbWVfcG0uYyB8IDMzICsrKysrKysrKysrKysr KysrKysrKysrKysKPiAgMiBmaWxlcyBjaGFuZ2VkLCA2MSBpbnNlcnRpb25zKCspCj4gCj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmggYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X3JlZy5oCj4gaW5kZXggNDJkMjU4NzJlY2ZlLi5jMmVjYWM0Y2I1MWIgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgKPiBAQCAtMTAyMCw2ICsxMDIwLDMxIEBAIHN0YXRp YyBpbmxpbmUgYm9vbCBpOTE1X21taW9fcmVnX3ZhbGlkKGk5MTVfcmVnX3QgcmVnKQo+ICAvKiBT ZWUgY29uZmlnZGIgYnVuaXQgU0IgYWRkciBtYXAgKi8KPiAgI2RlZmluZSBCVU5JVF9SRUdfQklT T0MJCQkJMHgxMQo+ICAKPiArLyogUFVOSVRfUkVHXypTU1BNMCAqLwo+ICsjZGVmaW5lICAgX1NT UE0wX1NTQyh2YWwpCQkJKCh2YWwpIDw8IDApCj4gKyNkZWZpbmUgICBTU1BNMF9TU0NfTUFTSwkJ CV9TU1BNMF9TU0MoMHgzKQo+ICsjZGVmaW5lICAgU1NQTTBfU1NDX1BXUl9PTgkJCV9TU1BNMF9T U0MoMHgwKQo+ICsjZGVmaW5lICAgU1NQTTBfU1NDX0NMS19HQVRFCQkJX1NTUE0wX1NTQygweDEp Cj4gKyNkZWZpbmUgICBTU1BNMF9TU0NfUkVTRVQJCQlfU1NQTTBfU1NDKDB4MikKPiArI2RlZmlu ZSAgIFNTUE0wX1NTQ19QV1JfR0FURQkJCV9TU1BNMF9TU0MoMHgzKQo+ICsjZGVmaW5lICAgX1NT UE0wX1NTUyh2YWwpCQkJKCh2YWwpIDw8IDI0KQo+ICsjZGVmaW5lICAgU1NQTTBfU1NTX01BU0sJ CQlfU1NQTTBfU1NTKDB4MykKPiArI2RlZmluZSAgIFNTUE0wX1NTU19QV1JfT04JCQlfU1NQTTBf U1NTKDB4MCkKPiArI2RlZmluZSAgIFNTUE0wX1NTU19DTEtfR0FURQkJCV9TU1BNMF9TU1MoMHgx KQo+ICsjZGVmaW5lICAgU1NQTTBfU1NTX1JFU0VUCQkJX1NTUE0wX1NTUygweDIpCj4gKyNkZWZp bmUgICBTU1BNMF9TU1NfUFdSX0dBVEUJCQlfU1NQTTBfU1NTKDB4MykKPiArCj4gKy8qIFBVTklU X1JFR18qU1NQTTEgKi8KPiArI2RlZmluZSAgIFNTUE0xX0ZSRVFTVEFUX1NISUZUCQkJMjQKPiAr I2RlZmluZSAgIFNTUE0xX0ZSRVFTVEFUX01BU0sJCQkoMHgxZiA8PCBTU1BNMV9GUkVRU1RBVF9T SElGVCkKPiArI2RlZmluZSAgIFNTUE0xX0ZSRVFHVUFSX1NISUZUCQkJOAo+ICsjZGVmaW5lICAg U1NQTTFfRlJFUUdVQVJfTUFTSwkJCSgweDFmIDw8IFNTUE0xX0ZSRVFHVUFSX1NISUZUKQo+ICsj ZGVmaW5lICAgU1NQTTFfRlJFUV9TSElGVAkJCTAKPiArI2RlZmluZSAgIFNTUE0xX0ZSRVFfTUFT SwkJCSgweDFmIDw8IFNTUE0xX0ZSRVFfU0hJRlQpCj4gKwo+ICsjZGVmaW5lIFBVTklUX1JFR19W RURTU1BNMAkJCTB4MzIKPiArI2RlZmluZSBQVU5JVF9SRUdfVkVEU1NQTTEJCQkweDMzCj4gKwo+ ICAjZGVmaW5lIFBVTklUX1JFR19EU1BTU1BNCQkJMHgzNgo+ICAjZGVmaW5lICAgRFNQRlJFUVNU QVRfU0hJRlRfQ0hWCQkJMjQKPiAgI2RlZmluZSAgIERTUEZSRVFTVEFUX01BU0tfQ0hWCQkJKDB4 MWYgPDwgRFNQRlJFUVNUQVRfU0hJRlRfQ0hWKQo+IEBAIC0xMDQ1LDYgKzEwNzAsOSBAQCBzdGF0 aWMgaW5saW5lIGJvb2wgaTkxNV9tbWlvX3JlZ192YWxpZChpOTE1X3JlZ190IHJlZykKPiAgI2Rl ZmluZSAgIERQX1NTU19SRVNFVChwaXBlKQkJCV9EUF9TU1MoMHgyLCAocGlwZSkpCj4gICNkZWZp bmUgICBEUF9TU1NfUFdSX0dBVEUocGlwZSkJCQlfRFBfU1NTKDB4MywgKHBpcGUpKQo+ICAKPiAr I2RlZmluZSBQVU5JVF9SRUdfSVNQU1NQTTAJCQkweDM5Cj4gKyNkZWZpbmUgUFVOSVRfUkVHX0lT UFNTUE0xCQkJMHgzYQo+ICsKPiAgLyoKPiAgICogaTkxNV9wb3dlcl93ZWxsX2lkOgo+ICAgKgo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ydW50aW1lX3BtLmMgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ydW50aW1lX3BtLmMKPiBpbmRleCBhZjQ5OWQ0YTBj NjYuLjQxNjUyMWY0NWVjNyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9ydW50aW1lX3BtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ydW50aW1l X3BtLmMKPiBAQCAtMzcwNiw2ICszNzA2LDM2IEBAIHN0YXRpYyB2b2lkIHZsdl9jbW5sYW5lX3dh KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgCWNtbi0+ZGVzYy0+b3BzLT5k aXNhYmxlKGRldl9wcml2LCBjbW4pOwo+ICB9Cj4gIAo+ICtzdGF0aWMgYm9vbCB2bHZfcHVuaXRf aXNfcG93ZXJfZ2F0ZWQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCB1MzIgcmVn MCkKPiArewo+ICsJYm9vbCByZXQ7Cj4gKwo+ICsJbXV0ZXhfbG9jaygmZGV2X3ByaXYtPnBjdV9s b2NrKTsKPiArCXJldCA9ICh2bHZfcHVuaXRfcmVhZChkZXZfcHJpdiwgcmVnMCkgJiBTU1BNMF9T U0NfTUFTSykgPT0gU1NQTTBfU1NDX1BXUl9HQVRFOwo+ICsJbXV0ZXhfdW5sb2NrKCZkZXZfcHJp di0+cGN1X2xvY2spOwo+ICsKPiArCXJldHVybiByZXQ7Cj4gK30KPiArCj4gK3N0YXRpYyB2b2lk IGFzc2VydF92ZWRfcG93ZXJfZ2F0ZWQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 KQo+ICt7Cj4gKwlXQVJOKCF2bHZfcHVuaXRfaXNfcG93ZXJfZ2F0ZWQoZGV2X3ByaXYsIFBVTklU X1JFR19WRURTU1BNMCksCj4gKwkgICAgICJWRUQgbm90IHBvd2VyIGdhdGVkXG4iKTsKPiArfQo+ ICsKPiArc3RhdGljIHZvaWQgYXNzZXJ0X2lzcF9wb3dlcl9nYXRlZChzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYpCj4gK3sKPiArCXN0YXRpYyBjb25zdCBzdHJ1Y3QgcGNpX2Rldmlj ZV9pZCBpc3BfaWRzW10gPSB7Cj4gKwkJe1BDSV9ERVZJQ0UoUENJX1ZFTkRPUl9JRF9JTlRFTCwg MHgwZjM4KX0sCj4gKwkJe1BDSV9ERVZJQ0UoUENJX1ZFTkRPUl9JRF9JTlRFTCwgMHgyMmI4KX0s Cj4gKwkJe30KPiArCX07Cj4gKwo+ICsJV0FSTighcGNpX2Rldl9wcmVzZW50KGlzcF9pZHMpICYm Cj4gKwkgICAgICF2bHZfcHVuaXRfaXNfcG93ZXJfZ2F0ZWQoZGV2X3ByaXYsIFBVTklUX1JFR19J U1BTU1BNMCksCj4gKwkgICAgICJJU1Agbm90IHBvd2VyIGdhdGVkXG4iKTsKPiArfQo+ICsKPiAg c3RhdGljIHZvaWQgaW50ZWxfcG93ZXJfZG9tYWluc192ZXJpZnlfc3RhdGUoc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2KTsKPiAgCj4gIC8qKgo+IEBAIC0zNzQyLDEwICszNzcyLDEz IEBAIHZvaWQgaW50ZWxfcG93ZXJfZG9tYWluc19pbml0X2h3KHN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICpkZXZfcHJpdiwgYm9vbCByZXN1bWUpCj4gIAkJbXV0ZXhfbG9jaygmcG93ZXJfZG9tYWlu cy0+bG9jayk7Cj4gIAkJY2h2X3BoeV9jb250cm9sX2luaXQoZGV2X3ByaXYpOwo+ICAJCW11dGV4 X3VubG9jaygmcG93ZXJfZG9tYWlucy0+bG9jayk7Cj4gKwkJYXNzZXJ0X2lzcF9wb3dlcl9nYXRl ZChkZXZfcHJpdik7Cj4gIAl9IGVsc2UgaWYgKElTX1ZBTExFWVZJRVcoZGV2X3ByaXYpKSB7Cj4g IAkJbXV0ZXhfbG9jaygmcG93ZXJfZG9tYWlucy0+bG9jayk7Cj4gIAkJdmx2X2NtbmxhbmVfd2Eo ZGV2X3ByaXYpOwo+ICAJCW11dGV4X3VubG9jaygmcG93ZXJfZG9tYWlucy0+bG9jayk7Cj4gKwkJ YXNzZXJ0X3ZlZF9wb3dlcl9nYXRlZChkZXZfcHJpdik7Cj4gKwkJYXNzZXJ0X2lzcF9wb3dlcl9n YXRlZChkZXZfcHJpdik7Cj4gIAl9IGVsc2UgaWYgKElTX0lWWUJSSURHRShkZXZfcHJpdikgfHwg SU5URUxfR0VOKGRldl9wcml2KSA+PSA3KQo+ICAJCWludGVsX3BjaF9yZXNldF9oYW5kc2hha2Uo ZGV2X3ByaXYsICFIQVNfUENIX05PUChkZXZfcHJpdikpOwo+ICAKPiAtLSAKPiAyLjE4LjEKPiAK PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVs LWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1h aWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4