Re: [RFC PATCH 30/42] drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET

Chris Wilson
2019-02-26T13:37:40Z

Quoting Tvrtko Ursulin (2019-02-26 13:34:51)
>
> On 14/02/2019 14:57, Matthew Auld wrote:
> > From: Abdiel Janulgue <abdiel.janulgue@linux.intel.com>
> >
> > CPU mmap implementation depending on the object's backing pages.
>
> depends?
>
> > At the moment we introduce shmem and local-memory BAR fault handlers
> > Note that the mmap type is done one at a time to circumvent the DRM
> > offset manager limitation. Note that we multiplex mmap_gtt and
>
> Perhaps it is time to sort out the offset manager? I have a feeling that
> would make things much easier/cleaner for us.

I had skipped the changelog and didn't realise that was being blamed
for getting mmaps so wrong...

I don't buy that excuse.
-Chris