Re: [RFC PATCH 03/42] drm/i915: buddy allocator

Jani Nikula
2019-02-18T11:33:39Z

On Fri, 15 Feb 2019, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Jani Nikula (2019-02-15 12:34:02)
>> Please replace the above with
>>
>> // SPDX-License-Identifier: MIT
>> /*
>> * Copyright © 2019 Intel Corporation
>> */
>>
>> Ditto for all new files being added. (Except .h which will need to have
>> old style /* ... */ comments around the first line.)
>
> Rebel against the overlords imposing C++ comments upon us; we will
> remain clean! I really do not see the point in using C++ for this one
> instance, the perl regex is not any harder to write...

In this case, I'd rather not leave people any wiggle room. Accept any
deviation, and it'll get copy-pasted and deviated more. I want the
message to be clear, put this in verbatim and don't come up with clever
ideas. (Yeah, I see there's deviation already, and I've already
contemplated patches to fix them.)

Perhaps my sentiments are amplified by my annoyance at the combinatorial
explosion of subtly different MIT license texts we already have, making
what's supposed to be a trivial switch to SPDX rather more complicated.

BR,
Jani.

--
Jani Nikula, Intel Open Source Graphics Center