From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 3/4] drm/i915: Remove the broken DP CRC
 support for g4x
Date: Thu, 14 Feb 2019 22:43:30 +0200
Message-ID: <20190214204330.GN20097@intel.com>
References: <20190214192219.3858-1-ville.syrjala@linux.intel.com>
 <20190214192219.3858-3-ville.syrjala@linux.intel.com>
 <20190214203822.GL31265@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by gabe.freedesktop.org (Postfix) with ESMTPS id B018E6E094
 for <intel-gfx@lists.freedesktop.org>; Thu, 14 Feb 2019 20:43:34 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20190214203822.GL31265@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVGh1LCBGZWIgMTQsIDIwMTkgYXQgMTI6Mzg6MjJQTSAtMDgwMCwgUm9kcmlnbyBWaXZpIHdy
b3RlOgo+IE9uIFRodSwgRmViIDE0LCAyMDE5IGF0IDA5OjIyOjE4UE0gKzAyMDAsIFZpbGxlIFN5
cmphbGEgd3JvdGU6Cj4gPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGlu
dXguaW50ZWwuY29tPgo+ID4gCj4gPiBEUCBDUkNzIGRvbid0IHJlYWxseSB3b3JrIG9uIGc0eC4g
SWYgeW91IHdhbnQgYW55IENSQ3Mgb24gRFAgeW91IG11c3QKPiA+IHNlbGVjdCB0aGUgQ1JDIHNv
dXJjZSBiZWZvcmUgdGhlIHBvcnQgaXMgZW5hYmxlZCwgb3RoZXJ3aXNlIHRoZSBDUkMKPiA+IHNv
dXJjZSBzZWxlY3QgYml0cyBzaW1wbHkgaWdub3JlIGFueSB3cml0ZXMgdG8gdGhlbS4gQW5kIG9u
Y2UgdGhlIHBvcnQKPiA+IGlzIGVuYWJsZWQgd2UgbXVzdG4ndCBjaGFuZ2UgdGhlIENSQyBzb3Vy
Y2Ugc2VsZWN0IHVudGlsIHRoZSBwb3J0IGlzCj4gPiBkaXNhYmxlZC4gVGhhdCBhbG1vc3Qgd29y
a3MsIGJ1dCBub3QgcXVpdGUgOiggRXZlbnR1YWxseSB0aGUgQ1JDIHNvdXJjZQo+ID4gc2VsZWN0
IGJpdHMgZ2V0IHBlcm1hbmVudGx5IHN0dWNrIG9uZSB3YXkgb3IgdGhlIG90aGVyLCBhbmQgYWZ0
ZXIgdGhhdAo+ID4gYSByZWJvb3QgKG9yIHBvc3NpYmx5IGEgZGlzcGxheSByZXNldCkgaXMgbmVl
ZGVkIHRvIGdldCB3b3JraW5nIENSQ3MKPiA+IG9uIHRoYXQgcGlwZSAobm90IG1hdHRlciB3aGlj
aCBDUkMgc291cmNlIHdlIHRyeSB0byB1c2UpLgo+ID4gCj4gPiBBZGRpdGlvbmFsbHkgdGhlIERG
VCBzY3JhbWJsZXIgcmVzZXQgYml0cyB3ZSdyZSB0cnlpbmcgdG8gdXNlIGRvbid0Cj4gPiBzZWVt
IHRvIGV4aXN0IG9uIGc0eC4gVGhlcmUgYXJlIHNvbWUgcG90ZW50aWFsbHkgcmVsZXZhbnQgbG9v
a2luZyBiaXRzCj4gPiBpbiB0aGUgcGlwZSByZWdpc3RlcnMsIGJ1dCB3aGVuIEkgdHJpZWQgaXQg
SSBnb3Qgc3RhYmxlIGxvb2tpbmcgQ1JDcwo+ID4gd2l0aG91dCBzZXR0aW5nIGFueSBiaXRzIGZv
ciB0aGlzLgo+ID4gCj4gPiBJZiB0aGVyZSBpcyBhIHdheSB0byBtYWtlIERQIENSQ3Mgd29yayBy
ZWxpYWJseSBvbiBnNHgsIEkgd2Fzbid0Cj4gPiBhYmxlIHRvIGZpbmQgaXQuIFNvIGxldCdzIGp1
c3QgcmVtb3ZlIHRoZSBicm9rZW4gY29kZSB3ZSBoYXZlLgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5
OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ID4gLS0t
Cj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcGlwZV9jcmMuYyB8IDgwICsrKystLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCsp
LCA2OSBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p
OTE1L2ludGVsX3BpcGVfY3JjLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9waXBlX2Ny
Yy5jCj4gPiBpbmRleCBmZTBmZjg5Yjk4MGIuLjY2YmI3YjAzMTUzNyAxMDA2NDQKPiA+IC0tLSBh
L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BpcGVfY3JjLmMKPiA+ICsrKyBiL2RyaXZlcnMv
Z3B1L2RybS9pOTE1L2ludGVsX3BpcGVfY3JjLmMKPiA+IEBAIC0xOTEsOCArMTkxLDYgQEAgc3Rh
dGljIGludCBpOXh4X3BpcGVfY3JjX2N0bF9yZWcoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl
dl9wcml2LAo+ID4gIAkJCQkgZW51bSBpbnRlbF9waXBlX2NyY19zb3VyY2UgKnNvdXJjZSwKPiA+
ICAJCQkJIHUzMiAqdmFsKQo+ID4gIHsKPiA+IC0JYm9vbCBuZWVkX3N0YWJsZV9zeW1ib2xzID0g
ZmFsc2U7Cj4gPiAtCj4gPiAgCWlmICgqc291cmNlID09IElOVEVMX1BJUEVfQ1JDX1NPVVJDRV9B
VVRPKSB7Cj4gPiAgCQlpbnQgcmV0ID0gaTl4eF9waXBlX2NyY19hdXRvX3NvdXJjZShkZXZfcHJp
diwgcGlwZSwgc291cmNlKTsKPiA+ICAJCWlmIChyZXQpCj4gPiBAQCAtMjA4LDU2ICsyMDYsMjMg
QEAgc3RhdGljIGludCBpOXh4X3BpcGVfY3JjX2N0bF9yZWcoc3RydWN0IGRybV9pOTE1X3ByaXZh
dGUgKmRldl9wcml2LAo+ID4gIAkJCXJldHVybiAtRUlOVkFMOwo+ID4gIAkJKnZhbCA9IFBJUEVf
Q1JDX0VOQUJMRSB8IFBJUEVfQ1JDX1NPVVJDRV9UVl9QUkU7Cj4gPiAgCQlicmVhazsKPiA+IC0J
Y2FzZSBJTlRFTF9QSVBFX0NSQ19TT1VSQ0VfRFBfQjoKPiA+IC0JCWlmICghSVNfRzRYKGRldl9w
cml2KSkKPiA+IC0JCQlyZXR1cm4gLUVJTlZBTDsKPiA+IC0JCSp2YWwgPSBQSVBFX0NSQ19FTkFC
TEUgfCBQSVBFX0NSQ19TT1VSQ0VfRFBfQl9HNFg7Cj4gPiAtCQluZWVkX3N0YWJsZV9zeW1ib2xz
ID0gdHJ1ZTsKPiA+IC0JCWJyZWFrOwo+ID4gLQljYXNlIElOVEVMX1BJUEVfQ1JDX1NPVVJDRV9E
UF9DOgo+ID4gLQkJaWYgKCFJU19HNFgoZGV2X3ByaXYpKQo+ID4gLQkJCXJldHVybiAtRUlOVkFM
Owo+ID4gLQkJKnZhbCA9IFBJUEVfQ1JDX0VOQUJMRSB8IFBJUEVfQ1JDX1NPVVJDRV9EUF9DX0c0
WDsKPiA+IC0JCW5lZWRfc3RhYmxlX3N5bWJvbHMgPSB0cnVlOwo+ID4gLQkJYnJlYWs7Cj4gPiAt
CWNhc2UgSU5URUxfUElQRV9DUkNfU09VUkNFX0RQX0Q6Cj4gPiAtCQlpZiAoIUlTX0c0WChkZXZf
cHJpdikpCj4gPiAtCQkJcmV0dXJuIC1FSU5WQUw7Cj4gPiAtCQkqdmFsID0gUElQRV9DUkNfRU5B
QkxFIHwgUElQRV9DUkNfU09VUkNFX0RQX0RfRzRYOwo+ID4gLQkJbmVlZF9zdGFibGVfc3ltYm9s
cyA9IHRydWU7Cj4gPiAtCQlicmVhazsKPiA+ICAJY2FzZSBJTlRFTF9QSVBFX0NSQ19TT1VSQ0Vf
Tk9ORToKPiA+ICAJCSp2YWwgPSAwOwo+ID4gIAkJYnJlYWs7Cj4gPiAgCWRlZmF1bHQ6Cj4gPiAr
CQkvKgo+ID4gKwkJICogVGhlIERQIENSQyBzb3VyY2UgZG9lc24ndCB3b3JrIG9uIGc0eC4KPiA+
ICsJCSAqIEl0IGNhbiBiZSBtYWRlIHRvIHdvcmsgdG8gc29tZSBkZWdyZWUgYnkgc2VsZWN0aW5n
Cj4gPiArCQkgKiB0aGUgY29ycmVjdCBDUkMgc291cmNlIGJlZm9yZSB0aGUgcG9ydCBpcyBlbmFi
bGVkLAo+ID4gKwkJICogYW5kIG5vdCB0b3VjaGluZyB0aGUgQ1JDIHNvdXJjZSBiaXRzIGFnYWlu
IHVudGlsCj4gPiArCQkgKiB0aGUgcG9ydCBpcyBkaXNhYmxlZC4gQnV0IGV2ZW4gdGhlbiB0aGUg
Yml0cwo+ID4gKwkJICogZXZlbnR1YWxseSBnZXQgc3R1Y2sgYW5kIGEgcmVib290IGlzIG5lZWRl
ZCB0byBnZXQKPiA+ICsJCSAqIHdvcmtpbmcgQ1JDcyBvbiB0aGUgcGlwZSBhZ2Fpbi4gTGV0J3Mg
c2ltcGx5Cj4gPiArCQkgKiByZWZ1c2UgdG8gdXNlIERQIENSQ3Mgb24gZzR4Lgo+ID4gKwkJICov
Cj4gPiAgCQlyZXR1cm4gLUVJTlZBTDsKPiAKPiBpcyB0aGlzIHRoZSByaWdodCByZXR1cm4gbm93
PyBtYXliZSBFTk9FTlQ/Cj4gKGp1c3QgYnJhaW5zdG9ybWluZyB3aXRob3V0IGxvb2tpbmcgdG8g
aWd0IHRlc3RzKQoKV2UgcmV0dXJuIC1FSU5WQUwgZm9yIGFsbCBvdGhlciB1bnN1cHBvcnRlZCBz
b3VyY2VzLCBzbyB0aGlzCnNlZW1zIGNvbnNpc3RlbnQuCgo+IAo+IEJ1dCBJIGtub3cgaG93IHRl
cnJpYmxlIHVucmVsaWFibGUgY3JjcyBhcmUgYW5kIHRoaXMgcGF0Y2gKPiBsb29rcyB0aGUgcmln
aHQgd2F5LCBzbzoKPiAKPiBSZXZpZXdlZC1ieTogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlA
aW50ZWwuY29tPgo+IAo+IAo+IAo+ID4gIAl9Cj4gPiAgCj4gPiAtCS8qCj4gPiAtCSAqIFdoZW4g
dGhlIHBpcGUgQ1JDIHRhcCBwb2ludCBpcyBhZnRlciB0aGUgdHJhbnNjb2RlcnMgd2UgbmVlZAo+
ID4gLQkgKiB0byB0d2VhayBzeW1ib2wtbGV2ZWwgZmVhdHVyZXMgdG8gcHJvZHVjZSBhIGRldGVy
bWluaXN0aWMgc2VyaWVzIG9mCj4gPiAtCSAqIHN5bWJvbHMgZm9yIGEgZ2l2ZW4gZnJhbWUuIFdl
IG5lZWQgdG8gcmVzZXQgdGhvc2UgZmVhdHVyZXMgb25seSBvbmNlCj4gPiAtCSAqIGEgZnJhbWUg
KGluc3RlYWQgb2YgZXZlcnkgbnRoIHN5bWJvbCk6Cj4gPiAtCSAqICAgLSBEQy1iYWxhbmNlOiB1
c2VkIHRvIGVuc3VyZSBhIGJldHRlciBjbG9jayByZWNvdmVyeSBmcm9tIHRoZSBkYXRhCj4gPiAt
CSAqICAgICBsaW5rIChTRFZPKQo+ID4gLQkgKiAgIC0gRGlzcGxheVBvcnQgc2NyYW1ibGluZzog
dXNlZCBmb3IgRU1JIHJlZHVjdGlvbgo+ID4gLQkgKi8KPiA+IC0JaWYgKG5lZWRfc3RhYmxlX3N5
bWJvbHMpIHsKPiA+IC0JCXUzMiB0bXAgPSBJOTE1X1JFQUQoUE9SVF9ERlQyX0c0WCk7Cj4gPiAt
Cj4gPiAtCQlXQVJOX09OKCFJU19HNFgoZGV2X3ByaXYpKTsKPiA+IC0KPiA+IC0JCUk5MTVfV1JJ
VEUoUE9SVF9ERlRfSTlYWCwKPiA+IC0JCQkgICBJOTE1X1JFQUQoUE9SVF9ERlRfSTlYWCkgfCBE
Q19CQUxBTkNFX1JFU0VUKTsKPiA+IC0KPiA+IC0JCWlmIChwaXBlID09IFBJUEVfQSkKPiA+IC0J
CQl0bXAgfD0gUElQRV9BX1NDUkFNQkxFX1JFU0VUOwo+ID4gLQkJZWxzZQo+ID4gLQkJCXRtcCB8
PSBQSVBFX0JfU0NSQU1CTEVfUkVTRVQ7Cj4gPiAtCj4gPiAtCQlJOTE1X1dSSVRFKFBPUlRfREZU
Ml9HNFgsIHRtcCk7Cj4gPiAtCX0KPiA+IC0KPiA+ICAJcmV0dXJuIDA7Cj4gPiAgfQo+ID4gIAo+
ID4gQEAgLTI4MiwyNCArMjQ3LDYgQEAgc3RhdGljIHZvaWQgdmx2X3VuZG9fcGlwZV9zY3JhbWJs
ZV9yZXNldChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gPiAgCWlmICghKHRt
cCAmIFBJUEVfU0NSQU1CTEVfUkVTRVRfTUFTSykpCj4gPiAgCQl0bXAgJj0gfkRDX0JBTEFOQ0Vf
UkVTRVRfVkxWOwo+ID4gIAlJOTE1X1dSSVRFKFBPUlRfREZUMl9HNFgsIHRtcCk7Cj4gPiAtCj4g
PiAtfQo+ID4gLQo+ID4gLXN0YXRpYyB2b2lkIGc0eF91bmRvX3BpcGVfc2NyYW1ibGVfcmVzZXQo
c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ID4gLQkJCQkJIGVudW0gcGlwZSBw
aXBlKQo+ID4gLXsKPiA+IC0JdTMyIHRtcCA9IEk5MTVfUkVBRChQT1JUX0RGVDJfRzRYKTsKPiA+
IC0KPiA+IC0JaWYgKHBpcGUgPT0gUElQRV9BKQo+ID4gLQkJdG1wICY9IH5QSVBFX0FfU0NSQU1C
TEVfUkVTRVQ7Cj4gPiAtCWVsc2UKPiA+IC0JCXRtcCAmPSB+UElQRV9CX1NDUkFNQkxFX1JFU0VU
Owo+ID4gLQlJOTE1X1dSSVRFKFBPUlRfREZUMl9HNFgsIHRtcCk7Cj4gPiAtCj4gPiAtCWlmICgh
KHRtcCAmIFBJUEVfU0NSQU1CTEVfUkVTRVRfTUFTSykpIHsKPiA+IC0JCUk5MTVfV1JJVEUoUE9S
VF9ERlRfSTlYWCwKPiA+IC0JCQkgICBJOTE1X1JFQUQoUE9SVF9ERlRfSTlYWCkgJiB+RENfQkFM
QU5DRV9SRVNFVCk7Cj4gPiAtCX0KPiA+ICB9Cj4gPiAgCj4gPiAgc3RhdGljIGludCBpbGtfcGlw
ZV9jcmNfY3RsX3JlZyhlbnVtIGludGVsX3BpcGVfY3JjX3NvdXJjZSAqc291cmNlLAo+ID4gQEAg
LTQ4NSw5ICs0MzIsNiBAQCBzdGF0aWMgaW50IGk5eHhfY3JjX3NvdXJjZV92YWxpZChzdHJ1Y3Qg
ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gPiAgCXN3aXRjaCAoc291cmNlKSB7Cj4gPiAg
CWNhc2UgSU5URUxfUElQRV9DUkNfU09VUkNFX1BJUEU6Cj4gPiAgCWNhc2UgSU5URUxfUElQRV9D
UkNfU09VUkNFX1RWOgo+ID4gLQljYXNlIElOVEVMX1BJUEVfQ1JDX1NPVVJDRV9EUF9COgo+ID4g
LQljYXNlIElOVEVMX1BJUEVfQ1JDX1NPVVJDRV9EUF9DOgo+ID4gLQljYXNlIElOVEVMX1BJUEVf
Q1JDX1NPVVJDRV9EUF9EOgo+ID4gIAljYXNlIElOVEVMX1BJUEVfQ1JDX1NPVVJDRV9OT05FOgo+
ID4gIAkJcmV0dXJuIDA7Cj4gPiAgCWRlZmF1bHQ6Cj4gPiBAQCAtNjEyLDkgKzU1Niw3IEBAIGlu
dCBpbnRlbF9jcnRjX3NldF9jcmNfc291cmNlKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywgY29uc3Qg
Y2hhciAqc291cmNlX25hbWUpCj4gPiAgCVBPU1RJTkdfUkVBRChQSVBFX0NSQ19DVEwoY3J0Yy0+
aW5kZXgpKTsKPiA+ICAKPiA+ICAJaWYgKCFzb3VyY2UpIHsKPiA+IC0JCWlmIChJU19HNFgoZGV2
X3ByaXYpKQo+ID4gLQkJCWc0eF91bmRvX3BpcGVfc2NyYW1ibGVfcmVzZXQoZGV2X3ByaXYsIGNy
dGMtPmluZGV4KTsKPiA+IC0JCWVsc2UgaWYgKElTX1ZBTExFWVZJRVcoZGV2X3ByaXYpIHx8IElT
X0NIRVJSWVZJRVcoZGV2X3ByaXYpKQo+ID4gKwkJaWYgKElTX1ZBTExFWVZJRVcoZGV2X3ByaXYp
IHx8IElTX0NIRVJSWVZJRVcoZGV2X3ByaXYpKQo+ID4gIAkJCXZsdl91bmRvX3BpcGVfc2NyYW1i
bGVfcmVzZXQoZGV2X3ByaXYsIGNydGMtPmluZGV4KTsKPiA+ICAJCWVsc2UgaWYgKChJU19IQVNX
RUxMKGRldl9wcml2KSB8fAo+ID4gIAkJCSAgSVNfQlJPQURXRUxMKGRldl9wcml2KSkgJiYgY3J0
Yy0+aW5kZXggPT0gUElQRV9BKQo+ID4gLS0gCj4gPiAyLjE5LjIKPiA+IAo+ID4gX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+IEludGVsLWdmeCBtYWls
aW5nIGxpc3QKPiA+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+IGh0dHBzOi8v
bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKVmls
bGUgU3lyasOkbMOkCkludGVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr
dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu
dGVsLWdmeA==