From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 3/4] drm/i915: Remove the broken DP CRC
 support for g4x
Date: Fri, 15 Feb 2019 14:47:29 +0200
Message-ID: <20190215124729.GQ20097@intel.com>
References: <20190214192219.3858-1-ville.syrjala@linux.intel.com>
 <20190214192219.3858-3-ville.syrjala@linux.intel.com>
 <ad3c8abc7a383b6ac07f319af46ae49129b36f40.camel@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 1FA866E09E
 for <intel-gfx@lists.freedesktop.org>; Fri, 15 Feb 2019 12:47:33 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <ad3c8abc7a383b6ac07f319af46ae49129b36f40.camel@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVGh1LCBGZWIgMTQsIDIwMTkgYXQgMDY6MjY6MjlQTSAtMDgwMCwgRGhpbmFrYXJhbiBQYW5k
aXlhbiB3cm90ZToKPiBPbiBUaHUsIDIwMTktMDItMTQgYXQgMjE6MjIgKzAyMDAsIFZpbGxlIFN5
cmphbGEgd3JvdGU6Cj4gPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGlu
dXguaW50ZWwuY29tPgo+ID4gCj4gPiBEUCBDUkNzIGRvbid0IHJlYWxseSB3b3JrIG9uIGc0eC4g
SWYgeW91IHdhbnQgYW55IENSQ3Mgb24gRFAgeW91IG11c3QKPiA+IHNlbGVjdCB0aGUgQ1JDIHNv
dXJjZSBiZWZvcmUgdGhlIHBvcnQgaXMgZW5hYmxlZCwgb3RoZXJ3aXNlIHRoZSBDUkMKPiA+IHNv
dXJjZSBzZWxlY3QgYml0cyBzaW1wbHkgaWdub3JlIGFueSB3cml0ZXMgdG8gdGhlbS4gQW5kIG9u
Y2UgdGhlCj4gPiBwb3J0Cj4gPiBpcyBlbmFibGVkIHdlIG11c3RuJ3QgY2hhbmdlIHRoZSBDUkMg
c291cmNlIHNlbGVjdCB1bnRpbCB0aGUgcG9ydCBpcwo+ID4gZGlzYWJsZWQuIFRoYXQgYWxtb3N0
IHdvcmtzLCBidXQgbm90IHF1aXRlIDooIEV2ZW50dWFsbHkgdGhlIENSQwo+ID4gc291cmNlCj4g
PiBzZWxlY3QgYml0cyBnZXQgcGVybWFuZW50bHkgc3R1Y2sgb25lIHdheSBvciB0aGUgb3RoZXIs
IGFuZCBhZnRlcgo+ID4gdGhhdAo+ID4gYSByZWJvb3QgKG9yIHBvc3NpYmx5IGEgZGlzcGxheSBy
ZXNldCkgaXMgbmVlZGVkIHRvIGdldCB3b3JraW5nIENSQ3MKPiA+IG9uIHRoYXQgcGlwZSAobm90
IG1hdHRlciB3aGljaCBDUkMgc291cmNlIHdlIHRyeSB0byB1c2UpLgo+ID4gCj4gPiBBZGRpdGlv
bmFsbHkgdGhlIERGVCBzY3JhbWJsZXIgcmVzZXQgYml0cyB3ZSdyZSB0cnlpbmcgdG8gdXNlIGRv
bid0Cj4gPiBzZWVtIHRvIGV4aXN0IG9uIGc0eC4gVGhlcmUgYXJlIHNvbWUgcG90ZW50aWFsbHkg
cmVsZXZhbnQgbG9va2luZwo+ID4gYml0cwo+ID4gaW4gdGhlIHBpcGUgcmVnaXN0ZXJzLCBidXQg
d2hlbiBJIHRyaWVkIGl0IEkgZ290IHN0YWJsZSBsb29raW5nIENSQ3MKPiA+IHdpdGhvdXQgc2V0
dGluZyBhbnkgYml0cyBmb3IgdGhpcy4KPiA+IAo+ID4gSWYgdGhlcmUgaXMgYSB3YXkgdG8gbWFr
ZSBEUCBDUkNzIHdvcmsgcmVsaWFibHkgb24gZzR4LCBJIHdhc24ndAo+ID4gYWJsZSB0byBmaW5k
IGl0LiBTbyBsZXQncyBqdXN0IHJlbW92ZSB0aGUgYnJva2VuIGNvZGUgd2UgaGF2ZS4KPiAKPiAK
PiBJIHRoaW5rIHdlIGNhbiBtb2RpZnkgaTl4eF9waXBlX2NyY19hdXRvX3NvdXJjZSgpIHRvIHBp
Y2sgInBpcGUiIENSQwo+IHdoZW4gdXNlcnNwYWNlIHNlbGVjdHMgImF1dG8iIGFuZCB0aGUgb3V0
cHV0IGlzIERQL2VEUC4KCk5vcGUuIFNwZWMgc2F5czoKIlBpcGUgQ1JDIHNob3VsZCBub3QgYmUg
cnVuIHdoZW4gRGlzcGxheSBQb3J0IG9yIFRWIGlzIGVuYWJsZWQgb24gdGhpcwogcGlwZS4iCgph
bmQKCiJDUkMgU291cmNlIFNlbGVjdDogVGhlc2UgYml0cyBzZWxlY3QgdGhlIHNvdXJjZSBvZiB0
aGUgZGF0YSB0byBwdXQgaW50bwogdGhlIENSQyBsb2dpYy4KIDAwMDogUGlwZSBBIChOb3QgYXZh
aWxhYmxlIHdoZW4gRGlzcGxheVBvcnQgb3IgVFYgaXMgZW5hYmxlZCBvbiB0aGlzCiBwaXBlKSIK
ClRob3VnaCBJIG11c3QgYWRtaXQgSSd2ZSBuZXZlciBhY3R1YWxseSB0cmllZCBpdCB0byBzZWUg
d2hhdCBhY3R1YWxseQpoYXBwZW5zLgoKPiAKPiAKPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogVmls
bGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+IC0tLQo+ID4g
IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BpcGVfY3JjLmMgfCA4MCArKysrLS0tLS0tLS0t
LS0tLS0tLS0tLS0tCj4gPiAtLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCsp
LCA2OSBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p
OTE1L2ludGVsX3BpcGVfY3JjLmMKPiA+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcGlw
ZV9jcmMuYwo+ID4gaW5kZXggZmUwZmY4OWI5ODBiLi42NmJiN2IwMzE1MzcgMTAwNjQ0Cj4gPiAt
LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9waXBlX2NyYy5jCj4gPiArKysgYi9kcml2
ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9waXBlX2NyYy5jCj4gPiBAQCAtMTkxLDggKzE5MSw2IEBA
IHN0YXRpYyBpbnQgaTl4eF9waXBlX2NyY19jdGxfcmVnKHN0cnVjdAo+ID4gZHJtX2k5MTVfcHJp
dmF0ZSAqZGV2X3ByaXYsCj4gPiAgCQkJCSBlbnVtIGludGVsX3BpcGVfY3JjX3NvdXJjZSAqc291
cmNlLAo+ID4gIAkJCQkgdTMyICp2YWwpCj4gPiAgewo+ID4gLQlib29sIG5lZWRfc3RhYmxlX3N5
bWJvbHMgPSBmYWxzZTsKPiA+IC0KPiA+ICAJaWYgKCpzb3VyY2UgPT0gSU5URUxfUElQRV9DUkNf
U09VUkNFX0FVVE8pIHsKPiA+ICAJCWludCByZXQgPSBpOXh4X3BpcGVfY3JjX2F1dG9fc291cmNl
KGRldl9wcml2LCBwaXBlLAo+ID4gc291cmNlKTsKPiA+ICAJCWlmIChyZXQpCj4gPiBAQCAtMjA4
LDU2ICsyMDYsMjMgQEAgc3RhdGljIGludCBpOXh4X3BpcGVfY3JjX2N0bF9yZWcoc3RydWN0Cj4g
PiBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiA+ICAJCQlyZXR1cm4gLUVJTlZBTDsKPiA+
ICAJCSp2YWwgPSBQSVBFX0NSQ19FTkFCTEUgfCBQSVBFX0NSQ19TT1VSQ0VfVFZfUFJFOwo+ID4g
IAkJYnJlYWs7Cj4gPiAtCWNhc2UgSU5URUxfUElQRV9DUkNfU09VUkNFX0RQX0I6Cj4gPiAtCQlp
ZiAoIUlTX0c0WChkZXZfcHJpdikpCj4gPiAtCQkJcmV0dXJuIC1FSU5WQUw7Cj4gPiAtCQkqdmFs
ID0gUElQRV9DUkNfRU5BQkxFIHwgUElQRV9DUkNfU09VUkNFX0RQX0JfRzRYOwo+ID4gLQkJbmVl
ZF9zdGFibGVfc3ltYm9scyA9IHRydWU7Cj4gPiAtCQlicmVhazsKPiA+IC0JY2FzZSBJTlRFTF9Q
SVBFX0NSQ19TT1VSQ0VfRFBfQzoKPiA+IC0JCWlmICghSVNfRzRYKGRldl9wcml2KSkKPiA+IC0J
CQlyZXR1cm4gLUVJTlZBTDsKPiA+IC0JCSp2YWwgPSBQSVBFX0NSQ19FTkFCTEUgfCBQSVBFX0NS
Q19TT1VSQ0VfRFBfQ19HNFg7Cj4gPiAtCQluZWVkX3N0YWJsZV9zeW1ib2xzID0gdHJ1ZTsKPiA+
IC0JCWJyZWFrOwo+ID4gLQljYXNlIElOVEVMX1BJUEVfQ1JDX1NPVVJDRV9EUF9EOgo+ID4gLQkJ
aWYgKCFJU19HNFgoZGV2X3ByaXYpKQo+ID4gLQkJCXJldHVybiAtRUlOVkFMOwo+ID4gLQkJKnZh
bCA9IFBJUEVfQ1JDX0VOQUJMRSB8IFBJUEVfQ1JDX1NPVVJDRV9EUF9EX0c0WDsKPiA+IC0JCW5l
ZWRfc3RhYmxlX3N5bWJvbHMgPSB0cnVlOwo+ID4gLQkJYnJlYWs7Cj4gPiAgCWNhc2UgSU5URUxf
UElQRV9DUkNfU09VUkNFX05PTkU6Cj4gPiAgCQkqdmFsID0gMDsKPiA+ICAJCWJyZWFrOwo+ID4g
IAlkZWZhdWx0Ogo+ID4gKwkJLyoKPiA+ICsJCSAqIFRoZSBEUCBDUkMgc291cmNlIGRvZXNuJ3Qg
d29yayBvbiBnNHguCj4gPiArCQkgKiBJdCBjYW4gYmUgbWFkZSB0byB3b3JrIHRvIHNvbWUgZGVn
cmVlIGJ5IHNlbGVjdGluZwo+ID4gKwkJICogdGhlIGNvcnJlY3QgQ1JDIHNvdXJjZSBiZWZvcmUg
dGhlIHBvcnQgaXMgZW5hYmxlZCwKPiA+ICsJCSAqIGFuZCBub3QgdG91Y2hpbmcgdGhlIENSQyBz
b3VyY2UgYml0cyBhZ2FpbiB1bnRpbAo+ID4gKwkJICogdGhlIHBvcnQgaXMgZGlzYWJsZWQuIEJ1
dCBldmVuIHRoZW4gdGhlIGJpdHMKPiA+ICsJCSAqIGV2ZW50dWFsbHkgZ2V0IHN0dWNrIGFuZCBh
IHJlYm9vdCBpcyBuZWVkZWQgdG8gZ2V0Cj4gPiArCQkgKiB3b3JraW5nIENSQ3Mgb24gdGhlIHBp
cGUgYWdhaW4uIExldCdzIHNpbXBseQo+ID4gKwkJICogcmVmdXNlIHRvIHVzZSBEUCBDUkNzIG9u
IGc0eC4KPiA+ICsJCSAqL3oKPiA+ICAJCXJldHVybiAtRUlOVkFMOwo+ID4gIAl9Cj4gPiAgCj4g
PiAtCS8qCj4gPiAtCSAqIFdoZW4gdGhlIHBpcGUgQ1JDIHRhcCBwb2ludCBpcyBhZnRlciB0aGUg
dHJhbnNjb2RlcnMgd2UgbmVlZAo+ID4gLQkgKiB0byB0d2VhayBzeW1ib2wtbGV2ZWwgZmVhdHVy
ZXMgdG8gcHJvZHVjZSBhIGRldGVybWluaXN0aWMKPiA+IHNlcmllcyBvZgo+ID4gLQkgKiBzeW1i
b2xzIGZvciBhIGdpdmVuIGZyYW1lLiBXZSBuZWVkIHRvIHJlc2V0IHRob3NlIGZlYXR1cmVzCj4g
PiBvbmx5IG9uY2UKPiA+IC0JICogYSBmcmFtZSAoaW5zdGVhZCBvZiBldmVyeSBudGggc3ltYm9s
KToKPiA+IC0JICogICAtIERDLWJhbGFuY2U6IHVzZWQgdG8gZW5zdXJlIGEgYmV0dGVyIGNsb2Nr
IHJlY292ZXJ5IGZyb20KPiA+IHRoZSBkYXRhCj4gPiAtCSAqICAgICBsaW5rIChTRFZPKQo+ID4g
LQkgKiAgIC0gRGlzcGxheVBvcnQgc2NyYW1ibGluZzogdXNlZCBmb3IgRU1JIHJlZHVjdGlvbgo+
ID4gLQkgKi8KPiA+IC0JaWYgKG5lZWRfc3RhYmxlX3N5bWJvbHMpIHsKPiA+IC0JCXUzMiB0bXAg
PSBJOTE1X1JFQUQoUE9SVF9ERlQyX0c0WCk7Cj4gPiAtCj4gPiAtCQlXQVJOX09OKCFJU19HNFgo
ZGV2X3ByaXYpKTsKPiA+IC0KPiA+IC0JCUk5MTVfV1JJVEUoUE9SVF9ERlRfSTlYWCwKPiA+IC0J
CQkgICBJOTE1X1JFQUQoUE9SVF9ERlRfSTlYWCkgfAo+ID4gRENfQkFMQU5DRV9SRVNFVCk7Cj4g
PiAtCj4gPiAtCQlpZiAocGlwZSA9PSBQSVBFX0EpCj4gPiAtCQkJdG1wIHw9IFBJUEVfQV9TQ1JB
TUJMRV9SRVNFVDsKPiA+IC0JCWVsc2UKPiA+IC0JCQl0bXAgfD0gUElQRV9CX1NDUkFNQkxFX1JF
U0VUOwo+ID4gLQo+ID4gLQkJSTkxNV9XUklURShQT1JUX0RGVDJfRzRYLCB0bXApOwo+ID4gLQl9
Cj4gPiAtCj4gPiAgCXJldHVybiAwOwo+ID4gIH0KPiA+ICAKPiA+IEBAIC0yODIsMjQgKzI0Nyw2
IEBAIHN0YXRpYyB2b2lkIHZsdl91bmRvX3BpcGVfc2NyYW1ibGVfcmVzZXQoc3RydWN0Cj4gPiBk
cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiA+ICAJaWYgKCEodG1wICYgUElQRV9TQ1JBTUJM
RV9SRVNFVF9NQVNLKSkKPiA+ICAJCXRtcCAmPSB+RENfQkFMQU5DRV9SRVNFVF9WTFY7Cj4gPiAg
CUk5MTVfV1JJVEUoUE9SVF9ERlQyX0c0WCwgdG1wKTsKPiA+IC0KPiA+IC19Cj4gPiAtCj4gPiAt
c3RhdGljIHZvaWQgZzR4X3VuZG9fcGlwZV9zY3JhbWJsZV9yZXNldChzdHJ1Y3QgZHJtX2k5MTVf
cHJpdmF0ZQo+ID4gKmRldl9wcml2LAo+ID4gLQkJCQkJIGVudW0gcGlwZSBwaXBlKQo+ID4gLXsK
PiA+IC0JdTMyIHRtcCA9IEk5MTVfUkVBRChQT1JUX0RGVDJfRzRYKTsKPiA+IC0KPiA+IC0JaWYg
KHBpcGUgPT0gUElQRV9BKQo+ID4gLQkJdG1wICY9IH5QSVBFX0FfU0NSQU1CTEVfUkVTRVQ7Cj4g
PiAtCWVsc2UKPiA+IC0JCXRtcCAmPSB+UElQRV9CX1NDUkFNQkxFX1JFU0VUOwo+ID4gLQlJOTE1
X1dSSVRFKFBPUlRfREZUMl9HNFgsIHRtcCk7Cj4gPiAtCj4gPiAtCWlmICghKHRtcCAmIFBJUEVf
U0NSQU1CTEVfUkVTRVRfTUFTSykpIHsKPiA+IC0JCUk5MTVfV1JJVEUoUE9SVF9ERlRfSTlYWCwK
PiA+IC0JCQkgICBJOTE1X1JFQUQoUE9SVF9ERlRfSTlYWCkgJgo+ID4gfkRDX0JBTEFOQ0VfUkVT
RVQpOwo+ID4gLQl9Cj4gPiAgfQo+ID4gIAo+ID4gIHN0YXRpYyBpbnQgaWxrX3BpcGVfY3JjX2N0
bF9yZWcoZW51bSBpbnRlbF9waXBlX2NyY19zb3VyY2UgKnNvdXJjZSwKPiA+IEBAIC00ODUsOSAr
NDMyLDYgQEAgc3RhdGljIGludCBpOXh4X2NyY19zb3VyY2VfdmFsaWQoc3RydWN0Cj4gPiBkcm1f
aTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiA+ICAJc3dpdGNoIChzb3VyY2UpIHsKPiA+ICAJY2Fz
ZSBJTlRFTF9QSVBFX0NSQ19TT1VSQ0VfUElQRToKPiA+ICAJY2FzZSBJTlRFTF9QSVBFX0NSQ19T
T1VSQ0VfVFY6Cj4gPiAtCWNhc2UgSU5URUxfUElQRV9DUkNfU09VUkNFX0RQX0I6Cj4gPiAtCWNh
c2UgSU5URUxfUElQRV9DUkNfU09VUkNFX0RQX0M6Cj4gPiAtCWNhc2UgSU5URUxfUElQRV9DUkNf
U09VUkNFX0RQX0Q6Cj4gPiAgCWNhc2UgSU5URUxfUElQRV9DUkNfU09VUkNFX05PTkU6Cj4gPiAg
CQlyZXR1cm4gMDsKPiA+ICAJZGVmYXVsdDoKPiA+IEBAIC02MTIsOSArNTU2LDcgQEAgaW50IGlu
dGVsX2NydGNfc2V0X2NyY19zb3VyY2Uoc3RydWN0IGRybV9jcnRjCj4gPiAqY3J0YywgY29uc3Qg
Y2hhciAqc291cmNlX25hbWUpCj4gPiAgCVBPU1RJTkdfUkVBRChQSVBFX0NSQ19DVEwoY3J0Yy0+
aW5kZXgpKTsKPiA+ICAKPiA+ICAJaWYgKCFzb3VyY2UpIHsKPiA+IC0JCWlmIChJU19HNFgoZGV2
X3ByaXYpKQo+ID4gLQkJCWc0eF91bmRvX3BpcGVfc2NyYW1ibGVfcmVzZXQoZGV2X3ByaXYsIGNy
dGMtCj4gPiA+aW5kZXgpOwo+ID4gLQkJZWxzZSBpZiAoSVNfVkFMTEVZVklFVyhkZXZfcHJpdikg
fHwKPiA+IElTX0NIRVJSWVZJRVcoZGV2X3ByaXYpKQo+ID4gKwkJaWYgKElTX1ZBTExFWVZJRVco
ZGV2X3ByaXYpIHx8IElTX0NIRVJSWVZJRVcoZGV2X3ByaXYpKQo+ID4gIAkJCXZsdl91bmRvX3Bp
cGVfc2NyYW1ibGVfcmVzZXQoZGV2X3ByaXYsIGNydGMtCj4gPiA+aW5kZXgpOwo+ID4gIAkJZWxz
ZSBpZiAoKElTX0hBU1dFTEwoZGV2X3ByaXYpIHx8Cj4gPiAgCQkJICBJU19CUk9BRFdFTEwoZGV2
X3ByaXYpKSAmJiBjcnRjLT5pbmRleCA9PQo+ID4gUElQRV9BKQoKLS0gClZpbGxlIFN5cmrDpGzD
pApJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ
bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0
cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=