From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 01/25] drm/i915: Move verify_wm_state() to heap Date: Tue, 19 Feb 2019 14:56:53 +0200 Message-ID: <20190219125653.GA20097@intel.com> References: <20190219122215.8941-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 89B87892A0 for ; Tue, 19 Feb 2019 12:56:56 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190219122215.8941-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBGZWIgMTksIDIwMTkgYXQgMTI6MjE6NTFQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFRoZSBzdGFjayB1c2FnZSBleGNlZWRlZCAxMDI0IGJ5dGVzIHByb21wdGluZyB3YXJu aW5ncyBvbiBjb25zZXJ2YXRpdmUKPiBzZXR1cHMsIHNvIG1vdmUgdGhlIHRlbXBvcmFyeSBhbGxv Y2F0aW9uIGZvciBIVyByZWFkYmFjayBvbnRvIHRoZSBoZWFwLgo+IAo+IFNpZ25lZC1vZmYtYnk6 IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IENjOiBWaWxsZSBTeXJq w6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgoKUmV2aWV3ZWQtYnk6IFZpbGxl IFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cgo+IC0tLQo+ICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCA0OCArKysrKysrKysrKysrKysrKyst LS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAzMSBpbnNlcnRpb25zKCspLCAxNyBkZWxldGlv bnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxh eS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gaW5kZXggM2I0YTZl ZWI0NTczLi40MTVkODk2OGYyYzUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxh eS5jCj4gQEAgLTEyMjI3LDEyICsxMjIyNywxNSBAQCBzdGF0aWMgdm9pZCB2ZXJpZnlfd21fc3Rh dGUoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ICAJCQkgICAgc3RydWN0IGRybV9jcnRjX3N0YXRl ICpuZXdfc3RhdGUpCj4gIHsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9 IHRvX2k5MTUoY3J0Yy0+ZGV2KTsKPiAtCXN0cnVjdCBza2xfZGRiX2FsbG9jYXRpb24gaHdfZGRi LCAqc3dfZGRiOwo+IC0Jc3RydWN0IHNrbF9waXBlX3dtIGh3X3dtLCAqc3dfd207Cj4gLQlzdHJ1 Y3Qgc2tsX3BsYW5lX3dtICpod19wbGFuZV93bSwgKnN3X3BsYW5lX3dtOwo+ICsJc3RydWN0IHNr bF9od19zdGF0ZSB7Cj4gKwkJc3RydWN0IHNrbF9kZGJfZW50cnkgZGRiX3lbSTkxNV9NQVhfUExB TkVTXTsKPiArCQlzdHJ1Y3Qgc2tsX2RkYl9lbnRyeSBkZGJfdXZbSTkxNV9NQVhfUExBTkVTXTsK PiArCQlzdHJ1Y3Qgc2tsX2RkYl9hbGxvY2F0aW9uIGRkYjsKPiArCQlzdHJ1Y3Qgc2tsX3BpcGVf d20gd207Cj4gKwl9ICpodzsKPiArCXN0cnVjdCBza2xfZGRiX2FsbG9jYXRpb24gKnN3X2RkYjsK PiArCXN0cnVjdCBza2xfcGlwZV93bSAqc3dfd207Cj4gIAlzdHJ1Y3Qgc2tsX2RkYl9lbnRyeSAq aHdfZGRiX2VudHJ5LCAqc3dfZGRiX2VudHJ5Owo+IC0Jc3RydWN0IHNrbF9kZGJfZW50cnkgaHdf ZGRiX3lbSTkxNV9NQVhfUExBTkVTXTsKPiAtCXN0cnVjdCBza2xfZGRiX2VudHJ5IGh3X2RkYl91 dltJOTE1X01BWF9QTEFORVNdOwo+ICAJc3RydWN0IGludGVsX2NydGMgKmludGVsX2NydGMgPSB0 b19pbnRlbF9jcnRjKGNydGMpOwo+ICAJY29uc3QgZW51bSBwaXBlIHBpcGUgPSBpbnRlbF9jcnRj LT5waXBlOwo+ICAJaW50IHBsYW5lLCBsZXZlbCwgbWF4X2xldmVsID0gaWxrX3dtX21heF9sZXZl bChkZXZfcHJpdik7Cj4gQEAgLTEyMjQwLDIyICsxMjI0MywyOSBAQCBzdGF0aWMgdm9pZCB2ZXJp Znlfd21fc3RhdGUoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ICAJaWYgKElOVEVMX0dFTihkZXZf cHJpdikgPCA5IHx8ICFuZXdfc3RhdGUtPmFjdGl2ZSkKPiAgCQlyZXR1cm47Cj4gIAo+IC0Jc2ts X3BpcGVfd21fZ2V0X2h3X3N0YXRlKGludGVsX2NydGMsICZod193bSk7Cj4gKwlodyA9IGt6YWxs b2Moc2l6ZW9mKCpodyksIEdGUF9LRVJORUwpOwo+ICsJaWYgKCFodykKPiArCQlyZXR1cm47Cj4g Kwo+ICsJc2tsX3BpcGVfd21fZ2V0X2h3X3N0YXRlKGludGVsX2NydGMsICZody0+d20pOwo+ICAJ c3dfd20gPSAmdG9faW50ZWxfY3J0Y19zdGF0ZShuZXdfc3RhdGUpLT53bS5za2wub3B0aW1hbDsK PiAgCj4gLQlza2xfcGlwZV9kZGJfZ2V0X2h3X3N0YXRlKGludGVsX2NydGMsIGh3X2RkYl95LCBo d19kZGJfdXYpOwo+ICsJc2tsX3BpcGVfZGRiX2dldF9od19zdGF0ZShpbnRlbF9jcnRjLCBody0+ ZGRiX3ksIGh3LT5kZGJfdXYpOwo+ICAKPiAtCXNrbF9kZGJfZ2V0X2h3X3N0YXRlKGRldl9wcml2 LCAmaHdfZGRiKTsKPiArCXNrbF9kZGJfZ2V0X2h3X3N0YXRlKGRldl9wcml2LCAmaHctPmRkYik7 Cj4gIAlzd19kZGIgPSAmZGV2X3ByaXYtPndtLnNrbF9ody5kZGI7Cj4gIAo+IC0JaWYgKElOVEVM X0dFTihkZXZfcHJpdikgPj0gMTEpCj4gLQkJaWYgKGh3X2RkYi5lbmFibGVkX3NsaWNlcyAhPSBz d19kZGItPmVuYWJsZWRfc2xpY2VzKQo+IC0JCQlEUk1fRVJST1IoIm1pc21hdGNoIGluIERCVUYg U2xpY2VzIChleHBlY3RlZCAldSwgZ290ICV1KVxuIiwKPiAtCQkJCSAgc3dfZGRiLT5lbmFibGVk X3NsaWNlcywKPiAtCQkJCSAgaHdfZGRiLmVuYWJsZWRfc2xpY2VzKTsKPiArCWlmIChJTlRFTF9H RU4oZGV2X3ByaXYpID49IDExICYmCj4gKwkgICAgaHctPmRkYi5lbmFibGVkX3NsaWNlcyAhPSBz d19kZGItPmVuYWJsZWRfc2xpY2VzKQo+ICsJCURSTV9FUlJPUigibWlzbWF0Y2ggaW4gREJVRiBT bGljZXMgKGV4cGVjdGVkICV1LCBnb3QgJXUpXG4iLAo+ICsJCQkgIHN3X2RkYi0+ZW5hYmxlZF9z bGljZXMsCj4gKwkJCSAgaHctPmRkYi5lbmFibGVkX3NsaWNlcyk7Cj4gKwo+ICAJLyogcGxhbmVz ICovCj4gIAlmb3JfZWFjaF91bml2ZXJzYWxfcGxhbmUoZGV2X3ByaXYsIHBpcGUsIHBsYW5lKSB7 Cj4gLQkJaHdfcGxhbmVfd20gPSAmaHdfd20ucGxhbmVzW3BsYW5lXTsKPiArCQlzdHJ1Y3Qgc2ts X3BsYW5lX3dtICpod19wbGFuZV93bSwgKnN3X3BsYW5lX3dtOwo+ICsKPiArCQlod19wbGFuZV93 bSA9ICZody0+d20ucGxhbmVzW3BsYW5lXTsKPiAgCQlzd19wbGFuZV93bSA9ICZzd193bS0+cGxh bmVzW3BsYW5lXTsKPiAgCj4gIAkJLyogV2F0ZXJtYXJrcyAqLwo+IEBAIC0xMjI4Nyw3ICsxMjI5 Nyw3IEBAIHN0YXRpYyB2b2lkIHZlcmlmeV93bV9zdGF0ZShzdHJ1Y3QgZHJtX2NydGMgKmNydGMs Cj4gIAkJfQo+ICAKPiAgCQkvKiBEREIgKi8KPiAtCQlod19kZGJfZW50cnkgPSAmaHdfZGRiX3lb cGxhbmVdOwo+ICsJCWh3X2RkYl9lbnRyeSA9ICZody0+ZGRiX3lbcGxhbmVdOwo+ICAJCXN3X2Rk Yl9lbnRyeSA9ICZ0b19pbnRlbF9jcnRjX3N0YXRlKG5ld19zdGF0ZSktPndtLnNrbC5wbGFuZV9k ZGJfeVtwbGFuZV07Cj4gIAo+ICAJCWlmICghc2tsX2RkYl9lbnRyeV9lcXVhbChod19kZGJfZW50 cnksIHN3X2RkYl9lbnRyeSkpIHsKPiBAQCAtMTIzMDUsNyArMTIzMTUsOSBAQCBzdGF0aWMgdm9p ZCB2ZXJpZnlfd21fc3RhdGUoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ICAJICogb25jZSB0aGUg cGxhbmUgYmVjb21lcyB2aXNpYmxlLCB3ZSBjYW4gc2tpcCB0aGlzIGNoZWNrCj4gIAkgKi8KPiAg CWlmICgxKSB7Cj4gLQkJaHdfcGxhbmVfd20gPSAmaHdfd20ucGxhbmVzW1BMQU5FX0NVUlNPUl07 Cj4gKwkJc3RydWN0IHNrbF9wbGFuZV93bSAqaHdfcGxhbmVfd20sICpzd19wbGFuZV93bTsKPiAr Cj4gKwkJaHdfcGxhbmVfd20gPSAmaHctPndtLnBsYW5lc1tQTEFORV9DVVJTT1JdOwo+ICAJCXN3 X3BsYW5lX3dtID0gJnN3X3dtLT5wbGFuZXNbUExBTkVfQ1VSU09SXTsKPiAgCj4gIAkJLyogV2F0 ZXJtYXJrcyAqLwo+IEBAIC0xMjMzNyw3ICsxMjM0OSw3IEBAIHN0YXRpYyB2b2lkIHZlcmlmeV93 bV9zdGF0ZShzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gIAkJfQo+ICAKPiAgCQkvKiBEREIgKi8K PiAtCQlod19kZGJfZW50cnkgPSAmaHdfZGRiX3lbUExBTkVfQ1VSU09SXTsKPiArCQlod19kZGJf ZW50cnkgPSAmaHctPmRkYl95W1BMQU5FX0NVUlNPUl07Cj4gIAkJc3dfZGRiX2VudHJ5ID0gJnRv X2ludGVsX2NydGNfc3RhdGUobmV3X3N0YXRlKS0+d20uc2tsLnBsYW5lX2RkYl95W1BMQU5FX0NV UlNPUl07Cj4gIAo+ICAJCWlmICghc2tsX2RkYl9lbnRyeV9lcXVhbChod19kZGJfZW50cnksIHN3 X2RkYl9lbnRyeSkpIHsKPiBAQCAtMTIzNDcsNiArMTIzNTksOCBAQCBzdGF0aWMgdm9pZCB2ZXJp Znlfd21fc3RhdGUoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ICAJCQkJICBod19kZGJfZW50cnkt PnN0YXJ0LCBod19kZGJfZW50cnktPmVuZCk7Cj4gIAkJfQo+ICAJfQo+ICsKPiArCWtmcmVlKGh3 KTsKPiAgfQo+ICAKPiAgc3RhdGljIHZvaWQKPiAtLSAKPiAyLjIwLjEKCi0tIApWaWxsZSBTeXJq w6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4