From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [CI, v3, 1/2] drm/i915: Prevent a race during I915_GEM_MMAP ioctl with WC set Date: Thu, 28 Feb 2019 13:32:41 -0800 Message-ID: <20190228213241.GA15462@roeck-us.net> References: <20190207085454.10598-1-joonas.lahtinen@linux.intel.com> <20190228191249.GA10430@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9CD1189EA9 for ; Thu, 28 Feb 2019 21:32:44 +0000 (UTC) Received: by mail-pg1-x542.google.com with SMTP id r124so10337679pgr.3 for ; Thu, 28 Feb 2019 13:32:44 -0800 (PST) Content-Disposition: inline In-Reply-To: <20190228191249.GA10430@roeck-us.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Joonas Lahtinen Cc: Intel graphics driver community testing & development List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBGZWIgMjgsIDIwMTkgYXQgMTE6MTI6NDlBTSAtMDgwMCwgR3VlbnRlciBSb2VjayB3 cm90ZToKPiBIaSwKPiAKPiBPbiBUaHUsIEZlYiAwNywgMjAxOSBhdCAxMDo1NDo1M0FNICswMjAw LCBKb29uYXMgTGFodGluZW4gd3JvdGU6Cj4gPiBNYWtlIHN1cmUgdGhlIHVuZGVybHlpbmcgVk1B IGluIHRoZSBwcm9jZXNzIGFkZHJlc3Mgc3BhY2UgaXMgdGhlCj4gPiBzYW1lIGFzIGl0IHdhcyBk dXJpbmcgdm1fbW1hcCB0byBhdm9pZCBhcHBseWluZyBXQyB0byB3cm9uZyBWTUEuCj4gPiAKPiA+ IEEgbW9yZSBsb25nLXRlcm0gc29sdXRpb24gd291bGQgYmUgdG8gaGF2ZSB2bV9tbWFwX2xvY2tl ZCB2YXJpYW50Cj4gPiBpbiBsaW51eC9tbWFwLmggZm9yIHdoZW4gY2FsbGVyIHdhbnRzIHRvIGhv bGQgbW1hcF9zZW0gZm9yIGFuCj4gPiBleHRlbmRlZCBkdXJhdGlvbi4KPiA+IAo+IAo+IEl0IHNl ZW1zIGxpa2Ugd2UgbWF5IGhhdmUgYSByZWdyZXNzaW9uIGR1ZSB0byB0aGlzIHBhdGNoLiBJIGFt IHN0aWxsCj4gZGVidWdnaW5nLCBidXQgSSBoYXZlIGEgcXVlc3Rpb247IHBsZWFzZSBzZWUgYmVs b3cuCj4gCj4gVGhhbmtzLAo+IEd1ZW50ZXIKPiAKPiA+IHYyOgo+ID4gLSBSZWZhY3RvciB0aGUg Y29tcGFyZSBmdW5jdGlvbgo+ID4gCj4gPiBGaXhlczogMTgxNmY5MjM2MzAzICgiZHJtL2k5MTU6 IFN1cHBvcnQgY3JlYXRpb24gb2YgdW5ib3VuZCB3YyB1c2VyIG1hcHBpbmdzIGZvciBvYmplY3Rz IikKPiA+IFJlcG9ydGVkLWJ5OiBBZGFtIFphYnJvY2tpIDxhZGFtemFAbWljcm9zb2Z0LmNvbT4K PiA+IFN1Z2dlc3RlZC1ieTogTGludXMgVG9ydmFsZHMgPHRvcnZhbGRzQGxpbnV4LWZvdW5kYXRp b24ub3JnPgo+ID4gU2lnbmVkLW9mZi1ieTogSm9vbmFzIExhaHRpbmVuIDxqb29uYXMubGFodGlu ZW5AbGludXguaW50ZWwuY29tPgo+ID4gQ2M6IDxzdGFibGVAdmdlci5rZXJuZWwub3JnPiAjIHY0 LjArCj4gPiBDYzogQWthc2ggR29lbCA8YWthc2guZ29lbEBpbnRlbC5jb20+Cj4gPiBDYzogQ2hy aXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gPiBDYzogVHZydGtvIFVyc3Vs aW4gPHR2cnRrby51cnN1bGluQGxpbnV4LmludGVsLmNvbT4KPiA+IENjOiBBZGFtIFphYnJvY2tp IDxhZGFtemFAbWljcm9zb2Z0LmNvbT4KPiA+IFJldmlld2VkLWJ5OiBDaHJpcyBXaWxzb24gPGNo cmlzQGNocmlzLXdpbHNvbi5jby51az4KPiA+IFJldmlld2VkLWJ5OiBUdnJ0a28gVXJzdWxpbiA8 dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPiAjdjEKPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZ2VtLmMgfCAxMiArKysrKysrKysrKy0KPiA+ICAxIGZpbGUgY2hhbmdlZCwg MTEgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf Z2VtLmMKPiA+IGluZGV4IDA1Y2U5MTc2YWM0ZS4uNTI2MzlmNzQ5OTA4IDEwMDY0NAo+ID4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+ID4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9nZW0uYwo+ID4gQEAgLTE2ODEsNiArMTY4MSwxNiBAQCBpOTE1X2dlbV9z d19maW5pc2hfaW9jdGwoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdm9pZCAqZGF0YSwKPiA+ICAJ cmV0dXJuIDA7Cj4gPiAgfQo+ID4gIAo+ID4gK3N0YXRpYyBpbmxpbmUgYm9vbAo+ID4gK19fdm1h X21hdGNoZXMoc3RydWN0IHZtX2FyZWFfc3RydWN0ICp2bWEsIHN0cnVjdCBmaWxlICpmaWxwLAo+ ID4gKwkgICAgICB1bnNpZ25lZCBsb25nIGFkZHIsIHVuc2lnbmVkIGxvbmcgc2l6ZSkKPiA+ICt7 Cj4gPiArCWlmICh2bWEtPnZtX2ZpbGUgIT0gZmlscCkKPiA+ICsJCXJldHVybiBmYWxzZTsKPiA+ ICsKPiA+ICsJcmV0dXJuIHZtYS0+dm1fc3RhcnQgPT0gYWRkciAmJiAodm1hLT52bV9lbmQgLSB2 bWEtPnZtX3N0YXJ0KSA9PSBzaXplOwo+IAo+IFNob3VsZG4ndCB0aGlzIGJlOgo+IAlyZXR1cm4g dm1hLT52bV9zdGFydCA9PSBhZGRyICYmICh2bWEtPnZtX2VuZCAtIHZtYS0+dm1fc3RhcnQgKyAx KSA9PSBzaXplOwo+IGluc3RlYWQgPwo+IAoKQW5zd2VyIGlzIG5vIC4uIGJlY2F1c2Ugdm1fZW5k IHBvaW50cyB0byB0aGUgZmlyc3QgYnl0ZSBhZnRlciB0aGUKZW5kIGFkZHJlc3MuCgpUaGUgYWN0 dWFsIHZhbHVlcyBhcmU6CgpzdGFydD03ZDI4OGY3ZjkwMDAgZW5kPTdkMjg4Zjg0ZDAwMCBlbmQt c3RhcnQ9NTQwMDAgc2l6ZT01MzQwMAoKbWVhbmluZyB0aGUgc2l6ZSBmaWVsZCBwYXNzZWQgaW4g dGhlIGlvY3RsIGlzIHNtYWxsZXIgdGhhbiB0aGUgdG90YWwgbGVuZ3RoCm9mIHRoZSBhcmVhLgoK UXVlc3Rpb24gaXMgbm93OiBJcyB0aGUgcmVxdWVzdC9pb2N0bCBpbmRlZWQgaW52YWxpZCwgaWUg ZG9lcyB0aGUgcmVxdWVzdGVkCnNpemUgaGF2ZSB0byBtYXRjaCB0aGUgdm1hIHNpemUgPyBUaGlz IHVzZWQgdG8gd29yayB1bnRpbCB0aGlzIHBhdGNoIHdhcwphcHBsaWVkLCBhbmQgdGhlIGNoYW5n ZSBjYXVzZXMgb3VyIHRlc3QgY29kZSB0byBmYWlsIChhbmQgcG9zc2libHkgbWluaWdibSwKd2hp Y2ggaXMgdXNlZCBieSB0aGUgdGVzdCBjb2RlKS4gVGhhdCBkb2Vzbid0IG1lYW4gdGhhdCBvdXIg Y29kZSBpcyBjb3JyZWN0CihJIHNlZSBzb21lIHJlbGF0ZWQgbG9jYWwgY2hhbmdlcyBpbiBvdXIg dmVyc2lvbiBvZiBtaW5pZ2JtKSwgYnV0IGl0IGlzCmFubm95aW5nLCBhbmQgSSBhbSBiZWluZyBh c2tlZCB0byByZXZlcnQgdGhpcyBwYXRjaCBhcyByZWdyZXNzaW9uCmZyb20gb3VyIGtlcm5lbCBy ZWxlYXNlcy4KClRoYW5rcywKR3VlbnRlcgoKPiA+ICt9Cj4gPiArCj4gPiAgLyoqCj4gPiAgICog aTkxNV9nZW1fbW1hcF9pb2N0bCAtIE1hcHMgdGhlIGNvbnRlbnRzIG9mIGFuIG9iamVjdCwgcmV0 dXJuaW5nIHRoZSBhZGRyZXNzCj4gPiAgICoJCQkgaXQgaXMgbWFwcGVkIHRvLgo+ID4gQEAgLTE3 MzksNyArMTc0OSw3IEBAIGk5MTVfZ2VtX21tYXBfaW9jdGwoc3RydWN0IGRybV9kZXZpY2UgKmRl diwgdm9pZCAqZGF0YSwKPiA+ICAJCQlyZXR1cm4gLUVJTlRSOwo+ID4gIAkJfQo+ID4gIAkJdm1h ID0gZmluZF92bWEobW0sIGFkZHIpOwo+ID4gLQkJaWYgKHZtYSkKPiA+ICsJCWlmICh2bWEgJiYg X192bWFfbWF0Y2hlcyh2bWEsIG9iai0+YmFzZS5maWxwLCBhZGRyLCBhcmdzLT5zaXplKSkKPiA+ ICAJCQl2bWEtPnZtX3BhZ2VfcHJvdCA9Cj4gPiAgCQkJCXBncHJvdF93cml0ZWNvbWJpbmUodm1f Z2V0X3BhZ2VfcHJvdCh2bWEtPnZtX2ZsYWdzKSk7Cj4gPiAgCQllbHNlCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QK SW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==