From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [CI, v3, 1/2] drm/i915: Prevent a race during I915_GEM_MMAP ioctl with WC set Date: Thu, 28 Feb 2019 13:57:03 -0800 Message-ID: <20190228215703.GA16857@roeck-us.net> References: <20190207085454.10598-1-joonas.lahtinen@linux.intel.com> <20190228191249.GA10430@roeck-us.net> <20190228213241.GA15462@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by gabe.freedesktop.org (Postfix) with ESMTPS id 221C16E23D for ; Thu, 28 Feb 2019 21:57:07 +0000 (UTC) Received: by mail-pg1-x543.google.com with SMTP id i130so10374522pgd.1 for ; Thu, 28 Feb 2019 13:57:07 -0800 (PST) Content-Disposition: inline In-Reply-To: <20190228213241.GA15462@roeck-us.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Joonas Lahtinen Cc: Intel graphics driver community testing & development List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBGZWIgMjgsIDIwMTkgYXQgMDE6MzI6NDFQTSAtMDgwMCwgR3VlbnRlciBSb2VjayB3 cm90ZToKPiBPbiBUaHUsIEZlYiAyOCwgMjAxOSBhdCAxMToxMjo0OUFNIC0wODAwLCBHdWVudGVy IFJvZWNrIHdyb3RlOgo+ID4gSGksCj4gPiAKPiA+IE9uIFRodSwgRmViIDA3LCAyMDE5IGF0IDEw OjU0OjUzQU0gKzAyMDAsIEpvb25hcyBMYWh0aW5lbiB3cm90ZToKPiA+ID4gTWFrZSBzdXJlIHRo ZSB1bmRlcmx5aW5nIFZNQSBpbiB0aGUgcHJvY2VzcyBhZGRyZXNzIHNwYWNlIGlzIHRoZQo+ID4g PiBzYW1lIGFzIGl0IHdhcyBkdXJpbmcgdm1fbW1hcCB0byBhdm9pZCBhcHBseWluZyBXQyB0byB3 cm9uZyBWTUEuCj4gPiA+IAo+ID4gPiBBIG1vcmUgbG9uZy10ZXJtIHNvbHV0aW9uIHdvdWxkIGJl IHRvIGhhdmUgdm1fbW1hcF9sb2NrZWQgdmFyaWFudAo+ID4gPiBpbiBsaW51eC9tbWFwLmggZm9y IHdoZW4gY2FsbGVyIHdhbnRzIHRvIGhvbGQgbW1hcF9zZW0gZm9yIGFuCj4gPiA+IGV4dGVuZGVk IGR1cmF0aW9uLgo+ID4gPiAKPiA+IAo+ID4gSXQgc2VlbXMgbGlrZSB3ZSBtYXkgaGF2ZSBhIHJl Z3Jlc3Npb24gZHVlIHRvIHRoaXMgcGF0Y2guIEkgYW0gc3RpbGwKPiA+IGRlYnVnZ2luZywgYnV0 IEkgaGF2ZSBhIHF1ZXN0aW9uOyBwbGVhc2Ugc2VlIGJlbG93Lgo+ID4gCj4gPiBUaGFua3MsCj4g PiBHdWVudGVyCj4gPiAKPiA+ID4gdjI6Cj4gPiA+IC0gUmVmYWN0b3IgdGhlIGNvbXBhcmUgZnVu Y3Rpb24KPiA+ID4gCj4gPiA+IEZpeGVzOiAxODE2ZjkyMzYzMDMgKCJkcm0vaTkxNTogU3VwcG9y dCBjcmVhdGlvbiBvZiB1bmJvdW5kIHdjIHVzZXIgbWFwcGluZ3MgZm9yIG9iamVjdHMiKQo+ID4g PiBSZXBvcnRlZC1ieTogQWRhbSBaYWJyb2NraSA8YWRhbXphQG1pY3Jvc29mdC5jb20+Cj4gPiA+ IFN1Z2dlc3RlZC1ieTogTGludXMgVG9ydmFsZHMgPHRvcnZhbGRzQGxpbnV4LWZvdW5kYXRpb24u b3JnPgo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBKb29uYXMgTGFodGluZW4gPGpvb25hcy5sYWh0aW5l bkBsaW51eC5pbnRlbC5jb20+Cj4gPiA+IENjOiA8c3RhYmxlQHZnZXIua2VybmVsLm9yZz4gIyB2 NC4wKwo+ID4gPiBDYzogQWthc2ggR29lbCA8YWthc2guZ29lbEBpbnRlbC5jb20+Cj4gPiA+IENj OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiA+ID4gQ2M6IFR2cnRr byBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBsaW51eC5pbnRlbC5jb20+Cj4gPiA+IENjOiBBZGFt IFphYnJvY2tpIDxhZGFtemFAbWljcm9zb2Z0LmNvbT4KPiA+ID4gUmV2aWV3ZWQtYnk6IENocmlz IFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+ID4gPiBSZXZpZXdlZC1ieTogVHZy dGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4gI3YxCj4gPiA+IC0tLQo+ID4g PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyB8IDEyICsrKysrKysrKysrLQo+ID4g PiAgMSBmaWxlIGNoYW5nZWQsIDExIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiA+ID4g Cj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+ID4gPiBpbmRleCAwNWNlOTE3NmFjNGUuLjUy NjM5Zjc0OTkwOCAxMDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9n ZW0uYwo+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gPiA+IEBA IC0xNjgxLDYgKzE2ODEsMTYgQEAgaTkxNV9nZW1fc3dfZmluaXNoX2lvY3RsKHN0cnVjdCBkcm1f ZGV2aWNlICpkZXYsIHZvaWQgKmRhdGEsCj4gPiA+ICAJcmV0dXJuIDA7Cj4gPiA+ICB9Cj4gPiA+ ICAKPiA+ID4gK3N0YXRpYyBpbmxpbmUgYm9vbAo+ID4gPiArX192bWFfbWF0Y2hlcyhzdHJ1Y3Qg dm1fYXJlYV9zdHJ1Y3QgKnZtYSwgc3RydWN0IGZpbGUgKmZpbHAsCj4gPiA+ICsJICAgICAgdW5z aWduZWQgbG9uZyBhZGRyLCB1bnNpZ25lZCBsb25nIHNpemUpCj4gPiA+ICt7Cj4gPiA+ICsJaWYg KHZtYS0+dm1fZmlsZSAhPSBmaWxwKQo+ID4gPiArCQlyZXR1cm4gZmFsc2U7Cj4gPiA+ICsKPiA+ ID4gKwlyZXR1cm4gdm1hLT52bV9zdGFydCA9PSBhZGRyICYmICh2bWEtPnZtX2VuZCAtIHZtYS0+ dm1fc3RhcnQpID09IHNpemU7Cj4gPiAKPiA+IFNob3VsZG4ndCB0aGlzIGJlOgo+ID4gCXJldHVy biB2bWEtPnZtX3N0YXJ0ID09IGFkZHIgJiYgKHZtYS0+dm1fZW5kIC0gdm1hLT52bV9zdGFydCAr IDEpID09IHNpemU7Cj4gPiBpbnN0ZWFkID8KPiA+IAo+IAo+IEFuc3dlciBpcyBubyAuLiBiZWNh dXNlIHZtX2VuZCBwb2ludHMgdG8gdGhlIGZpcnN0IGJ5dGUgYWZ0ZXIgdGhlCj4gZW5kIGFkZHJl c3MuCj4gCj4gVGhlIGFjdHVhbCB2YWx1ZXMgYXJlOgo+IAo+IHN0YXJ0PTdkMjg4ZjdmOTAwMCBl bmQ9N2QyODhmODRkMDAwIGVuZC1zdGFydD01NDAwMCBzaXplPTUzNDAwCj4gCj4gbWVhbmluZyB0 aGUgc2l6ZSBmaWVsZCBwYXNzZWQgaW4gdGhlIGlvY3RsIGlzIHNtYWxsZXIgdGhhbiB0aGUgdG90 YWwgbGVuZ3RoCj4gb2YgdGhlIGFyZWEuCj4gCj4gUXVlc3Rpb24gaXMgbm93OiBJcyB0aGUgcmVx dWVzdC9pb2N0bCBpbmRlZWQgaW52YWxpZCwgaWUgZG9lcyB0aGUgcmVxdWVzdGVkCj4gc2l6ZSBo YXZlIHRvIG1hdGNoIHRoZSB2bWEgc2l6ZSA/IFRoaXMgdXNlZCB0byB3b3JrIHVudGlsIHRoaXMg cGF0Y2ggd2FzCj4gYXBwbGllZCwgYW5kIHRoZSBjaGFuZ2UgY2F1c2VzIG91ciB0ZXN0IGNvZGUg dG8gZmFpbCAoYW5kIHBvc3NpYmx5IG1pbmlnYm0sCj4gd2hpY2ggaXMgdXNlZCBieSB0aGUgdGVz dCBjb2RlKS4gVGhhdCBkb2Vzbid0IG1lYW4gdGhhdCBvdXIgY29kZSBpcyBjb3JyZWN0Cj4gKEkg c2VlIHNvbWUgcmVsYXRlZCBsb2NhbCBjaGFuZ2VzIGluIG91ciB2ZXJzaW9uIG9mIG1pbmlnYm0p LCBidXQgaXQgaXMKPiBhbm5veWluZywgYW5kIEkgYW0gYmVpbmcgYXNrZWQgdG8gcmV2ZXJ0IHRo aXMgcGF0Y2ggYXMgcmVncmVzc2lvbgo+IGZyb20gb3VyIGtlcm5lbCByZWxlYXNlcy4KPiAKCklu IGk5MTVfZ2VtX2NyZWF0ZSgpOgoKCXNpemUgPSByb3VuZHVwKHNpemUsIFBBR0VfU0laRSk7Cglp ZiAoc2l6ZSA9PSAwKQoJCXJldHVybiAtRUlOVkFMOwoKVGhpcyBzdWdnZXN0cyB0byBtZSB0aGF0 IHRoZSByZXF1ZXN0ZWQgc2l6ZSBjYW4gYmUgc21hbGxlciB0aGFuIHRoZQphbGxvY2F0ZWQgc2l6 ZSwgd2hpY2ggaW4gdHVybiBzdWdnZXN0cyB0aGF0IHRoZSBjaGVjawoJKHZtYS0+dm1fZW5kIC0g dm1hLT52bV9zdGFydCkgPT0gc2l6ZTsKaXMgd3JvbmcuIEVpdGhlciBpdCBzaG91bGQgYmUKCSh2 bWEtPnZtX2VuZCAtIHZtYS0+dm1fc3RhcnQpID49IHNpemU7Cm9yIHBvc3NpYmx5Cgkodm1hLT52 bV9lbmQgLSB2bWEtPnZtX3N0YXJ0KSA9PSByb3VuZHVwKHNpemUsIFBBR0VfU0laRSk7CgpBbnkg Y29tbWVudHMvZmVlZGJhY2svdGhvdWdodHMgPwoKVGhhbmtzLApHdWVudGVyCgo+IFRoYW5rcywK PiBHdWVudGVyCj4gCj4gPiA+ICt9Cj4gPiA+ICsKPiA+ID4gIC8qKgo+ID4gPiAgICogaTkxNV9n ZW1fbW1hcF9pb2N0bCAtIE1hcHMgdGhlIGNvbnRlbnRzIG9mIGFuIG9iamVjdCwgcmV0dXJuaW5n IHRoZSBhZGRyZXNzCj4gPiA+ICAgKgkJCSBpdCBpcyBtYXBwZWQgdG8uCj4gPiA+IEBAIC0xNzM5 LDcgKzE3NDksNyBAQCBpOTE1X2dlbV9tbWFwX2lvY3RsKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYs IHZvaWQgKmRhdGEsCj4gPiA+ICAJCQlyZXR1cm4gLUVJTlRSOwo+ID4gPiAgCQl9Cj4gPiA+ICAJ CXZtYSA9IGZpbmRfdm1hKG1tLCBhZGRyKTsKPiA+ID4gLQkJaWYgKHZtYSkKPiA+ID4gKwkJaWYg KHZtYSAmJiBfX3ZtYV9tYXRjaGVzKHZtYSwgb2JqLT5iYXNlLmZpbHAsIGFkZHIsIGFyZ3MtPnNp emUpKQo+ID4gPiAgCQkJdm1hLT52bV9wYWdlX3Byb3QgPQo+ID4gPiAgCQkJCXBncHJvdF93cml0 ZWNvbWJpbmUodm1fZ2V0X3BhZ2VfcHJvdCh2bWEtPnZtX2ZsYWdzKSk7Cj4gPiA+ICAJCWVsc2UK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4