From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [CI, v3, 1/2] drm/i915: Prevent a race during I915_GEM_MMAP ioctl with WC set Date: Thu, 28 Feb 2019 14:11:51 -0800 Message-ID: <20190228221151.GA17424@roeck-us.net> References: <20190207085454.10598-1-joonas.lahtinen@linux.intel.com> <20190228191249.GA10430@roeck-us.net> <20190228213241.GA15462@roeck-us.net> <20190228215703.GA16857@roeck-us.net> <155139130531.5847.10912664209750394419@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1C86389F0B for ; Thu, 28 Feb 2019 22:11:54 +0000 (UTC) Received: by mail-pf1-x441.google.com with SMTP id a3so10363588pff.11 for ; Thu, 28 Feb 2019 14:11:54 -0800 (PST) Content-Disposition: inline In-Reply-To: <155139130531.5847.10912664209750394419@skylake-alporthouse-com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: Intel graphics driver community testing & development List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBGZWIgMjgsIDIwMTkgYXQgMTA6MDE6NDVQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFF1b3RpbmcgR3VlbnRlciBSb2VjayAoMjAxOS0wMi0yOCAyMTo1NzowMykKPiA+IE9u IFRodSwgRmViIDI4LCAyMDE5IGF0IDAxOjMyOjQxUE0gLTA4MDAsIEd1ZW50ZXIgUm9lY2sgd3Jv dGU6Cj4gPiA+IE9uIFRodSwgRmViIDI4LCAyMDE5IGF0IDExOjEyOjQ5QU0gLTA4MDAsIEd1ZW50 ZXIgUm9lY2sgd3JvdGU6Cj4gPiA+ID4gSGksCj4gPiA+ID4gCj4gPiA+ID4gT24gVGh1LCBGZWIg MDcsIDIwMTkgYXQgMTA6NTQ6NTNBTSArMDIwMCwgSm9vbmFzIExhaHRpbmVuIHdyb3RlOgo+ID4g PiA+ID4gTWFrZSBzdXJlIHRoZSB1bmRlcmx5aW5nIFZNQSBpbiB0aGUgcHJvY2VzcyBhZGRyZXNz IHNwYWNlIGlzIHRoZQo+ID4gPiA+ID4gc2FtZSBhcyBpdCB3YXMgZHVyaW5nIHZtX21tYXAgdG8g YXZvaWQgYXBwbHlpbmcgV0MgdG8gd3JvbmcgVk1BLgo+ID4gPiA+ID4gCj4gPiA+ID4gPiBBIG1v cmUgbG9uZy10ZXJtIHNvbHV0aW9uIHdvdWxkIGJlIHRvIGhhdmUgdm1fbW1hcF9sb2NrZWQgdmFy aWFudAo+ID4gPiA+ID4gaW4gbGludXgvbW1hcC5oIGZvciB3aGVuIGNhbGxlciB3YW50cyB0byBo b2xkIG1tYXBfc2VtIGZvciBhbgo+ID4gPiA+ID4gZXh0ZW5kZWQgZHVyYXRpb24uCj4gPiA+ID4g PiAKPiA+ID4gPiAKPiA+ID4gPiBJdCBzZWVtcyBsaWtlIHdlIG1heSBoYXZlIGEgcmVncmVzc2lv biBkdWUgdG8gdGhpcyBwYXRjaC4gSSBhbSBzdGlsbAo+ID4gPiA+IGRlYnVnZ2luZywgYnV0IEkg aGF2ZSBhIHF1ZXN0aW9uOyBwbGVhc2Ugc2VlIGJlbG93Lgo+ID4gPiA+IAo+ID4gPiA+IFRoYW5r cywKPiA+ID4gPiBHdWVudGVyCj4gPiA+ID4gCj4gPiA+ID4gPiB2MjoKPiA+ID4gPiA+IC0gUmVm YWN0b3IgdGhlIGNvbXBhcmUgZnVuY3Rpb24KPiA+ID4gPiA+IAo+ID4gPiA+ID4gRml4ZXM6IDE4 MTZmOTIzNjMwMyAoImRybS9pOTE1OiBTdXBwb3J0IGNyZWF0aW9uIG9mIHVuYm91bmQgd2MgdXNl ciBtYXBwaW5ncyBmb3Igb2JqZWN0cyIpCj4gPiA+ID4gPiBSZXBvcnRlZC1ieTogQWRhbSBaYWJy b2NraSA8YWRhbXphQG1pY3Jvc29mdC5jb20+Cj4gPiA+ID4gPiBTdWdnZXN0ZWQtYnk6IExpbnVz IFRvcnZhbGRzIDx0b3J2YWxkc0BsaW51eC1mb3VuZGF0aW9uLm9yZz4KPiA+ID4gPiA+IFNpZ25l ZC1vZmYtYnk6IEpvb25hcyBMYWh0aW5lbiA8am9vbmFzLmxhaHRpbmVuQGxpbnV4LmludGVsLmNv bT4KPiA+ID4gPiA+IENjOiA8c3RhYmxlQHZnZXIua2VybmVsLm9yZz4gIyB2NC4wKwo+ID4gPiA+ ID4gQ2M6IEFrYXNoIEdvZWwgPGFrYXNoLmdvZWxAaW50ZWwuY29tPgo+ID4gPiA+ID4gQ2M6IENo cmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+ID4gPiA+ID4gQ2M6IFR2cnRr byBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBsaW51eC5pbnRlbC5jb20+Cj4gPiA+ID4gPiBDYzog QWRhbSBaYWJyb2NraSA8YWRhbXphQG1pY3Jvc29mdC5jb20+Cj4gPiA+ID4gPiBSZXZpZXdlZC1i eTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gPiA+ID4gPiBSZXZp ZXdlZC1ieTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4gI3YxCj4g PiA+ID4gPiAtLS0KPiA+ID4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jIHwg MTIgKysrKysrKysrKystCj4gPiA+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDExIGluc2VydGlvbnMo KyksIDEgZGVsZXRpb24oLSkKPiA+ID4gPiA+IAo+ID4gPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dl bS5jCj4gPiA+ID4gPiBpbmRleCAwNWNlOTE3NmFjNGUuLjUyNjM5Zjc0OTkwOCAxMDA2NDQKPiA+ ID4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiA+ID4gPiA+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiA+ID4gPiA+IEBAIC0xNjgxLDYg KzE2ODEsMTYgQEAgaTkxNV9nZW1fc3dfZmluaXNoX2lvY3RsKHN0cnVjdCBkcm1fZGV2aWNlICpk ZXYsIHZvaWQgKmRhdGEsCj4gPiA+ID4gPiAgIHJldHVybiAwOwo+ID4gPiA+ID4gIH0KPiA+ID4g PiA+ICAKPiA+ID4gPiA+ICtzdGF0aWMgaW5saW5lIGJvb2wKPiA+ID4gPiA+ICtfX3ZtYV9tYXRj aGVzKHN0cnVjdCB2bV9hcmVhX3N0cnVjdCAqdm1hLCBzdHJ1Y3QgZmlsZSAqZmlscCwKPiA+ID4g PiA+ICsgICAgICAgdW5zaWduZWQgbG9uZyBhZGRyLCB1bnNpZ25lZCBsb25nIHNpemUpCj4gPiA+ ID4gPiArewo+ID4gPiA+ID4gKyBpZiAodm1hLT52bV9maWxlICE9IGZpbHApCj4gPiA+ID4gPiAr ICAgICAgICAgcmV0dXJuIGZhbHNlOwo+ID4gPiA+ID4gKwo+ID4gPiA+ID4gKyByZXR1cm4gdm1h LT52bV9zdGFydCA9PSBhZGRyICYmICh2bWEtPnZtX2VuZCAtIHZtYS0+dm1fc3RhcnQpID09IHNp emU7Cj4gPiA+ID4gCj4gPiA+ID4gU2hvdWxkbid0IHRoaXMgYmU6Cj4gPiA+ID4gICAgIHJldHVy biB2bWEtPnZtX3N0YXJ0ID09IGFkZHIgJiYgKHZtYS0+dm1fZW5kIC0gdm1hLT52bV9zdGFydCAr IDEpID09IHNpemU7Cj4gPiA+ID4gaW5zdGVhZCA/Cj4gPiA+ID4gCj4gPiA+IAo+ID4gPiBBbnN3 ZXIgaXMgbm8gLi4gYmVjYXVzZSB2bV9lbmQgcG9pbnRzIHRvIHRoZSBmaXJzdCBieXRlIGFmdGVy IHRoZQo+ID4gPiBlbmQgYWRkcmVzcy4KPiA+ID4gCj4gPiA+IFRoZSBhY3R1YWwgdmFsdWVzIGFy ZToKPiA+ID4gCj4gPiA+IHN0YXJ0PTdkMjg4ZjdmOTAwMCBlbmQ9N2QyODhmODRkMDAwIGVuZC1z dGFydD01NDAwMCBzaXplPTUzNDAwCj4gPiA+IAo+ID4gPiBtZWFuaW5nIHRoZSBzaXplIGZpZWxk IHBhc3NlZCBpbiB0aGUgaW9jdGwgaXMgc21hbGxlciB0aGFuIHRoZSB0b3RhbCBsZW5ndGgKPiA+ ID4gb2YgdGhlIGFyZWEuCj4gPiA+IAo+ID4gPiBRdWVzdGlvbiBpcyBub3c6IElzIHRoZSByZXF1 ZXN0L2lvY3RsIGluZGVlZCBpbnZhbGlkLCBpZSBkb2VzIHRoZSByZXF1ZXN0ZWQKPiA+ID4gc2l6 ZSBoYXZlIHRvIG1hdGNoIHRoZSB2bWEgc2l6ZSA/IFRoaXMgdXNlZCB0byB3b3JrIHVudGlsIHRo aXMgcGF0Y2ggd2FzCj4gPiA+IGFwcGxpZWQsIGFuZCB0aGUgY2hhbmdlIGNhdXNlcyBvdXIgdGVz dCBjb2RlIHRvIGZhaWwgKGFuZCBwb3NzaWJseSBtaW5pZ2JtLAo+ID4gPiB3aGljaCBpcyB1c2Vk IGJ5IHRoZSB0ZXN0IGNvZGUpLiBUaGF0IGRvZXNuJ3QgbWVhbiB0aGF0IG91ciBjb2RlIGlzIGNv cnJlY3QKPiA+ID4gKEkgc2VlIHNvbWUgcmVsYXRlZCBsb2NhbCBjaGFuZ2VzIGluIG91ciB2ZXJz aW9uIG9mIG1pbmlnYm0pLCBidXQgaXQgaXMKPiA+ID4gYW5ub3lpbmcsIGFuZCBJIGFtIGJlaW5n IGFza2VkIHRvIHJldmVydCB0aGlzIHBhdGNoIGFzIHJlZ3Jlc3Npb24KPiA+ID4gZnJvbSBvdXIg a2VybmVsIHJlbGVhc2VzLgo+ID4gPiAKPiA+IAo+ID4gSW4gaTkxNV9nZW1fY3JlYXRlKCk6Cj4g PiAKPiA+ICAgICAgICAgc2l6ZSA9IHJvdW5kdXAoc2l6ZSwgUEFHRV9TSVpFKTsKPiA+ICAgICAg ICAgaWYgKHNpemUgPT0gMCkKPiA+ICAgICAgICAgICAgICAgICByZXR1cm4gLUVJTlZBTDsKPiA+ IAo+ID4gVGhpcyBzdWdnZXN0cyB0byBtZSB0aGF0IHRoZSByZXF1ZXN0ZWQgc2l6ZSBjYW4gYmUg c21hbGxlciB0aGFuIHRoZQo+IAo+IE5vdCByZWFsbHksIHRoZSBBQkkgaGFzIG5ldmVyIGhhbmRs ZWQgbGVzcyB0aGFuIHBhZ2Utc2l6ZWQgcmVxdWVzdHMuCj4gSXQncyBhIG1pc3Rha2UgZnJvbSB0 aGUgdmVyeSBiZWdpbm5pbmcgdGhhdCBpdCB3YXMgbm90IHJlamVjdGVkIGFzIGJlaW5nCj4gdGhl IGludmFsaWQgc2l6ZSBpdCB3YXMuCj4gCj4gPiBhbGxvY2F0ZWQgc2l6ZSwgd2hpY2ggaW4gdHVy biBzdWdnZXN0cyB0aGF0IHRoZSBjaGVjawo+ID4gICAgICAgICAodm1hLT52bV9lbmQgLSB2bWEt PnZtX3N0YXJ0KSA9PSBzaXplOwo+ID4gaXMgd3JvbmcuIEVpdGhlciBpdCBzaG91bGQgYmUKPiA+ ICAgICAgICAgKHZtYS0+dm1fZW5kIC0gdm1hLT52bV9zdGFydCkgPj0gc2l6ZTsKPiA+IG9yIHBv c3NpYmx5Cj4gPiAgICAgICAgICh2bWEtPnZtX2VuZCAtIHZtYS0+dm1fc3RhcnQpID09IHJvdW5k dXAoc2l6ZSwgUEFHRV9TSVpFKTsKPiA+IAo+ID4gQW55IGNvbW1lbnRzL2ZlZWRiYWNrL3Rob3Vn aHRzID8KPiAKPiBJdCdzIGEgdmlvbGF0aW9uIG9mIG1tYXAoMikuCj4gCj4gSXMgcHJvYmFibHkg d2hhdCB3ZSB3aWxsIGhhdmUgdG8gZG8gaWYgeW91IHJpbmcgdGhlIHJlZ3Jlc3Npb24gYmVsbCBs b3VkCj4gZW5vdWdoLCBhbmQgZG8gbm90IHNlZSB0aGUgZm9sbHkgb2YgeW91ciB3YXlzLiA6LXAK Ckkgd29uJ3QgcmluZyBhbnkgYmVsbHM7IEkgZG9uJ3QgcGxheSBzdWNoIGdhbWVzLiBJJ2xsIG1h a2UgYSBsb2NhbCBjaGFuZ2UKaW4gb3VyIGtlcm5lbCB0byBmaXggdGhlIHByb2JsZW0sIHF1b3Rp bmcgeW91ciBzdGF0ZW1lbnQgdGhhdCBsZXNzIHRoYW4KcGFnZS1zaXplZCByZXF1ZXN0cyB3ZXJl IG5ldmVyIHN1cHBvc2VkIHRvIGJlIHN1cHBvcnRlZCwgYW5kIGFkZCBhIG5vdGUKdGhhdCB3ZSds bCBoYXZlIHRvIGhhbmRsZSB0aGlzIHdpdGggYSBsb2NhbCBwYXRjaCBnb2luZyBmb3J3YXJkLgoK R3VlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=