From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 02/12] drm/i915: Extract functions to derive
 SKL+ DIMM info
Date: Mon, 4 Mar 2019 18:44:15 +0200
Message-ID: <20190304164415.GA20097@intel.com>
References: <20190225202907.731-1-ville.syrjala@linux.intel.com>
 <20190225202907.731-3-ville.syrjala@linux.intel.com>
 <87a7iamwh2.fsf@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by gabe.freedesktop.org (Postfix) with ESMTPS id AABB789B9E
 for <intel-gfx@lists.freedesktop.org>; Mon,  4 Mar 2019 16:44:18 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <87a7iamwh2.fsf@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gTW9uLCBNYXIgMDQsIDIwMTkgYXQgMDY6MzI6MjVQTSArMDIwMCwgSmFuaSBOaWt1bGEgd3Jv
dGU6Cj4gT24gTW9uLCAyNSBGZWIgMjAxOSwgVmlsbGUgU3lyamFsYSA8dmlsbGUuc3lyamFsYUBs
aW51eC5pbnRlbC5jb20+IHdyb3RlOgo+ID4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5z
eXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+Cj4gPiBNYWtlIHRoZSBjb2RlIGxlc3MgcmVwZXRp
dGl2ZSBieSBleHRyYWN0aW5nIGEgZmV3IHNtYWxsIGhlbHBlcnMuCj4gPgo+ID4gU2lnbmVkLW9m
Zi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+
IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMgfCA2OCArKysrKysrKysr
KysrKysrKysrKystLS0tLS0tLS0tLS0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgNDMgaW5zZXJ0aW9u
cygrKSwgMjUgZGVsZXRpb25zKC0pCj4gPgo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry
bS9pOTE1L2k5MTVfZHJ2LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jCj4gPiBp
bmRleCA0OGM2YmM0NDA3MmQuLmI5NGJmNDc1YjA0YyAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMv
Z3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5
MTVfZHJ2LmMKPiA+IEBAIC0xMDY4LDE2ICsxMDY4LDQyIEBAIHN0YXRpYyB2b2lkIGludGVsX3Nh
bml0aXplX29wdGlvbnMoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ID4gIAlp
bnRlbF9ndnRfc2FuaXRpemVfb3B0aW9ucyhkZXZfcHJpdik7Cj4gPiAgfQo+ID4gIAo+ID4gLXN0
YXRpYyBpbnQgc2tsX2dldF9kaW1tX3JhbmtzKHU4IHNpemUsIHUzMiByYW5rKQo+ID4gK3N0YXRp
YyBpbnQgc2tsX2dldF9kaW1tX3NpemUodTE2IHZhbCkKPiA+ICB7Cj4gPiAtCWlmIChzaXplID09
IDApCj4gPiArCXJldHVybiB2YWwgJiBTS0xfRFJBTV9TSVpFX01BU0s7Cj4gPiArfQo+ID4gKwo+
ID4gK3N0YXRpYyBpbnQgc2tsX2dldF9kaW1tX3dpZHRoKHUxNiB2YWwpCj4gPiArewo+ID4gKwlp
ZiAoc2tsX2dldF9kaW1tX3NpemUodmFsKSA9PSAwKQo+ID4gIAkJcmV0dXJuIDA7Cj4gPiAtCWlm
IChyYW5rID09IFNLTF9EUkFNX1JBTktfU0lOR0xFKQo+ID4gLQkJcmV0dXJuIDE7Cj4gPiAtCWVs
c2UgaWYgKHJhbmsgPT0gU0tMX0RSQU1fUkFOS19EVUFMKQo+ID4gLQkJcmV0dXJuIDI7Cj4gPiAg
Cj4gPiAtCXJldHVybiAwOwo+ID4gKwlzd2l0Y2ggKHZhbCAmIFNLTF9EUkFNX1dJRFRIX01BU0sp
IHsKPiA+ICsJY2FzZSBTS0xfRFJBTV9XSURUSF9YODoKPiA+ICsJY2FzZSBTS0xfRFJBTV9XSURU
SF9YMTY6Cj4gPiArCWNhc2UgU0tMX0RSQU1fV0lEVEhfWDMyOgo+ID4gKwkJdmFsID0gKHZhbCAm
IFNLTF9EUkFNX1dJRFRIX01BU0spID4+IFNLTF9EUkFNX1dJRFRIX1NISUZUOwo+ID4gKwkJcmV0
dXJuIDggPDwgdmFsOwo+ID4gKwlkZWZhdWx0Ogo+ID4gKwkJTUlTU0lOR19DQVNFKHZhbCk7Cj4g
PiArCQlyZXR1cm4gMDsKPiA+ICsJfQo+ID4gK30KPiA+ICsKPiA+ICtzdGF0aWMgaW50IHNrbF9n
ZXRfZGltbV9yYW5rcyh1MTYgdmFsKQo+ID4gK3sKPiA+ICsJaWYgKHNrbF9nZXRfZGltbV9zaXpl
KHZhbCkgPT0gMCkKPiA+ICsJCXJldHVybiAwOwo+ID4gKwo+ID4gKwlzd2l0Y2ggKHZhbCAmIFNL
TF9EUkFNX1JBTktfTUFTSykgewo+ID4gKwljYXNlIFNLTF9EUkFNX1JBTktfU0lOR0xFOgo+ID4g
KwljYXNlIFNLTF9EUkFNX1JBTktfRFVBTDoKPiA+ICsJCXZhbCA9ICh2YWwgJiBTS0xfRFJBTV9S
QU5LX01BU0spID4+IFNLTF9EUkFNX1JBTktfU0hJRlQ7Cj4gPiArCQlyZXR1cm4gdmFsICsgMTsK
PiA+ICsJZGVmYXVsdDoKPiA+ICsJCU1JU1NJTkdfQ0FTRSh2YWwpOwo+ID4gKwkJcmV0dXJuIDA7
Cj4gPiArCX0KPiAKPiBJIGRvbid0IG11Y2ggY2FyZSBmb3IgdGhpcyBkdWFsIHVzZSBvZiBib3Ro
IHRoZSBtYWNybyBhbmQgdGhlbiB0aGUKPiBjYWxjdWxhdGlvbi4gSSdkIGVpdGhlciBqdXN0IGNh
bGN1bGF0ZSwgb3IgcmV0dXJuIHByZS1jYWxjdWxhdGVkIHZhbHVlcwo+IGZyb20gdGhlIGNhc2Vz
LCBub3QgYm90aC4gVGhlIG1pc3NpbmcgY2FzZXMgY2FuIGFsc28gbmV2ZXIgaGFwcGVuLgoKSSBn
ZW5lcmFsbHkgbGVhbiB0b3dhcmQgdGhlIGFyaXRobWV0aWMgb3B0aW9uIG15c2VsZiwgYW5kIEkg
ZGlkCmNvbnNpZGVyIGl0IGhlcmUgYXMgd2VsbC4gSSBzdXBwb3NlIEkgZW5kZWQgdXAgYmVpbmcg
c3dheWVkCnNsaWdodGx5IHRvd2FyZHMgdGhlIG90aGVyIGVuZCBvZiB0aGUgc3BlY3RydW0gYnkg
dGhlIHBvdGVudGlhbApkb2N1bWVudGF0aW9uIHZhbHVlIG9mIHRoZSBjYXNlIGxhYmVscy4gQW5k
IHNvIEkgZW5kZWQgdXAKc29tZXdoZXJlIGluIHRoZSBtaWRkbGUuCgo+IAo+IEJ1dCBpdCBhbGwg
Y2hlY2tzIG91dCwgc28KPiAKPiBSZXZpZXdlZC1ieTogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxh
QGludGVsLmNvbT4KPiAKPiAKPiA+ICB9Cj4gPiAgCj4gPiAgc3RhdGljIGJvb2wKPiA+IEBAIC0x
MDk4LDMwICsxMTI0LDIyIEBAIHNrbF9pc18xNmdiX2RpbW0odTggcmFua3MsIHU4IHNpemUsIHU4
IHdpZHRoKQo+ID4gIHN0YXRpYyBpbnQKPiA+ICBza2xfZHJhbV9nZXRfY2hhbm5lbF9pbmZvKHN0
cnVjdCBkcmFtX2NoYW5uZWxfaW5mbyAqY2gsIHUzMiB2YWwpCj4gPiAgewo+ID4gLQl1MzIgdG1w
X2wsIHRtcF9zOwo+ID4gLQl1MzIgc192YWwgPSB2YWwgPj4gU0tMX0RSQU1fU19TSElGVDsKPiA+
ICsJdTE2IHRtcF9sLCB0bXBfczsKPiA+ICAKPiA+IC0JaWYgKCF2YWwpCj4gPiAtCQlyZXR1cm4g
LUVJTlZBTDsKPiA+ICsJdG1wX2wgPSB2YWwgJiAweGZmZmY7Cj4gPiArCXRtcF9zID0gdmFsID4+
IDE2Owo+ID4gIAo+ID4gLQl0bXBfbCA9IHZhbCAmIFNLTF9EUkFNX1NJWkVfTUFTSzsKPiA+IC0J
dG1wX3MgPSBzX3ZhbCAmIFNLTF9EUkFNX1NJWkVfTUFTSzsKPiA+ICsJY2gtPmxfaW5mby5zaXpl
ID0gc2tsX2dldF9kaW1tX3NpemUodG1wX2wpOwo+ID4gKwljaC0+c19pbmZvLnNpemUgPSBza2xf
Z2V0X2RpbW1fc2l6ZSh0bXBfcyk7Cj4gPiAgCj4gPiAtCWlmICh0bXBfbCA9PSAwICYmIHRtcF9z
ID09IDApCj4gPiArCWlmIChjaC0+bF9pbmZvLnNpemUgPT0gMCAmJiBjaC0+c19pbmZvLnNpemUg
PT0gMCkKPiA+ICAJCXJldHVybiAtRUlOVkFMOwo+ID4gIAo+ID4gLQljaC0+bF9pbmZvLnNpemUg
PSB0bXBfbDsKPiA+IC0JY2gtPnNfaW5mby5zaXplID0gdG1wX3M7Cj4gPiAtCj4gPiAtCXRtcF9s
ID0gKHZhbCAmIFNLTF9EUkFNX1dJRFRIX01BU0spID4+IFNLTF9EUkFNX1dJRFRIX1NISUZUOwo+
ID4gLQl0bXBfcyA9IChzX3ZhbCAmIFNLTF9EUkFNX1dJRFRIX01BU0spID4+IFNLTF9EUkFNX1dJ
RFRIX1NISUZUOwo+ID4gLQljaC0+bF9pbmZvLndpZHRoID0gKDEgPDwgdG1wX2wpICogODsKPiA+
IC0JY2gtPnNfaW5mby53aWR0aCA9ICgxIDw8IHRtcF9zKSAqIDg7Cj4gPiArCWNoLT5sX2luZm8u
d2lkdGggPSBza2xfZ2V0X2RpbW1fd2lkdGgodG1wX2wpOwo+ID4gKwljaC0+c19pbmZvLndpZHRo
ID0gc2tsX2dldF9kaW1tX3dpZHRoKHRtcF9zKTsKPiA+ICAKPiA+IC0JdG1wX2wgPSB2YWwgJiBT
S0xfRFJBTV9SQU5LX01BU0s7Cj4gPiAtCXRtcF9zID0gc192YWwgJiBTS0xfRFJBTV9SQU5LX01B
U0s7Cj4gPiAtCWNoLT5sX2luZm8ucmFua3MgPSBza2xfZ2V0X2RpbW1fcmFua3MoY2gtPmxfaW5m
by5zaXplLCB0bXBfbCk7Cj4gPiAtCWNoLT5zX2luZm8ucmFua3MgPSBza2xfZ2V0X2RpbW1fcmFu
a3MoY2gtPnNfaW5mby5zaXplLCB0bXBfcyk7Cj4gPiArCWNoLT5sX2luZm8ucmFua3MgPSBza2xf
Z2V0X2RpbW1fcmFua3ModG1wX2wpOwo+ID4gKwljaC0+c19pbmZvLnJhbmtzID0gc2tsX2dldF9k
aW1tX3JhbmtzKHRtcF9zKTsKPiA+ICAKPiA+ICAJaWYgKGNoLT5sX2luZm8ucmFua3MgPT0gMiB8
fCBjaC0+c19pbmZvLnJhbmtzID09IDIpCj4gPiAgCQljaC0+cmFua3MgPSAyOwo+IAo+IC0tIAo+
IEphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBHcmFwaGljcyBDZW50ZXIKCi0tIApWaWxs
ZSBTeXJqw6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0
b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50
ZWwtZ2Z4