From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH 5/5] drm/i915/gtt: Refactor common ppgtt
 initialisation
Date: Thu, 14 Mar 2019 15:53:44 -0700
Message-ID: <20190314225344.GB11873@intel.com>
References: <20190314223839.28258-1-chris@chris-wilson.co.uk>
 <20190314223839.28258-5-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 3036D895E1
 for <intel-gfx@lists.freedesktop.org>; Thu, 14 Mar 2019 22:53:30 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20190314223839.28258-5-chris@chris-wilson.co.uk>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVGh1LCBNYXIgMTQsIDIwMTkgYXQgMTA6Mzg6MzlQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy
b3RlOgo+IFRoZSBiYXNpYyBzZXR1cCBvZiB0aGUgaTkxNV9od19wcGd0dCBpcyB0aGUgc2FtZSBi
ZXR3ZWVuIGdlbjYgYW5kIGdlbjgsCj4gc28gcmVmYWN0b3IgdGhhdCBpbnRvIGEgY29tbW9uIHJv
dXRpbmUuCj4gCj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxz
b24uY28udWs+Cj4gQ2M6IEJvYiBQYWF1d2UgPGJvYi5qLnBhYXV3ZUBpbnRlbC5jb20+Cj4gQ2M6
IE1hdHRoZXcgQXVsZCA8bWF0dGhldy53aWxsaWFtLmF1bGRAZ21haWwuY29tPgo+IENjOiBKb29u
YXMgTGFodGluZW4gPGpvb25hcy5sYWh0aW5lbkBsaW51eC5pbnRlbC5jb20+CgpSZXZpZXdlZC1i
eTogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgoKPiAtLS0KPiAgZHJpdmVy
cy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmMgfCA0MyArKysrKysrKysrKysrLS0tLS0tLS0t
LS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMTkgaW5zZXJ0aW9ucygrKSwgMjQgZGVsZXRpb25z
KC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5j
IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmMKPiBpbmRleCA4MzM2MmM4YWMx
MTAuLmI4MDU1YzhkNGU3MSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1
X2dlbV9ndHQuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5jCj4g
QEAgLTE1MTMsNiArMTUxMywyMyBAQCBzdGF0aWMgaW50IGdlbjhfcHJlYWxsb2NhdGVfdG9wX2xl
dmVsX3BkcChzdHJ1Y3QgaTkxNV9od19wcGd0dCAqcHBndHQpCj4gIAlyZXR1cm4gLUVOT01FTTsK
PiAgfQo+ICAKPiArc3RhdGljIHZvaWQgcHBndHRfaW5pdChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0
ZSAqaTkxNSwKPiArCQkgICAgICAgc3RydWN0IGk5MTVfaHdfcHBndHQgKnBwZ3R0KQo+ICt7Cj4g
KwlrcmVmX2luaXQoJnBwZ3R0LT5yZWYpOwo+ICsKPiArCXBwZ3R0LT52bS5pOTE1ID0gaTkxNTsK
PiArCXBwZ3R0LT52bS5kbWEgPSAmaTkxNS0+ZHJtLnBkZXYtPmRldjsKPiArCXBwZ3R0LT52bS50
b3RhbCA9IEJJVF9VTEwoSU5URUxfSU5GTyhpOTE1KS0+cHBndHRfc2l6ZSk7Cj4gKwo+ICsJaTkx
NV9hZGRyZXNzX3NwYWNlX2luaXQoJnBwZ3R0LT52bSwgVk1fQ0xBU1NfUFBHVFQpOwo+ICsKPiAr
CXBwZ3R0LT52bS52bWFfb3BzLmJpbmRfdm1hICAgID0gcHBndHRfYmluZF92bWE7Cj4gKwlwcGd0
dC0+dm0udm1hX29wcy51bmJpbmRfdm1hICA9IHBwZ3R0X3VuYmluZF92bWE7Cj4gKwlwcGd0dC0+
dm0udm1hX29wcy5zZXRfcGFnZXMgICA9IHBwZ3R0X3NldF9wYWdlczsKPiArCXBwZ3R0LT52bS52
bWFfb3BzLmNsZWFyX3BhZ2VzID0gY2xlYXJfcGFnZXM7Cj4gK30KPiArCj4gIC8qCj4gICAqIEdF
TjggbGVnYWN5IHBwZ3R0IHByb2dyYW1taW5nIGlzIGFjY29tcGxpc2hlZCB0aHJvdWdoIGEgbWF4
IDQgUERQIHJlZ2lzdGVycwo+ICAgKiB3aXRoIGEgbmV0IGVmZmVjdCByZXNlbWJsaW5nIGEgMi1s
ZXZlbCBwYWdlIHRhYmxlIGluIG5vcm1hbCB4ODYgdGVybXMuIEVhY2gKPiBAQCAtMTUyOSwxNyAr
MTU0NiwxMSBAQCBzdGF0aWMgc3RydWN0IGk5MTVfaHdfcHBndHQgKmdlbjhfcHBndHRfY3JlYXRl
KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1KQo+ICAJaWYgKCFwcGd0dCkKPiAgCQlyZXR1
cm4gRVJSX1BUUigtRU5PTUVNKTsKPiAgCj4gLQlrcmVmX2luaXQoJnBwZ3R0LT5yZWYpOwo+IC0K
PiAtCXBwZ3R0LT52bS5pOTE1ID0gaTkxNTsKPiAtCXBwZ3R0LT52bS5kbWEgPSAmaTkxNS0+ZHJt
LnBkZXYtPmRldjsKPiAtCXBwZ3R0LT52bS50b3RhbCA9IEJJVF9VTEwoSU5URUxfSU5GTyhpOTE1
KS0+cHBndHRfc2l6ZSk7Cj4gKwlwcGd0dF9pbml0KGk5MTUsIHBwZ3R0KTsKPiAgCj4gIAkvKiBG
cm9tIGJkdywgdGhlcmUgaXMgc3VwcG9ydCBmb3IgcmVhZC1vbmx5IHBhZ2VzIGluIHRoZSBQUEdU
VC4gKi8KPiAgCXBwZ3R0LT52bS5oYXNfcmVhZF9vbmx5ID0gdHJ1ZTsKPiAgCj4gLQlpOTE1X2Fk
ZHJlc3Nfc3BhY2VfaW5pdCgmcHBndHQtPnZtLCBWTV9DTEFTU19QUEdUVCk7Cj4gLQo+ICAJLyog
VGhlcmUgYXJlIG9ubHkgZmV3IGV4Y2VwdGlvbnMgZm9yIGdlbiA+PTYuIGNodiBhbmQgYnh0Lgo+
ICAJICogQW5kIHdlIGFyZSBub3Qgc3VyZSBhYm91dCB0aGUgbGF0dGVyIHNvIHBsYXkgc2FmZSBm
b3Igbm93Lgo+ICAJICovCj4gQEAgLTE1ODMsMTEgKzE1OTQsNiBAQCBzdGF0aWMgc3RydWN0IGk5
MTVfaHdfcHBndHQgKmdlbjhfcHBndHRfY3JlYXRlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpp
OTE1KQo+ICAKPiAgCXBwZ3R0LT52bS5jbGVhbnVwID0gZ2VuOF9wcGd0dF9jbGVhbnVwOwo+ICAK
PiAtCXBwZ3R0LT52bS52bWFfb3BzLmJpbmRfdm1hICAgID0gcHBndHRfYmluZF92bWE7Cj4gLQlw
cGd0dC0+dm0udm1hX29wcy51bmJpbmRfdm1hICA9IHBwZ3R0X3VuYmluZF92bWE7Cj4gLQlwcGd0
dC0+dm0udm1hX29wcy5zZXRfcGFnZXMgICA9IHBwZ3R0X3NldF9wYWdlczsKPiAtCXBwZ3R0LT52
bS52bWFfb3BzLmNsZWFyX3BhZ2VzID0gY2xlYXJfcGFnZXM7Cj4gLQo+ICAJcmV0dXJuIHBwZ3R0
Owo+ICAKPiAgZXJyX3NjcmF0Y2g6Cj4gQEAgLTE5NzksMjQgKzE5ODUsMTMgQEAgc3RhdGljIHN0
cnVjdCBpOTE1X2h3X3BwZ3R0ICpnZW42X3BwZ3R0X2NyZWF0ZShzdHJ1Y3QgZHJtX2k5MTVfcHJp
dmF0ZSAqaTkxNSkKPiAgCWlmICghcHBndHQpCj4gIAkJcmV0dXJuIEVSUl9QVFIoLUVOT01FTSk7
Cj4gIAo+IC0Ja3JlZl9pbml0KCZwcGd0dC0+YmFzZS5yZWYpOwo+IC0KPiAtCXBwZ3R0LT5iYXNl
LnZtLmk5MTUgPSBpOTE1Owo+IC0JcHBndHQtPmJhc2Uudm0uZG1hID0gJmk5MTUtPmRybS5wZGV2
LT5kZXY7Cj4gLQlwcGd0dC0+YmFzZS52bS50b3RhbCA9IEJJVF9VTEwoSU5URUxfSU5GTyhpOTE1
KS0+cHBndHRfc2l6ZSk7Cj4gLQo+IC0JaTkxNV9hZGRyZXNzX3NwYWNlX2luaXQoJnBwZ3R0LT5i
YXNlLnZtLCBWTV9DTEFTU19QUEdUVCk7Cj4gKwlwcGd0dF9pbml0KGk5MTUsICZwcGd0dC0+YmFz
ZSk7Cj4gIAo+ICAJcHBndHQtPmJhc2Uudm0uYWxsb2NhdGVfdmFfcmFuZ2UgPSBnZW42X2FsbG9j
X3ZhX3JhbmdlOwo+ICAJcHBndHQtPmJhc2Uudm0uY2xlYXJfcmFuZ2UgPSBnZW42X3BwZ3R0X2Ns
ZWFyX3JhbmdlOwo+ICAJcHBndHQtPmJhc2Uudm0uaW5zZXJ0X2VudHJpZXMgPSBnZW42X3BwZ3R0
X2luc2VydF9lbnRyaWVzOwo+ICAJcHBndHQtPmJhc2Uudm0uY2xlYW51cCA9IGdlbjZfcHBndHRf
Y2xlYW51cDsKPiAgCj4gLQlwcGd0dC0+YmFzZS52bS52bWFfb3BzLmJpbmRfdm1hICAgID0gcHBn
dHRfYmluZF92bWE7Cj4gLQlwcGd0dC0+YmFzZS52bS52bWFfb3BzLnVuYmluZF92bWEgID0gcHBn
dHRfdW5iaW5kX3ZtYTsKPiAtCXBwZ3R0LT5iYXNlLnZtLnZtYV9vcHMuc2V0X3BhZ2VzICAgPSBw
cGd0dF9zZXRfcGFnZXM7Cj4gLQlwcGd0dC0+YmFzZS52bS52bWFfb3BzLmNsZWFyX3BhZ2VzID0g
Y2xlYXJfcGFnZXM7Cj4gLQo+ICAJcHBndHQtPmJhc2Uudm0ucHRlX2VuY29kZSA9IGdndHQtPnZt
LnB0ZV9lbmNvZGU7Cj4gIAo+ICAJZXJyID0gZ2VuNl9wcGd0dF9pbml0X3NjcmF0Y2gocHBndHQp
Owo+IC0tIAo+IDIuMjAuMQo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5m
cmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp
c3RpbmZvL2ludGVsLWdmeApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv
cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRl
bC1nZng=