From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH 1/2] drm/i915: Add support for retrying hotplug Date: Sat, 16 Mar 2019 15:16:32 +0200 Message-ID: <20190316131632.GA29287@ideak-desk.fi.intel.com> References: <20190313005852.17119-1-jose.souza@intel.com> <20190314160935.GA9133@ideak-desk.fi.intel.com> <20190315013920.GF9133@ideak-desk.fi.intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 06B836E082 for ; Sat, 16 Mar 2019 13:16:39 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Souza, Jose" Cc: "Nikula, Jani" , "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org T24gU2F0LCBNYXIgMTYsIDIwMTkgYXQgMTI6MjI6MzBBTSArMDIwMCwgU291emEsIEpvc2Ugd3Jv dGU6Cj4gWy4uLl0KPiA+ID4gPiA+IEBAIC0zODksNiArNDEwLDE1IEBAIHN0YXRpYyB2b2lkIGk5 MTVfaG90cGx1Z193b3JrX2Z1bmMoc3RydWN0Cj4gPiA+ID4gPiB3b3JrX3N0cnVjdCAqd29yaykK PiA+ID4gPiA+ICAKPiA+ID4gPiA+ICAJaWYgKGNoYW5nZWQpCj4gPiA+ID4gPiAgCQlkcm1fa21z X2hlbHBlcl9ob3RwbHVnX2V2ZW50KGRldik7Cj4gPiA+ID4gCj4gPiA+ID4gSnVzdCByZWFsaXpl ZCwgdGhhdCB0aGlzIHdheSB3ZSdsbCBkbyBob3RwbHVnIHByb2Nlc3NpbmcgZm9yCj4gPiA+ID4g cGlucyB3aXRoIGEgc2hhcmVkIGVuY29kZXIgKERESSBEUC9IRE1JKSB0d2ljZSwgZXZlbiBpZiBv bmUKPiA+ID4gPiBlbmNvZGVyJ3MgaG90cGx1ZyBob29rIHNpZ25hbGVkIGEgY2hhbmdlIChhbmQg c28gdGhlcmUgY2FuJ3QgYmUKPiA+ID4gPiBhbnkgY2hhbmdlIG9uIG90aGVyIGNvbm5lY3RvcnMg c2hhcmluZyB0aGlzIGVuY29kZXIpLiBJIHN1cHBvc2UKPiA+ID4gPiBwcmV2ZW50aW5nIGNhbGxp bmcgdGhlIGhvb2sgZm9yIGEgcGluIHRoYXQgYWxyZWFkeSBzaWduYWxsZWQgYQo+ID4gPiA+IGNo YW5nZSB3b3VsZCBtYWtlIHNlbnNlLCBidXQgdGhhdCdzIGEgc2VwYXJhdGUgaXNzdWUgYW5kIGNv dWxkCj4gPiA+ID4gc3RpbGwgbGVhZCB0byByZXRyeWluZyBuZWVkbGVzc2x5LiBTbyBJIHRoaW5r IHdlIHNob3VsZCBwcmV2ZW50Cj4gPiA+ID4gdGhlIHJldHJ5IGhlcmUgZXhwbGljaXRseToKPiA+ ID4gPiAKPiA+ID4gPiAJcmV0cnkgJj0gfmNoYW5nZWQ7Cj4gPiA+IAo+ID4gPiBJIHdhcyBub3Qg YXdhcmUgb2YgdGhpcyBzaGFyZWQgaG90cGx1ZyBwaW4sIGJ1dCBpdCB3aWxsIG5lZWQgbW9yZQo+ ID4gPiB0aGFuIHRoYXQsIGlmIHRoZSBmaXJzdCBwb3J0IHNoYXJpbmcgYSBwaW4gaGF2ZSBjaGFu Z2VkIGJ1dCB0aGUKPiA+ID4gc2Vjb25kIGRvbid0IGl0IHdvdWxkIHN0aWxsIG1hcmsgdGhlIHBp biB0byByZXRyeSwKPiA+IAo+ID4gRm9yIHR3byBjb25uZWN0b3JzIHNoYXJpbmcgYW4gZW5jb2Rl ciB0aGVpciBwb3J0cyBhbmQgcGlucyB3aWxsIGJlCj4gPiB0aGUgc2FtZS4gU28gaWYgeW91IGRv IGFib3ZlOgo+ID4gCj4gPiAJCWNhc2UgSU5URUxfSE9UUExVR19DSEFOR0VEOgo+ID4gCQkJY2hh bmdlZCB8PSBocGRfYml0Owo+ID4gCQkJYnJlYWs7Cj4gPiAKPiA+IAkJLi4uCj4gPiAKPiA+IHlv dSBjYW4ganVzdCBhdm9pZCB0aGUgcmV0cmllcyBmb3Igc3VjaCBjaGFuZ2VkIGNvbm5lY3RvcnMg YnkKPiA+IAo+ID4gCXJldHJ5ICY9IH5jaGFuZ2VkOwo+ID4gCQo+ID4gaGVyZS4JCj4gCj4gU28g bGV0cyBzYXkgdGhhdCB3ZSBoYXZlOiBIRE1JLTEgb24gZW5jb25kZXJfQSBhbmQgRFAtMSBvbiBl bmNvZGVyX0EsCj4gdXNlciBob3RwbHVnIEhETUktMSBhbmQgd2hlbiBpdGVyYXRpbmcgb3ZlciBh bGwgY29ubmVjdG9ycyBpbgo+IGk5MTVfaG90cGx1Z193b3JrX2Z1bmMoKSB3ZSBoYXZlIHRoaXM6 Cj4gCj4gLy8gZmlzdCBpdGVyYXRpb24KPiByZXQgPSBpbnRlbF9lbmNvZGVyLT5ob3RwbHVnLT5o b3RwbHVnKGVuY29kZXIsIEhETUktMSk7Cj4gLy9yZXQgPSBJTlRFTF9IT1RQTFVHX0NIQU5HRUQK PiAKPiAvLyBzZWNvbmQgaXRlcmF0aW9uCj4gcmV0ID0gaW50ZWxfZW5jb2Rlci0+aG90cGx1Zy0+ aG90cGx1ZyhlbmNvZGVyLCBEUC0xKTsKPiAvL3JldCA9IElOVEVMX0hPVFBMVUdfUkVUUlkKPiAK PiBzbyBhICdyZXRyeSAmPSB+Y2hhbmdlZDsnIGluICdjYXNlIElOVEVMX0hPVFBMVUdfQ0hBTkdF RDonIGFsb25lIHdvdWxkCj4gbm90IHByZXZlbnQgaXQgdG8gc2V0IHJldHJ5X2JpdHM7CgpUaGUg Yml0cyBmcm9tIHJldHJ5IGFyZSBjbGVhcmVkIGFmdGVyIHRoZSBsb29wIHdoaWNoIGRvZXMgcHJl dmVudCBpdC4KSGVyZSdzIHRoZSB1cGRhdGVkIGRpZmYgZm9yIHRoZSBmdW5jdGlvbjoKCkBAIC0z NDgsMTQgKzM1MSwxNyBAQCBzdGF0aWMgdm9pZCBpOTE1X2RpZ3BvcnRfd29ya19mdW5jKHN0cnVj dCB3b3JrX3N0cnVjdCAqd29yaykKIHN0YXRpYyB2b2lkIGk5MTVfaG90cGx1Z193b3JrX2Z1bmMo c3RydWN0IHdvcmtfc3RydWN0ICp3b3JrKQogewogCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdiA9Ci0JCWNvbnRhaW5lcl9vZih3b3JrLCBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSwg aG90cGx1Zy5ob3RwbHVnX3dvcmspOworCQljb250YWluZXJfb2Yod29yaywgc3RydWN0IGRybV9p OTE1X3ByaXZhdGUsCisJCQkgICAgIGhvdHBsdWcuaG90cGx1Z193b3JrLndvcmspOwogCXN0cnVj dCBkcm1fZGV2aWNlICpkZXYgPSAmZGV2X3ByaXYtPmRybTsKIAlzdHJ1Y3QgaW50ZWxfY29ubmVj dG9yICppbnRlbF9jb25uZWN0b3I7CiAJc3RydWN0IGludGVsX2VuY29kZXIgKmludGVsX2VuY29k ZXI7CiAJc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvcjsKIAlzdHJ1Y3QgZHJtX2Nvbm5l Y3Rvcl9saXN0X2l0ZXIgY29ubl9pdGVyOwotCWJvb2wgY2hhbmdlZCA9IGZhbHNlOworCXUzMiBj aGFuZ2VkID0gMDsKKwl1MzIgcmV0cnkgPSAwOwogCXUzMiBocGRfZXZlbnRfYml0czsKKwl1MzIg aHBkX3JldHJ5X2JpdHM7CiAKIAltdXRleF9sb2NrKCZkZXYtPm1vZGVfY29uZmlnLm11dGV4KTsK IAlEUk1fREVCVUdfS01TKCJydW5uaW5nIGVuY29kZXIgaG90cGx1ZyBmdW5jdGlvbnNcbiIpOwpA QCAtMzY0LDYgKzM3MCw4IEBAIHN0YXRpYyB2b2lkIGk5MTVfaG90cGx1Z193b3JrX2Z1bmMoc3Ry dWN0IHdvcmtfc3RydWN0ICp3b3JrKQogCiAJaHBkX2V2ZW50X2JpdHMgPSBkZXZfcHJpdi0+aG90 cGx1Zy5ldmVudF9iaXRzOwogCWRldl9wcml2LT5ob3RwbHVnLmV2ZW50X2JpdHMgPSAwOworCWhw ZF9yZXRyeV9iaXRzID0gZGV2X3ByaXYtPmhvdHBsdWcucmV0cnlfYml0czsKKwlkZXZfcHJpdi0+ aG90cGx1Zy5yZXRyeV9iaXRzID0gMDsKIAogCS8qIEVuYWJsZSBwb2xsaW5nIGZvciBjb25uZWN0 b3JzIHdoaWNoIGhhZCBIUEQgSVJRIHN0b3JtcyAqLwogCWludGVsX2hwZF9pcnFfc3Rvcm1fc3dp dGNoX3RvX3BvbGxpbmcoZGV2X3ByaXYpOwpAQCAtMzcyLDE2ICszODAsMjkgQEAgc3RhdGljIHZv aWQgaTkxNV9ob3RwbHVnX3dvcmtfZnVuYyhzdHJ1Y3Qgd29ya19zdHJ1Y3QgKndvcmspCiAKIAlk cm1fY29ubmVjdG9yX2xpc3RfaXRlcl9iZWdpbihkZXYsICZjb25uX2l0ZXIpOwogCWRybV9mb3Jf ZWFjaF9jb25uZWN0b3JfaXRlcihjb25uZWN0b3IsICZjb25uX2l0ZXIpIHsKKwkJdTMyIGhwZF9i aXQ7CisKIAkJaW50ZWxfY29ubmVjdG9yID0gdG9faW50ZWxfY29ubmVjdG9yKGNvbm5lY3Rvcik7 CiAJCWlmICghaW50ZWxfY29ubmVjdG9yLT5lbmNvZGVyKQogCQkJY29udGludWU7CiAJCWludGVs X2VuY29kZXIgPSBpbnRlbF9jb25uZWN0b3ItPmVuY29kZXI7Ci0JCWlmIChocGRfZXZlbnRfYml0 cyAmICgxIDw8IGludGVsX2VuY29kZXItPmhwZF9waW4pKSB7CisJCWhwZF9iaXQgPSBCSVQoaW50 ZWxfZW5jb2Rlci0+aHBkX3Bpbik7CisJCWlmICgoaHBkX2V2ZW50X2JpdHMgfCBocGRfcmV0cnlf Yml0cykgJiBocGRfYml0KSB7CiAJCQlEUk1fREVCVUdfS01TKCJDb25uZWN0b3IgJXMgKHBpbiAl aSkgcmVjZWl2ZWQgaG90cGx1ZyBldmVudC5cbiIsCiAJCQkJICAgICAgY29ubmVjdG9yLT5uYW1l LCBpbnRlbF9lbmNvZGVyLT5ocGRfcGluKTsKIAotCQkJY2hhbmdlZCB8PSBpbnRlbF9lbmNvZGVy LT5ob3RwbHVnKGludGVsX2VuY29kZXIsCi0JCQkJCQkJICBpbnRlbF9jb25uZWN0b3IpOworCQkJ c3dpdGNoIChpbnRlbF9lbmNvZGVyLT5ob3RwbHVnKGludGVsX2VuY29kZXIsCisJCQkJCQkgICAg ICAgaW50ZWxfY29ubmVjdG9yLAorCQkJCQkJICAgICAgIGhwZF9ldmVudF9iaXRzICYgaHBkX2Jp dCkpIHsKKwkJCWNhc2UgSU5URUxfSE9UUExVR19OT0NIQU5HRToKKwkJCQlicmVhazsKKwkJCWNh c2UgSU5URUxfSE9UUExVR19DSEFOR0VEOgorCQkJCWNoYW5nZWQgfD0gaHBkX2JpdDsKKwkJCQli cmVhazsKKwkJCWNhc2UgSU5URUxfSE9UUExVR19SRVRSWToKKwkJCQlyZXRyeSB8PSBocGRfYml0 OworCQkJCWJyZWFrOworCQkJfQogCQl9CiAJfQogCWRybV9jb25uZWN0b3JfbGlzdF9pdGVyX2Vu ZCgmY29ubl9pdGVyKTsKQEAgLTM4OSw2ICs0MTAsMTcgQEAgc3RhdGljIHZvaWQgaTkxNV9ob3Rw bHVnX3dvcmtfZnVuYyhzdHJ1Y3Qgd29ya19zdHJ1Y3QgKndvcmspCiAKIAlpZiAoY2hhbmdlZCkK IAkJZHJtX2ttc19oZWxwZXJfaG90cGx1Z19ldmVudChkZXYpOworCisJcmV0cnkgJj0gfmNoYW5n ZWQ7CisKKwlpZiAocmV0cnkpIHsKKwkJc3Bpbl9sb2NrX2lycSgmZGV2X3ByaXYtPmlycV9sb2Nr KTsKKwkJZGV2X3ByaXYtPmhvdHBsdWcucmV0cnlfYml0cyB8PSByZXRyeTsKKwkJc3Bpbl91bmxv Y2tfaXJxKCZkZXZfcHJpdi0+aXJxX2xvY2spOworCisJCW1vZF9kZWxheWVkX3dvcmsoc3lzdGVt X3dxLCAmZGV2X3ByaXYtPmhvdHBsdWcuaG90cGx1Z193b3JrLAorCQkJCSBtc2Vjc190b19qaWZm aWVzKEhQRF9SRVRSWV9ERUxBWSkpOworCX0KIH0KIAogCi0tSW1yZQpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=