From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915/icl: Fix clockgating issue when using scalars Date: Mon, 18 Mar 2019 15:30:52 +0200 Message-ID: <20190318133052.GI3888@intel.com> References: <20190315221838.22444-1-radhakrishna.sripada@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2976F898C2 for ; Mon, 18 Mar 2019 13:30:56 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190315221838.22444-1-radhakrishna.sripada@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Radhakrishna Sripada Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBNYXIgMTUsIDIwMTkgYXQgMDM6MTg6MzhQTSAtMDcwMCwgUmFkaGFrcmlzaG5hIFNy aXBhZGEgd3JvdGU6Cj4gRml4ZXMgdGhlIGNsb2NrLWdhdGluZyBpc3N1ZSB3aGVuIHBpcGUgc2Nh bGluZyBpcyBlbmFibGVkLgo+IChMaW5lYWdlICMyMDA2NjA0MzEyKQo+IAo+IENjOiBSb2RyaWdv IFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5jb20+Cj4gQ2M6IEFudXNoYSBTcml2YXRzYSA8YW51 c2hhLnNyaXZhdHNhQGludGVsLmNvbT4KPiBDYzogQWRpdHlhIFN3YXJ1cCA8YWRpdHlhLnN3YXJ1 cEBpbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogUmFkaGFrcmlzaG5hIFNyaXBhZGEgPHJhZGhh a3Jpc2huYS5zcmlwYWRhQGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZGlzcGxheS5jIHwgMTcgKysrKysrKysrKysrKysrKy0KPiAgMSBmaWxlIGNoYW5nZWQs IDE2IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZGlzcGxheS5jCj4gaW5kZXggNjFhY2JhZjJhZjc1Li45NzM0NGNjYTg5YzQgMTAwNjQ0Cj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTUxOTMsOSArNTE5MywxNyBAQCBz dGF0aWMgaW50IHNrbF91cGRhdGVfc2NhbGVyX3BsYW5lKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRl ICpjcnRjX3N0YXRlLAo+ICBzdGF0aWMgdm9pZCBza3lsYWtlX3NjYWxlcl9kaXNhYmxlKHN0cnVj dCBpbnRlbF9jcnRjICpjcnRjKQo+ICB7Cj4gIAlpbnQgaTsKPiArCXN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoY3J0Yy0+YmFzZS5kZXYpOwo+ICsJaTkxNV9yZWdf dCByZWcgPSBDTEtHQVRFX0RJU19QU0woY3J0Yy0+cGlwZSk7Cj4gIAo+ICAJZm9yIChpID0gMDsg aSA8IGNydGMtPm51bV9zY2FsZXJzOyBpKyspCj4gIAkJc2tsX2RldGFjaF9zY2FsZXIoY3J0Yywg aSk7Cj4gKwo+ICsJLyoKPiArCSAqIFdhXzIwMDY2MDQzMTI6aWNsCj4gKwkgKi8KPiArCWlmIChJ U19JQ0VMQUtFKGRldl9wcml2KSkKPiArCQlJOTE1X1dSSVRFKHJlZywgSTkxNV9SRUFEKHJlZykg JiB+RFBGUl9HQVRJTkdfRElTKTsKClRoZSByZWdpc3RlciBkb2Vzbid0IGFwcGVhciB0byBiZSBk b3VibGUgYnVmZmVyZWQgc28gSSBkb24ndCB0aGluayB3ZQpzaG91bGQgYmUgZG9pbmcgdGhpcyBo ZXJlLiBJbnN0ZWFkIGl0IHNob3VsZCBiZSBiZSBzb21ld2hlcmUgYXJvdW5kIHRoZQpwcmUvcG9y dCBwbGFuZSB1cGRhdGUgc3R1ZmYuCgo+ICB9Cj4gIAo+ICBzdGF0aWMgdm9pZCBza3lsYWtlX3Bm aXRfZW5hYmxlKGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlKQo+IEBA IC01MjA1LDYgKzUyMTMsNyBAQCBzdGF0aWMgdm9pZCBza3lsYWtlX3BmaXRfZW5hYmxlKGNvbnN0 IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlKQo+ICAJZW51bSBwaXBlIHBpcGUg PSBjcnRjLT5waXBlOwo+ICAJY29uc3Qgc3RydWN0IGludGVsX2NydGNfc2NhbGVyX3N0YXRlICpz Y2FsZXJfc3RhdGUgPQo+ICAJCSZjcnRjX3N0YXRlLT5zY2FsZXJfc3RhdGU7Cj4gKwlpOTE1X3Jl Z190IHJlZyA9IENMS0dBVEVfRElTX1BTTChwaXBlKTsKPiAgCj4gIAlpZiAoY3J0Y19zdGF0ZS0+ cGNoX3BmaXQuZW5hYmxlZCkgewo+ICAJCXUxNiB1dl9yZ2JfaHBoYXNlLCB1dl9yZ2JfdnBoYXNl Owo+IEBAIC01MjMyLDYgKzUyNDEsMTIgQEAgc3RhdGljIHZvaWQgc2t5bGFrZV9wZml0X2VuYWJs ZShjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSkKPiAgCQkJICAgICAg UFNfWV9QSEFTRSgwKSB8IFBTX1VWX1JHQl9QSEFTRSh1dl9yZ2JfaHBoYXNlKSk7Cj4gIAkJSTkx NV9XUklURShTS0xfUFNfV0lOX1BPUyhwaXBlLCBpZCksIGNydGNfc3RhdGUtPnBjaF9wZml0LnBv cyk7Cj4gIAkJSTkxNV9XUklURShTS0xfUFNfV0lOX1NaKHBpcGUsIGlkKSwgY3J0Y19zdGF0ZS0+ cGNoX3BmaXQuc2l6ZSk7Cj4gKwo+ICsJCS8qCj4gKwkJICogV2FfMjAwNjYwNDMxMjppY2wKPiAr CQkqLwo+ICsJCWlmIChJU19JQ0VMQUtFKGRldl9wcml2KSkKPiArCQkJSTkxNV9XUklURShyZWcs IEk5MTVfUkVBRChyZWcpIHwgRFBGUl9HQVRJTkdfRElTKTsKCj4gIAl9Cj4gIH0KPiAgCj4gQEAg LTU5NzIsNyArNTk4Nyw3IEBAIHN0YXRpYyB2b2lkIGhhc3dlbGxfY3J0Y19lbmFibGUoc3RydWN0 IGludGVsX2NydGNfc3RhdGUgKnBpcGVfY29uZmlnLAo+ICAKPiAgCS8qIERpc3BsYXkgV0EgIzEx ODA6IFdhRGlzYWJsZVNjYWxhckNsb2NrR2F0aW5nOiBnbGssIGNubCAqLwo+ICAJcHNsX2Nsa2dh dGVfd2EgPSAoSVNfR0VNSU5JTEFLRShkZXZfcHJpdikgfHwgSVNfQ0FOTk9OTEFLRShkZXZfcHJp dikpICYmCj4gLQkJCSBwaXBlX2NvbmZpZy0+cGNoX3BmaXQuZW5hYmxlZDsKPiArCQkJICBwaXBl X2NvbmZpZy0+cGNoX3BmaXQuZW5hYmxlZDsKClVucmVsYXRlZCBjaGFuZ2UuCgo+ICAJaWYgKHBz bF9jbGtnYXRlX3dhKQo+ICAJCWdsa19waXBlX3NjYWxlcl9jbG9ja19nYXRpbmdfd2EoZGV2X3By aXYsIHBpcGUsIHRydWUpOwo+ICAKPiAtLSAKPiAyLjIwLjAucmMyLjcuZzk2NTc5OGQxZjI5OQo+ IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50 ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoK LS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9pbnRlbC1nZng=