From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH] drm/i915/icl: pass cfgcr* register around
 instead of pll_id
Date: Mon, 18 Mar 2019 15:31:52 +0200
Message-ID: <20190318133152.GJ3888@intel.com>
References: <20190316004526.12065-1-lucas.demarchi@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 9324989736
 for <intel-gfx@lists.freedesktop.org>; Mon, 18 Mar 2019 13:31:55 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20190316004526.12065-1-lucas.demarchi@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gRnJpLCBNYXIgMTUsIDIwMTkgYXQgMDU6NDU6MjZQTSAtMDcwMCwgTHVjYXMgRGUgTWFyY2hp
IHdyb3RlOgo+IFRoZSBjYWxsZXIgYWxyZWFkeSBrbm93cyB3aGF0IHBsYXRmb3JtIHRoYXQgaXMg
YW5kIHdoYXQgcmVnaXN0ZXIgc2hvdWxkCj4gYmUgdXNlZC4gSW5zdGVhZCBvZiBrZWVwIGFkZGlu
ZyBpZi9lbHNlIGNoYWlucyBvbiBhIGxlYWYgZnVuY3Rpb25zLAo+IGxldCB0aGUgY2FsbGVyIHBh
c3MgdGhlIHJlZ2lzdGVyLgo+IAo+IFdlIHJlYWQgY2ZnY3IwIHR3aWNlIGZvciBDTkwsIGJ1dCB3
ZSB3ZXJlIGFscmVhZHkgZG9pbmcgdGhhdCBhbnl3YXkuCj4gCj4gaWNsX2NhbGNfZHBfY29tYm9f
cGxsX2xpbmsoKSBpcyBvbmx5IHVzZWQgZm9yIElDTCwgYnV0IGxldCdzIGtlZXAKPiBjb25zaXN0
ZW5jeSB3aXRoIGNubF9jYWxjX3dycGxsX2xpbmsoKS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBMdWNh
cyBEZSBNYXJjaGkgPGx1Y2FzLmRlbWFyY2hpQGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9n
cHUvZHJtL2k5MTUvaWNsX2RzaS5jICAgICAgICB8ICA0ICsrKy0KPiAgZHJpdmVycy9ncHUvZHJt
L2k5MTUvaW50ZWxfZGRpLmMgICAgICB8IDI1ICsrKysrKysrKysrKysrLS0tLS0tLS0tLS0KPiAg
ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuYyB8ICA2ICsrKy0tLQo+ICBkcml2
ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5oIHwgIDIgKy0KPiAgZHJpdmVycy9ncHUv
ZHJtL2k5MTUvaW50ZWxfZHJ2LmggICAgICB8ICAyICstCj4gIDUgZmlsZXMgY2hhbmdlZCwgMjIg
aW5zZXJ0aW9ucygrKSwgMTcgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv
Z3B1L2RybS9pOTE1L2ljbF9kc2kuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ljbF9kc2kuYwo+
IGluZGV4IGJlYjMwZDlhODU1Yy4uMjhmNWRhNjk3NjkzIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv
Z3B1L2RybS9pOTE1L2ljbF9kc2kuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ljbF9k
c2kuYwo+IEBAIC0xMTgzLDcgKzExODMsOSBAQCBzdGF0aWMgdm9pZCBnZW4xMV9kc2lfZ2V0X2Nv
bmZpZyhzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlciwKPiAgCj4gIAkvKiBGSVhNRTogYWRh
cHQgaWNsX2RkaV9jbG9ja19nZXQoKSBmb3IgRFNJIGFuZCB1c2UgdGhhdD8gKi8KPiAgCXBsbF9p
ZCA9IGludGVsX2dldF9zaGFyZWRfZHBsbF9pZChkZXZfcHJpdiwgcGlwZV9jb25maWctPnNoYXJl
ZF9kcGxsKTsKPiAtCXBpcGVfY29uZmlnLT5wb3J0X2Nsb2NrID0gY25sX2NhbGNfd3JwbGxfbGlu
ayhkZXZfcHJpdiwgcGxsX2lkKTsKPiArCXBpcGVfY29uZmlnLT5wb3J0X2Nsb2NrID0gY25sX2Nh
bGNfd3JwbGxfbGluayhkZXZfcHJpdiwKPiArCQkJCQkJICAgICAgSUNMX0RQTExfQ0ZHQ1IwKHBs
bF9pZCksCj4gKwkJCQkJCSAgICAgIElDTF9EUExMX0NGR0NSMShwbGxfaWQpKTsKPiAgCXBpcGVf
Y29uZmlnLT5iYXNlLmFkanVzdGVkX21vZGUuY3J0Y19jbG9jayA9IGludGVsX2RzaS0+cGNsazsK
PiAgCXBpcGVfY29uZmlnLT5vdXRwdXRfdHlwZXMgfD0gQklUKElOVEVMX09VVFBVVF9EU0kpOwo+
ICB9Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jIGIvZHJp
dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiBpbmRleCA2OWFhMGQxNDg3OTUuLjI0Njc1
ZWY4YjI2MiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+
ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gQEAgLTEzMDQsMTggKzEz
MDQsMTMgQEAgc3RhdGljIGludCBza2xfY2FsY193cnBsbF9saW5rKHN0cnVjdCBkcm1faTkxNV9w
cml2YXRlICpkZXZfcHJpdiwKPiAgfQo+ICAKPiAgaW50IGNubF9jYWxjX3dycGxsX2xpbmsoc3Ry
dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+IC0JCQllbnVtIGludGVsX2RwbGxfaWQg
cGxsX2lkKQo+ICsJCQlpOTE1X3JlZ190IGNmZ2NyMF9yZWcsIGk5MTVfcmVnX3QgY2ZnY3IxX3Jl
ZykKPiAgewo+ICAJdTMyIGNmZ2NyMCwgY2ZnY3IxOwo+ICAJdTMyIHAwLCBwMSwgcDIsIGRjb19m
cmVxLCByZWZfY2xvY2s7Cj4gIAo+IC0JaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0gMTEpIHsK
PiAtCQljZmdjcjAgPSBJOTE1X1JFQUQoSUNMX0RQTExfQ0ZHQ1IwKHBsbF9pZCkpOwo+IC0JCWNm
Z2NyMSA9IEk5MTVfUkVBRChJQ0xfRFBMTF9DRkdDUjEocGxsX2lkKSk7Cj4gLQl9IGVsc2Ugewo+
IC0JCWNmZ2NyMCA9IEk5MTVfUkVBRChDTkxfRFBMTF9DRkdDUjAocGxsX2lkKSk7Cj4gLQkJY2Zn
Y3IxID0gSTkxNV9SRUFEKENOTF9EUExMX0NGR0NSMShwbGxfaWQpKTsKPiAtCX0KPiArCWNmZ2Ny
MCA9IEk5MTVfUkVBRChjZmdjcjBfcmVnKTsKPiArCWNmZ2NyMSA9IEk5MTVfUkVBRChjZmdjcjFf
cmVnKTsKCkRvbid0IHdlIGFscmVkeSBoYXZlIHRoZSBkcGxsIHN0YXRlIHJlYWQgb3V0IGF0IHRo
aXMgcG9pbnQ/CkkgdGhvdWdodCBJIGNoYW5nZWQgYXQgbGVhc3Qgc29tZSBvZiB0aGVzZSB0byBu
b3QgcmVhZCBpdCBvdXQKZGlyZWN0bHkuCgo+ICAKPiAgCXAwID0gY2ZnY3IxICYgRFBMTF9DRkdD
UjFfUERJVl9NQVNLOwo+ICAJcDIgPSBjZmdjcjEgJiBEUExMX0NGR0NSMV9LRElWX01BU0s7Cj4g
QEAgLTE0NzEsMTcgKzE0NjYsMjMgQEAgc3RhdGljIHZvaWQgaWNsX2RkaV9jbG9ja19nZXQoc3Ry
dWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4gIAkJCSAgICAgIHN0cnVjdCBpbnRlbF9jcnRj
X3N0YXRlICpwaXBlX2NvbmZpZykKPiAgewo+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl
dl9wcml2ID0gdG9faTkxNShlbmNvZGVyLT5iYXNlLmRldik7Cj4gKwlpOTE1X3JlZ190IGNmZ2Ny
MF9yZWcsIGNmZ2NyMV9yZWc7Cj4gIAllbnVtIHBvcnQgcG9ydCA9IGVuY29kZXItPnBvcnQ7Cj4g
IAlpbnQgbGlua19jbG9jayA9IDA7Cj4gIAl1MzIgcGxsX2lkOwo+ICAKPiAgCXBsbF9pZCA9IGlu
dGVsX2dldF9zaGFyZWRfZHBsbF9pZChkZXZfcHJpdiwgcGlwZV9jb25maWctPnNoYXJlZF9kcGxs
KTsKPiArCWNmZ2NyMF9yZWcgPSBJQ0xfRFBMTF9DRkdDUjAocGxsX2lkKTsKPiArCWNmZ2NyMV9y
ZWcgPSBJQ0xfRFBMTF9DRkdDUjEocGxsX2lkKTsKPiArCj4gIAlpZiAoaW50ZWxfcG9ydF9pc19j
b21ib3BoeShkZXZfcHJpdiwgcG9ydCkpIHsKPiAgCQlpZiAoaW50ZWxfY3J0Y19oYXNfdHlwZShw
aXBlX2NvbmZpZywgSU5URUxfT1VUUFVUX0hETUkpKQo+IC0JCQlsaW5rX2Nsb2NrID0gY25sX2Nh
bGNfd3JwbGxfbGluayhkZXZfcHJpdiwgcGxsX2lkKTsKPiArCQkJbGlua19jbG9jayA9IGNubF9j
YWxjX3dycGxsX2xpbmsoZGV2X3ByaXYsIGNmZ2NyMF9yZWcsCj4gKwkJCQkJCQkgY2ZnY3IxX3Jl
Zyk7Cj4gIAkJZWxzZQo+ICAJCQlsaW5rX2Nsb2NrID0gaWNsX2NhbGNfZHBfY29tYm9fcGxsX2xp
bmsoZGV2X3ByaXYsCj4gLQkJCQkJCQkJcGxsX2lkKTsKPiArCQkJCQkJCQljZmdjcjBfcmVnLAo+
ICsJCQkJCQkJCWNmZ2NyMV9yZWcpOwo+ICAJfSBlbHNlIHsKPiAgCQlpZiAocGxsX2lkID09IERQ
TExfSURfSUNMX1RCVFBMTCkKPiAgCQkJbGlua19jbG9jayA9IGljbF9jYWxjX3RidF9wbGxfbGlu
ayhkZXZfcHJpdiwgcG9ydCk7Cj4gQEAgLTE1MDYsNyArMTUwNyw5IEBAIHN0YXRpYyB2b2lkIGNu
bF9kZGlfY2xvY2tfZ2V0KHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ICAJY2ZnY3Iw
ID0gSTkxNV9SRUFEKENOTF9EUExMX0NGR0NSMChwbGxfaWQpKTsKPiAgCj4gIAlpZiAoY2ZnY3Iw
ICYgRFBMTF9DRkdDUjBfSERNSV9NT0RFKSB7Cj4gLQkJbGlua19jbG9jayA9IGNubF9jYWxjX3dy
cGxsX2xpbmsoZGV2X3ByaXYsIHBsbF9pZCk7Cj4gKwkJbGlua19jbG9jayA9IGNubF9jYWxjX3dy
cGxsX2xpbmsoZGV2X3ByaXYsCj4gKwkJCQkJCSBDTkxfRFBMTF9DRkdDUjAocGxsX2lkKSwKPiAr
CQkJCQkJIENOTF9EUExMX0NGR0NSMShwbGxfaWQpKTsKPiAgCX0gZWxzZSB7Cj4gIAkJbGlua19j
bG9jayA9IGNmZ2NyMCAmIERQTExfQ0ZHQ1IwX0xJTktfUkFURV9NQVNLOwo+ICAKPiBkaWZmIC0t
Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuYyBiL2RyaXZlcnMvZ3B1
L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmMKPiBpbmRleCBjYTk3NTIxM2RhMmEuLmVkNDAyNGY0
Mzk0YiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5j
Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuYwo+IEBAIC0yNTY5
LDcgKzI1NjksNyBAQCBzdGF0aWMgYm9vbCBpY2xfY2FsY19kcGxsX3N0YXRlKHN0cnVjdCBpbnRl
bF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlLAo+ICB9Cj4gIAo+ICBpbnQgaWNsX2NhbGNfZHBfY29t
Ym9fcGxsX2xpbmsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+IC0JCQkgICAg
ICAgdTMyIHBsbF9pZCkKPiArCQkJICAgICAgIGk5MTVfcmVnX3QgY2ZnY3IwX3JlZywgaTkxNV9y
ZWdfdCBjZmdjcjFfcmVnKQo+ICB7Cj4gIAl1MzIgY2ZnY3IwLCBjZmdjcjE7Cj4gIAl1MzIgcGRp
diwga2RpdiwgcWRpdl9tb2RlLCBxZGl2X3JhdGlvLCBkY29faW50ZWdlciwgZGNvX2ZyYWN0aW9u
Owo+IEBAIC0yNTc3LDggKzI1NzcsOCBAQCBpbnQgaWNsX2NhbGNfZHBfY29tYm9fcGxsX2xpbmso
c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJaW50IGluZGV4LCBuX2VudHJp
ZXMsIGxpbmtfY2xvY2s7Cj4gIAo+ICAJLyogUmVhZCBiYWNrIHZhbHVlcyBmcm9tIERQTEwgQ0ZH
Q1IgcmVnaXN0ZXJzICovCj4gLQljZmdjcjAgPSBJOTE1X1JFQUQoSUNMX0RQTExfQ0ZHQ1IwKHBs
bF9pZCkpOwo+IC0JY2ZnY3IxID0gSTkxNV9SRUFEKElDTF9EUExMX0NGR0NSMShwbGxfaWQpKTsK
PiArCWNmZ2NyMCA9IEk5MTVfUkVBRChjZmdjcjBfcmVnKTsKPiArCWNmZ2NyMSA9IEk5MTVfUkVB
RChjZmdjcjFfcmVnKTsKPiAgCj4gIAlkY29faW50ZWdlciA9IGNmZ2NyMCAmIERQTExfQ0ZHQ1Iw
X0RDT19JTlRFR0VSX01BU0s7Cj4gIAlkY29fZnJhY3Rpb24gPSAoY2ZnY3IwICYgRFBMTF9DRkdD
UjBfRENPX0ZSQUNUSU9OX01BU0spID4+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p
OTE1L2ludGVsX2RwbGxfbWdyLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21n
ci5oCj4gaW5kZXggNDBlODM5MWE5MmYyLi4wYWE1MDRlOWJmYmYgMTAwNjQ0Cj4gLS0tIGEvZHJp
dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry
bS9pOTE1L2ludGVsX2RwbGxfbWdyLmgKPiBAQCAtMzQyLDcgKzM0Miw3IEBAIHZvaWQgaW50ZWxf
c2hhcmVkX2RwbGxfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KTsKPiAgdm9pZCBpbnRlbF9k
cGxsX2R1bXBfaHdfc3RhdGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJ
CQkgICAgICBzdHJ1Y3QgaW50ZWxfZHBsbF9od19zdGF0ZSAqaHdfc3RhdGUpOwo+ICBpbnQgaWNs
X2NhbGNfZHBfY29tYm9fcGxsX2xpbmsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2
LAo+IC0JCQkgICAgICAgdTMyIHBsbF9pZCk7Cj4gKwkJCSAgICAgICBpOTE1X3JlZ190IGNmZ2Ny
MF9yZWcsIGk5MTVfcmVnX3QgY2ZnY3IxX3JlZyk7Cj4gIGludCBjbmxfaGRtaV9wbGxfcmVmX2Ns
b2NrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdik7Cj4gIGVudW0gaW50ZWxfZHBs
bF9pZCBpY2xfdGNfcG9ydF90b19wbGxfaWQoZW51bSB0Y19wb3J0IHRjX3BvcnQpOwo+ICBib29s
IGludGVsX2RwbGxfaXNfY29tYm9waHkoZW51bSBpbnRlbF9kcGxsX2lkIGlkKTsKPiBkaWZmIC0t
Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0v
aTkxNS9pbnRlbF9kcnYuaAo+IGluZGV4IGQ5ZjE4OGVmMjFmNC4uOWQwYmYxOTE0NzczIDEwMDY0
NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gKysrIGIvZHJpdmVy
cy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiBAQCAtMTY1OSw3ICsxNjU5LDcgQEAgaW50IGlu
dGVsX2RkaV90b2dnbGVfaGRjcF9zaWduYWxsaW5nKHN0cnVjdCBpbnRlbF9lbmNvZGVyICppbnRl
bF9lbmNvZGVyLAo+ICAJCQkJICAgICBib29sIGVuYWJsZSk7Cj4gIHZvaWQgaWNsX3Nhbml0aXpl
X2VuY29kZXJfcGxsX21hcHBpbmcoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIpOwo+ICBp
bnQgY25sX2NhbGNfd3JwbGxfbGluayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYs
Cj4gLQkJCWVudW0gaW50ZWxfZHBsbF9pZCBwbGxfaWQpOwo+ICsJCQlpOTE1X3JlZ190IGNnZmNy
MF9yZWcsIGk5MTVfcmVnX3QgY2dmY3IxX3JlZyk7Cj4gIAo+ICB1bnNpZ25lZCBpbnQgaW50ZWxf
ZmJfYWxpZ25faGVpZ2h0KGNvbnN0IHN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiLAo+ICAJCQkJ
ICAgaW50IGNvbG9yX3BsYW5lLCB1bnNpZ25lZCBpbnQgaGVpZ2h0KTsKPiAtLSAKPiAyLjIwLjEK
Ci0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu
ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz
dGluZm8vaW50ZWwtZ2Z4