From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v6 2/2] drm/i915: Skip modeset for cdclk changes if possible Date: Mon, 18 Mar 2019 20:37:33 +0200 Message-ID: <20190318183733.GQ3888@intel.com> References: <20190318143435.1686-1-imre.deak@intel.com> <20190318143435.1686-3-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 998E689598 for ; Mon, 18 Mar 2019 18:37:37 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190318143435.1686-3-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Imre Deak Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBNYXIgMTgsIDIwMTkgYXQgMDQ6MzQ6MzVQTSArMDIwMCwgSW1yZSBEZWFrIHdyb3Rl Ogo+IEBAIC0yMTM3LDYgKzIxOTQsNDQgQEAgdm9pZCBpbnRlbF9zZXRfY2RjbGsoc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJfQo+ICB9Cj4gIAo+ICsvKioKPiArICogaW50 ZWxfc2V0X2NkY2xrX3ByZV9wbGFuZV91cGRhdGUgLSBQdXNoIHRoZSBDRENMSyBzdGF0ZSB0byB0 aGUgaGFyZHdhcmUKPiArICogQGRldl9wcml2OiBpOTE1IGRldmljZQo+ICsgKiBAY2RjbGtfc3Rh dGU6IG5ldyBDRENMSyBzdGF0ZQo+ICsgKiBAcGlwZTogcGlwZSB3aXRoIHdoaWNoIHRvIHN5bmNo cm9uaXplIHRoZSB1cGRhdGUKPiArICoKPiArICogUHJvZ3JhbSB0aGUgaGFyZHdhcmUgYmVmb3Jl IHVwZGF0aW5nIHRoZSBIVyBwbGFuZSBzdGF0ZSBiYXNlZCBvbiB0aGUgcGFzc2VkCj4gKyAqIGlu IENEQ0xLIHN0YXRlLCBpZiBuZWNlc3NhcnkuCj4gKyAqLwo+ICt2b2lkCj4gK2ludGVsX3NldF9j ZGNsa19wcmVfcGxhbmVfdXBkYXRlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwK PiArCQkJCSBjb25zdCBzdHJ1Y3QgaW50ZWxfY2RjbGtfc3RhdGUgKmNkY2xrX3N0YXRlLAo+ICsJ CQkJIGVudW0gcGlwZSBwaXBlKQo+ICt7Cj4gKwlpZiAocGlwZSA9PSBJTlZBTElEX1BJUEUgfHwK PiArCSAgICBkZXZfcHJpdi0+Y2RjbGsuYWN0dWFsLmNkY2xrID49IGNkY2xrX3N0YXRlLT5jZGNs aykKCmNkY2xrX3N0YXRlID09ICZkZXZfcHJpdi0+Y2RjbGsuYWN0dWFsCnNvIHRoZXNlIGxvb2sg YSBiaXQgYnVnZ2VyZWQuCgpXb3VsZCBiZSBzb21ld2hhdCBuaWNlIHRvIHVzZSB0aGUgcHJpdmF0 ZSBvYmogc3R1ZmYgZm9yIHRoaXMgYnV0CnRoZSBsb2NraW5nIG5vdyBlbmZvcmNlZCBieSB0aGF0 IG1ha2UgaXQgZGlmZmljdWx0LiBQZXJoYXBzIGEKc3dhcChkZXZfcHJpdi0+Y2Rsaywgc3RhdGUt PmNkY2xrKSB3b3VsZCBiZSBwb3NzaWJsZT8gQSBxdWljayBzY2FuCnRocm91Z2ggdGhlIGNvZGUg ZGlkbid0IHJldmVhbCBhbnkgdXNlcyBvZiBzdGF0ZS0+Y2RjbGsgb3V0c2lkZSB0aGUKY29tcHV0 ZSBjb2RlIHBhdGhzLCBzbyBsb29rcyBzYWZlaXNoLiBBbm90aGVyIG9wdGlvbiBpcyBqdXN0CmNv bXBhcmluZyBhZ2FpbnN0IGRldl9wcml2LT5jZGNsay5odyBzaW5jZSB3ZSBzdGlsbCBoYXZlIHRo YXQuCgo+ICsJCWludGVsX3NldF9jZGNsayhkZXZfcHJpdiwgY2RjbGtfc3RhdGUsIHBpcGUpOwo+ ICt9Cj4gKwo+ICsvKioKPiArICogaW50ZWxfc2V0X2NkY2xrX3Bvc3RfcGxhbmVfdXBkYXRlIC0g UHVzaCB0aGUgQ0RDTEsgc3RhdGUgdG8gdGhlIGhhcmR3YXJlCj4gKyAqIEBkZXZfcHJpdjogaTkx NSBkZXZpY2UKPiArICogQGNkY2xrX3N0YXRlOiBuZXcgQ0RDTEsgc3RhdGUKPiArICogQHBpcGU6 IHBpcGUgd2l0aCB3aGljaCB0byBzeW5jaHJvbml6ZSB0aGUgdXBkYXRlCj4gKyAqCj4gKyAqIFBy b2dyYW0gdGhlIGhhcmR3YXJlIGFmdGVyIHVwZGF0aW5nIHRoZSBIVyBwbGFuZSBzdGF0ZSBiYXNl ZCBvbiB0aGUgcGFzc2VkCj4gKyAqIGluIENEQ0xLIHN0YXRlLCBpZiBuZWNlc3NhcnkuCj4gKyAq Lwo+ICt2b2lkCj4gK2ludGVsX3NldF9jZGNsa19wb3N0X3BsYW5lX3VwZGF0ZShzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gKwkJCQkgIGNvbnN0IHN0cnVjdCBpbnRlbF9jZGNs a19zdGF0ZSAqY2RjbGtfc3RhdGUsCj4gKwkJCQkgIGVudW0gcGlwZSBwaXBlKQo+ICt7Cj4gKwlp ZiAocGlwZSAhPSBJTlZBTElEX1BJUEUgJiYKPiArCSAgICBkZXZfcHJpdi0+Y2RjbGsuYWN0dWFs LmNkY2xrIDwgY2RjbGtfc3RhdGUtPmNkY2xrKQo+ICsJCWludGVsX3NldF9jZGNsayhkZXZfcHJp diwgY2RjbGtfc3RhdGUsIHBpcGUpOwo+ICt9Cj4gKwo+ICBzdGF0aWMgaW50IGludGVsX3BpeGVs X3JhdGVfdG9fY2RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJCQkJ ICAgICBpbnQgcGl4ZWxfcmF0ZSkKPiAgewo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5 LmMKPiBpbmRleCBiNDE5OWNkNTMzNDkuLjBmOTg4NGVjN2U4ZSAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBAQCAtMTI5ODIsNiArMTI5ODIsNyBAQCBzdGF0aWMgaW50 IGludGVsX21vZGVzZXRfY2hlY2tzKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkKPiAg CWludGVsX3N0YXRlLT5hY3RpdmVfY3J0Y3MgPSBkZXZfcHJpdi0+YWN0aXZlX2NydGNzOwo+ICAJ aW50ZWxfc3RhdGUtPmNkY2xrLmxvZ2ljYWwgPSBkZXZfcHJpdi0+Y2RjbGsubG9naWNhbDsKPiAg CWludGVsX3N0YXRlLT5jZGNsay5hY3R1YWwgPSBkZXZfcHJpdi0+Y2RjbGsuYWN0dWFsOwo+ICsJ aW50ZWxfc3RhdGUtPmNkY2xrLnBpcGUgPSBJTlZBTElEX1BJUEU7Cj4gIAo+ICAJZm9yX2VhY2hf b2xkbmV3X2NydGNfaW5fc3RhdGUoc3RhdGUsIGNydGMsIG9sZF9jcnRjX3N0YXRlLCBuZXdfY3J0 Y19zdGF0ZSwgaSkgewo+ICAJCWlmIChuZXdfY3J0Y19zdGF0ZS0+YWN0aXZlKQo+IEBAIC0xMzAw MSw2ICsxMzAwMiw4IEBAIHN0YXRpYyBpbnQgaW50ZWxfbW9kZXNldF9jaGVja3Moc3RydWN0IGRy bV9hdG9taWNfc3RhdGUgKnN0YXRlKQo+ICAJICogYWRqdXN0ZWRfbW9kZSBiaXRzIGluIHRoZSBj cnRjIGRpcmVjdGx5Lgo+ICAJICovCj4gIAlpZiAoZGV2X3ByaXYtPmRpc3BsYXkubW9kZXNldF9j YWxjX2NkY2xrKSB7Cj4gKwkJZW51bSBwaXBlIHBpcGU7Cj4gKwo+ICAJCXJldCA9IGRldl9wcml2 LT5kaXNwbGF5Lm1vZGVzZXRfY2FsY19jZGNsayhzdGF0ZSk7Cj4gIAkJaWYgKHJldCA8IDApCj4g IAkJCXJldHVybiByZXQ7Cj4gQEAgLTEzMDE3LDEyICsxMzAyMCwzNiBAQCBzdGF0aWMgaW50IGlu dGVsX21vZGVzZXRfY2hlY2tzKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkKPiAgCQkJ CXJldHVybiByZXQ7Cj4gIAkJfQo+ICAKPiArCQlpZiAoaXNfcG93ZXJfb2ZfMihpbnRlbF9zdGF0 ZS0+YWN0aXZlX2NydGNzKSkgewo+ICsJCQlzdHJ1Y3QgZHJtX2NydGMgKmNydGM7Cj4gKwkJCXN0 cnVjdCBkcm1fY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZTsKPiArCj4gKwkJCXBpcGUgPSBpbG9nMihp bnRlbF9zdGF0ZS0+YWN0aXZlX2NydGNzKTsKPiArCQkJY3J0YyA9ICZpbnRlbF9nZXRfY3J0Y19m b3JfcGlwZShkZXZfcHJpdiwgcGlwZSktPmJhc2U7Cj4gKwkJCWNydGNfc3RhdGUgPSBkcm1fYXRv bWljX2dldF9uZXdfY3J0Y19zdGF0ZShzdGF0ZSwgY3J0Yyk7Cj4gKwkJCWlmIChjcnRjX3N0YXRl ICYmIG5lZWRzX21vZGVzZXQoY3J0Y19zdGF0ZSkpCj4gKwkJCQlwaXBlID0gSU5WQUxJRF9QSVBF Owo+ICsJCX0gZWxzZSB7Cj4gKwkJCXBpcGUgPSBJTlZBTElEX1BJUEU7Cj4gKwkJfQo+ICsKPiAg CQkvKiBBbGwgcGlwZXMgbXVzdCBiZSBzd2l0Y2hlZCBvZmYgd2hpbGUgd2UgY2hhbmdlIHRoZSBj ZGNsay4gKi8KPiAtCQlpZiAoaW50ZWxfY2RjbGtfbmVlZHNfbW9kZXNldCgmZGV2X3ByaXYtPmNk Y2xrLmFjdHVhbCwKPiAtCQkJCQkgICAgICAmaW50ZWxfc3RhdGUtPmNkY2xrLmFjdHVhbCkpIHsK PiArCQlpZiAocGlwZSAhPSBJTlZBTElEX1BJUEUgJiYKPiArCQkgICAgaW50ZWxfY2RjbGtfbmVl ZHNfY2QyeF91cGRhdGUoZGV2X3ByaXYsCj4gKwkJCQkJCSAgJmRldl9wcml2LT5jZGNsay5hY3R1 YWwsCj4gKwkJCQkJCSAgJmludGVsX3N0YXRlLT5jZGNsay5hY3R1YWwpKSB7Cj4gKwkJCXJldCA9 IGludGVsX2xvY2tfYWxsX3BpcGVzKHN0YXRlKTsKPiArCQkJaWYgKHJldCA8IDApCj4gKwkJCQly ZXR1cm4gcmV0Owo+ICsKPiArCQkJaW50ZWxfc3RhdGUtPmNkY2xrLnBpcGUgPSBwaXBlOwo+ICsJ CX0gZWxzZSBpZiAoaW50ZWxfY2RjbGtfbmVlZHNfbW9kZXNldCgmZGV2X3ByaXYtPmNkY2xrLmFj dHVhbCwKPiArCQkJCQkJICAgICAmaW50ZWxfc3RhdGUtPmNkY2xrLmFjdHVhbCkpIHsKPiAgCQkJ cmV0ID0gaW50ZWxfbW9kZXNldF9hbGxfcGlwZXMoc3RhdGUpOwo+ICAJCQlpZiAocmV0IDwgMCkK PiAgCQkJCXJldHVybiByZXQ7Cj4gKwo+ICsJCQlpbnRlbF9zdGF0ZS0+Y2RjbGsucGlwZSA9IElO VkFMSURfUElQRTsKPiAgCQl9Cj4gIAo+ICAJCURSTV9ERUJVR19LTVMoIk5ldyBjZGNsayBjYWxj dWxhdGVkIHRvIGJlIGxvZ2ljYWwgJXUga0h6LCBhY3R1YWwgJXUga0h6XG4iLAo+IEBAIC0xMzQz Myw3ICsxMzQ2MCw5IEBAIHN0YXRpYyB2b2lkIGludGVsX2F0b21pY19jb21taXRfdGFpbChzdHJ1 Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUpCj4gIAlpZiAoaW50ZWxfc3RhdGUtPm1vZGVzZXQp IHsKPiAgCQlkcm1fYXRvbWljX2hlbHBlcl91cGRhdGVfbGVnYWN5X21vZGVzZXRfc3RhdGUoc3Rh dGUtPmRldiwgc3RhdGUpOwo+ICAKPiAtCQlpbnRlbF9zZXRfY2RjbGsoZGV2X3ByaXYsICZkZXZf cHJpdi0+Y2RjbGsuYWN0dWFsKTsKPiArCQlpbnRlbF9zZXRfY2RjbGtfcHJlX3BsYW5lX3VwZGF0 ZShkZXZfcHJpdiwKPiArCQkJCQkJICZkZXZfcHJpdi0+Y2RjbGsuYWN0dWFsLAo+ICsJCQkJCQkg aW50ZWxfc3RhdGUtPmNkY2xrLnBpcGUpOwo+ICAKPiAgCQkvKgo+ICAJCSAqIFNLTCB3b3JrYXJv dW5kOiBic3BlYyByZWNvbW1lbmRzIHdlIGRpc2FibGUgdGhlIFNBR1Ygd2hlbiB3ZQo+IEBAIC0x MzQ2Miw2ICsxMzQ5MSwxMCBAQCBzdGF0aWMgdm9pZCBpbnRlbF9hdG9taWNfY29tbWl0X3RhaWwo c3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlKQo+ICAJLyogTm93IGVuYWJsZSB0aGUgY2xv Y2tzLCBwbGFuZSwgcGlwZSwgYW5kIGNvbm5lY3RvcnMgdGhhdCB3ZSBzZXQgdXAuICovCj4gIAlk ZXZfcHJpdi0+ZGlzcGxheS51cGRhdGVfY3J0Y3Moc3RhdGUpOwo+ICAKPiArCWludGVsX3NldF9j ZGNsa19wb3N0X3BsYW5lX3VwZGF0ZShkZXZfcHJpdiwKPiArCQkJCQkgICZkZXZfcHJpdi0+Y2Rj bGsuYWN0dWFsLAo+ICsJCQkJCSAgaW50ZWxfc3RhdGUtPmNkY2xrLnBpcGUpOwo+ICsKPiAgCS8q IEZJWE1FOiBXZSBzaG91bGQgY2FsbCBkcm1fYXRvbWljX2hlbHBlcl9jb21taXRfaHdfZG9uZSgp IGhlcmUKPiAgCSAqIGFscmVhZHksIGJ1dCBzdGlsbCBuZWVkIHRoZSBzdGF0ZSBmb3IgdGhlIGRl bGF5ZWQgb3B0aW1pemF0aW9uLiBUbwo+ICAJICogZml4IHRoaXM6Cj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZHJ2LmgKPiBpbmRleCAwYjg0ZTU1N2MyNjcuLmU1YTFlMjQ1ZWU2NSAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2Rydi5oCj4gQEAgLTU1OSw2ICs1NTksOCBAQCBzdHJ1Y3QgaW50ZWxfYXRv bWljX3N0YXRlIHsKPiAgCj4gIAkJaW50IGZvcmNlX21pbl9jZGNsazsKPiAgCQlib29sIGZvcmNl X21pbl9jZGNsa19jaGFuZ2VkOwo+ICsJCS8qIHBpcGUgdG8gd2hpY2ggY2QyeCB1cGRhdGUgaXMg c3luY2hyb25pemVkICovCj4gKwkJZW51bSBwaXBlIHBpcGU7Cj4gIAl9IGNkY2xrOwo+ICAKPiAg CWJvb2wgZHBsbF9zZXQsIG1vZGVzZXQ7Cj4gQEAgLTE2OTQsMTIgKzE2OTYsMjEgQEAgdm9pZCBp bnRlbF9pbml0X2NkY2xrX2hvb2tzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdik7 Cj4gIHZvaWQgaW50ZWxfdXBkYXRlX21heF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq ZGV2X3ByaXYpOwo+ICB2b2lkIGludGVsX3VwZGF0ZV9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJp dmF0ZSAqZGV2X3ByaXYpOwo+ICB2b2lkIGludGVsX3VwZGF0ZV9yYXdjbGsoc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2KTsKPiArYm9vbCBpbnRlbF9jZGNsa19uZWVkc19jZDJ4X3Vw ZGF0ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gKwkJCQkgICBjb25zdCBz dHJ1Y3QgaW50ZWxfY2RjbGtfc3RhdGUgKmEsCj4gKwkJCQkgICBjb25zdCBzdHJ1Y3QgaW50ZWxf Y2RjbGtfc3RhdGUgKmIpOwo+ICBib29sIGludGVsX2NkY2xrX25lZWRzX21vZGVzZXQoY29uc3Qg c3RydWN0IGludGVsX2NkY2xrX3N0YXRlICphLAo+ICAJCQkgICAgICAgY29uc3Qgc3RydWN0IGlu dGVsX2NkY2xrX3N0YXRlICpiKTsKPiAgYm9vbCBpbnRlbF9jZGNsa19jaGFuZ2VkKGNvbnN0IHN0 cnVjdCBpbnRlbF9jZGNsa19zdGF0ZSAqYSwKPiAgCQkJIGNvbnN0IHN0cnVjdCBpbnRlbF9jZGNs a19zdGF0ZSAqYik7Cj4gLXZvaWQgaW50ZWxfc2V0X2NkY2xrKHN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICpkZXZfcHJpdiwKPiAtCQkgICAgIGNvbnN0IHN0cnVjdCBpbnRlbF9jZGNsa19zdGF0ZSAq Y2RjbGtfc3RhdGUpOwo+ICt2b2lkCj4gK2ludGVsX3NldF9jZGNsa19wcmVfcGxhbmVfdXBkYXRl KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiArCQkJCSBjb25zdCBzdHJ1Y3Qg aW50ZWxfY2RjbGtfc3RhdGUgKmNkY2xrX3N0YXRlLAo+ICsJCQkJIGVudW0gcGlwZSBwaXBlKTsK PiArdm9pZAo+ICtpbnRlbF9zZXRfY2RjbGtfcG9zdF9wbGFuZV91cGRhdGUoc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICsJCQkJICBjb25zdCBzdHJ1Y3QgaW50ZWxfY2RjbGtf c3RhdGUgKmNkY2xrX3N0YXRlLAo+ICsJCQkJICBlbnVtIHBpcGUgcGlwZSk7Cj4gIHZvaWQgaW50 ZWxfZHVtcF9jZGNsa19zdGF0ZShjb25zdCBzdHJ1Y3QgaW50ZWxfY2RjbGtfc3RhdGUgKmNkY2xr X3N0YXRlLAo+ICAJCQkgICAgY29uc3QgY2hhciAqY29udGV4dCk7Cj4gIAo+IC0tIAo+IDIuMTMu MgoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9pbnRlbC1nZng=