From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 6/6] drm/i915: Clean up gen2 DPLL readout Date: Tue, 19 Mar 2019 16:17:19 +0200 Message-ID: <20190319141719.GB3888@intel.com> References: <20190318165633.28924-1-ville.syrjala@linux.intel.com> <20190318165633.28924-6-ville.syrjala@linux.intel.com> <1f079235-794d-45ec-e57d-688c5ce4ef3a@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 92C0489A60 for ; Tue, 19 Mar 2019 14:17:23 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1f079235-794d-45ec-e57d-688c5ce4ef3a@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBNYXIgMTksIDIwMTkgYXQgMDE6MzQ6MzFQTSArMDAwMCwgVHZydGtvIFVyc3VsaW4g d3JvdGU6Cj4gCj4gT24gMTgvMDMvMjAxOSAxNjo1NiwgVmlsbGUgU3lyamFsYSB3cm90ZToKPiA+ IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4g PiAKPiA+IFRoZSBjdXJyZW50IGdlbjIgRFBMTCByZWFkb3V0IGNvZGU6Cj4gPiAqIGFzc3VtZXMg aTg0NS9pODY1IGhhdmUgTFZEUyB3aGljaCBpcyBub3QgdHJ1ZQo+ID4gKiBhc3N1bWVzIG9ubHkg cGlwZSBCIGNhbiBkcml2ZSBMVkRTICh0cnVlLCBidXQgbWFrZXMKPiA+ICAgIHRoZSBjb2RlIGFw cGVhciBhIGJpdCBtYWdpY2FsKQo+ID4gKiBoYXJkIHRvIHBhcnNlIGluIGdlbmVyYWwKPiA+IAo+ ID4gQ2xlYW4gaXQgdXAgYnkgY2hlY2tpbmcgZm9yIGk4NXggKHRoZSBvbmx5IGdlbjIgcGxhdGZv cm0KPiA+IHdpdGggTFZEUykgYW5kIHJldXNpbmcgaW50ZWxfbHZkc19wb3J0X2VuYWJsZWQoKS4K PiA+IAo+ID4gQ2M6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBsaW51eC5pbnRlbC5j b20+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGlu dXguaW50ZWwuY29tPgo+ID4gLS0tCj4gPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rp c3BsYXkuYyB8IDEwICsrKysrKy0tLS0KPiA+ICAgMSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0aW9u cygrKSwgNCBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3Bs YXkuYwo+ID4gaW5kZXggMmJhNjExODE3NDZkLi45ZjMxZDk0ZmMwNGIgMTAwNjQ0Cj4gPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4gQEAgLTEwODA5LDcgKzEwODA5LDYgQEAg c3RhdGljIHZvaWQgaTl4eF9jcnRjX2Nsb2NrX2dldChzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywK PiA+ICAgewo+ID4gICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGNydGMtPmJhc2UuZGV2Owo+ ID4gICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShkZXYpOwo+ ID4gLQlpbnQgcGlwZSA9IHBpcGVfY29uZmlnLT5jcHVfdHJhbnNjb2RlcjsKPiA+ICAgCXUzMiBk cGxsID0gcGlwZV9jb25maWctPmRwbGxfaHdfc3RhdGUuZHBsbDsKPiA+ICAgCXUzMiBmcDsKPiA+ ICAgCXN0cnVjdCBkcGxsIGNsb2NrOwo+ID4gQEAgLTEwODU4LDEwICsxMDg1NywxMyBAQCBzdGF0 aWMgdm9pZCBpOXh4X2NydGNfY2xvY2tfZ2V0KHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+ID4g ICAJCWVsc2UKPiA+ICAgCQkJcG9ydF9jbG9jayA9IGk5eHhfY2FsY19kcGxsX3BhcmFtcyhyZWZj bGssICZjbG9jayk7Cj4gPiAgIAl9IGVsc2Ugewo+ID4gLQkJdTMyIGx2ZHMgPSBJU19JODMwKGRl dl9wcml2KSA/IDAgOiBJOTE1X1JFQUQoTFZEUyk7Cj4gPiAtCQlib29sIGlzX2x2ZHMgPSAocGlw ZSA9PSAxKSAmJiAobHZkcyAmIExWRFNfUE9SVF9FTik7Cj4gPiArCQllbnVtIHBpcGUgbHZkc19w aXBlOwo+ID4gKwo+ID4gKwkJaWYgKElTX0k4NVgoZGV2X3ByaXYpICYmCj4gPiArCQkgICAgaW50 ZWxfbHZkc19wb3J0X2VuYWJsZWQoZGV2X3ByaXYsIExWRFMsICZsdmRzX3BpcGUpICYmCj4gPiAr CQkgICAgbHZkc19waXBlID09IGNydGMtPnBpcGUpIHsKPiA+ICsJCQl1MzIgbHZkcyA9IEk5MTVf UkVBRChMVkRTKTsKPiA+ICAgCj4gPiAtCQlpZiAoaXNfbHZkcykgewo+ID4gICAJCQljbG9jay5w MSA9IGZmcygoZHBsbCAmIERQTExfRlBBMDFfUDFfUE9TVF9ESVZfTUFTS19JODMwX0xWRFMpID4+ Cj4gPiAgIAkJCQkgICAgICAgRFBMTF9GUEEwMV9QMV9QT1NUX0RJVl9TSElGVCk7Cj4gPiAgIAo+ ID4gCj4gCj4gSSBkZWZlciB0byBkb21haW4gZXhwZXJ0cyBvbiB0aGlzIG9uZS4KClllYWguIFRo aXMgd2Fzbid0IHJlYWxseSBtZWFudCB0byBiZSBwYXJ0IG9mIHRoaXMgc2VyaWVzLiBJdCBqdXN0 CmhhcHBlbmVkIHRvIGxpdmUgaW4gdGhlIHNhbWUgYnJhbmNoIHdoZXJlIEkgaGFkIGFscmVhZHkg dHlwZWQgdXAKc29tZSBvZiB0aGUgaTl4eF9oYXNfcGZpdCgpIGV0Yy4gYW5kIGhlbmNlIGdvdCBw aWdneWJhY2tlZCB0byB0aGUKbGlzdC4KCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxp bmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4