From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 3/3] drm/i915/icl: use previous pll hw
 readout
Date: Fri, 22 Mar 2019 15:09:59 +0200
Message-ID: <20190322130959.GP3888@intel.com>
References: <20190321220257.32638-1-lucas.demarchi@intel.com>
 <20190321220257.32638-4-lucas.demarchi@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by gabe.freedesktop.org (Postfix) with ESMTPS id AF88D6E384
 for <intel-gfx@lists.freedesktop.org>; Fri, 22 Mar 2019 13:10:07 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20190321220257.32638-4-lucas.demarchi@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVGh1LCBNYXIgMjEsIDIwMTkgYXQgMDM6MDI6NTdQTSAtMDcwMCwgTHVjYXMgRGUgTWFyY2hp
IHdyb3RlOgo+IEJ5IHRoZSB0aW1lIGljbF9kZGlfY2xvY2tfZ2V0KCkgaXMgY2FsbGVkIHdlJ3Zl
IGp1c3QgZ290IHRoZSBodyBzdGF0ZQo+IGZyb20gdGhlIHBsbCByZWdpc3RlcnMuIFdlIGRvbid0
IG5lZWQgdG8gcmVhZCB0aGVtIGFnYWluOiB3ZSBjYW4gcmF0aGVyCj4gcmV1c2Ugd2hhdCB3YXMg
Y2FjaGVkIGluIHRoZSBkcGxsX2h3X3N0YXRlLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEx1Y2FzIERl
IE1hcmNoaSA8bHVjYXMuZGVtYXJjaGlAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9k
cm0vaTkxNS9pbnRlbF9kZGkuYyB8IDM5ICsrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0t
Cj4gIDEgZmlsZSBjaGFuZ2VkLCAxOCBpbnNlcnRpb25zKCspLCAyMSBkZWxldGlvbnMoLSkKPiAK
PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMgYi9kcml2ZXJz
L2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+IGluZGV4IGZlNTJhZjlmYTRhYS4uMGVhNWE5N2Rm
ZTlkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gKysr
IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiBAQCAtMTM3MiwyNiArMTM3Miwy
MCBAQCBzdGF0aWMgaW50IGljbF9jYWxjX3RidF9wbGxfbGluayhzdHJ1Y3QgZHJtX2k5MTVfcHJp
dmF0ZSAqZGV2X3ByaXYsCj4gIAl9Cj4gIH0KPiAgCj4gLXN0YXRpYyBpbnQgaWNsX2NhbGNfbWdf
cGxsX2xpbmsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+IC0JCQkJZW51bSBw
b3J0IHBvcnQpCj4gKwo+ICtzdGF0aWMgaW50IGljbF9jYWxjX21nX3BsbF9saW5rKHN0cnVjdCBp
bnRlbF9kcGxsX2h3X3N0YXRlICpzdGF0ZSwgdTMyIHJlZmNsaykKCkluY29uc2lzdGVudCB3aXRo
IHRoZSBjbmwgdmFyaWFudC4KCj4gIHsKPiAtCWVudW0gdGNfcG9ydCB0Y19wb3J0ID0gaW50ZWxf
cG9ydF90b190YyhkZXZfcHJpdiwgcG9ydCk7Cj4gLQl1MzIgbWdfcGxsX2RpdjAsIG1nX2Nsa3Rv
cF9oc2Nsa2N0bDsKPiAtCXUzMiBtMSwgbTJfaW50LCBtMl9mcmFjLCBkaXYxLCBkaXYyLCByZWZj
bGs7Cj4gKwl1MzIgbTEsIG0yX2ludCwgbTJfZnJhYywgZGl2MSwgZGl2MjsKPiAgCXU2NCB0bXA7
Cj4gIAo+IC0JcmVmY2xrID0gZGV2X3ByaXYtPmNkY2xrLmh3LnJlZjsKPiAtCj4gLQltZ19wbGxf
ZGl2MCA9IEk5MTVfUkVBRChNR19QTExfRElWMCh0Y19wb3J0KSk7Cj4gLQltZ19jbGt0b3BfaHNj
bGtjdGwgPSBJOTE1X1JFQUQoTUdfQ0xLVE9QMl9IU0NMS0NUTCh0Y19wb3J0KSk7Cj4gLQo+IC0J
bTEgPSBJOTE1X1JFQUQoTUdfUExMX0RJVjEodGNfcG9ydCkpICYgTUdfUExMX0RJVjFfRkJQUkVE
SVZfTUFTSzsKPiAtCW0yX2ludCA9IG1nX3BsbF9kaXYwICYgTUdfUExMX0RJVjBfRkJESVZfSU5U
X01BU0s7Cj4gLQltMl9mcmFjID0gKG1nX3BsbF9kaXYwICYgTUdfUExMX0RJVjBfRlJBQ05FTl9I
KSA/Cj4gLQkJICAobWdfcGxsX2RpdjAgJiBNR19QTExfRElWMF9GQkRJVl9GUkFDX01BU0spID4+
Cj4gKwltMSA9IHN0YXRlLT5tZ19wbGxfZGl2MSAmIE1HX1BMTF9ESVYxX0ZCUFJFRElWX01BU0s7
Cj4gKwltMl9pbnQgPSBzdGF0ZS0+bWdfcGxsX2RpdjAgJiBNR19QTExfRElWMF9GQkRJVl9JTlRf
TUFTSzsKPiArCW0yX2ZyYWMgPSAoc3RhdGUtPm1nX3BsbF9kaXYwICYgTUdfUExMX0RJVjBfRlJB
Q05FTl9IKSA/Cj4gKwkJICAoc3RhdGUtPm1nX3BsbF9kaXYwICYgTUdfUExMX0RJVjBfRkJESVZf
RlJBQ19NQVNLKSA+Pgo+ICAJCSAgTUdfUExMX0RJVjBfRkJESVZfRlJBQ19TSElGVCA6IDA7Cj4g
IAo+IC0Jc3dpdGNoIChtZ19jbGt0b3BfaHNjbGtjdGwgJiBNR19DTEtUT1AyX0hTQ0xLQ1RMX0hT
RElWX1JBVElPX01BU0spIHsKPiArCXN3aXRjaCAoc3RhdGUtPm1nX2Nsa3RvcDJfaHNjbGtjdGwg
Jgo+ICsJCU1HX0NMS1RPUDJfSFNDTEtDVExfSFNESVZfUkFUSU9fTUFTSykgewo+ICAJY2FzZSBN
R19DTEtUT1AyX0hTQ0xLQ1RMX0hTRElWX1JBVElPXzI6Cj4gIAkJZGl2MSA9IDI7Cj4gIAkJYnJl
YWs7Cj4gQEAgLTE0MDUsMTIgKzEzOTksMTQgQEAgc3RhdGljIGludCBpY2xfY2FsY19tZ19wbGxf
bGluayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAkJZGl2MSA9IDc7Cj4g
IAkJYnJlYWs7Cj4gIAlkZWZhdWx0Ogo+IC0JCU1JU1NJTkdfQ0FTRShtZ19jbGt0b3BfaHNjbGtj
dGwpOwo+ICsJCU1JU1NJTkdfQ0FTRShzdGF0ZS0+bWdfY2xrdG9wMl9oc2Nsa2N0bCk7Cj4gIAkJ
cmV0dXJuIDA7Cj4gIAl9Cj4gIAo+IC0JZGl2MiA9IChtZ19jbGt0b3BfaHNjbGtjdGwgJiBNR19D
TEtUT1AyX0hTQ0xLQ1RMX0RTRElWX1JBVElPX01BU0spID4+Cj4gKwlkaXYyID0gKHN0YXRlLT5t
Z19jbGt0b3AyX2hzY2xrY3RsICYKPiArCQlNR19DTEtUT1AyX0hTQ0xLQ1RMX0RTRElWX1JBVElP
X01BU0spID4+Cj4gIAkJTUdfQ0xLVE9QMl9IU0NMS0NUTF9EU0RJVl9SQVRJT19TSElGVDsKPiAr
Cj4gIAkvKiBkaXYyIHZhbHVlIG9mIDAgaXMgc2FtZSBhcyAxIG1lYW5zIG5vIGRpdiAqLwo+ICAJ
aWYgKGRpdjIgPT0gMCkKPiAgCQlkaXYyID0gMTsKPiBAQCAtMTQ1Nyw5ICsxNDUzLDYgQEAgc3Rh
dGljIHZvaWQgaWNsX2RkaV9jbG9ja19nZXQoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIs
Cj4gIAlzdHJ1Y3QgaW50ZWxfZHBsbF9od19zdGF0ZSAqc3RhdGU7Cj4gIAllbnVtIHBvcnQgcG9y
dCA9IGVuY29kZXItPnBvcnQ7Cj4gIAlpbnQgbGlua19jbG9jayA9IDA7Cj4gLQl1MzIgcGxsX2lk
Owo+IC0KPiAtCXBsbF9pZCA9IGludGVsX2dldF9zaGFyZWRfZHBsbF9pZChkZXZfcHJpdiwgcGlw
ZV9jb25maWctPnNoYXJlZF9kcGxsKTsKPiAgCj4gIAkvKiBGb3IgRERJIHBvcnRzIHdlIGFsd2F5
cyB1c2UgYSBzaGFyZWQgUExMLiAqLwo+ICAJaWYgKFdBUk5fT04oIXBpcGVfY29uZmlnLT5zaGFy
ZWRfZHBsbCkpCj4gQEAgLTE0NzAsMTAgKzE0NjMsMTQgQEAgc3RhdGljIHZvaWQgaWNsX2RkaV9j
bG9ja19nZXQoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4gIAlpZiAoaW50ZWxfcG9y
dF9pc19jb21ib3BoeShkZXZfcHJpdiwgcG9ydCkpIHsKPiAgCQlsaW5rX2Nsb2NrID0gY25sX2Nh
bGNfd3JwbGxfbGluayhkZXZfcHJpdiwgc3RhdGUpOwo+ICAJfSBlbHNlIHsKPiArCQllbnVtIGlu
dGVsX2RwbGxfaWQgcGxsX2lkID0gaW50ZWxfZ2V0X3NoYXJlZF9kcGxsX2lkKGRldl9wcml2LAo+
ICsJCQkJcGlwZV9jb25maWctPnNoYXJlZF9kcGxsKTsKPiArCj4gIAkJaWYgKHBsbF9pZCA9PSBE
UExMX0lEX0lDTF9UQlRQTEwpCj4gIAkJCWxpbmtfY2xvY2sgPSBpY2xfY2FsY190YnRfcGxsX2xp
bmsoZGV2X3ByaXYsIHBvcnQpOwo+ICAJCWVsc2UKPiAtCQkJbGlua19jbG9jayA9IGljbF9jYWxj
X21nX3BsbF9saW5rKGRldl9wcml2LCBwb3J0KTsKPiArCQkJbGlua19jbG9jayA9IGljbF9jYWxj
X21nX3BsbF9saW5rKAo+ICsJCQkJCXN0YXRlLCBkZXZfcHJpdi0+Y2RjbGsuaHcucmVmKTsKPiAg
CX0KPiAgCj4gIGVuZDoKPiAtLSAKPiAyLjIwLjEKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwK
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4
IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4