From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH v3] drm/i915/icl: Fix clockgating issue when
 using scalers
Date: Fri, 22 Mar 2019 15:14:49 +0200
Message-ID: <20190322131449.GQ3888@intel.com>
References: <20190315221838.22444-1-radhakrishna.sripada@intel.com>
 <20190321214431.515-1-radhakrishna.sripada@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 2BCAF6E38C
 for <intel-gfx@lists.freedesktop.org>; Fri, 22 Mar 2019 13:14:53 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20190321214431.515-1-radhakrishna.sripada@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVGh1LCBNYXIgMjEsIDIwMTkgYXQgMDI6NDQ6MzFQTSAtMDcwMCwgUmFkaGFrcmlzaG5hIFNy
aXBhZGEgd3JvdGU6Cj4gRml4ZXMgdGhlIGNsb2NrLWdhdGluZyBpc3N1ZSB3aGVuIHBpcGUgc2Nh
bGluZyBpcyBlbmFibGVkLgo+IChMaW5lYWdlICMyMDA2NjA0MzEyKQo+IAo+IFYyOiBGaXggdHlw
byBpbiBoZWFkbGluZShDaHJpcykKPiAgICAgSGFuZGxlIHRoZSBub24gZG91YmxlIGJ1ZmZlcmVk
IG5hdHVyZSBvZiB0aGUgcmVnaXN0ZXIoVmlsbGUpCj4gVjM6IEZpeCBjaGVja3BhdGNoIHdhcm5p
bmcuIEJBVCBmYWlsdXJlIGZvciBWMiBvbiBnZW4zIGxvb2tzIHVucmVsYXRlZC4KPiAKPiBDYzog
Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gQ2M6IFZpbGxlIFN5cmph
bGEgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IENjOiBSb2RyaWdvIFZpdmkgPHJv
ZHJpZ28udml2aUBpbnRlbC5jb20+Cj4gQ2M6IEFkaXR5YSBTd2FydXAgPGFkaXR5YS5zd2FydXBA
aW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IFJhZGhha3Jpc2huYSBTcmlwYWRhIDxyYWRoYWty
aXNobmEuc3JpcGFkYUBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2lu
dGVsX2Rpc3BsYXkuYyB8IDQzICsrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0KPiAgMSBmaWxl
IGNoYW5nZWQsIDI3IGluc2VydGlvbnMoKyksIDE2IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1n
aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9k
cm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBpbmRleCA3YzE1YjQyOGZmODQuLmNmYTE5YWUxMmUy
MiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiAr
KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBAQCAtNDY5LDEzICs0
NjksMjIgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBpbnRlbF9saW1pdCBpbnRlbF9saW1pdHNfYnh0
ID0gewo+ICBzdGF0aWMgdm9pZAo+ICBza2xfd2FfY2xrZ2F0ZShzdHJ1Y3QgZHJtX2k5MTVfcHJp
dmF0ZSAqZGV2X3ByaXYsIGludCBwaXBlLCBib29sIGVuYWJsZSkKPiAgewo+ICsJdTMyIHZhbCA9
IDA7Cj4gKwo+ICsJLyoKPiArCSAqIFdhXzIwMDY2MDQzMTI6aWNsCj4gKwkgKi8KPiArCWlmIChJ
U19JQ0VMQUtFKGRldl9wcml2KSkKPiArCQl2YWwgPSBEUEZSX0dBVElOR19ESVM7Cj4gKwllbHNl
Cj4gKwkJdmFsID0gRFVQUzFfR0FUSU5HX0RJUyB8IERVUFMyX0dBVElOR19ESVM7Cj4gKwo+ICsJ
LyogV0EgRGlzcGxheSAjMDgyNzogR2VuOTphbGwgKi8KCllvdSdyZSBub3cgY29uZmxhdGluZyB0
d28gd29ya2Fyb3VuZCBhbmQgc3BsaXR0aW5nIHRoZWlyIGltcGxlbWVudGF0aW9uCmJldHdlZW4g
dHdvIGZ1bmN0aW9ucyBpbiBhIGNvbmZ1c2luZyB3YXkuIEJldHRlciB0byBrZWVwIHRoZW0gc2Vw
YXJhdGUKSU1PLgoKPiAgCWlmIChlbmFibGUpCj4gLQkJSTkxNV9XUklURShDTEtHQVRFX0RJU19Q
U0wocGlwZSksCj4gLQkJCSAgIERVUFMxX0dBVElOR19ESVMgfCBEVVBTMl9HQVRJTkdfRElTKTsK
PiArCQlJOTE1X1dSSVRFKENMS0dBVEVfRElTX1BTTChwaXBlKSwgdmFsKTsKPiAgCWVsc2UKPiAg
CQlJOTE1X1dSSVRFKENMS0dBVEVfRElTX1BTTChwaXBlKSwKPiAtCQkJICAgSTkxNV9SRUFEKENM
S0dBVEVfRElTX1BTTChwaXBlKSkgJgo+IC0JCQkgICB+KERVUFMxX0dBVElOR19ESVMgfCBEVVBT
Ml9HQVRJTkdfRElTKSk7Cj4gKwkJCSAgIEk5MTVfUkVBRChDTEtHQVRFX0RJU19QU0wocGlwZSkp
ICYgfnZhbCk7Cj4gIH0KPiAgCj4gIHN0YXRpYyBib29sCj4gQEAgLTU0ODEsMTQgKzU0OTAsMTgg
QEAgc3RhdGljIGJvb2wgaHN3X3Bvc3RfdXBkYXRlX2VuYWJsZV9pcHMoY29uc3Qgc3RydWN0IGlu
dGVsX2NydGNfc3RhdGUgKm9sZF9jcnRjX3MKPiAgCXJldHVybiAhb2xkX2NydGNfc3RhdGUtPmlw
c19lbmFibGVkOwo+ICB9Cj4gIAo+IC1zdGF0aWMgYm9vbCBuZWVkc19udjEyX3dhKHN0cnVjdCBk
cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAtCQkJICBjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0
Y19zdGF0ZSAqY3J0Y19zdGF0ZSkKPiArc3RhdGljIGJvb2wgc2tsX25lZWRzX2Nsa193YShzdHJ1
Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gKwkJCSAgICAgY29uc3Qgc3RydWN0IGlu
dGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUpCj4gIHsKPiAtCWlmICghY3J0Y19zdGF0ZS0+bnYx
Ml9wbGFuZXMpCj4gLQkJcmV0dXJuIGZhbHNlOwo+IC0KPiAgCS8qIFdBIERpc3BsYXkgIzA4Mjc6
IEdlbjk6YWxsICovCj4gLQlpZiAoSVNfR0VOKGRldl9wcml2LCA5KSAmJiAhSVNfR0VNSU5JTEFL
RShkZXZfcHJpdikpCj4gKwlpZiAoISFjcnRjX3N0YXRlLT5udjEyX3BsYW5lcyAmJiBJU19HRU4o
ZGV2X3ByaXYsIDkpICYmCj4gKwkgICAgIUlTX0dFTUlOSUxBS0UoZGV2X3ByaXYpKQo+ICsJCXJl
dHVybiB0cnVlOwo+ICsKPiArCS8qCj4gKwkgKiBXYV8yMDA2NjA0MzEyOmljbAo+ICsJICovCj4g
KwlpZiAoSVNfSUNFTEFLRShkZXZfcHJpdikgJiYgY3J0Y19zdGF0ZS0+cGNoX3BmaXQuZW5hYmxl
ZCkKPiAgCQlyZXR1cm4gdHJ1ZTsKPiAgCj4gIAlyZXR1cm4gZmFsc2U7Cj4gQEAgLTU1MjcsOSAr
NTU0MCw4IEBAIHN0YXRpYyB2b2lkIGludGVsX3Bvc3RfcGxhbmVfdXBkYXRlKHN0cnVjdCBpbnRl
bF9jcnRjX3N0YXRlICpvbGRfY3J0Y19zdGF0ZSkKPiAgCQkJaW50ZWxfcG9zdF9lbmFibGVfcHJp
bWFyeSgmY3J0Yy0+YmFzZSwgcGlwZV9jb25maWcpOwo+ICAJfQo+ICAKPiAtCS8qIERpc3BsYXkg
V0EgODI3ICovCj4gLQlpZiAobmVlZHNfbnYxMl93YShkZXZfcHJpdiwgb2xkX2NydGNfc3RhdGUp
ICYmCj4gLQkgICAgIW5lZWRzX252MTJfd2EoZGV2X3ByaXYsIHBpcGVfY29uZmlnKSkgewo+ICsJ
aWYgKHNrbF9uZWVkc19jbGtfd2EoZGV2X3ByaXYsIG9sZF9jcnRjX3N0YXRlKSAmJgo+ICsJICAg
ICFza2xfbmVlZHNfY2xrX3dhKGRldl9wcml2LCBwaXBlX2NvbmZpZykpIHsKPiAgCQlza2xfd2Ff
Y2xrZ2F0ZShkZXZfcHJpdiwgY3J0Yy0+cGlwZSwgZmFsc2UpOwo+ICAJfQo+ICB9Cj4gQEAgLTU1
NjYsOSArNTU3OCw4IEBAIHN0YXRpYyB2b2lkIGludGVsX3ByZV9wbGFuZV91cGRhdGUoc3RydWN0
IGludGVsX2NydGNfc3RhdGUgKm9sZF9jcnRjX3N0YXRlLAo+ICAJCQlpbnRlbF9zZXRfY3B1X2Zp
Zm9fdW5kZXJydW5fcmVwb3J0aW5nKGRldl9wcml2LCBjcnRjLT5waXBlLCBmYWxzZSk7Cj4gIAl9
Cj4gIAo+IC0JLyogRGlzcGxheSBXQSA4MjcgKi8KPiAtCWlmICghbmVlZHNfbnYxMl93YShkZXZf
cHJpdiwgb2xkX2NydGNfc3RhdGUpICYmCj4gLQkgICAgbmVlZHNfbnYxMl93YShkZXZfcHJpdiwg
cGlwZV9jb25maWcpKSB7Cj4gKwlpZiAoIXNrbF9uZWVkc19jbGtfd2EoZGV2X3ByaXYsIG9sZF9j
cnRjX3N0YXRlKSAmJgo+ICsJICAgIHNrbF9uZWVkc19jbGtfd2EoZGV2X3ByaXYsIHBpcGVfY29u
ZmlnKSkgewo+ICAJCXNrbF93YV9jbGtnYXRlKGRldl9wcml2LCBjcnRjLT5waXBlLCB0cnVlKTsK
PiAgCX0KPiAgCj4gLS0gCj4gMi4yMC4wLnJjMi43Lmc5NjU3OThkMWYyOTkKCi0tIApWaWxsZSBT
eXJqw6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au
b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwt
Z2Z4