From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/3] drm/i915: Handle YUV subpixel support better Date: Fri, 22 Mar 2019 16:08:33 +0200 Message-ID: <20190322140833.GW3888@intel.com> References: <20190322135954.20434-1-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 15C06895C4 for ; Fri, 22 Mar 2019 14:08:37 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190322135954.20434-1-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBNYXIgMjIsIDIwMTkgYXQgMDI6NTk6NTJQTSArMDEwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gWTQxeCBmb3JtYXRzIGlzIGEgNDo0OjQgZm9ybWF0LCBzbyBpdCBjYW4gYmUg YWRkcmVzc2VkIHdpdGggcGl4ZWwgbGV2ZWwgYWNjdXJhY3kuCj4gTWVhbndoaWxlIGl0IHNlZW1z IHRoYXQgd2hpbGUgcm90YXRpbmcgWVVZViA0OjI6MiBmb3JtYXRzIG5lZWQgYSBtdWx0aXBsZSBv ZiAyCj4gZm9yIHdpZHRoIGFuZCBoZWlnaHQsIG90aGVyd2lzZSBjb3JydXB0aW9uIG9jY3Vycy4K PiAKPiBGb3IgWVVWIDQ6MjoyLCB0aGUgc3BlYyBzYXlzIHRoYXQgdy9oIHNob3VsZCBhbHdheXMg YmUgZXZlbiwgYnV0IHdlIGdldAo+IGF3YXkgd2l0aCBvZGQgaGVpZ2h0IHdoaWxlIHVucm90YXRl ZC4gV2hlbiByb3RhdGluZyBpdCBzZWVtcyBjb3JydXB0aW9uCj4gb2NjdXJzIHdpdGggYW4gb2Rk IHgveSwgYW5kIHcvaCBzaG91bGQgYWx3YXlzIGJlIGV2ZW4uCj4gSnVzdCB0byBiZSBjb21wbGV0 ZWx5IHBhcmFub2lkLCByZWplY3Qgb2RkIHgveSB3L2ggd2hlbiByb3RhdGluZyA5MC8yNzAuCj4g Cj4gU2lnbmVkLW9mZi1ieTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxp bnV4LmludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRl LmMgfCAyOSArKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwg MTkgaW5zZXJ0aW9ucygrKSwgMTAgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nwcml0ZS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfc3ByaXRlLmMKPiBpbmRleCAzZjIwNTVmNzBkMDUuLmFjYTk4NzM1NjE5NCAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX3Nwcml0ZS5jCj4gQEAgLTI2OSw3ICsyNjksOCBAQCBpbnQgaW50 ZWxfcGxhbmVfY2hlY2tfc3JjX2Nvb3JkaW5hdGVzKHN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAq cGxhbmVfc3RhdGUpCj4gIHsKPiAgCWNvbnN0IHN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiID0g cGxhbmVfc3RhdGUtPmJhc2UuZmI7Cj4gIAlzdHJ1Y3QgZHJtX3JlY3QgKnNyYyA9ICZwbGFuZV9z dGF0ZS0+YmFzZS5zcmM7Cj4gLQl1MzIgc3JjX3gsIHNyY195LCBzcmNfdywgc3JjX2g7Cj4gKwl1 MzIgc3JjX3gsIHNyY195LCBzcmNfdywgc3JjX2gsIGhzdWIsIHZzdWI7Cj4gKwlib29sIHJvdGF0 ZWQgPSBkcm1fcm90YXRpb25fOTBfb3JfMjcwKHBsYW5lX3N0YXRlLT5iYXNlLnJvdGF0aW9uKTsK PiAgCj4gIAkvKgo+ICAJICogSGFyZHdhcmUgZG9lc24ndCBoYW5kbGUgc3VicGl4ZWwgY29vcmRp bmF0ZXMuCj4gQEAgLTI4NywxOCArMjg4LDI2IEBAIGludCBpbnRlbF9wbGFuZV9jaGVja19zcmNf Y29vcmRpbmF0ZXMoc3RydWN0IGludGVsX3BsYW5lX3N0YXRlICpwbGFuZV9zdGF0ZSkKPiAgCXNy Yy0+eTEgPSBzcmNfeSA8PCAxNjsKPiAgCXNyYy0+eTIgPSAoc3JjX3kgKyBzcmNfaCkgPDwgMTY7 Cj4gIAo+IC0JaWYgKGZiLT5mb3JtYXQtPmlzX3l1diAmJgo+IC0JICAgIChzcmNfeCAmIDEgfHwg c3JjX3cgJiAxKSkgewo+IC0JCURSTV9ERUJVR19LTVMoInNyYyB4L3cgKCV1LCAldSkgbXVzdCBi ZSBhIG11bHRpcGxlIG9mIDIgZm9yIFlVViBwbGFuZXNcbiIsCj4gLQkJCSAgICAgIHNyY194LCBz cmNfdyk7Cj4gKwlpZiAoIWZiLT5mb3JtYXQtPmlzX3l1dikKPiArCQlyZXR1cm4gMDsKPiArCj4g KwkvKiBZVVYgc3BlY2lmaWMgY2hlY2tzICovCj4gKwlpZiAoIXJvdGF0ZWQpIHsKPiArCQloc3Vi ID0gZmItPmZvcm1hdC0+aHN1YjsKPiArCQl2c3ViID0gZmItPmZvcm1hdC0+dnN1YjsKPiArCX0g ZWxzZSB7CgpUaGlzIGNvdWxkIG1heWJlIHVzZSBhIGNvbW1lbnQgb2Ygc29tZSBzb3J0LiBCdXQg Y2FuJ3QgdGhpbmsgb2Ygb25lCnJpZ2h0IG5vdyBzbyBtZWguCgpSZXZpZXdlZC1ieTogVmlsbGUg U3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KCj4gKwkJaHN1YiA9IHZz dWIgPSBtYXgoZmItPmZvcm1hdC0+aHN1YiwgZmItPmZvcm1hdC0+dnN1Yik7Cj4gKwl9Cj4gKwo+ ICsJaWYgKHNyY194ICUgaHN1YiB8fCBzcmNfdyAlIGhzdWIpIHsKPiArCQlEUk1fREVCVUdfS01T KCJzcmMgeC93ICgldSwgJXUpIG11c3QgYmUgYSBtdWx0aXBsZSBvZiAldSBmb3IgJXNZVVYgcGxh bmVzXG4iLAo+ICsJCQkgICAgICBzcmNfeCwgc3JjX3csIGhzdWIsIHJvdGF0ZWQgPyAicm90YXRl ZCAiIDogIiIpOwo+ICAJCXJldHVybiAtRUlOVkFMOwo+ICAJfQo+ICAKPiAtCWlmIChmYi0+Zm9y bWF0LT5pc195dXYgJiYKPiAtCSAgICBmYi0+Zm9ybWF0LT5udW1fcGxhbmVzID4gMSAmJgo+IC0J ICAgIChzcmNfeSAmIDEgfHwgc3JjX2ggJiAxKSkgewo+IC0JCURSTV9ERUJVR19LTVMoInNyYyB5 L2ggKCV1LCAldSkgbXVzdCBiZSBhIG11bHRpcGxlIG9mIDIgZm9yIHBsYW5hciBZVVYgcGxhbmVz XG4iLAo+IC0JCQkgICAgICBzcmNfeSwgc3JjX2gpOwo+ICsJaWYgKHNyY195ICUgdnN1YiB8fCBz cmNfaCAlIHZzdWIpIHsKPiArCQlEUk1fREVCVUdfS01TKCJzcmMgeS9oICgldSwgJXUpIG11c3Qg YmUgYSBtdWx0aXBsZSBvZiAldSBmb3IgJXNZVVYgcGxhbmVzXG4iLAo+ICsJCQkgICAgICBzcmNf eSwgc3JjX2gsIHZzdWIsIHJvdGF0ZWQgPyAicm90YXRlZCAiIDogIiIpOwo+ICAJCXJldHVybiAt RUlOVkFMOwo+ICAJfQo+ICAKPiAtLSAKPiAyLjIwLjEKPiAKPiBfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJ bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50 ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4