From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 2/2] drm/i915: Skip object locking around a no-op set-domain ioctl Date: Fri, 22 Mar 2019 16:28:37 +0200 Message-ID: <20190322142837.GY3888@intel.com> References: <20190321161908.8007-1-chris@chris-wilson.co.uk> <20190321161908.8007-2-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8C0AB6E3A4 for ; Fri, 22 Mar 2019 14:28:40 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190321161908.8007-2-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBNYXIgMjEsIDIwMTkgYXQgMDQ6MTk6MDhQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IElmIHdlIGFyZSBhbHJlYWR5IGluIHRoZSBkZXNpcmVkIHdyaXRlIGRvbWFpbiBvZiBh IHNldC1kb21haW4gaW9jdGwsCj4gdGhlbiB0aGVyZSBpcyBub3RoaW5nIGZvciB1cyB0byBkbyBh bmQgd2UgY2FuIHF1aWNrbHkgcmV0dXJuIGJhY2sgdG8KPiB1c2Vyc3BhY2UsIGF2b2lkaW5nIGFu eSBsb2NrIGNvbnRlbnRpb24uIEJ5IHJlY29nbmlzaW5nIHRoYXQgdGhlCj4gd3JpdGVfZG9tYWlu IGlzIGFsd2F5cyBhIHN1YnNldCBvZiB0aGUgcmVhZF9kb21haW5zLCBhbmQgZXhjbHVkaW5nIHRo ZQo+IG5vLW9wIGNhc2Ugb2YgcmVxdWlyaW5nIDAgcmVhZF9kb21haW5zIGluIHRoZSBpb2N0bCwg d2UgY2FuIGluZmVyIGlmIHRoZQo+IGN1cnJlbnQgd3JpdGVfZG9tYWluIG1hdGNoZXMgdGhlIHRh cmdldCByZWFkX2RvbWFpbnMsIHRoZXJlIGlzIG5vdGhpbmcKPiBmb3IgdXMgdG8gZG8uCj4gCj4g U2Vjb25kYXJ5IGFzcGVjdCBvZiB0aGlzIGlzIHRoYXQgd2UgdW5kbyB0aGUgYXJiaXRyYXJ5IGZl dGNoaW5nIGFuZAo+IHBvdGVudGlhbCBmbHVzaGluZyBvZiBhbGwgcGFnZXMgZm9yIGEgc2V0LWRv bWFpbigud3JpdGU9Q1BVKSBjYWxsIG9uIGEKPiBmcmVzaCBvYmplY3QgLS0gd2hpY2ggd2FzIGlu dHJvZHVjZWQgc2ltcGx5IGJlY2F1c2Ugd2UgZG8gdGhlIGdldC1wYWdlcwo+IGJlZm9yZSB0YWtp bmcgdGhlIHN0cnVjdF9tdXRleC4KPiAKPiBSZWZlcmVuY2VzOiA0MGU2MmQ1ZDZiZTggKCJkcm0v aTkxNTogQWNxdWlyZSB0aGUgYmFja2luZyBzdG9yYWdlIG91dHNpZGUgb2Ygc3RydWN0X211dGV4 IGluIHNldC1kb21haW4iKQo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hy aXMtd2lsc29uLmNvLnVrPgo+IENjOiBKb29uYXMgTGFodGluZW4gPGpvb25hcy5sYWh0aW5lbkBs aW51eC5pbnRlbC5jb20+Cj4gQ2M6IE1hdHRoZXcgQXVsZCA8bWF0dGhldy53aWxsaWFtLmF1bGRA Z21haWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jIHwgMjYg KysrKysrKysrKysrKysrKysrKysrKystLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDIzIGluc2VydGlv bnMoKyksIDMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZ2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gaW5kZXgg NzIzNzRlOTUyZTRiLi4zNmY1NTcwMDIwMDUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9nZW0uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMK PiBAQCAtMTQ4NCwxNyArMTQ4NCwzNyBAQCBpOTE1X2dlbV9zZXRfZG9tYWluX2lvY3RsKHN0cnVj dCBkcm1fZGV2aWNlICpkZXYsIHZvaWQgKmRhdGEsCj4gIAlpZiAoKHdyaXRlX2RvbWFpbiB8IHJl YWRfZG9tYWlucykgJiBJOTE1X0dFTV9HUFVfRE9NQUlOUykKPiAgCQlyZXR1cm4gLUVJTlZBTDsK PiAgCj4gLQkvKiBIYXZpbmcgc29tZXRoaW5nIGluIHRoZSB3cml0ZSBkb21haW4gaW1wbGllcyBp dCdzIGluIHRoZSByZWFkCj4gKwkvKgo+ICsJICogSGF2aW5nIHNvbWV0aGluZyBpbiB0aGUgd3Jp dGUgZG9tYWluIGltcGxpZXMgaXQncyBpbiB0aGUgcmVhZAo+ICAJICogZG9tYWluLCBhbmQgb25s eSB0aGF0IHJlYWQgZG9tYWluLiAgRW5mb3JjZSB0aGF0IGluIHRoZSByZXF1ZXN0Lgo+ICAJICov Cj4gLQlpZiAod3JpdGVfZG9tYWluICE9IDAgJiYgcmVhZF9kb21haW5zICE9IHdyaXRlX2RvbWFp bikKPiArCWlmICh3cml0ZV9kb21haW4gJiYgcmVhZF9kb21haW5zICE9IHdyaXRlX2RvbWFpbikK PiAgCQlyZXR1cm4gLUVJTlZBTDsKPiAgCj4gKwlpZiAoIXJlYWRfZG9tYWlucykKPiArCQlyZXR1 cm4gMDsKCkhvcGVmdWxseSBubyBvbmUgaXMgcmVseWluZyBvbiByZWFkX2RvbWFpbnM9PTAgbWVh bmluZyBjcHUgZG9tYWluLgpUaGF0IHNlZW1zIHRvIGJlIGhvdyB0aGlzIHdhcyBoYW5kbGVkIGJl Zm9yZS4KCk9yIG1heWJlIHdlIHdhbnQgLUVJVk5BTCBoZXJlPwoKPiArCj4gIAlvYmogPSBpOTE1 X2dlbV9vYmplY3RfbG9va3VwKGZpbGUsIGFyZ3MtPmhhbmRsZSk7Cj4gIAlpZiAoIW9iaikKPiAg CQlyZXR1cm4gLUVOT0VOVDsKPiAgCj4gLQkvKiBUcnkgdG8gZmx1c2ggdGhlIG9iamVjdCBvZmYg dGhlIEdQVSB3aXRob3V0IGhvbGRpbmcgdGhlIGxvY2suCj4gKwkvKgo+ICsJICogQWxyZWFkeSBp biB0aGUgZGVzaXJlZCB0YXJnZXQgd3JpdGUgZG9tYWluPyBOb3RoaW5nIGZvciB1cyB0byEKPiAr CSAqCj4gKwkgKiBXZSBhcHBseSBhIGxpdHRsZSBiaXQgb2YgY3VubmluZyBoZXJlIHRvIGNhdGNo IGEgYnJvYWRlciBzZXQgb2YKPiArCSAqIG5vLW9wcy4gSWYgb2JqLT53cml0ZV9kb21haW4gaXMg c2V0LCB3ZSBtdXN0IGJlIGluIHRoZSBzYW1lCj4gKwkgKiBvYmotPnJlYWRfZG9tYWlucywgYW5k IG9ubHkgdGhhdCBkb21haW4uIFRoZXJlZm9yZSwgaWYgdGhhdAo+ICsJICogb2JqLT53cml0ZV9k b21haW4gbWF0Y2hlcyB0aGUgcmVxdWVzdCByZWFkX2RvbWFpbnMsIHdlIGFyZQo+ICsJICogYWxy ZWFkeSBpbiB0aGUgc2FtZSByZWFkL3dyaXRlIGRvbWFpbiBhbmQgY2FuIHNraXAgdGhlIG9wZXJh dGlvbiwKPiArCSAqIHdpdGhvdXQgaGF2aW5nIHRvIGZ1cnRoZXIgY2hlY2sgdGhlIHJlcXVlc3Rl ZCB3cml0ZV9kb21haW4uCj4gKwkgKi8KPiArCWlmIChSRUFEX09OQ0Uob2JqLT53cml0ZV9kb21h aW4pID09IHJlYWRfZG9tYWlucykgewo+ICsJCWVyciA9IDA7Cj4gKwkJZ290byBvdXQ7Cj4gKwl9 CgpIYXJkIHRvIGFyZ3VlIHdpdGggdGhhdCBsb2dpYy4gCgpIYXZlbid0IHBhaWQgdG9vIG11Y2gg YXR0ZW50aW9uIHRvIHRoaXMgYXJlYSBsYXRlbHkgYnV0IHRoaXMKbWFrZXMgc2Vuc2UgdG8gbWUu CgpSZXZpZXdlZC1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVs LmNvbT4KCj4gKwo+ICsJLyoKPiArCSAqIFRyeSB0byBmbHVzaCB0aGUgb2JqZWN0IG9mZiB0aGUg R1BVIHdpdGhvdXQgaG9sZGluZyB0aGUgbG9jay4KPiAgCSAqIFdlIHdpbGwgcmVwZWF0IHRoZSBm bHVzaCBob2xkaW5nIHRoZSBsb2NrIGluIHRoZSBub3JtYWwgbWFubmVyCj4gIAkgKiB0byBjYXRj aCBjYXNlcyB3aGVyZSB3ZSBhcmUgZ2F6dW1wZWQuCj4gIAkgKi8KPiAtLSAKPiAyLjIwLjEKPiAK PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVs LWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0t IApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vaW50ZWwtZ2Z4