From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/6] drm/i915: Refactor EDID fixed mode search Date: Fri, 22 Mar 2019 18:48:03 +0200 Message-ID: <20190322164803.GF3888@intel.com> References: <20190321132446.22394-1-ville.syrjala@linux.intel.com> <87a7hncnrr.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6D0536E1B3 for ; Fri, 22 Mar 2019 16:48:07 +0000 (UTC) Content-Disposition: inline In-Reply-To: <87a7hncnrr.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBNYXIgMjIsIDIwMTkgYXQgMTA6MzI6NDBBTSArMDIwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gT24gVGh1LCAyMSBNYXIgMjAxOSwgVmlsbGUgU3lyamFsYSA8dmlsbGUuc3lyamFsYUBs aW51eC5pbnRlbC5jb20+IHdyb3RlOgo+ID4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5z eXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+Cj4gPiBCb3RoIExWRFMgYW5kIGVEUCBoYXZlIHRo ZSBzYW1lIGNvZGUgdG8gbG9vayB1cCB0aGUgcHJlZmVycmVkIG1vZGUKPiA+IGZyb20gdGhlIGNv bm5lY3RvciBwcm9iZWRfbW9kZXMgbGlzdC4gTW92ZSB0aGUgY29kZSB0byBhIGNvbW1vbgo+ID4g bG9jYXRpb24uCj4gPgo+ID4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5z eXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiAKPiBUaGlzIHNlcmllcyBpcyBzb21ldGhpbmcgSSd2 ZSBiZWVuIG1lYW5pbmcgdG8gZG8gZm9yIGFnZXMuCgpJIHRoaW5rIEkgaGFkIHRoZXNlIG1vcmUg b3IgbGVzcyB0eXBlZCB1cCBmb3IgYSBmZXcgeWVhcnMgbm93LgpGaW5hbGx5IGdvdCBhbiBleGN1 c2UgKHRoZSBidWcpIHRvIGZpbmlzaCB0aGVtIDspCgpTZXJpZXMgcHVzaGVkIHRvIGRpbnEuIFRo YW5rcyBmb3IgdGhlIHJldmlld3MvYWNrcyBldmVyeW9uZS4KCj4gVGhhbmtzIGZvcgo+IGRvaW5n IGl0LiBPdGhlcnMgYmVhdCBtZSB0byByZXZpZXcsIEkgb25seSBnbGFuY2VkIHRocm91Z2guIE9u IHRoZQo+IHNlcmllcywKPiAKPiBBY2tlZC1ieTogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGlu dGVsLmNvbT4KPiAKPiAKPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rw LmMgICAgfCAxMyArKystLS0tLS0tLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZHJ2LmggICB8ICAyICsrCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHZkcy5jICB8 IDE0ICsrKy0tLS0tLS0tLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcGFuZWwu YyB8IDI3ICsrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ID4gIDQgZmlsZXMgY2hhbmdlZCwg MzUgaW5zZXJ0aW9ucygrKSwgMjEgZGVsZXRpb25zKC0pCj4gPgo+ID4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kcC5jCj4gPiBpbmRleCA3YzA0M2U4ZjYyOTguLjUwOTZlOTlmZmFhZCAxMDA2NDQKPiA+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2RwLmMKPiA+IEBAIC03MDU3LDcgKzcwNTcsNiBAQCBzdGF0aWMgYm9v bCBpbnRlbF9lZHBfaW5pdF9jb25uZWN0b3Ioc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwKPiA+ ICAJc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKmZpeGVkX21vZGUgPSBOVUxMOwo+ID4gIAlzdHJ1 Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqZG93bmNsb2NrX21vZGUgPSBOVUxMOwo+ID4gIAlib29sIGhh c19kcGNkOwo+ID4gLQlzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqc2NhbjsKPiA+ICAJZW51bSBw aXBlIHBpcGUgPSBJTlZBTElEX1BJUEU7Cj4gPiAgCWludGVsX3dha2VyZWZfdCB3YWtlcmVmOwo+ ID4gIAlzdHJ1Y3QgZWRpZCAqZWRpZDsKPiA+IEBAIC03MTEwLDE1ICs3MTA5LDkgQEAgc3RhdGlj IGJvb2wgaW50ZWxfZWRwX2luaXRfY29ubmVjdG9yKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAs Cj4gPiAgCX0KPiA+ICAJaW50ZWxfY29ubmVjdG9yLT5lZGlkID0gZWRpZDsKPiA+ICAKPiA+IC0J LyogcHJlZmVyIGZpeGVkIG1vZGUgZnJvbSBFRElEIGlmIGF2YWlsYWJsZSAqLwo+ID4gLQlsaXN0 X2Zvcl9lYWNoX2VudHJ5KHNjYW4sICZjb25uZWN0b3ItPnByb2JlZF9tb2RlcywgaGVhZCkgewo+ ID4gLQkJaWYgKChzY2FuLT50eXBlICYgRFJNX01PREVfVFlQRV9QUkVGRVJSRUQpKSB7Cj4gPiAt CQkJZml4ZWRfbW9kZSA9IGRybV9tb2RlX2R1cGxpY2F0ZShkZXYsIHNjYW4pOwo+ID4gLQkJCWRv d25jbG9ja19tb2RlID0gaW50ZWxfZHBfZHJyc19pbml0KAo+ID4gLQkJCQkJCWludGVsX2Nvbm5l Y3RvciwgZml4ZWRfbW9kZSk7Cj4gPiAtCQkJYnJlYWs7Cj4gPiAtCQl9Cj4gPiAtCX0KPiA+ICsJ Zml4ZWRfbW9kZSA9IGludGVsX3BhbmVsX2VkaWRfZml4ZWRfbW9kZShpbnRlbF9jb25uZWN0b3Ip Owo+ID4gKwlpZiAoZml4ZWRfbW9kZSkKPiA+ICsJCWRvd25jbG9ja19tb2RlID0gaW50ZWxfZHBf ZHJyc19pbml0KGludGVsX2Nvbm5lY3RvciwgZml4ZWRfbW9kZSk7Cj4gPiAgCj4gPiAgCS8qIGZh bGxiYWNrIHRvIFZCVCBpZiBhdmFpbGFibGUgZm9yIGVEUCAqLwo+ID4gIAlpZiAoIWZpeGVkX21v ZGUgJiYgZGV2X3ByaXYtPnZidC5sZnBfbHZkc192YnRfbW9kZSkgewo+ID4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZHJ2LmgKPiA+IGluZGV4IDRkN2FlNTc5ZmM5Mi4uNGQ0NWVkNmFhMDk3IDEwMDY0NAo+ ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiA+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gPiBAQCAtMjE1OCw2ICsyMTU4LDggQEAgZXh0 ZXJuIHN0cnVjdCBkcm1fZGlzcGxheV9tb2RlICppbnRlbF9maW5kX3BhbmVsX2Rvd25jbG9jaygK PiA+ICAJCQkJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ID4gIAkJCQlzdHJ1 Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqZml4ZWRfbW9kZSwKPiA+ICAJCQkJc3RydWN0IGRybV9jb25u ZWN0b3IgKmNvbm5lY3Rvcik7Cj4gPiArc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKgo+ID4gK2lu dGVsX3BhbmVsX2VkaWRfZml4ZWRfbW9kZShzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICpjb25uZWN0 b3IpOwo+ID4gIAo+ID4gICNpZiBJU19FTkFCTEVEKENPTkZJR19CQUNLTElHSFRfQ0xBU1NfREVW SUNFKQo+ID4gIGludCBpbnRlbF9iYWNrbGlnaHRfZGV2aWNlX3JlZ2lzdGVyKHN0cnVjdCBpbnRl bF9jb25uZWN0b3IgKmNvbm5lY3Rvcik7Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfbHZkcy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHZkcy5jCj4g PiBpbmRleCA4NDU3OTJhYTBhYmUuLjA2ODZhZDFmMTJkZiAxMDA2NDQKPiA+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2x2ZHMuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfbHZkcy5jCj4gPiBAQCAtODEwLDcgKzgxMCw2IEBAIHZvaWQgaW50ZWxfbHZkc19p bml0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiA+ICAJc3RydWN0IGludGVs X2Nvbm5lY3RvciAqaW50ZWxfY29ubmVjdG9yOwo+ID4gIAlzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAq Y29ubmVjdG9yOwo+ID4gIAlzdHJ1Y3QgZHJtX2VuY29kZXIgKmVuY29kZXI7Cj4gPiAtCXN0cnVj dCBkcm1fZGlzcGxheV9tb2RlICpzY2FuOyAvKiAqbW9kZXMsICpiaW9zX21vZGU7ICovCj4gPiAg CXN0cnVjdCBkcm1fZGlzcGxheV9tb2RlICpmaXhlZF9tb2RlID0gTlVMTDsKPiA+ICAJc3RydWN0 IGRybV9kaXNwbGF5X21vZGUgKmRvd25jbG9ja19tb2RlID0gTlVMTDsKPiA+ICAJc3RydWN0IGVk aWQgKmVkaWQ7Cj4gPiBAQCAtOTQ5LDE2ICs5NDgsOSBAQCB2b2lkIGludGVsX2x2ZHNfaW5pdChz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiAgCX0KPiA+ICAJaW50ZWxfY29u bmVjdG9yLT5lZGlkID0gZWRpZDsKPiA+ICAKPiA+IC0JbGlzdF9mb3JfZWFjaF9lbnRyeShzY2Fu LCAmY29ubmVjdG9yLT5wcm9iZWRfbW9kZXMsIGhlYWQpIHsKPiA+IC0JCWlmIChzY2FuLT50eXBl ICYgRFJNX01PREVfVFlQRV9QUkVGRVJSRUQpIHsKPiA+IC0JCQlEUk1fREVCVUdfS01TKCJ1c2lu ZyBwcmVmZXJyZWQgbW9kZSBmcm9tIEVESUQ6ICIpOwo+ID4gLQkJCWRybV9tb2RlX2RlYnVnX3By aW50bW9kZWxpbmUoc2Nhbik7Cj4gPiAtCj4gPiAtCQkJZml4ZWRfbW9kZSA9IGRybV9tb2RlX2R1 cGxpY2F0ZShkZXYsIHNjYW4pOwo+ID4gLQkJCWlmIChmaXhlZF9tb2RlKQo+ID4gLQkJCQlnb3Rv IG91dDsKPiA+IC0JCX0KPiA+IC0JfQo+ID4gKwlmaXhlZF9tb2RlID0gaW50ZWxfcGFuZWxfZWRp ZF9maXhlZF9tb2RlKGludGVsX2Nvbm5lY3Rvcik7Cj4gPiArCWlmIChmaXhlZF9tb2RlKQo+ID4g KwkJZ290byBvdXQ7Cj4gPiAgCj4gPiAgCS8qIEZhaWxlZCB0byBnZXQgRURJRCwgd2hhdCBhYm91 dCBWQlQ/ICovCj4gPiAgCWlmIChkZXZfcHJpdi0+dmJ0LmxmcF9sdmRzX3ZidF9tb2RlKSB7Cj4g PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcGFuZWwuYyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX3BhbmVsLmMKPiA+IGluZGV4IGVkZDU1NDA2MzliMC4uZjQy MTM3NTEyMDEwIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcGFu ZWwuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcGFuZWwuYwo+ID4gQEAg LTk5LDYgKzk5LDMzIEBAIGludGVsX2ZpbmRfcGFuZWxfZG93bmNsb2NrKHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdiwKPiA+ICAJCXJldHVybiBOVUxMOwo+ID4gIH0KPiA+ICAKPiA+ ICtzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqCj4gPiAraW50ZWxfcGFuZWxfZWRpZF9maXhlZF9t b2RlKHN0cnVjdCBpbnRlbF9jb25uZWN0b3IgKmNvbm5lY3RvcikKPiA+ICt7Cj4gPiArCXN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoY29ubmVjdG9yLT5iYXNlLmRl dik7Cj4gPiArCWNvbnN0IHN0cnVjdCBkcm1fZGlzcGxheV9tb2RlICpzY2FuOwo+ID4gKwo+ID4g KwkvKiBwcmVmZXIgZml4ZWQgbW9kZSBmcm9tIEVESUQgaWYgYXZhaWxhYmxlICovCj4gPiArCWxp c3RfZm9yX2VhY2hfZW50cnkoc2NhbiwgJmNvbm5lY3Rvci0+YmFzZS5wcm9iZWRfbW9kZXMsIGhl YWQpIHsKPiA+ICsJCXN0cnVjdCBkcm1fZGlzcGxheV9tb2RlICpmaXhlZF9tb2RlOwo+ID4gKwo+ ID4gKwkJaWYgKChzY2FuLT50eXBlICYgRFJNX01PREVfVFlQRV9QUkVGRVJSRUQpID09IDApCj4g PiArCQkJY29udGludWU7Cj4gPiArCj4gPiArCQlmaXhlZF9tb2RlID0gZHJtX21vZGVfZHVwbGlj YXRlKCZkZXZfcHJpdi0+ZHJtLCBzY2FuKTsKPiA+ICsJCWlmICghZml4ZWRfbW9kZSkKPiA+ICsJ CQlyZXR1cm4gTlVMTDsKPiA+ICsKPiA+ICsJCURSTV9ERUJVR19LTVMoIltDT05ORUNUT1I6JWQ6 JXNdIHVzaW5nIHByZWZlcnJlZCBtb2RlIGZyb20gRURJRDogIiwKPiA+ICsJCQkgICAgICBjb25u ZWN0b3ItPmJhc2UuYmFzZS5pZCwgY29ubmVjdG9yLT5iYXNlLm5hbWUpOwo+ID4gKwkJZHJtX21v ZGVfZGVidWdfcHJpbnRtb2RlbGluZShmaXhlZF9tb2RlKTsKPiA+ICsKPiA+ICsJCXJldHVybiBm aXhlZF9tb2RlOwo+ID4gKwl9Cj4gPiArCj4gPiArCXJldHVybiBOVUxMOwo+ID4gK30KPiA+ICsK PiA+ICAvKiBhZGp1c3RlZF9tb2RlIGhhcyBiZWVuIHByZXNldCB0byBiZSB0aGUgcGFuZWwncyBm aXhlZCBtb2RlICovCj4gPiAgdm9pZAo+ID4gIGludGVsX3BjaF9wYW5lbF9maXR0aW5nKHN0cnVj dCBpbnRlbF9jcnRjICppbnRlbF9jcnRjLAo+IAo+IC0tIAo+IEphbmkgTmlrdWxhLCBJbnRlbCBP cGVuIFNvdXJjZSBHcmFwaGljcyBDZW50ZXIKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1h aWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4