From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "Souza, Jose" <jose.souza@intel.com>
Cc: "intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] drm/i915: Mark AML 0x87CA as ULX
Date: Mon, 25 Mar 2019 09:03:44 +0200 [thread overview]
Message-ID: <20190325070344.GO3888@intel.com> (raw)
In-Reply-To: <ac9811a0f09f713df0fe846a8feb1fb7ad5bb567.camel@intel.com>
On Fri, Mar 22, 2019 at 09:37:48PM +0000, Souza, Jose wrote:
> On Fri, 2019-03-22 at 22:49 +0200, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > If I'm reading the spec right AML 0x87CA is a Y SKU, so it
> > should be marked as ULX in our old style terminology.
>
> You are right, only the CPU is based on CFL.
>
> Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Thanks. Pushed.
>
> >
> > Cc: stable@vger.kernel.org
> > Cc: José Roberto de Souza <jose.souza@intel.com>
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > Fixes: c0c46ca461f1 ("drm/i915/aml: Add new Amber Lake PCI ID")
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/i915_drv.h | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_drv.h
> > b/drivers/gpu/drm/i915/i915_drv.h
> > index f723b15527f8..428279fd88a0 100644
> > --- a/drivers/gpu/drm/i915/i915_drv.h
> > +++ b/drivers/gpu/drm/i915/i915_drv.h
> > @@ -2361,7 +2361,8 @@ static inline unsigned int
> > i915_sg_segment_size(void)
> > INTEL_DEVID(dev_priv) == 0x5915 || \
> > INTEL_DEVID(dev_priv) == 0x591E)
> > #define IS_AML_ULX(dev_priv) (INTEL_DEVID(dev_priv) == 0x591C || \
> > - INTEL_DEVID(dev_priv) == 0x87C0)
> > + INTEL_DEVID(dev_priv) == 0x87C0 || \
> > + INTEL_DEVID(dev_priv) == 0x87CA)
> > #define IS_SKL_GT2(dev_priv) (IS_SKYLAKE(dev_priv) && \
> > INTEL_INFO(dev_priv)->gt == 2)
> > #define IS_SKL_GT3(dev_priv) (IS_SKYLAKE(dev_priv) && \
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-03-25 7:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 20:49 [PATCH] drm/i915: Mark AML 0x87CA as ULX Ville Syrjala
2019-03-22 21:37 ` Souza, Jose
2019-03-25 7:03 ` Ville Syrjälä [this message]
2019-03-22 21:38 ` ✗ Fi.CI.SPARSE: warning for " Patchwork
2019-03-22 22:05 ` ✓ Fi.CI.BAT: success " Patchwork
2019-03-24 3:28 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190325070344.GO3888@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jose.souza@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox