Re: [PATCH v2 00/10] drm/i915: Clean up intel_color_check()

Matt Roper
2019-03-27T17:30:20Z

On Wed, Mar 27, 2019 at 05:50:35PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Repost of the earlier series to clean up intel_color_check().
> I tried to address all of Matt's review comments (thanks!).
>
> All reviewed except patch 8.

Patch 8 (and the rest of the series):

Reviewed-by: Matt Roper <matthew.d.roper@intel.com>

> Ville Syrjälä (10):
> drm/i915: Extract check_luts()
> drm/i915: Turn intel_color_check() into a vfunc
> drm/i915: Extract i9xx_color_check()
> drm/i915: Extract chv_color_check()
> drm/i915: Extract icl_color_check()
> drm/i915: Extract glk_color_check()
> drm/i915: Extract bdw_color_check()
> drm/i915: Extract ilk_color_check()
> drm/i915: Drop the pointless linear legacy LUT load on CHV
> drm/i915: Skip the linear degamma LUT load on ICL+
>
> drivers/gpu/drm/i915/i915_drv.h | 1 +
> drivers/gpu/drm/i915/intel_color.c | 416 +++++++++++++++++++++--------
> 2 files changed, 311 insertions(+), 106 deletions(-)
>
> --
> 2.19.2
>

--
Matt Roper
Graphics Software Engineer
IoTG Platform Enabling & Development
Intel Corporation
(916) 356-2795