From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2 1/2] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color Date: Tue, 2 Apr 2019 21:16:31 +0300 Message-ID: <20190402181631.GR3888@intel.com> References: <20190402121440.20116-1-aditya.swarup@intel.com> <20190402125306.GP3888@intel.com> <2a8f9488-0b58-4461-0bde-67e1c0b66f81@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4A9876E4A6 for ; Tue, 2 Apr 2019 18:16:35 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Clinton Taylor Cc: Jani Nikula , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBBcHIgMDIsIDIwMTkgYXQgMDk6MjU6NThBTSAtMDcwMCwgQ2xpbnRvbiBUYXlsb3Ig d3JvdGU6Cj4gCj4gT24gNC8yLzE5IDg6NTQgQU0sIENsaW50b24gVGF5bG9yIHdyb3RlOgo+ID4K PiA+IE9uIDQvMi8xOSA1OjUzIEFNLCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6Cj4gPj4gT24gVHVl LCBBcHIgMDIsIDIwMTkgYXQgMDU6MTQ6MzlBTSAtMDcwMCwgQWRpdHlhIFN3YXJ1cCB3cm90ZToK PiA+Pj4gRnJvbTogQ2xpbnRvbiBUYXlsb3IgPENsaW50b24uQS5UYXlsb3JAaW50ZWwuY29tPgo+ ID4+Pgo+ID4+PiB2MjogRml4IGNvbW1pdCBtc2cgdG8gcmVmbGVjdCB3aHkgaXNzdWUgb2NjdXJz KEphbmkpCj4gPj4+IFNldCBHQ1BfQ09MT1JfSU5ESUNBVElPTiBvbmx5IHdoZW4gd2Ugc2V0IDEw LzEyIGJpdCBkZWVwIGNvbG9yLgo+ID4+Pgo+ID4+PiBDaGFuZ2luZyBzZXR0aW5ncyBmcm9tIDEw LzEyIGJpdCBkZWVwIGNvbG9yIHRvIDggYml0KCYgdmljZSB2ZXJzYSkKPiA+Pj4gZG9lc24ndCB3 b3JrIGNvcnJlY3RseSB1c2luZyB4cmFuZHIgbWF4IGJwYyBwcm9wZXJ0eS4gV2hlbiB3ZQo+ID4+ PiBjb25uZWN0IGEgbW9uaXRvciB3aGljaCBzdXBwb3J0cyBkZWVwIGNvbG9yLCB0aGUgaGlnaGVz dCBkZWVwIGNvbG9yCj4gPj4+IHNldHRpbmcgaXMgc2VsZWN0ZWQ7IHdoaWNoIHNldHMgR0NQX0NP TE9SX0lORElDQVRJT04uIFdoZW4gd2UgY2hhbmdlCj4gPj4+IHRoZSBzZXR0aW5nIHRvIDggYml0 IGNvbG9yLCB3ZSBzdGlsbCBzZXQgR0NQX0NPTE9SX0lORElDQVRJT04gd2hpY2gKPiA+Pj4gZG9l c24ndCBhbGxvdyB0aGUgc3dpdGNoIGJhY2sgdG8gOCBiaXQgY29sb3IuCj4gPj4gV2h5IG5vdD8g VGFibGUgNi0xIGluIEhETUkgMS40YSBzcGVjIGNsZWFybHkgbGlzdHMgOGJwYyBhcyBhCj4gPj4g dmFsaWQgc2V0dGluZyBmb3IgR0NQLgo+ID4KPiA+IFRoaXMgYXBwZWFycyB0byBiZSBhIHVuZG9j dW1lbnRlZCBTSSBpc3N1ZS4gQWNjb3JkaW5nIHRvIHRoZSBzcGVjIDggCj4gPiBiaXQgaXMgYSB2 YWxpZCBHQ1AgdmFsdWUuIEhvd2V2ZXIsIGlmIHlvdSBlbmFibGUgR0NQIGluZGljYXRpb24gYW5k IDggCj4gPiBiaXQgaXMgY3VycmVudCB0aGVuIDEwIGJpdCBpcyB0cmFuc21pdCB2aWEgR0NQIGNv bmZ1c2luZyBtb25pdG9ycy4gVGhlIAo+ID4gR0NQIGlzIGJlaW5nIHZhbGlkYXRlZCB1c2luZyAy IGRpZmZlcmVudCBIRE1JIEFuYWx5emVyJ3MgY29uZmlybWluZyAKPiA+IHRoZSByZXN1bHRzLgo+ IAo+IEFmdGVyIGRvdWJsZSBjaGVja2luZyBCU1BFQyAoNTA1MjQpIHRoaXMgYmVoYXZpb3IgYXBw ZWFycyB0byBiZSBhcyBhcyAKPiBkZXNpZ25lZC4gVW5kZXIgUmVzdHJpY3Rpb24gZm9yIGJpdCAy OiBUaGlzIGJpdCBtdXN0IGJlIHNldCB3aGVuIGluIEhETUkgCj4gZGVlcCBjb2xvciAoPjggQlBD KSBtb2RlLiBJIGRvbid0IGFncmVlIHdpdGggdGhpcyByZXN0cmljdGlvbiBhcyA4IGJpdCAKPiBp cyBhIHZhbGlkIEdDUCBpbmRpY2F0aW9uLgoKVGhhdCBkb2Vzbid0IHNheSB3ZSBtdXNuJ3QgZW5h YmxlIGl0IHdpdGggOGJwYy4KCkhvd2V2ZXIgY3VycmVudCBCc3BlYyBoYXMgdGhpcyB0byBzYXk6 CiJHQ1AgaXMgb25seSBzdXBwb3J0ZWQgd2l0aCBIRE1JIHdoZW4gdGhlIGJpdHMgcGVyIGNvbG9y IGlzIG5vdCBlcXVhbAogdG8gOC4gR0NQIG11c3QgYmUgZW5hYmxlZCBwcmlvciB0byBlbmFibGlu ZyBUUkFOU19ERElfRlVOQ19DVEwgZm9yIEhETUkKIHdpdGggYml0cyBwZXIgY29sb3Igbm90IGVx dWFsIHRvIDggYW5kIGRpc2FibGVkIGFmdGVyIGRpc2FibGluZwogVFJBTlNfRERJX0ZVTkNfQ1RM IgoKU28geWVhaCwgbG9va3MgbGlrZSB0aGlzIGlzbid0IHN1cHBvcnRlZCBieSBvdXIgY3VycmVu dCBody4KCkl0IHdhcyBzdXBwb3J0ZWQgaW4gdGhlIHBhc3QuIEVnLiBDUFQgYnNwZWMgc3RpbGwg aGFzIHRoaXMgdG8gc2F5OgoiVGhpcyBiaXQgbXVzdCBiZSBzZXQgd2hlbiBpbiBkZWVwIGNvbG9y IG1vZGUuIEl0IG1heSBvcHRpb25hbGx5IGJlIHNldAogZm9yIDI0LWJpdCBtb2RlLiBJdCBtdXN0 IGJlIHNldCBpZiB0aGUgc2luayBhdHRhY2hlZCB0byB0aGUgdHJhbnNjb2RlcgogY2FuIHJlY2Vp dmUgR0NQIGRhdGEuIgoKQnV0IEhTVyBic3BlYyBhbHJlYWR5IGZvcmJpZHMgaXQuIFNvIGxvb2tz IGxpa2Ugd2UgaGF2ZSB0byBkaXNhYmxlIHRoaXMgCm9uIEhTVysgYXQgbGVhc3QuIFByb2JhYmx5 IGVhc2llciB0byBqdXN0IGRpc2FibGUgaXQgYWNyb3NzIHRoZSBib2FyZC4KVGhlIHNwZWMgc2Vl bXMgdG8gc3VnZ2VzdCB0aGF0IHdlIHNob3VsZCBkaXNhYmxlIEdDUCBlbnRpcmVseSBpbiA4YnBj Cm1vZGUsIGJ1dCB0aGVyZSBhcmUgc29tZSBjaGFuZ2xvZyBlbnRyaWVzIGluIHRoZSBIU1cgZG9j cyB0aGF0CnN1Z2dlc3QgdG8gbWUgdGhhdCBzZXR0aW5nIENEPTAgc2hvdWxkIGJlIHN1ZmZpY2ll bnQuIEkgZ3Vlc3MgdGhhdAphZ3JlZXMgd2l0aCB5b3VyIHBhdGNoLgoKPiAKPiAtQ2xpbnQKPiAK PiAKPiA+Cj4gPiBXZSB3aWxsIGZpbGUgYSBTSSBidWcgYWdhaW5zdCB0aGUgY3VycmVudCBiZWhh dmlvci4KPiA+Cj4gPiAtQ2xpbnQKPiA+Cj4gPgo+ID4+Cj4gPj4+IFNpZ25lZC1vZmYtYnk6IENs aW50b24gVGF5bG9yIDxDbGludG9uLkEuVGF5bG9yQGludGVsLmNvbT4KPiA+Pj4gU2lnbmVkLW9m Zi1ieTogQWRpdHlhIFN3YXJ1cCA8YWRpdHlhLnN3YXJ1cEBpbnRlbC5jb20+Cj4gPj4+IENjOiBW aWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ID4+PiBDYzog SmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4KPiA+Pj4gQ2M6IE1hbmFzaSBOYXZh cmUgPG1hbmFzaS5kLm5hdmFyZUBpbnRlbC5jb20+Cj4gPj4+IC0tLQo+ID4+PiDCoCBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9oZG1pLmMgfCAzMSAKPiA+Pj4gKysrKysrKysrKysrKysrLS0t LS0tLS0tLS0tLS0tLQo+ID4+PiDCoCAxIGZpbGUgY2hhbmdlZCwgMTUgaW5zZXJ0aW9ucygrKSwg MTYgZGVsZXRpb25zKC0pCj4gPj4+Cj4gPj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9oZG1pLmMgCj4gPj4+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfaGRt aS5jCj4gPj4+IGluZGV4IDVjY2IzMDVhNmUxYy4uNDc2MDQ2MmY4NGNhIDEwMDY0NAo+ID4+PiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9oZG1pLmMKPiA+Pj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfaGRtaS5jCj4gPj4+IEBAIC05NjMsNyArOTYzLDkgQEAgc3Rh dGljIHZvaWQgCj4gPj4+IGludGVsX2hkbWlfY29tcHV0ZV9nY3BfaW5mb2ZyYW1lKHN0cnVjdCBp bnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ID4+PiBpbnRlbF9oZG1pX2luZm9mcmFtZV9lbmFibGUo SERNSV9QQUNLRVRfVFlQRV9HRU5FUkFMX0NPTlRST0wpOwo+ID4+PiDCoCDCoMKgwqDCoMKgIC8q IEluZGljYXRlIGNvbG9yIGRlcHRoIHdoZW5ldmVyIHRoZSBzaW5rIHN1cHBvcnRzIGRlZXAgCj4g Pj4+IGNvbG9yICovCj4gPj4+IC3CoMKgwqAgaWYgKGhkbWlfc2lua19pc19kZWVwX2NvbG9yKGNv bm5fc3RhdGUpKQo+ID4+PiArCj4gPj4+ICvCoMKgwqAgaWYgKGhkbWlfc2lua19pc19kZWVwX2Nv bG9yKGNvbm5fc3RhdGUpICYmCj4gPj4+ICvCoMKgwqDCoMKgwqDCoCAoY3J0Y19zdGF0ZS0+cGlw ZV9icHAgPiAyNCkpCj4gPj4+IMKgwqDCoMKgwqDCoMKgwqDCoCBjcnRjX3N0YXRlLT5pbmZvZnJh bWVzLmdjcCB8PSBHQ1BfQ09MT1JfSU5ESUNBVElPTjsKPiA+Pj4gwqAgwqDCoMKgwqDCoCAvKiBF bmFibGUgZGVmYXVsdF9waGFzZSB3aGVuZXZlciB0aGUgZGlzcGxheSBtb2RlIGlzIAo+ID4+PiBz dWl0YWJseSBhbGlnbmVkICovCgpTbyBJIHRoaW5rIHRoaXMgaHVuayBvbiBpdHMgb3duIHNob3Vs ZCBiZSBzdWZmaWNpZW50LiBJJ2QgbGlrZSB0byBzZWUKdGhlIHBvaW50bGVzcyBwYXJlbnMgZWxp bWluYXRlZCwgYW5kIGEgY29tbWVudCBhZGRlZCB0aGF0IGV4cGxhaW5zCnRoYXQgOGJwYyArIGNv bG9yIGRlcHRoIGluZGljYXRpb24gaXMgbm8gbG9uZ2VyIHN1cHBvcnRlZCBvbiBIU1crLgoKPiA+ Pj4gQEAgLTIyNjAsNiArMjI2Miw3IEBAIGludCBpbnRlbF9oZG1pX2NvbXB1dGVfY29uZmlnKHN0 cnVjdCAKPiA+Pj4gaW50ZWxfZW5jb2RlciAqZW5jb2RlciwKPiA+Pj4gwqDCoMKgwqDCoCBpbnQg Y2xvY2tfOGJwYyA9IHBpcGVfY29uZmlnLT5iYXNlLmFkanVzdGVkX21vZGUuY3J0Y19jbG9jazsK PiA+Pj4gwqDCoMKgwqDCoCBpbnQgY2xvY2tfMTBicGMgPSBjbG9ja184YnBjICogNSAvIDQ7Cj4g Pj4+IMKgwqDCoMKgwqAgaW50IGNsb2NrXzEyYnBjID0gY2xvY2tfOGJwYyAqIDMgLyAyOwo+ID4+ PiArwqDCoMKgIGludCBkY19jbG9jayA9IGNsb2NrXzEyYnBjOwo+ID4+PiDCoMKgwqDCoMKgIGlu dCBkZXNpcmVkX2JwcDsKPiA+Pj4gwqDCoMKgwqDCoCBib29sIGZvcmNlX2R2aSA9IGludGVsX2Nv bm5fc3RhdGUtPmZvcmNlX2F1ZGlvID09IAo+ID4+PiBIRE1JX0FVRElPX09GRl9EVkk7Cj4gPj4+ IMKgIEBAIC0yMzE0LDIyICsyMzE3LDE4IEBAIGludCBpbnRlbF9oZG1pX2NvbXB1dGVfY29uZmln KHN0cnVjdCAKPiA+Pj4gaW50ZWxfZW5jb2RlciAqZW5jb2RlciwKPiA+Pj4gwqDCoMKgwqDCoMKg ICogTm90ZSB0aGF0IGc0eC92bHYgZG9uJ3Qgc3VwcG9ydCAxMmJwYyBoZG1pIG91dHB1dHMuIFdl IGFsc28gCj4gPj4+IG5lZWQKPiA+Pj4gwqDCoMKgwqDCoMKgICogdG8gY2hlY2sgdGhhdCB0aGUg aGlnaGVyIGNsb2NrIHN0aWxsIGZpdHMgd2l0aGluIGxpbWl0cy4KPiA+Pj4gwqDCoMKgwqDCoMKg ICovCj4gPj4+IC3CoMKgwqAgaWYgKGhkbWlfZGVlcF9jb2xvcl9wb3NzaWJsZShwaXBlX2NvbmZp ZywgMTIpICYmCj4gPj4+IC3CoMKgwqDCoMKgwqDCoCBoZG1pX3BvcnRfY2xvY2tfdmFsaWQoaW50 ZWxfaGRtaSwgY2xvY2tfMTJicGMsCj4gPj4+ICvCoMKgwqAgaWYgKHBpcGVfY29uZmlnLT5waXBl X2JwcCA9PSAzMCkKPiA+Pj4gK8KgwqDCoMKgwqDCoMKgIGRjX2Nsb2NrID0gY2xvY2tfMTBicGM7 Cj4gPj4+ICsKPiA+Pj4gK8KgwqDCoCBpZiAoaGRtaV9kZWVwX2NvbG9yX3Bvc3NpYmxlKHBpcGVf Y29uZmlnLCBwaXBlX2NvbmZpZy0+cGlwZV9icHAgCj4gPj4+IC8gMykgJiYKPiA+Pj4gK8KgwqDC oMKgwqDCoMKgIGhkbWlfcG9ydF9jbG9ja192YWxpZChpbnRlbF9oZG1pLCBkY19jbG9jaywKPiA+ Pj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgdHJ1ZSwgZm9yY2VfZHZp KSA9PSBNT0RFX09LKSB7Cj4gPj4+IC3CoMKgwqDCoMKgwqDCoCBEUk1fREVCVUdfS01TKCJwaWNr aW5nIGJwYyB0byAxMiBmb3IgSERNSSBvdXRwdXRcbiIpOwo+ID4+PiAtwqDCoMKgwqDCoMKgwqAg ZGVzaXJlZF9icHAgPSAxMiozOwo+ID4+PiAtCj4gPj4+IC3CoMKgwqDCoMKgwqDCoCAvKiBOZWVk IHRvIGFkanVzdCB0aGUgcG9ydCBsaW5rIGJ5IDEuNXggZm9yIDEyYnBjLiAqLwo+ID4+PiAtwqDC oMKgwqDCoMKgwqAgcGlwZV9jb25maWctPnBvcnRfY2xvY2sgPSBjbG9ja18xMmJwYzsKPiA+Pj4g LcKgwqDCoCB9IGVsc2UgaWYgKGhkbWlfZGVlcF9jb2xvcl9wb3NzaWJsZShwaXBlX2NvbmZpZywg MTApICYmCj4gPj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoCBoZG1pX3BvcnRfY2xvY2tfdmFsaWQo aW50ZWxfaGRtaSwgY2xvY2tfMTBicGMsCj4gPj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgIHRydWUsIGZvcmNlX2R2aSkgPT0gTU9ERV9PSykgewo+ID4+PiAtwqDC oMKgwqDCoMKgwqAgRFJNX0RFQlVHX0tNUygicGlja2luZyBicGMgdG8gMTAgZm9yIEhETUkgb3V0 cHV0XG4iKTsKPiA+Pj4gLcKgwqDCoMKgwqDCoMKgIGRlc2lyZWRfYnBwID0gMTAgKiAzOwo+ID4+ PiAtCj4gPj4+IC3CoMKgwqDCoMKgwqDCoCAvKiBOZWVkIHRvIGFkanVzdCB0aGUgcG9ydCBsaW5r IGJ5IDEuMjV4IGZvciAxMGJwYy4gKi8KPiA+Pj4gLcKgwqDCoMKgwqDCoMKgIHBpcGVfY29uZmln LT5wb3J0X2Nsb2NrID0gY2xvY2tfMTBicGM7Cj4gPj4+ICvCoMKgwqDCoMKgwqDCoCBEUk1fREVC VUdfS01TKCJwaWNraW5nIGJwYyB0byAlZCBmb3IgSERNSSBvdXRwdXRcbiIsCj4gPj4+ICvCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBwaXBlX2NvbmZpZy0+cGlwZV9icHAgLyAzKTsK PiA+Pj4gK8KgwqDCoMKgwqDCoMKgIGRlc2lyZWRfYnBwID0gcGlwZV9jb25maWctPnBpcGVfYnBw Owo+ID4+PiArCj4gPj4+ICvCoMKgwqDCoMKgwqDCoCAvKiBOZWVkIHRvIGFkanVzdCB0aGUgcG9y dCBsaW5rIGRjIG1vZGVzLiAqLwo+ID4+PiArwqDCoMKgwqDCoMKgwqAgcGlwZV9jb25maWctPnBv cnRfY2xvY2sgPSBkY19jbG9jazsKPiA+PiBUaGlzIHBhcnQgaGFzIG5vdGhpbmcgdG8gZG8gd2l0 aCB0aGUgY29tbWl0IG1lc3NhZ2UuCj4gPj4KPiA+Pgo+ID4+PiDCoMKgwqDCoMKgIH0gZWxzZSB7 Cj4gPj4+IMKgwqDCoMKgwqDCoMKgwqDCoCBEUk1fREVCVUdfS01TKCJwaWNraW5nIGJwYyB0byA4 IGZvciBIRE1JIG91dHB1dFxuIik7Cj4gPj4+IMKgwqDCoMKgwqDCoMKgwqDCoCBkZXNpcmVkX2Jw cCA9IDgqMzsKPiA+Pj4gLS0gCj4gPj4+IDIuMTcuMQoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRl bApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1n ZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=