From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH] drm/i915/ehl: Add support for DPLL4 (v3)
Date: Fri, 5 Apr 2019 21:33:56 +0300
Message-ID: <20190405183356.GP3888@intel.com>
References: <20190405000616.32568.75409@emeril.freedesktop.org>
 <20190405175953.7206-1-vivek.kasireddy@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 7A17F89F89
 for <intel-gfx@lists.freedesktop.org>; Fri,  5 Apr 2019 18:34:00 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20190405175953.7206-1-vivek.kasireddy@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Vivek Kasireddy <vivek.kasireddy@intel.com>
Cc: intel-gfx@lists.freedesktop.org, Lucas De Marchi <lucas.demarchi@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

T24gRnJpLCBBcHIgMDUsIDIwMTkgYXQgMTA6NTk6NTNBTSAtMDcwMCwgVml2ZWsgS2FzaXJlZGR5
IHdyb3RlOgo+IFRoaXMgcGF0Y2ggYWRkcyBzdXBwb3J0IGZvciBEUExMNCBvbiBFSEwgdGhhdCBp
bmNsdWRlIHRoZQo+IGZvbGxvd2luZyByZXN0cmljdGlvbnM6Cj4gCj4gLSBEUExMNCBjYW5ub3Qg
YmUgdXNlZCB3aXRoIERESUEgKGNvbWJvIHBvcnQgQSBpbnRlcm5hbCBlRFAgdXNhZ2UpLgo+ICAg
RFBMTDQgY2FuIGJlIHVzZWQgd2l0aCBvdGhlciBERElzLCBpbmNsdWRpbmcgRERJRAo+ICAgKGNv
bWJvIHBvcnQgQSBleHRlcm5hbCB1c2FnZSkuCj4gCj4gLSBEUExMNCBjYW5ub3QgYmUgZW5hYmxl
ZCB3aGVuIERDNSBvciBEQzYgYXJlIGVuYWJsZWQuCj4gCj4gLSBUaGUgRFBMTDQgZW5hYmxlLCBs
b2NrLCBwb3dlciBlbmFibGVkLCBhbmQgcG93ZXIgc3RhdGUgYXJlIGNvbm5lY3RlZAo+ICAgdG8g
dGhlIE1HUExMMV9FTkFCTEUgcmVnaXN0ZXIuCj4gCj4gdjI6IChzdWdnZXN0aW9ucyBmcm9tIEJv
YiBQYWF1d2UpCj4gLSBSZXdvcmsgZWhsX2dldF9kcGxsKCkgZnVuY3Rpb24gdG8gY2FsbCBpbnRl
bF9maW5kX3NoYXJlZF9kcGxsKCkgYW5kCj4gICBpdGVyYXRlIHR3aWNlOiBvbmNlIGZvciBDb21i
byBwbGxzIGFuZCBvbmNlIGZvciBNRyBwbGxzLgo+IAo+IC0gVXNlIE1HIHBsbCBmdW5jcyBmb3Ig
RFBMTDQgaW5zdGVhZCBvZiBjcmVhdGluZyBuZXcgb25lcyBhbmQgbW9kaWZ5Cj4gICBtZ19wbGxf
ZW5hYmxlIHRvIGluY2x1ZGUgdGhlIHJlc3RyaWN0aW9ucyBmb3IgRUhMLgo+IAo+IHYzOiBGaXgg
Y29tcGlsYXRpb24gZXJyb3IKPiAKPiBDYzogTHVjYXMgRGUgTWFyY2hpIDxsdWNhcy5kZW1hcmNo
aUBpbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogVml2ZWsgS2FzaXJlZGR5IDx2aXZlay5rYXNp
cmVkZHlAaW50ZWwuY29tPgo+IFJldmlld2VkLWJ5OiBCb2IgUGFhdXdlIDxib2Iuai5wYWF1d2VA
aW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5j
IHwgNjAgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0KPiAgMSBmaWxlIGNoYW5n
ZWQsIDU5IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJp
dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1
L2ludGVsX2RwbGxfbWdyLmMKPiBpbmRleCBlMDFjMDU3Y2U1MGIuLmMzZjBiOTcyMGM1NCAxMDA2
NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5jCj4gKysrIGIv
ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuYwo+IEBAIC0yODcwLDYgKzI4NzAs
NTYgQEAgaWNsX2dldF9kcGxsKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlLAo+
ICAJcmV0dXJuIHBsbDsKPiAgfQo+ICAKPiArc3RhdGljIHN0cnVjdCBpbnRlbF9zaGFyZWRfZHBs
bCAqCj4gK2VobF9nZXRfZHBsbChzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSwK
PiArCSAgICAgc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIpCj4gK3sKPiArCXN0cnVjdCBk
cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoY3J0Y19zdGF0ZS0+YmFzZS5jcnRj
LT5kZXYpOwo+ICsJc3RydWN0IGludGVsX3NoYXJlZF9kcGxsICpwbGw7Cj4gKwllbnVtIHBvcnQg
cG9ydCA9IGVuY29kZXItPnBvcnQ7Cj4gKwllbnVtIGludGVsX2RwbGxfaWQgbWluLCBtYXg7Cj4g
Kwlib29sIHJldDsKPiArCj4gKwlpZiAoIWludGVsX3BvcnRfaXNfY29tYm9waHkoZGV2X3ByaXYs
IHBvcnQpKSB7Cj4gKwkJTUlTU0lOR19DQVNFKHBvcnQpOwo+ICsJCXJldHVybiBOVUxMOwo+ICsJ
fQo+ICsKPiArCW1pbiA9IERQTExfSURfSUNMX0RQTEwwOwo+ICsJbWF4ID0gRFBMTF9JRF9JQ0xf
RFBMTDE7Cj4gKwlyZXQgPSBpY2xfY2FsY19kcGxsX3N0YXRlKGNydGNfc3RhdGUsIGVuY29kZXIp
Owo+ICsJaWYgKHJldCkgewo+ICsJCXBsbCA9IGludGVsX2ZpbmRfc2hhcmVkX2RwbGwoY3J0Y19z
dGF0ZSwgbWluLCBtYXgpOwo+ICsJCWlmIChwbGwpIHsKPiArCQkJaW50ZWxfcmVmZXJlbmNlX3No
YXJlZF9kcGxsKHBsbCwgY3J0Y19zdGF0ZSk7Cj4gKwkJCXJldHVybiBwbGw7Cj4gKwkJfQo+ICsJ
fSBlbHNlIHsKPiArCQlEUk1fREVCVUdfS01TKCJDb3VsZCBub3QgY2FsY3VsYXRlIFBMTCBzdGF0
ZS5cbiIpOwo+ICsJfQo+ICsKPiArCWlmIChlbmNvZGVyLT50eXBlID09IElOVEVMX09VVFBVVF9F
RFApIHsKPiArCQlEUk1fREVCVUdfS01TKCJDYW5ub3QgdXNlIERQTEw0IHdpdGggRURQLlxuIik7
Cj4gKwkJcmV0dXJuIE5VTEw7Cj4gKwl9Cj4gKwo+ICsJbWluID0gbWF4ID0gRFBMTF9JRF9JQ0xf
TUdQTEwxOwo+ICsJcmV0ID0gaWNsX2NhbGNfbWdfcGxsX3N0YXRlKGNydGNfc3RhdGUpOwo+ICsJ
aWYgKCFyZXQpIHsKPiArCQlEUk1fREVCVUdfS01TKCJDb3VsZCBub3QgY2FsY3VsYXRlIFBMTCBz
dGF0ZS5cbiIpOwo+ICsJCXJldHVybiBOVUxMOwo+ICsJfQo+ICsKPiArCXBsbCA9IGludGVsX2Zp
bmRfc2hhcmVkX2RwbGwoY3J0Y19zdGF0ZSwgbWluLCBtYXgpOwo+ICsJaWYgKCFwbGwpIHsKPiAr
CQlEUk1fREVCVUdfS01TKCJObyBQTEwgc2VsZWN0ZWRcbiIpOwo+ICsJCXJldHVybiBOVUxMOwo+
ICsJfQo+ICsKPiArCWludGVsX3JlZmVyZW5jZV9zaGFyZWRfZHBsbChwbGwsIGNydGNfc3RhdGUp
Owo+ICsJcmV0dXJuIHBsbDsKPiArfQo+ICsKPiAgc3RhdGljIGJvb2wgbWdfcGxsX2dldF9od19z
dGF0ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAkJCQlzdHJ1Y3QgaW50
ZWxfc2hhcmVkX2RwbGwgKnBsbCwKPiAgCQkJCXN0cnVjdCBpbnRlbF9kcGxsX2h3X3N0YXRlICpo
d19zdGF0ZSkKPiBAQCAtMzExNSw2ICszMTY1LDEzIEBAIHN0YXRpYyB2b2lkIG1nX3BsbF9lbmFi
bGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJaTkxNV9yZWdfdCBlbmFi
bGVfcmVnID0KPiAgCQlNR19QTExfRU5BQkxFKGljbF9wbGxfaWRfdG9fdGNfcG9ydChwbGwtPmlu
Zm8tPmlkKSk7Cj4gIAo+ICsJaWYgKElTX0VMS0hBUlRMQUtFKGRldl9wcml2KSAmJgo+ICsJICAg
KEk5MTVfUkVBRChEQ19TVEFURV9FTikgJiBEQ19TVEFURV9FTl9VUFRPX0RDNSB8fAo+ICsJICAg
IEk5MTVfUkVBRChEQ19TVEFURV9FTikgJiBEQ19TVEFURV9FTl9VUFRPX0RDNikpIHsKPiArCQlE
Uk1fRVJST1IoIkNhbnQgZW5hYmxlIERQTEw0IHdoZW4gREM1IG9yIERDNiBhcmUgZW5hYmxlZFxu
Iik7Cj4gKwkJcmV0dXJuOwo+ICsJfQoKVGhpcyBsb29rcyBsaWtlIGRlYWQgY29kZSwgb3Igd2Ug
bWVzc2VkIHVwIGVhcmxpZXIgYWxyZWFkeSAoaW4gd2hpY2gKY2FzZSBpdCBzaG91bGQganVzdCBi
ZSBzb21lIGtpbmQgb2YgYXNzZXJ0IElNTykuCgpBbHNvIHdoYXQgaXMgdGhpcyBFSEwgdGhpbmcg
YW55d2F5PyBJIGNhbid0IGV2ZW4gZmluZCBpdCBpbiB0aGUgc3BlYy4KCj4gKwo+ICAJaWNsX3Bs
bF9wb3dlcl9lbmFibGUoZGV2X3ByaXYsIHBsbCwgZW5hYmxlX3JlZyk7Cj4gIAo+ICAJaWNsX21n
X3BsbF93cml0ZShkZXZfcHJpdiwgcGxsKTsKPiBAQCAtMzI0OSwxMiArMzMwNiwxMyBAQCBzdGF0
aWMgY29uc3Qgc3RydWN0IGludGVsX2RwbGxfbWdyIGljbF9wbGxfbWdyID0gewo+ICBzdGF0aWMg
Y29uc3Qgc3RydWN0IGRwbGxfaW5mbyBlaGxfcGxsc1tdID0gewo+ICAJeyAiRFBMTCAwIiwgJmNv
bWJvX3BsbF9mdW5jcywgRFBMTF9JRF9JQ0xfRFBMTDAsIDAgfSwKPiAgCXsgIkRQTEwgMSIsICZj
b21ib19wbGxfZnVuY3MsIERQTExfSURfSUNMX0RQTEwxLCAwIH0sCj4gKwl7ICJEUExMIDQiLCAm
bWdfcGxsX2Z1bmNzLCBEUExMX0lEX0lDTF9NR1BMTDEsMCB9LAo+ICAJeyB9LAo+ICB9Owo+ICAK
PiAgc3RhdGljIGNvbnN0IHN0cnVjdCBpbnRlbF9kcGxsX21nciBlaGxfcGxsX21nciA9IHsKPiAg
CS5kcGxsX2luZm8gPSBlaGxfcGxscywKPiAtCS5nZXRfZHBsbCA9IGljbF9nZXRfZHBsbCwKPiAr
CS5nZXRfZHBsbCA9IGVobF9nZXRfZHBsbCwKPiAgCS5kdW1wX2h3X3N0YXRlID0gaWNsX2R1bXBf
aHdfc3RhdGUsCj4gIH07Cj4gIAo+IC0tIAo+IDIuMTQuNQo+IAo+IF9fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+
IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNr
dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0gClZpbGxlIFN5cmrDpGzDpApJ
bnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRl
bC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6
Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=