From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH] drm/i915: Track the temporary wakerefs used for hsw_get_pipe_config Date: Sun, 7 Apr 2019 16:34:47 +0300 Message-ID: <20190407133447.GC17917@ideak-desk.fi.intel.com> References: <20190406074858.9028-1-chris@chris-wilson.co.uk> <20190406080341.2654-1-chris@chris-wilson.co.uk> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id B57F88924C for ; Sun, 7 Apr 2019 13:35:14 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190406080341.2654-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gU2F0LCBBcHIgMDYsIDIwMTkgYXQgMDk6MDM6NDFBTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IEhhc3dlbGwrIHJlcXVpcmUgbWFueSBwb3dlciB3ZWxscyB0byBwcm9iZSB0aGUgY3Vy cmVudCBIVyBkaXNwbGF5IHN0YXRlLgo+IFVuZGVyIHRoZSB3YWtlcmVmIHRyYWNraW5nIHNjaGVt ZSwgd2Ugd2FudCBlYWNoIG93bmVyIHRvIHN0b3JlIGFuZAo+IHJlbGVhc2UgdGhlIHdha2VyZWYg dGhleSB1c2UsIHNvIHdlIGNhbiBpZGVudGlmeSBjYWxsZXJzIHRoYXQgaGF2ZQo+IGxlYWtlZCB0 aGVpciB3YWtlcmVmLiBGb3IgaHN3X2dldF9waXBlX2NvbmZpZywgdGhpcyBtZWFucyB3ZSBoYXZl IHRvCj4ga2VlcCB0aGUgYXJyYXkgb2YgYWxsIHdha2VyZWZzIGFzIGl0IGN1cnJlbnQgYWNxdWly ZXMgaXRzIHBvd2VyIHdlbGxzCj4gcGllY2VtZWFsIGFuZCByZWxlYXNlcyB0aGVtIGVuIG1hc3Nl Lgo+IAo+IEJ5IHRyYWNraW5nIHRoZXNlIHdha2VyZWZzLCB3ZSBzaG91bGQgYmUgYWJsZSB0byBl bGltaW5hdGUgYSBsb3Qgb2YKPiBub2lzZSBmcm9tIHRoZSBydW50aW1lLXBtIGRlYnVnIGxvZ3Mu Cj4gCj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28u dWs+CgpMb29rcyBvaywgdGhhbmtzIGZvciBmaXhpbmcgaXQ6ClJldmlld2VkLWJ5OiBJbXJlIERl YWsgPGltcmUuZGVha0BpbnRlbC5jb20+Cgo+IC0tLQo+IEhlbHAgZ2NjIGJ5IHVzaW5nIGV4cGxp Y2l0IHRlbXBvcmFyaWVzIGZvciB0aGUgcHJlZGljYXRlcy4KPiAtLS0KPiAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgNDYgKysrKysrKysrKysrKysrKysrKystLS0tLS0t LQo+ICAxIGZpbGUgY2hhbmdlZCwgMzMgaW5zZXJ0aW9ucygrKSwgMTMgZGVsZXRpb25zKC0pCj4g Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IGluZGV4IDdlY2ZiN2Q5ODgzOS4u ZDc2NTc2OWQ2YmFiIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rp c3BsYXkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IEBA IC05NzU0LDcgKzk3NTQsOCBAQCBzdGF0aWMgdm9pZCBoYXN3ZWxsX2dldF9kZGlfcGxsKHN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCj4gIHN0YXRpYyBib29sIGhzd19nZXRf dHJhbnNjb2Rlcl9zdGF0ZShzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywKPiAgCQkJCSAgICAgc3Ry dWN0IGludGVsX2NydGNfc3RhdGUgKnBpcGVfY29uZmlnLAo+IC0JCQkJICAgICB1NjQgKnBvd2Vy X2RvbWFpbl9tYXNrKQo+ICsJCQkJICAgICB1NjQgKnBvd2VyX2RvbWFpbl9tYXNrLAo+ICsJCQkJ ICAgICBpbnRlbF93YWtlcmVmX3QgKndha2VyZWZzKQo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX2Rldmlj ZSAqZGV2ID0gY3J0Yy0+YmFzZS5kZXY7Cj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYgPSB0b19pOTE1KGRldik7Cj4gQEAgLTk3NjIsNiArOTc2Myw3IEBAIHN0YXRpYyBib29s IGhzd19nZXRfdHJhbnNjb2Rlcl9zdGF0ZShzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywKPiAgCXVu c2lnbmVkIGxvbmcgcGFuZWxfdHJhbnNjb2Rlcl9tYXNrID0gMDsKPiAgCXVuc2lnbmVkIGxvbmcg ZW5hYmxlZF9wYW5lbF90cmFuc2NvZGVycyA9IDA7Cj4gIAllbnVtIHRyYW5zY29kZXIgcGFuZWxf dHJhbnNjb2RlcjsKPiArCWludGVsX3dha2VyZWZfdCB3ZjsKPiAgCXUzMiB0bXA7Cj4gIAo+ICAJ aWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0gMTEpCj4gQEAgLTk4MjcsMTAgKzk4MjksMTMgQEAg c3RhdGljIGJvb2wgaHN3X2dldF90cmFuc2NvZGVyX3N0YXRlKHN0cnVjdCBpbnRlbF9jcnRjICpj cnRjLAo+ICAJCWVuYWJsZWRfcGFuZWxfdHJhbnNjb2RlcnMgIT0gQklUKFRSQU5TQ09ERVJfRURQ KSk7Cj4gIAo+ICAJcG93ZXJfZG9tYWluID0gUE9XRVJfRE9NQUlOX1RSQU5TQ09ERVIocGlwZV9j b25maWctPmNwdV90cmFuc2NvZGVyKTsKPiAtCWlmICghaW50ZWxfZGlzcGxheV9wb3dlcl9nZXRf aWZfZW5hYmxlZChkZXZfcHJpdiwgcG93ZXJfZG9tYWluKSkKPiArCVdBUk5fT04oKnBvd2VyX2Rv bWFpbl9tYXNrICYgQklUX1VMTChwb3dlcl9kb21haW4pKTsKPiArCj4gKwl3ZiA9IGludGVsX2Rp c3BsYXlfcG93ZXJfZ2V0X2lmX2VuYWJsZWQoZGV2X3ByaXYsIHBvd2VyX2RvbWFpbik7Cj4gKwlp ZiAoIXdmKQo+ICAJCXJldHVybiBmYWxzZTsKPiAgCj4gLQlXQVJOX09OKCpwb3dlcl9kb21haW5f bWFzayAmIEJJVF9VTEwocG93ZXJfZG9tYWluKSk7Cj4gKwl3YWtlcmVmc1twb3dlcl9kb21haW5d ID0gd2Y7Cj4gIAkqcG93ZXJfZG9tYWluX21hc2sgfD0gQklUX1VMTChwb3dlcl9kb21haW4pOwo+ ICAKPiAgCXRtcCA9IEk5MTVfUkVBRChQSVBFQ09ORihwaXBlX2NvbmZpZy0+Y3B1X3RyYW5zY29k ZXIpKTsKPiBAQCAtOTg0MCwxMyArOTg0NSwxNSBAQCBzdGF0aWMgYm9vbCBoc3dfZ2V0X3RyYW5z Y29kZXJfc3RhdGUoc3RydWN0IGludGVsX2NydGMgKmNydGMsCj4gIAo+ICBzdGF0aWMgYm9vbCBi eHRfZ2V0X2RzaV90cmFuc2NvZGVyX3N0YXRlKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+ICAJ CQkJCSBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqcGlwZV9jb25maWcsCj4gLQkJCQkJIHU2NCAq cG93ZXJfZG9tYWluX21hc2spCj4gKwkJCQkJIHU2NCAqcG93ZXJfZG9tYWluX21hc2ssCj4gKwkJ CQkJIGludGVsX3dha2VyZWZfdCAqd2FrZXJlZnMpCj4gIHsKPiAgCXN0cnVjdCBkcm1fZGV2aWNl ICpkZXYgPSBjcnRjLT5iYXNlLmRldjsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf cHJpdiA9IHRvX2k5MTUoZGV2KTsKPiAgCWVudW0gaW50ZWxfZGlzcGxheV9wb3dlcl9kb21haW4g cG93ZXJfZG9tYWluOwo+IC0JZW51bSBwb3J0IHBvcnQ7Cj4gIAllbnVtIHRyYW5zY29kZXIgY3B1 X3RyYW5zY29kZXI7Cj4gKwlpbnRlbF93YWtlcmVmX3Qgd2Y7Cj4gKwllbnVtIHBvcnQgcG9ydDsK PiAgCXUzMiB0bXA7Cj4gIAo+ICAJZm9yX2VhY2hfcG9ydF9tYXNrZWQocG9ydCwgQklUKFBPUlRf QSkgfCBCSVQoUE9SVF9DKSkgewo+IEBAIC05ODU2LDEwICs5ODYzLDEzIEBAIHN0YXRpYyBib29s IGJ4dF9nZXRfZHNpX3RyYW5zY29kZXJfc3RhdGUoc3RydWN0IGludGVsX2NydGMgKmNydGMsCj4g IAkJCWNwdV90cmFuc2NvZGVyID0gVFJBTlNDT0RFUl9EU0lfQzsKPiAgCj4gIAkJcG93ZXJfZG9t YWluID0gUE9XRVJfRE9NQUlOX1RSQU5TQ09ERVIoY3B1X3RyYW5zY29kZXIpOwo+IC0JCWlmICgh aW50ZWxfZGlzcGxheV9wb3dlcl9nZXRfaWZfZW5hYmxlZChkZXZfcHJpdiwgcG93ZXJfZG9tYWlu KSkKPiArCQlXQVJOX09OKCpwb3dlcl9kb21haW5fbWFzayAmIEJJVF9VTEwocG93ZXJfZG9tYWlu KSk7Cj4gKwo+ICsJCXdmID0gaW50ZWxfZGlzcGxheV9wb3dlcl9nZXRfaWZfZW5hYmxlZChkZXZf cHJpdiwgcG93ZXJfZG9tYWluKTsKPiArCQlpZiAoIXdmKQo+ICAJCQljb250aW51ZTsKPiAgCj4g LQkJV0FSTl9PTigqcG93ZXJfZG9tYWluX21hc2sgJiBCSVRfVUxMKHBvd2VyX2RvbWFpbikpOwo+ ICsJCXdha2VyZWZzW3Bvd2VyX2RvbWFpbl0gPSB3ZjsKPiAgCQkqcG93ZXJfZG9tYWluX21hc2sg fD0gQklUX1VMTChwb3dlcl9kb21haW4pOwo+ICAKPiAgCQkvKgo+IEBAIC05OTM4LDYgKzk5NDgs NyBAQCBzdGF0aWMgYm9vbCBoYXN3ZWxsX2dldF9waXBlX2NvbmZpZyhzdHJ1Y3QgaW50ZWxfY3J0 YyAqY3J0YywKPiAgCQkJCSAgICBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqcGlwZV9jb25maWcp Cj4gIHsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoY3J0 Yy0+YmFzZS5kZXYpOwo+ICsJaW50ZWxfd2FrZXJlZl90IHdha2VyZWZzW1BPV0VSX0RPTUFJTl9O VU1dLCB3ZjsKPiAgCWVudW0gaW50ZWxfZGlzcGxheV9wb3dlcl9kb21haW4gcG93ZXJfZG9tYWlu Owo+ICAJdTY0IHBvd2VyX2RvbWFpbl9tYXNrOwo+ICAJYm9vbCBhY3RpdmU7Cj4gQEAgLTk5NDUs MTYgKzk5NTYsMjEgQEAgc3RhdGljIGJvb2wgaGFzd2VsbF9nZXRfcGlwZV9jb25maWcoc3RydWN0 IGludGVsX2NydGMgKmNydGMsCj4gIAlpbnRlbF9jcnRjX2luaXRfc2NhbGVycyhjcnRjLCBwaXBl X2NvbmZpZyk7Cj4gIAo+ICAJcG93ZXJfZG9tYWluID0gUE9XRVJfRE9NQUlOX1BJUEUoY3J0Yy0+ cGlwZSk7Cj4gLQlpZiAoIWludGVsX2Rpc3BsYXlfcG93ZXJfZ2V0X2lmX2VuYWJsZWQoZGV2X3By aXYsIHBvd2VyX2RvbWFpbikpCj4gKwl3ZiA9IGludGVsX2Rpc3BsYXlfcG93ZXJfZ2V0X2lmX2Vu YWJsZWQoZGV2X3ByaXYsIHBvd2VyX2RvbWFpbik7Cj4gKwlpZiAoIXdmKQo+ICAJCXJldHVybiBm YWxzZTsKPiArCj4gKwl3YWtlcmVmc1twb3dlcl9kb21haW5dID0gd2Y7Cj4gIAlwb3dlcl9kb21h aW5fbWFzayA9IEJJVF9VTEwocG93ZXJfZG9tYWluKTsKPiAgCj4gIAlwaXBlX2NvbmZpZy0+c2hh cmVkX2RwbGwgPSBOVUxMOwo+ICAKPiAtCWFjdGl2ZSA9IGhzd19nZXRfdHJhbnNjb2Rlcl9zdGF0 ZShjcnRjLCBwaXBlX2NvbmZpZywgJnBvd2VyX2RvbWFpbl9tYXNrKTsKPiArCWFjdGl2ZSA9IGhz d19nZXRfdHJhbnNjb2Rlcl9zdGF0ZShjcnRjLCBwaXBlX2NvbmZpZywKPiArCQkJCQkgICZwb3dl cl9kb21haW5fbWFzaywgd2FrZXJlZnMpOwo+ICAKPiAgCWlmIChJU19HRU45X0xQKGRldl9wcml2 KSAmJgo+IC0JICAgIGJ4dF9nZXRfZHNpX3RyYW5zY29kZXJfc3RhdGUoY3J0YywgcGlwZV9jb25m aWcsICZwb3dlcl9kb21haW5fbWFzaykpIHsKPiArCSAgICBieHRfZ2V0X2RzaV90cmFuc2NvZGVy X3N0YXRlKGNydGMsIHBpcGVfY29uZmlnLAo+ICsJCQkJCSAmcG93ZXJfZG9tYWluX21hc2ssIHdh a2VyZWZzKSkgewo+ICAJCVdBUk5fT04oYWN0aXZlKTsKPiAgCQlhY3RpdmUgPSB0cnVlOwo+ICAJ fQo+IEBAIC05OTg4LDggKzEwMDA0LDExIEBAIHN0YXRpYyBib29sIGhhc3dlbGxfZ2V0X3BpcGVf Y29uZmlnKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+ICAJfQo+ICAKPiAgCXBvd2VyX2RvbWFp biA9IFBPV0VSX0RPTUFJTl9QSVBFX1BBTkVMX0ZJVFRFUihjcnRjLT5waXBlKTsKPiAtCWlmIChp bnRlbF9kaXNwbGF5X3Bvd2VyX2dldF9pZl9lbmFibGVkKGRldl9wcml2LCBwb3dlcl9kb21haW4p KSB7Cj4gLQkJV0FSTl9PTihwb3dlcl9kb21haW5fbWFzayAmIEJJVF9VTEwocG93ZXJfZG9tYWlu KSk7Cj4gKwlXQVJOX09OKHBvd2VyX2RvbWFpbl9tYXNrICYgQklUX1VMTChwb3dlcl9kb21haW4p KTsKPiArCj4gKwl3ZiA9IGludGVsX2Rpc3BsYXlfcG93ZXJfZ2V0X2lmX2VuYWJsZWQoZGV2X3By aXYsIHBvd2VyX2RvbWFpbik7Cj4gKwlpZiAod2YpIHsKPiArCQl3YWtlcmVmc1twb3dlcl9kb21h aW5dID0gd2Y7Cj4gIAkJcG93ZXJfZG9tYWluX21hc2sgfD0gQklUX1VMTChwb3dlcl9kb21haW4p Owo+ICAKPiAgCQlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSA5KQo+IEBAIC0xMDAyMSw3ICsx MDA0MCw4IEBAIHN0YXRpYyBib29sIGhhc3dlbGxfZ2V0X3BpcGVfY29uZmlnKHN0cnVjdCBpbnRl bF9jcnRjICpjcnRjLAo+ICAKPiAgb3V0Ogo+ICAJZm9yX2VhY2hfcG93ZXJfZG9tYWluKHBvd2Vy X2RvbWFpbiwgcG93ZXJfZG9tYWluX21hc2spCj4gLQkJaW50ZWxfZGlzcGxheV9wb3dlcl9wdXRf dW5jaGVja2VkKGRldl9wcml2LCBwb3dlcl9kb21haW4pOwo+ICsJCWludGVsX2Rpc3BsYXlfcG93 ZXJfcHV0KGRldl9wcml2LAo+ICsJCQkJCXBvd2VyX2RvbWFpbiwgd2FrZXJlZnNbcG93ZXJfZG9t YWluXSk7Cj4gIAo+ICAJcmV0dXJuIGFjdGl2ZTsKPiAgfQo+IC0tIAo+IDIuMjAuMQo+IAo+IF9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeApfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGlu ZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=