From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915/ehl: Add support for DPLL4 (v3) Date: Wed, 10 Apr 2019 20:57:20 +0300 Message-ID: <20190410175720.GO3888@intel.com> References: <20190405000616.32568.75409@emeril.freedesktop.org> <20190405175953.7206-1-vivek.kasireddy@intel.com> <20190405183356.GP3888@intel.com> <20190405183911.GQ3888@intel.com> <20190405163330.0b116e9d@vkasired-desk2.fm.intel.com> <20190408091115.GX3888@intel.com> <20190409170044.66f8e92e@vkasired-desk2.fm.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 698008926E for ; Wed, 10 Apr 2019 17:57:24 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190409170044.66f8e92e@vkasired-desk2.fm.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Vivek Kasireddy Cc: intel-gfx@lists.freedesktop.org, Lucas De Marchi List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBBcHIgMDksIDIwMTkgYXQgMDU6MDA6NDRQTSAtMDcwMCwgVml2ZWsgS2FzaXJlZGR5 IHdyb3RlOgo+IE9uIE1vbiwgOCBBcHIgMjAxOSAxMjoxMToxNSArMDMwMAo+IFZpbGxlIFN5cmrD pGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+IHdyb3RlOgo+IEhpLAo+IAo+ID4g T24gRnJpLCBBcHIgMDUsIDIwMTkgYXQgMDQ6MzM6MzBQTSAtMDcwMCwgVml2ZWsgS2FzaXJlZGR5 IHdyb3RlOgo+ID4gPiBPbiBGcmksIDUgQXByIDIwMTkgMjE6Mzk6MTEgKzAzMDAKPiA+ID4gVmls bGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4gd3JvdGU6Cj4gPiA+ IEhpIFZpbGxlLAo+ID4gPiAgIAo+ID4gPiA+IE9uIEZyaSwgQXByIDA1LCAyMDE5IGF0IDA5OjMz OjU2UE0gKzAzMDAsIFZpbGxlIFN5cmrDpGzDpCB3cm90ZTogIAo+ID4gPiA+ID4gT24gRnJpLCBB cHIgMDUsIDIwMTkgYXQgMTA6NTk6NTNBTSAtMDcwMCwgVml2ZWsgS2FzaXJlZGR5Cj4gPiA+ID4g PiB3cm90ZTogICAgCj4gPiA+ID4gPiA+IFRoaXMgcGF0Y2ggYWRkcyBzdXBwb3J0IGZvciBEUExM NCBvbiBFSEwgdGhhdCBpbmNsdWRlIHRoZQo+ID4gPiA+ID4gPiBmb2xsb3dpbmcgcmVzdHJpY3Rp b25zOgo+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gLSBEUExMNCBjYW5ub3QgYmUgdXNlZCB3aXRo IERESUEgKGNvbWJvIHBvcnQgQSBpbnRlcm5hbCBlRFAKPiA+ID4gPiA+ID4gdXNhZ2UpLiBEUExM NCBjYW4gYmUgdXNlZCB3aXRoIG90aGVyIERESXMsIGluY2x1ZGluZyBERElECj4gPiA+ID4gPiA+ ICAgKGNvbWJvIHBvcnQgQSBleHRlcm5hbCB1c2FnZSkuCj4gPiA+ID4gPiA+IAo+ID4gPiA+ID4g PiAtIERQTEw0IGNhbm5vdCBiZSBlbmFibGVkIHdoZW4gREM1IG9yIERDNiBhcmUgZW5hYmxlZC4K PiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+IC0gVGhlIERQTEw0IGVuYWJsZSwgbG9jaywgcG93ZXIg ZW5hYmxlZCwgYW5kIHBvd2VyIHN0YXRlIGFyZQo+ID4gPiA+ID4gPiBjb25uZWN0ZWQgdG8gdGhl IE1HUExMMV9FTkFCTEUgcmVnaXN0ZXIuCj4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiB2MjogKHN1 Z2dlc3Rpb25zIGZyb20gQm9iIFBhYXV3ZSkKPiA+ID4gPiA+ID4gLSBSZXdvcmsgZWhsX2dldF9k cGxsKCkgZnVuY3Rpb24gdG8gY2FsbAo+ID4gPiA+ID4gPiBpbnRlbF9maW5kX3NoYXJlZF9kcGxs KCkgYW5kIGl0ZXJhdGUgdHdpY2U6IG9uY2UgZm9yIENvbWJvCj4gPiA+ID4gPiA+IHBsbHMgYW5k IG9uY2UgZm9yIE1HIHBsbHMuCj4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiAtIFVzZSBNRyBwbGwg ZnVuY3MgZm9yIERQTEw0IGluc3RlYWQgb2YgY3JlYXRpbmcgbmV3IG9uZXMgYW5kCj4gPiA+ID4g PiA+IG1vZGlmeSBtZ19wbGxfZW5hYmxlIHRvIGluY2x1ZGUgdGhlIHJlc3RyaWN0aW9ucyBmb3Ig RUhMLgo+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gdjM6IEZpeCBjb21waWxhdGlvbiBlcnJvcgo+ ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gQ2M6IEx1Y2FzIERlIE1hcmNoaSA8bHVjYXMuZGVtYXJj aGlAaW50ZWwuY29tPgo+ID4gPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBWaXZlayBLYXNpcmVkZHkg PHZpdmVrLmthc2lyZWRkeUBpbnRlbC5jb20+Cj4gPiA+ID4gPiA+IFJldmlld2VkLWJ5OiBCb2Ig UGFhdXdlIDxib2Iuai5wYWF1d2VAaW50ZWwuY29tPgo+ID4gPiA+ID4gPiAtLS0KPiA+ID4gPiA+ ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmMgfCA2MAo+ID4gPiA+ID4g PiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLSAxIGZpbGUgY2hhbmdlZCwgNTkK PiA+ID4gPiA+ID4gaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+ID4gPiA+ID4gPiAKPiA+ ID4gPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdy LmMKPiA+ID4gPiA+ID4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5jIGlu ZGV4Cj4gPiA+ID4gPiA+IGUwMWMwNTdjZTUwYi4uYzNmMGI5NzIwYzU0IDEwMDY0NCAtLS0KPiA+ ID4gPiA+ID4gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5jICsrKwo+ID4g PiA+ID4gPiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmMgQEAgLTI4NzAs NiArMjg3MCw1NiBAQAo+ID4gPiA+ID4gPiBpY2xfZ2V0X2RwbGwoc3RydWN0IGludGVsX2NydGNf c3RhdGUgKmNydGNfc3RhdGUsIHJldHVybiBwbGw7Cj4gPiA+ID4gPiA+ICB9Cj4gPiA+ID4gPiA+ ICAKPiA+ID4gPiA+ID4gK3N0YXRpYyBzdHJ1Y3QgaW50ZWxfc2hhcmVkX2RwbGwgKgo+ID4gPiA+ ID4gPiArZWhsX2dldF9kcGxsKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlLAo+ ID4gPiA+ID4gPiArCSAgICAgc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIpCj4gPiA+ID4g PiA+ICt7Cj4gPiA+ID4gPiA+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0K PiA+ID4gPiA+ID4gdG9faTkxNShjcnRjX3N0YXRlLT5iYXNlLmNydGMtPmRldik7Cj4gPiA+ID4g PiA+ICsJc3RydWN0IGludGVsX3NoYXJlZF9kcGxsICpwbGw7Cj4gPiA+ID4gPiA+ICsJZW51bSBw b3J0IHBvcnQgPSBlbmNvZGVyLT5wb3J0Owo+ID4gPiA+ID4gPiArCWVudW0gaW50ZWxfZHBsbF9p ZCBtaW4sIG1heDsKPiA+ID4gPiA+ID4gKwlib29sIHJldDsKPiA+ID4gPiA+ID4gKwo+ID4gPiA+ ID4gPiArCWlmICghaW50ZWxfcG9ydF9pc19jb21ib3BoeShkZXZfcHJpdiwgcG9ydCkpIHsKPiA+ ID4gPiA+ID4gKwkJTUlTU0lOR19DQVNFKHBvcnQpOwo+ID4gPiA+ID4gPiArCQlyZXR1cm4gTlVM TDsKPiA+ID4gPiA+ID4gKwl9Cj4gPiA+ID4gPiA+ICsKPiA+ID4gPiA+ID4gKwltaW4gPSBEUExM X0lEX0lDTF9EUExMMDsKPiA+ID4gPiA+ID4gKwltYXggPSBEUExMX0lEX0lDTF9EUExMMTsKPiA+ ID4gPiA+ID4gKwlyZXQgPSBpY2xfY2FsY19kcGxsX3N0YXRlKGNydGNfc3RhdGUsIGVuY29kZXIp Owo+ID4gPiA+ID4gPiArCWlmIChyZXQpIHsKPiA+ID4gPiA+ID4gKwkJcGxsID0gaW50ZWxfZmlu ZF9zaGFyZWRfZHBsbChjcnRjX3N0YXRlLCBtaW4sCj4gPiA+ID4gPiA+IG1heCk7Cj4gPiA+ID4g PiA+ICsJCWlmIChwbGwpIHsKPiA+ID4gPiA+ID4gKwkJCWludGVsX3JlZmVyZW5jZV9zaGFyZWRf ZHBsbChwbGwsCj4gPiA+ID4gPiA+IGNydGNfc3RhdGUpOwo+ID4gPiA+ID4gPiArCQkJcmV0dXJu IHBsbDsKPiA+ID4gPiA+ID4gKwkJfQo+ID4gPiA+ID4gPiArCX0gZWxzZSB7Cj4gPiA+ID4gPiA+ ICsJCURSTV9ERUJVR19LTVMoIkNvdWxkIG5vdCBjYWxjdWxhdGUgUExMCj4gPiA+ID4gPiA+IHN0 YXRlLlxuIik7Cj4gPiA+ID4gPiA+ICsJfQo+ID4gPiA+ID4gPiArCj4gPiA+ID4gPiA+ICsJaWYg KGVuY29kZXItPnR5cGUgPT0gSU5URUxfT1VUUFVUX0VEUCkgewo+ID4gPiA+ID4gPiArCQlEUk1f REVCVUdfS01TKCJDYW5ub3QgdXNlIERQTEw0IHdpdGgKPiA+ID4gPiA+ID4gRURQLlxuIik7Cj4g PiA+ID4gPiA+ICsJCXJldHVybiBOVUxMOwo+ID4gPiA+ID4gPiArCX0KPiA+ID4gPiA+ID4gKwo+ ID4gPiA+ID4gPiArCW1pbiA9IG1heCA9IERQTExfSURfSUNMX01HUExMMTsKPiA+ID4gPiA+ID4g KwlyZXQgPSBpY2xfY2FsY19tZ19wbGxfc3RhdGUoY3J0Y19zdGF0ZSk7Cj4gPiA+ID4gPiA+ICsJ aWYgKCFyZXQpIHsKPiA+ID4gPiA+ID4gKwkJRFJNX0RFQlVHX0tNUygiQ291bGQgbm90IGNhbGN1 bGF0ZSBQTEwKPiA+ID4gPiA+ID4gc3RhdGUuXG4iKTsKPiA+ID4gPiA+ID4gKwkJcmV0dXJuIE5V TEw7Cj4gPiA+ID4gPiA+ICsJfQo+ID4gPiA+ID4gPiArCj4gPiA+ID4gPiA+ICsJcGxsID0gaW50 ZWxfZmluZF9zaGFyZWRfZHBsbChjcnRjX3N0YXRlLCBtaW4sIG1heCk7Cj4gPiA+ID4gPiA+ICsJ aWYgKCFwbGwpIHsKPiA+ID4gPiA+ID4gKwkJRFJNX0RFQlVHX0tNUygiTm8gUExMIHNlbGVjdGVk XG4iKTsKPiA+ID4gPiA+ID4gKwkJcmV0dXJuIE5VTEw7Cj4gPiA+ID4gPiA+ICsJfQo+ID4gPiA+ ID4gPiArCj4gPiA+ID4gPiA+ICsJaW50ZWxfcmVmZXJlbmNlX3NoYXJlZF9kcGxsKHBsbCwgY3J0 Y19zdGF0ZSk7Cj4gPiA+ID4gPiA+ICsJcmV0dXJuIHBsbDsKPiA+ID4gPiA+ID4gK30KPiA+ID4g PiA+ID4gKwo+ID4gPiA+ID4gPiAgc3RhdGljIGJvb2wgbWdfcGxsX2dldF9od19zdGF0ZShzdHJ1 Y3QgZHJtX2k5MTVfcHJpdmF0ZQo+ID4gPiA+ID4gPiAqZGV2X3ByaXYsIHN0cnVjdCBpbnRlbF9z aGFyZWRfZHBsbCAqcGxsLAo+ID4gPiA+ID4gPiAgCQkJCXN0cnVjdCBpbnRlbF9kcGxsX2h3X3N0 YXRlCj4gPiA+ID4gPiA+ICpod19zdGF0ZSkgQEAgLTMxMTUsNiArMzE2NSwxMyBAQCBzdGF0aWMg dm9pZAo+ID4gPiA+ID4gPiBtZ19wbGxfZW5hYmxlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdiwgaTkxNV9yZWdfdAo+ID4gPiA+ID4gPiBlbmFibGVfcmVnID0KPiA+ID4gPiA+ID4g TUdfUExMX0VOQUJMRShpY2xfcGxsX2lkX3RvX3RjX3BvcnQocGxsLT5pbmZvLT5pZCkpOyAKPiA+ ID4gPiA+ID4gKwlpZiAoSVNfRUxLSEFSVExBS0UoZGV2X3ByaXYpICYmCj4gPiA+ID4gPiA+ICsJ ICAgKEk5MTVfUkVBRChEQ19TVEFURV9FTikgJiBEQ19TVEFURV9FTl9VUFRPX0RDNSB8fAo+ID4g PiA+ID4gPiArCSAgICBJOTE1X1JFQUQoRENfU1RBVEVfRU4pICYgRENfU1RBVEVfRU5fVVBUT19E QzYpKSB7Cj4gPiA+ID4gPiA+ICsJCURSTV9FUlJPUigiQ2FudCBlbmFibGUgRFBMTDQgd2hlbiBE QzUgb3IgREM2Cj4gPiA+ID4gPiA+IGFyZSBlbmFibGVkXG4iKTsKPiA+ID4gPiA+ID4gKwkJcmV0 dXJuOwo+ID4gPiA+ID4gPiArCX0gICAgCj4gPiA+ID4gPiAKPiA+ID4gPiA+IFRoaXMgbG9va3Mg bGlrZSBkZWFkIGNvZGUsIG9yIHdlIG1lc3NlZCB1cCBlYXJsaWVyIGFscmVhZHkgKGluCj4gPiA+ ID4gPiB3aGljaCBjYXNlIGl0IHNob3VsZCBqdXN0IGJlIHNvbWUga2luZCBvZiBhc3NlcnQgSU1P KS4gICAgCj4gPiA+IEFyZSB5b3Ugc3VnZ2VzdGluZyB0aGF0IEkgcHV0IHRoaXMgaW4gYSAtPnBy ZXBhcmUoKSBob29rIG9yIG11Y2gKPiA+ID4gZWFybGllciBpbiB0aGUgYXRvbWljIGNoZWNrL3By ZXBhcmUgcGhhc2U/IEZZSSwgSSBhbSBqdXN0IGFkZGluZyBhCj4gPiA+IHJlc3RyaWN0aW9uIG1l bnRpb25lZCBpbiB0aGUgc3BlYyBjb25jZXJuaW5nIHRoaXMgRFBMTC4KPiA+ID4gICAKPiA+ID4g PiAKPiA+ID4gPiBEb2VzIERNQyBoYW5kbGUgb3RoZXIgTUcgUExMcz8gSSB3b3VsZCBoYXZlIHRo b3VnaHQgbm90LCBzbyBpZiB3ZQo+ID4gPiA+IGtlZXAgdGhlIGFzc2VydCB0aGVuIGl0IHNob3Vs ZCBwZXJoYXBzIGJlIHVuY29uZGl0aW9uYWwuIEhtbS4gQnV0Cj4gPiA+ID4gYXJlbid0IHdlIHN0 aWxsIGhvZGxpbmcgdGhlIG1vZGVzZXQgcG93ZXIgZG9tYWluIHdoZW4gdGhpcyBnZXRzCj4gPiA+ ID4gY2FsbGVkPyBJZiBzbyB0aGlzIGlzIGRlZmluaXRlbHkgZGVhZCBjb2RlLiAgCj4gPiA+IEkg YW0gbm90IHN1cmUgd2hldGhlciBETUMgaGFuZGxlcyBvdGhlciBNRyBQTExzIGJ1dCB0aGUgc3Bl Ywo+ID4gPiBleHBsaWNpdGx5IHNheXMgdGhhdCBETUMgd2lsbCBub3QgaGFuZGxlIHRoaXMgUExM LiBXaGVyZSBkbyB5b3UKPiA+ID4gc3VnZ2VzdCBpcyBhbiBhcHByb3ByaWF0ZSBwbGFjZSB0byBw dXQgdGhpcyBhc3NlcnQ/ICAKPiA+IAo+ID4gREM1LzYgZW5hYmxlIHByb2JhYmx5IGlzIHRoZSBi ZXN0LCBpZiB3ZSBldmVuIHdhbnQgdGhlIGFzc2VydC4gQW5kIEknbQo+ID4gbm90IGNvbnZpbmNl ZCB0aGF0IHdlIGRvIHNpbmNlIHdlIGRvbid0IGhhdmUgaXQgZm9yIGFueSBvdGhlciBQTEwKPiA+ IGVpdGhlci4KPiBBcyBJIG1lbnRpb25lZCBlYXJsaWVyLCB0aGUgc3BlYyBzYXlzIHdlIGNhbm5v dCBlbmFibGUgdGhpcyBEUExMIGZvciBFSEwKPiBpZiBEQzUgb3IgREM2IGlzIGVuYWJsZWQuIERv IHlvdSB0aGluayB3ZSBzaG91bGQgZGlzYWJsZSBEQzUvREM2IG9uIEVITAo+IGluIG9yZGVyIHRv IGVuYWJsZSB0aGlzIERQTEwgb24gRUhMPyBTaG91bGQgdGhlIHVzZXIvc3lzdGVtIGludGVncmF0 b3IgCj4gYmUgbWFraW5nIHRoYXQgZGVjaXNpb24gdmlhIGEgbW9kdWxlIHBhcmFtZXRlcj8KCklm IHRoZXJlIGlzIHNvbWUgd2F5IHRoYXQgY291bGQgaGFwcGVuIGN1cnJlbnRseSwgdGhlbiB3ZSBu ZWVkIHRvCnByZXZlbnQgREM1LzYgdmlhIHNvbWUgcG93ZXIgZG9tYWluIHN0dWZmLgoKLS0gClZp bGxlIFN5cmrDpGzDpApJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZng=