From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Nuke drm_crtc_state and use intel_atomic_state instead Date: Fri, 12 Apr 2019 09:11:58 +0300 Message-ID: <20190412061158.GE3888@intel.com> References: <20190411230254.6357-1-manasi.d.navare@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 50716898A4 for ; Fri, 12 Apr 2019 06:12:02 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190411230254.6357-1-manasi.d.navare@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Manasi Navare Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBBcHIgMTEsIDIwMTkgYXQgMDQ6MDI6NTRQTSAtMDcwMCwgTWFuYXNpIE5hdmFyZSB3 cm90ZToKPiBUaGlzIGlzIG9uZSBvZiB0aGUgcGF0Y2hlcyB0byBzdGFydCByZXBsYWNpbmcgZHJt IHBvaW50ZXJzCj4gYW5kIHVzZSB0aGUgaW50ZWxfYXRvbWljX3N0YXRlIGFuZCBpbnRlbF9jcnRj IHRvIGRlcml2ZQo+IHRoZSBuZWNlc3NhcnkgaW50ZWwgc3RhdGUgdmFyaWFibGVzIHJlcXVpcmVk IGZvciB0aGUgaW50ZWwKPiBtb2Rlc2V0IGZ1bmN0aW9ucy4KPiAKPiBTdWdnZXN0ZWQtYnk6IFZp bGxlIFN5cmphbGEgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IENjOiBWaWxsZSBT eXJqYWxhIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBN YW5hc2kgTmF2YXJlIDxtYW5hc2kuZC5uYXZhcmVAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCAzOCArKysrKysrKysrKysrLS0tLS0tLS0t LS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxOCBpbnNlcnRpb25zKCspLCAyMCBkZWxldGlvbnMo LSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5j IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gaW5kZXggZjI5YTM0OGU4 ZDcxLi4wNjJiOWU4NmE5ODcgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5j Cj4gQEAgLTEyNSw4ICsxMjUsOCBAQCBzdGF0aWMgdm9pZCB2bHZfcHJlcGFyZV9wbGwoc3RydWN0 IGludGVsX2NydGMgKmNydGMsCj4gIAkJCSAgICBjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0 ZSAqcGlwZV9jb25maWcpOwo+ICBzdGF0aWMgdm9pZCBjaHZfcHJlcGFyZV9wbGwoc3RydWN0IGlu dGVsX2NydGMgKmNydGMsCj4gIAkJCSAgICBjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAq cGlwZV9jb25maWcpOwo+IC1zdGF0aWMgdm9pZCBpbnRlbF9iZWdpbl9jcnRjX2NvbW1pdChzdHJ1 Y3QgZHJtX2NydGMgKiwgc3RydWN0IGRybV9jcnRjX3N0YXRlICopOwo+IC1zdGF0aWMgdm9pZCBp bnRlbF9maW5pc2hfY3J0Y19jb21taXQoc3RydWN0IGRybV9jcnRjICosIHN0cnVjdCBkcm1fY3J0 Y19zdGF0ZSAqKTsKPiArc3RhdGljIHZvaWQgaW50ZWxfYmVnaW5fY3J0Y19jb21taXQoc3RydWN0 IGludGVsX2NydGMgKiwgc3RydWN0IGludGVsX2F0b21pY19zdGF0ZSAqKTsKPiArc3RhdGljIHZv aWQgaW50ZWxfZmluaXNoX2NydGNfY29tbWl0KHN0cnVjdCBpbnRlbF9jcnRjICosIHN0cnVjdCBp bnRlbF9hdG9taWNfc3RhdGUgKik7Cj4gIHN0YXRpYyB2b2lkIGludGVsX2NydGNfaW5pdF9zY2Fs ZXJzKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+ICAJCQkJICAgIHN0cnVjdCBpbnRlbF9jcnRj X3N0YXRlICpjcnRjX3N0YXRlKTsKPiAgc3RhdGljIHZvaWQgc2t5bGFrZV9wZml0X2VuYWJsZShj b25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSk7Cj4gQEAgLTEzMjczLDE0 ICsxMzI3MywxNCBAQCBzdGF0aWMgdm9pZCBpbnRlbF91cGRhdGVfY3J0YyhzdHJ1Y3QgZHJtX2Ny dGMgKmNydGMsCj4gIAllbHNlIGlmIChuZXdfcGxhbmVfc3RhdGUpCj4gIAkJaW50ZWxfZmJjX2Vu YWJsZShpbnRlbF9jcnRjLCBwaXBlX2NvbmZpZywgbmV3X3BsYW5lX3N0YXRlKTsKPiAgCj4gLQlp bnRlbF9iZWdpbl9jcnRjX2NvbW1pdChjcnRjLCBvbGRfY3J0Y19zdGF0ZSk7Cj4gKwlpbnRlbF9i ZWdpbl9jcnRjX2NvbW1pdChpbnRlbF9jcnRjLCB0b19pbnRlbF9hdG9taWNfc3RhdGUoc3RhdGUp KTsKPiAgCj4gIAlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSA5KQo+ICAJCXNrbF91cGRhdGVf cGxhbmVzX29uX2NydGModG9faW50ZWxfYXRvbWljX3N0YXRlKHN0YXRlKSwgaW50ZWxfY3J0Yyk7 Cj4gIAllbHNlCj4gIAkJaTl4eF91cGRhdGVfcGxhbmVzX29uX2NydGModG9faW50ZWxfYXRvbWlj X3N0YXRlKHN0YXRlKSwgaW50ZWxfY3J0Yyk7Cj4gIAo+IC0JaW50ZWxfZmluaXNoX2NydGNfY29t bWl0KGNydGMsIG9sZF9jcnRjX3N0YXRlKTsKPiArCWludGVsX2ZpbmlzaF9jcnRjX2NvbW1pdChp bnRlbF9jcnRjLCB0b19pbnRlbF9hdG9taWNfc3RhdGUoc3RhdGUpKTsKPiAgfQo+ICAKPiAgc3Rh dGljIHZvaWQgaW50ZWxfdXBkYXRlX2NydGNzKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0 ZSkKPiBAQCAtMTQwNzAsMTggKzE0MDcwLDE2IEBAIHNrbF9tYXhfc2NhbGUoY29uc3Qgc3RydWN0 IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUsCj4gIAlyZXR1cm4gbWF4X3NjYWxlOwo+ICB9 Cj4gIAo+IC1zdGF0aWMgdm9pZCBpbnRlbF9iZWdpbl9jcnRjX2NvbW1pdChzdHJ1Y3QgZHJtX2Ny dGMgKmNydGMsCj4gLQkJCQkgICAgc3RydWN0IGRybV9jcnRjX3N0YXRlICpvbGRfY3J0Y19zdGF0 ZSkKPiArc3RhdGljIHZvaWQgaW50ZWxfYmVnaW5fY3J0Y19jb21taXQoc3RydWN0IGludGVsX2Ny dGMgKmNydGMsCj4gKwkJCQkgICAgc3RydWN0IGludGVsX2F0b21pY19zdGF0ZSAqc3RhdGUpCgpG bGlwIHRoZSBhcmd1bWVudHMgYXJvdW5kIHRvIGJlIGNvbnNpc3RlbnQgd2l0aCBleGlzdGluZyBj b2RlLgoKPiAgewo+IC0Jc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGNydGMtPmRldjsKPiArCXN0 cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBjcnRjLT5iYXNlLmRldjsKClRoYXQgY2FuIGJlIGtpbGxl ZCBhcyB3ZWxsLgoKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5 MTUoZGV2KTsKPiAtCXN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRjID0gdG9faW50ZWxfY3J0 YyhjcnRjKTsKPiAgCXN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpvbGRfaW50ZWxfY3N0YXRlID0K ClBsZWFzZSByZW5hbWUgdG8gb2xkX2NydGNfc3RhdGUsIGFuZCBzaW1pbGFybHkgZm9yIG5ld19j cnRjX3N0YXRlLgoKPiAtCQl0b19pbnRlbF9jcnRjX3N0YXRlKG9sZF9jcnRjX3N0YXRlKTsKPiAt CXN0cnVjdCBpbnRlbF9hdG9taWNfc3RhdGUgKm9sZF9pbnRlbF9zdGF0ZSA9Cj4gLQkJdG9faW50 ZWxfYXRvbWljX3N0YXRlKG9sZF9jcnRjX3N0YXRlLT5zdGF0ZSk7Cj4gKwkJaW50ZWxfYXRvbWlj X2dldF9vbGRfY3J0Y19zdGF0ZShzdGF0ZSwKPiArCQkJCQkJY3J0Yyk7CgpUb28gbWFueSBuZXds aW5lcy4KCj4gIAlzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqaW50ZWxfY3N0YXRlID0KPiAtCQlp bnRlbF9hdG9taWNfZ2V0X25ld19jcnRjX3N0YXRlKG9sZF9pbnRlbF9zdGF0ZSwgaW50ZWxfY3J0 Yyk7Cj4gKwkJaW50ZWxfYXRvbWljX2dldF9uZXdfY3J0Y19zdGF0ZShzdGF0ZSwgY3J0Yyk7Cj4g IAlib29sIG1vZGVzZXQgPSBuZWVkc19tb2Rlc2V0KCZpbnRlbF9jc3RhdGUtPmJhc2UpOwo+ICAK PiAgCS8qIFBlcmZvcm0gdmJsYW5rIGV2YXNpb24gYXJvdW5kIGNvbW1pdCBvcGVyYXRpb24gKi8K PiBAQCAtMTQxMDEsNyArMTQwOTksNyBAQCBzdGF0aWMgdm9pZCBpbnRlbF9iZWdpbl9jcnRjX2Nv bW1pdChzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gIAo+ICBvdXQ6Cj4gIAlpZiAoZGV2X3ByaXYt PmRpc3BsYXkuYXRvbWljX3VwZGF0ZV93YXRlcm1hcmtzKQo+IC0JCWRldl9wcml2LT5kaXNwbGF5 LmF0b21pY191cGRhdGVfd2F0ZXJtYXJrcyhvbGRfaW50ZWxfc3RhdGUsCj4gKwkJZGV2X3ByaXYt PmRpc3BsYXkuYXRvbWljX3VwZGF0ZV93YXRlcm1hcmtzKHN0YXRlLAo+ICAJCQkJCQkJICAgaW50 ZWxfY3N0YXRlKTsKPiAgfQo+ICAKPiBAQCAtMTQxMjEsMjEgKzE0MTE5LDIxIEBAIHZvaWQgaW50 ZWxfY3J0Y19hcm1fZmlmb191bmRlcnJ1bihzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywKPiAgCX0K PiAgfQo+ICAKPiAtc3RhdGljIHZvaWQgaW50ZWxfZmluaXNoX2NydGNfY29tbWl0KHN0cnVjdCBk cm1fY3J0YyAqY3J0YywKPiAtCQkJCSAgICAgc3RydWN0IGRybV9jcnRjX3N0YXRlICpvbGRfY3J0 Y19zdGF0ZSkKPiArc3RhdGljIHZvaWQgaW50ZWxfZmluaXNoX2NydGNfY29tbWl0KHN0cnVjdCBp bnRlbF9jcnRjICpjcnRjLAo+ICsJCQkJICAgICBzdHJ1Y3QgaW50ZWxfYXRvbWljX3N0YXRlICpz dGF0ZSkKPiAgewo+IC0Jc3RydWN0IGludGVsX2NydGMgKmludGVsX2NydGMgPSB0b19pbnRlbF9j cnRjKGNydGMpOwo+IC0Jc3RydWN0IGludGVsX2F0b21pY19zdGF0ZSAqb2xkX2ludGVsX3N0YXRl ID0KPiAtCQl0b19pbnRlbF9hdG9taWNfc3RhdGUob2xkX2NydGNfc3RhdGUtPnN0YXRlKTsKPiAr CXN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqb2xkX2NydGNfc3RhdGUgPQoKUGxzIGNvbnZlcnQgdGhp cyB0byBpbnRlbCB0eXBlIGFzIHdlbGwuCgo+ICsJCSZpbnRlbF9hdG9taWNfZ2V0X29sZF9jcnRj X3N0YXRlKHN0YXRlLAo+ICsJCQkJCQljcnRjKS0+YmFzZTsKPiAgCXN0cnVjdCBpbnRlbF9jcnRj X3N0YXRlICpuZXdfY3J0Y19zdGF0ZSA9Cj4gLQkJaW50ZWxfYXRvbWljX2dldF9uZXdfY3J0Y19z dGF0ZShvbGRfaW50ZWxfc3RhdGUsIGludGVsX2NydGMpOwo+ICsJCWludGVsX2F0b21pY19nZXRf bmV3X2NydGNfc3RhdGUoc3RhdGUsIGNydGMpOwo+ICAKPiAgCWludGVsX3BpcGVfdXBkYXRlX2Vu ZChuZXdfY3J0Y19zdGF0ZSk7Cj4gIAo+ICAJaWYgKG5ld19jcnRjX3N0YXRlLT51cGRhdGVfcGlw ZSAmJgo+ICAJICAgICFuZWVkc19tb2Rlc2V0KCZuZXdfY3J0Y19zdGF0ZS0+YmFzZSkgJiYKPiAg CSAgICBvbGRfY3J0Y19zdGF0ZS0+bW9kZS5wcml2YXRlX2ZsYWdzICYgSTkxNV9NT0RFX0ZMQUdf SU5IRVJJVEVEKQo+IC0JCWludGVsX2NydGNfYXJtX2ZpZm9fdW5kZXJydW4oaW50ZWxfY3J0Yywg bmV3X2NydGNfc3RhdGUpOwo+ICsJCWludGVsX2NydGNfYXJtX2ZpZm9fdW5kZXJydW4oY3J0Yywg bmV3X2NydGNfc3RhdGUpOwo+ICB9Cj4gIAo+ICAvKioKPiAtLSAKPiAyLjE5LjEKCi0tIApWaWxs ZSBTeXJqw6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4