From mboxrd@z Thu Jan  1 00:00:00 1970
From: Manasi Navare <manasi.d.navare@intel.com>
Subject: Re: [PATCH] drm/i915: Nuke drm_crtc_state and use
 intel_atomic_state instead
Date: Fri, 12 Apr 2019 12:58:50 -0700
Message-ID: <20190412195850.GE17858@intel.com>
References: <20190411230254.6357-1-manasi.d.navare@intel.com>
 <20190412061158.GE3888@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 57DC6899EA
 for <intel-gfx@lists.freedesktop.org>; Fri, 12 Apr 2019 19:56:33 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20190412061158.GE3888@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gRnJpLCBBcHIgMTIsIDIwMTkgYXQgMDk6MTE6NThBTSArMDMwMCwgVmlsbGUgU3lyasOkbMOk
IHdyb3RlOgo+IE9uIFRodSwgQXByIDExLCAyMDE5IGF0IDA0OjAyOjU0UE0gLTA3MDAsIE1hbmFz
aSBOYXZhcmUgd3JvdGU6Cj4gPiBUaGlzIGlzIG9uZSBvZiB0aGUgcGF0Y2hlcyB0byBzdGFydCBy
ZXBsYWNpbmcgZHJtIHBvaW50ZXJzCj4gPiBhbmQgdXNlIHRoZSBpbnRlbF9hdG9taWNfc3RhdGUg
YW5kIGludGVsX2NydGMgdG8gZGVyaXZlCj4gPiB0aGUgbmVjZXNzYXJ5IGludGVsIHN0YXRlIHZh
cmlhYmxlcyByZXF1aXJlZCBmb3IgdGhlIGludGVsCj4gPiBtb2Rlc2V0IGZ1bmN0aW9ucy4KPiA+
IAo+ID4gU3VnZ2VzdGVkLWJ5OiBWaWxsZSBTeXJqYWxhIDx2aWxsZS5zeXJqYWxhQGxpbnV4Lmlu
dGVsLmNvbT4KPiA+IENjOiBWaWxsZSBTeXJqYWxhIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVs
LmNvbT4KPiA+IFNpZ25lZC1vZmYtYnk6IE1hbmFzaSBOYXZhcmUgPG1hbmFzaS5kLm5hdmFyZUBp
bnRlbC5jb20+Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5
LmMgfCAzOCArKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tCj4gPiAgMSBmaWxlIGNoYW5nZWQs
IDE4IGluc2VydGlvbnMoKyksIDIwIGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEv
ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5
MTUvaW50ZWxfZGlzcGxheS5jCj4gPiBpbmRleCBmMjlhMzQ4ZThkNzEuLjA2MmI5ZTg2YTk4NyAx
MDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4g
KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiBAQCAtMTI1LDgg
KzEyNSw4IEBAIHN0YXRpYyB2b2lkIHZsdl9wcmVwYXJlX3BsbChzdHJ1Y3QgaW50ZWxfY3J0YyAq
Y3J0YywKPiA+ICAJCQkgICAgY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKnBpcGVfY29u
ZmlnKTsKPiA+ICBzdGF0aWMgdm9pZCBjaHZfcHJlcGFyZV9wbGwoc3RydWN0IGludGVsX2NydGMg
KmNydGMsCj4gPiAgCQkJICAgIGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpwaXBlX2Nv
bmZpZyk7Cj4gPiAtc3RhdGljIHZvaWQgaW50ZWxfYmVnaW5fY3J0Y19jb21taXQoc3RydWN0IGRy
bV9jcnRjICosIHN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqKTsKPiA+IC1zdGF0aWMgdm9pZCBpbnRl
bF9maW5pc2hfY3J0Y19jb21taXQoc3RydWN0IGRybV9jcnRjICosIHN0cnVjdCBkcm1fY3J0Y19z
dGF0ZSAqKTsKPiA+ICtzdGF0aWMgdm9pZCBpbnRlbF9iZWdpbl9jcnRjX2NvbW1pdChzdHJ1Y3Qg
aW50ZWxfY3J0YyAqLCBzdHJ1Y3QgaW50ZWxfYXRvbWljX3N0YXRlICopOwo+ID4gK3N0YXRpYyB2
b2lkIGludGVsX2ZpbmlzaF9jcnRjX2NvbW1pdChzdHJ1Y3QgaW50ZWxfY3J0YyAqLCBzdHJ1Y3Qg
aW50ZWxfYXRvbWljX3N0YXRlICopOwo+ID4gIHN0YXRpYyB2b2lkIGludGVsX2NydGNfaW5pdF9z
Y2FsZXJzKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+ID4gIAkJCQkgICAgc3RydWN0IGludGVs
X2NydGNfc3RhdGUgKmNydGNfc3RhdGUpOwo+ID4gIHN0YXRpYyB2b2lkIHNreWxha2VfcGZpdF9l
bmFibGUoY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUpOwo+ID4gQEAg
LTEzMjczLDE0ICsxMzI3MywxNCBAQCBzdGF0aWMgdm9pZCBpbnRlbF91cGRhdGVfY3J0YyhzdHJ1
Y3QgZHJtX2NydGMgKmNydGMsCj4gPiAgCWVsc2UgaWYgKG5ld19wbGFuZV9zdGF0ZSkKPiA+ICAJ
CWludGVsX2ZiY19lbmFibGUoaW50ZWxfY3J0YywgcGlwZV9jb25maWcsIG5ld19wbGFuZV9zdGF0
ZSk7Cj4gPiAgCj4gPiAtCWludGVsX2JlZ2luX2NydGNfY29tbWl0KGNydGMsIG9sZF9jcnRjX3N0
YXRlKTsKPiA+ICsJaW50ZWxfYmVnaW5fY3J0Y19jb21taXQoaW50ZWxfY3J0YywgdG9faW50ZWxf
YXRvbWljX3N0YXRlKHN0YXRlKSk7Cj4gPiAgCj4gPiAgCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYp
ID49IDkpCj4gPiAgCQlza2xfdXBkYXRlX3BsYW5lc19vbl9jcnRjKHRvX2ludGVsX2F0b21pY19z
dGF0ZShzdGF0ZSksIGludGVsX2NydGMpOwo+ID4gIAllbHNlCj4gPiAgCQlpOXh4X3VwZGF0ZV9w
bGFuZXNfb25fY3J0Yyh0b19pbnRlbF9hdG9taWNfc3RhdGUoc3RhdGUpLCBpbnRlbF9jcnRjKTsK
PiA+ICAKPiA+IC0JaW50ZWxfZmluaXNoX2NydGNfY29tbWl0KGNydGMsIG9sZF9jcnRjX3N0YXRl
KTsKPiA+ICsJaW50ZWxfZmluaXNoX2NydGNfY29tbWl0KGludGVsX2NydGMsIHRvX2ludGVsX2F0
b21pY19zdGF0ZShzdGF0ZSkpOwo+ID4gIH0KPiA+ICAKPiA+ICBzdGF0aWMgdm9pZCBpbnRlbF91
cGRhdGVfY3J0Y3Moc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlKQo+ID4gQEAgLTE0MDcw
LDE4ICsxNDA3MCwxNiBAQCBza2xfbWF4X3NjYWxlKGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0
YXRlICpjcnRjX3N0YXRlLAo+ID4gIAlyZXR1cm4gbWF4X3NjYWxlOwo+ID4gIH0KPiA+ICAKPiA+
IC1zdGF0aWMgdm9pZCBpbnRlbF9iZWdpbl9jcnRjX2NvbW1pdChzdHJ1Y3QgZHJtX2NydGMgKmNy
dGMsCj4gPiAtCQkJCSAgICBzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKm9sZF9jcnRjX3N0YXRlKQo+
ID4gK3N0YXRpYyB2b2lkIGludGVsX2JlZ2luX2NydGNfY29tbWl0KHN0cnVjdCBpbnRlbF9jcnRj
ICpjcnRjLAo+ID4gKwkJCQkgICAgc3RydWN0IGludGVsX2F0b21pY19zdGF0ZSAqc3RhdGUpCj4g
Cj4gRmxpcCB0aGUgYXJndW1lbnRzIGFyb3VuZCB0byBiZSBjb25zaXN0ZW50IHdpdGggZXhpc3Rp
bmcgY29kZS4KCkJ1dCBtb3N0IGZ1bmN0aW9ucyBoYXZlIHRoZSBtb2Rlc2V0IG9iamVjdCAoY3J0
YywgcGxhbmUgZXRjKSBhcyB0aGUgZmlyc3QgYXJndW1lbnQKdGhlbiB0aGUgc3RhdGUuCkRvIHlv
dSBzdGlsbCB3YW50IHRvIGZsaXAgdGhlIGFyZ3VtZW50cz8KCk1hbmFzaQoKPiAKPiA+ICB7Cj4g
PiAtCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBjcnRjLT5kZXY7Cj4gPiArCXN0cnVjdCBkcm1f
ZGV2aWNlICpkZXYgPSBjcnRjLT5iYXNlLmRldjsKPiAKPiBUaGF0IGNhbiBiZSBraWxsZWQgYXMg
d2VsbC4KPiAKPiA+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkx
NShkZXYpOwo+ID4gLQlzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50ZWxfY3J0YyA9IHRvX2ludGVsX2Ny
dGMoY3J0Yyk7Cj4gPiAgCXN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpvbGRfaW50ZWxfY3N0YXRl
ID0KPiAKPiBQbGVhc2UgcmVuYW1lIHRvIG9sZF9jcnRjX3N0YXRlLCBhbmQgc2ltaWxhcmx5IGZv
ciBuZXdfY3J0Y19zdGF0ZS4KPiAKPiA+IC0JCXRvX2ludGVsX2NydGNfc3RhdGUob2xkX2NydGNf
c3RhdGUpOwo+ID4gLQlzdHJ1Y3QgaW50ZWxfYXRvbWljX3N0YXRlICpvbGRfaW50ZWxfc3RhdGUg
PQo+ID4gLQkJdG9faW50ZWxfYXRvbWljX3N0YXRlKG9sZF9jcnRjX3N0YXRlLT5zdGF0ZSk7Cj4g
PiArCQlpbnRlbF9hdG9taWNfZ2V0X29sZF9jcnRjX3N0YXRlKHN0YXRlLAo+ID4gKwkJCQkJCWNy
dGMpOwo+IAo+IFRvbyBtYW55IG5ld2xpbmVzLgo+IAo+ID4gIAlzdHJ1Y3QgaW50ZWxfY3J0Y19z
dGF0ZSAqaW50ZWxfY3N0YXRlID0KPiA+IC0JCWludGVsX2F0b21pY19nZXRfbmV3X2NydGNfc3Rh
dGUob2xkX2ludGVsX3N0YXRlLCBpbnRlbF9jcnRjKTsKPiA+ICsJCWludGVsX2F0b21pY19nZXRf
bmV3X2NydGNfc3RhdGUoc3RhdGUsIGNydGMpOwo+ID4gIAlib29sIG1vZGVzZXQgPSBuZWVkc19t
b2Rlc2V0KCZpbnRlbF9jc3RhdGUtPmJhc2UpOwo+ID4gIAo+ID4gIAkvKiBQZXJmb3JtIHZibGFu
ayBldmFzaW9uIGFyb3VuZCBjb21taXQgb3BlcmF0aW9uICovCj4gPiBAQCAtMTQxMDEsNyArMTQw
OTksNyBAQCBzdGF0aWMgdm9pZCBpbnRlbF9iZWdpbl9jcnRjX2NvbW1pdChzdHJ1Y3QgZHJtX2Ny
dGMgKmNydGMsCj4gPiAgCj4gPiAgb3V0Ogo+ID4gIAlpZiAoZGV2X3ByaXYtPmRpc3BsYXkuYXRv
bWljX3VwZGF0ZV93YXRlcm1hcmtzKQo+ID4gLQkJZGV2X3ByaXYtPmRpc3BsYXkuYXRvbWljX3Vw
ZGF0ZV93YXRlcm1hcmtzKG9sZF9pbnRlbF9zdGF0ZSwKPiA+ICsJCWRldl9wcml2LT5kaXNwbGF5
LmF0b21pY191cGRhdGVfd2F0ZXJtYXJrcyhzdGF0ZSwKPiA+ICAJCQkJCQkJICAgaW50ZWxfY3N0
YXRlKTsKPiA+ICB9Cj4gPiAgCj4gPiBAQCAtMTQxMjEsMjEgKzE0MTE5LDIxIEBAIHZvaWQgaW50
ZWxfY3J0Y19hcm1fZmlmb191bmRlcnJ1bihzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywKPiA+ICAJ
fQo+ID4gIH0KPiA+ICAKPiA+IC1zdGF0aWMgdm9pZCBpbnRlbF9maW5pc2hfY3J0Y19jb21taXQo
c3RydWN0IGRybV9jcnRjICpjcnRjLAo+ID4gLQkJCQkgICAgIHN0cnVjdCBkcm1fY3J0Y19zdGF0
ZSAqb2xkX2NydGNfc3RhdGUpCj4gPiArc3RhdGljIHZvaWQgaW50ZWxfZmluaXNoX2NydGNfY29t
bWl0KHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+ID4gKwkJCQkgICAgIHN0cnVjdCBpbnRlbF9h
dG9taWNfc3RhdGUgKnN0YXRlKQo+ID4gIHsKPiA+IC0Jc3RydWN0IGludGVsX2NydGMgKmludGVs
X2NydGMgPSB0b19pbnRlbF9jcnRjKGNydGMpOwo+ID4gLQlzdHJ1Y3QgaW50ZWxfYXRvbWljX3N0
YXRlICpvbGRfaW50ZWxfc3RhdGUgPQo+ID4gLQkJdG9faW50ZWxfYXRvbWljX3N0YXRlKG9sZF9j
cnRjX3N0YXRlLT5zdGF0ZSk7Cj4gPiArCXN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqb2xkX2NydGNf
c3RhdGUgPQo+IAo+IFBscyBjb252ZXJ0IHRoaXMgdG8gaW50ZWwgdHlwZSBhcyB3ZWxsLgo+IAo+
ID4gKwkJJmludGVsX2F0b21pY19nZXRfb2xkX2NydGNfc3RhdGUoc3RhdGUsCj4gPiArCQkJCQkJ
Y3J0YyktPmJhc2U7Cj4gPiAgCXN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpuZXdfY3J0Y19zdGF0
ZSA9Cj4gPiAtCQlpbnRlbF9hdG9taWNfZ2V0X25ld19jcnRjX3N0YXRlKG9sZF9pbnRlbF9zdGF0
ZSwgaW50ZWxfY3J0Yyk7Cj4gPiArCQlpbnRlbF9hdG9taWNfZ2V0X25ld19jcnRjX3N0YXRlKHN0
YXRlLCBjcnRjKTsKPiA+ICAKPiA+ICAJaW50ZWxfcGlwZV91cGRhdGVfZW5kKG5ld19jcnRjX3N0
YXRlKTsKPiA+ICAKPiA+ICAJaWYgKG5ld19jcnRjX3N0YXRlLT51cGRhdGVfcGlwZSAmJgo+ID4g
IAkgICAgIW5lZWRzX21vZGVzZXQoJm5ld19jcnRjX3N0YXRlLT5iYXNlKSAmJgo+ID4gIAkgICAg
b2xkX2NydGNfc3RhdGUtPm1vZGUucHJpdmF0ZV9mbGFncyAmIEk5MTVfTU9ERV9GTEFHX0lOSEVS
SVRFRCkKPiA+IC0JCWludGVsX2NydGNfYXJtX2ZpZm9fdW5kZXJydW4oaW50ZWxfY3J0YywgbmV3
X2NydGNfc3RhdGUpOwo+ID4gKwkJaW50ZWxfY3J0Y19hcm1fZmlmb191bmRlcnJ1bihjcnRjLCBu
ZXdfY3J0Y19zdGF0ZSk7Cj4gPiAgfQo+ID4gIAo+ID4gIC8qKgo+ID4gLS0gCj4gPiAyLjE5LjEK
PiAKPiAtLSAKPiBWaWxsZSBTeXJqw6Rsw6QKPiBJbnRlbApfX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdm
eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp
bG1hbi9saXN0aW5mby9pbnRlbC1nZng=