From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH v2] drm/i915: Nuke drm_crtc_state and use
 intel_atomic_state instead
Date: Mon, 15 Apr 2019 15:17:30 +0300
Message-ID: <20190415121730.GL3888@intel.com>
References: <20190411230254.6357-1-manasi.d.navare@intel.com>
 <20190412212232.13539-1-manasi.d.navare@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 549A88967A
 for <intel-gfx@lists.freedesktop.org>; Mon, 15 Apr 2019 12:17:34 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20190412212232.13539-1-manasi.d.navare@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Manasi Navare <manasi.d.navare@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gRnJpLCBBcHIgMTIsIDIwMTkgYXQgMDI6MjI6MzJQTSAtMDcwMCwgTWFuYXNpIE5hdmFyZSB3
cm90ZToKPiBUaGlzIGlzIG9uZSBvZiB0aGUgcGF0Y2hlcyB0byBzdGFydCByZXBsYWNpbmcgZHJt
IHBvaW50ZXJzCj4gYW5kIHVzZSB0aGUgaW50ZWxfYXRvbWljX3N0YXRlIGFuZCBpbnRlbF9jcnRj
IHRvIGRlcml2ZQo+IHRoZSBuZWNlc3NhcnkgaW50ZWwgc3RhdGUgdmFyaWFibGVzIHJlcXVpcmVk
IGZvciB0aGUgaW50ZWwKPiBtb2Rlc2V0IGZ1bmN0aW9ucy4KPiAKPiB2MjoKPiAqIEZsaXAgdGhl
IGZ1bmN0aW9uIGFyZ3VtZW50cyAoVmlsbGUpCj4gKiBSZW1vdmUgc29tZSByZW1haW5pbmcgaW5z
dGFuY2VzIG9mIGRybSBwb2ludGVycyAoVmlsbGUpCj4gKiBVc2Ugb2xkX2NydGNfc3RhdGUgYW5k
IG5ld19jcnRjX3N0YXRlIChWaWxsZSkKPiAKPiBTdWdnZXN0ZWQtYnk6IFZpbGxlIFN5cmphbGEg
PHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IENjOiBWaWxsZSBTeXJqYWxhIDx2aWxs
ZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBNYW5hc2kgTmF2YXJl
IDxtYW5hc2kuZC5uYXZhcmVAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkx
NS9pbnRlbF9kaXNwbGF5LmMgfCA2MiArKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tCj4gIDEg
ZmlsZSBjaGFuZ2VkLCAyOSBpbnNlcnRpb25zKCspLCAzMyBkZWxldGlvbnMoLSkKPiAKPiBkaWZm
IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9n
cHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gaW5kZXggZjI5YTM0OGU4ZDcxLi5hYTg0ZjU3
Y2Q2NWQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5j
Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTEyNSw4
ICsxMjUsOCBAQCBzdGF0aWMgdm9pZCB2bHZfcHJlcGFyZV9wbGwoc3RydWN0IGludGVsX2NydGMg
KmNydGMsCj4gIAkJCSAgICBjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqcGlwZV9jb25m
aWcpOwo+ICBzdGF0aWMgdm9pZCBjaHZfcHJlcGFyZV9wbGwoc3RydWN0IGludGVsX2NydGMgKmNy
dGMsCj4gIAkJCSAgICBjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqcGlwZV9jb25maWcp
Owo+IC1zdGF0aWMgdm9pZCBpbnRlbF9iZWdpbl9jcnRjX2NvbW1pdChzdHJ1Y3QgZHJtX2NydGMg
Kiwgc3RydWN0IGRybV9jcnRjX3N0YXRlICopOwo+IC1zdGF0aWMgdm9pZCBpbnRlbF9maW5pc2hf
Y3J0Y19jb21taXQoc3RydWN0IGRybV9jcnRjICosIHN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqKTsK
PiArc3RhdGljIHZvaWQgaW50ZWxfYmVnaW5fY3J0Y19jb21taXQoc3RydWN0IGludGVsX2F0b21p
Y19zdGF0ZSAqLCBzdHJ1Y3QgaW50ZWxfY3J0YyAqKTsKPiArc3RhdGljIHZvaWQgaW50ZWxfZmlu
aXNoX2NydGNfY29tbWl0KHN0cnVjdCBpbnRlbF9hdG9taWNfc3RhdGUgKiwgc3RydWN0IGludGVs
X2NydGMgKik7Cj4gIHN0YXRpYyB2b2lkIGludGVsX2NydGNfaW5pdF9zY2FsZXJzKHN0cnVjdCBp
bnRlbF9jcnRjICpjcnRjLAo+ICAJCQkJICAgIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRj
X3N0YXRlKTsKPiAgc3RhdGljIHZvaWQgc2t5bGFrZV9wZml0X2VuYWJsZShjb25zdCBzdHJ1Y3Qg
aW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSk7Cj4gQEAgLTEzMjczLDE0ICsxMzI3MywxNCBA
QCBzdGF0aWMgdm9pZCBpbnRlbF91cGRhdGVfY3J0YyhzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4g
IAllbHNlIGlmIChuZXdfcGxhbmVfc3RhdGUpCj4gIAkJaW50ZWxfZmJjX2VuYWJsZShpbnRlbF9j
cnRjLCBwaXBlX2NvbmZpZywgbmV3X3BsYW5lX3N0YXRlKTsKPiAgCj4gLQlpbnRlbF9iZWdpbl9j
cnRjX2NvbW1pdChjcnRjLCBvbGRfY3J0Y19zdGF0ZSk7Cj4gKwlpbnRlbF9iZWdpbl9jcnRjX2Nv
bW1pdCh0b19pbnRlbF9hdG9taWNfc3RhdGUoc3RhdGUpLCBpbnRlbF9jcnRjKTsKPiAgCj4gIAlp
ZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSA5KQo+ICAJCXNrbF91cGRhdGVfcGxhbmVzX29uX2Ny
dGModG9faW50ZWxfYXRvbWljX3N0YXRlKHN0YXRlKSwgaW50ZWxfY3J0Yyk7Cj4gIAllbHNlCj4g
IAkJaTl4eF91cGRhdGVfcGxhbmVzX29uX2NydGModG9faW50ZWxfYXRvbWljX3N0YXRlKHN0YXRl
KSwgaW50ZWxfY3J0Yyk7Cj4gIAo+IC0JaW50ZWxfZmluaXNoX2NydGNfY29tbWl0KGNydGMsIG9s
ZF9jcnRjX3N0YXRlKTsKPiArCWludGVsX2ZpbmlzaF9jcnRjX2NvbW1pdCh0b19pbnRlbF9hdG9t
aWNfc3RhdGUoc3RhdGUpLCBpbnRlbF9jcnRjKTsKPiAgfQo+ICAKPiAgc3RhdGljIHZvaWQgaW50
ZWxfdXBkYXRlX2NydGNzKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkKPiBAQCAtMTQw
NzAsMzkgKzE0MDcwLDM2IEBAIHNrbF9tYXhfc2NhbGUoY29uc3Qgc3RydWN0IGludGVsX2NydGNf
c3RhdGUgKmNydGNfc3RhdGUsCj4gIAlyZXR1cm4gbWF4X3NjYWxlOwo+ICB9Cj4gIAo+IC1zdGF0
aWMgdm9pZCBpbnRlbF9iZWdpbl9jcnRjX2NvbW1pdChzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4g
LQkJCQkgICAgc3RydWN0IGRybV9jcnRjX3N0YXRlICpvbGRfY3J0Y19zdGF0ZSkKPiArc3RhdGlj
IHZvaWQgaW50ZWxfYmVnaW5fY3J0Y19jb21taXQoc3RydWN0IGludGVsX2F0b21pY19zdGF0ZSAq
c3RhdGUsCj4gKwkJCQkgICAgc3RydWN0IGludGVsX2NydGMgKmNydGMpCj4gIHsKPiAtCXN0cnVj
dCBkcm1fZGV2aWNlICpkZXYgPSBjcnRjLT5kZXY7Cj4gLQlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0
ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGRldik7Cj4gLQlzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50ZWxf
Y3J0YyA9IHRvX2ludGVsX2NydGMoY3J0Yyk7Cj4gLQlzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAq
b2xkX2ludGVsX2NzdGF0ZSA9Cj4gLQkJdG9faW50ZWxfY3J0Y19zdGF0ZShvbGRfY3J0Y19zdGF0
ZSk7Cj4gLQlzdHJ1Y3QgaW50ZWxfYXRvbWljX3N0YXRlICpvbGRfaW50ZWxfc3RhdGUgPQo+IC0J
CXRvX2ludGVsX2F0b21pY19zdGF0ZShvbGRfY3J0Y19zdGF0ZS0+c3RhdGUpOwo+IC0Jc3RydWN0
IGludGVsX2NydGNfc3RhdGUgKmludGVsX2NzdGF0ZSA9Cj4gLQkJaW50ZWxfYXRvbWljX2dldF9u
ZXdfY3J0Y19zdGF0ZShvbGRfaW50ZWxfc3RhdGUsIGludGVsX2NydGMpOwo+IC0JYm9vbCBtb2Rl
c2V0ID0gbmVlZHNfbW9kZXNldCgmaW50ZWxfY3N0YXRlLT5iYXNlKTsKPiArCXN0cnVjdCBkcm1f
aTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoY3J0Yy0+YmFzZS5kZXYpOwo+ICsJc3Ry
dWN0IGludGVsX2NydGNfc3RhdGUgKm9sZF9jcnRjX3N0YXRlID0KPiArCQlpbnRlbF9hdG9taWNf
Z2V0X29sZF9jcnRjX3N0YXRlKHN0YXRlLAo+ICsJCQkJCQljcnRjKTsKClBvaW50bGVzcyBuZXds
aW5lLgoKUmV2aWV3ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5p
bnRlbC5jb20+Cgo+ICsJc3RydWN0IGludGVsX2NydGNfc3RhdGUgKm5ld19jcnRjX3N0YXRlID0K
PiArCQlpbnRlbF9hdG9taWNfZ2V0X25ld19jcnRjX3N0YXRlKHN0YXRlLCBjcnRjKTsKPiArCWJv
b2wgbW9kZXNldCA9IG5lZWRzX21vZGVzZXQoJm5ld19jcnRjX3N0YXRlLT5iYXNlKTsKPiAgCj4g
IAkvKiBQZXJmb3JtIHZibGFuayBldmFzaW9uIGFyb3VuZCBjb21taXQgb3BlcmF0aW9uICovCj4g
LQlpbnRlbF9waXBlX3VwZGF0ZV9zdGFydChpbnRlbF9jc3RhdGUpOwo+ICsJaW50ZWxfcGlwZV91
cGRhdGVfc3RhcnQobmV3X2NydGNfc3RhdGUpOwo+ICAKPiAgCWlmIChtb2Rlc2V0KQo+ICAJCWdv
dG8gb3V0Owo+ICAKPiAtCWlmIChpbnRlbF9jc3RhdGUtPmJhc2UuY29sb3JfbWdtdF9jaGFuZ2Vk
IHx8Cj4gLQkgICAgaW50ZWxfY3N0YXRlLT51cGRhdGVfcGlwZSkKPiAtCQlpbnRlbF9jb2xvcl9j
b21taXQoaW50ZWxfY3N0YXRlKTsKPiArCWlmIChuZXdfY3J0Y19zdGF0ZS0+YmFzZS5jb2xvcl9t
Z210X2NoYW5nZWQgfHwKPiArCSAgICBuZXdfY3J0Y19zdGF0ZS0+dXBkYXRlX3BpcGUpCj4gKwkJ
aW50ZWxfY29sb3JfY29tbWl0KG5ld19jcnRjX3N0YXRlKTsKPiAgCj4gLQlpZiAoaW50ZWxfY3N0
YXRlLT51cGRhdGVfcGlwZSkKPiAtCQlpbnRlbF91cGRhdGVfcGlwZV9jb25maWcob2xkX2ludGVs
X2NzdGF0ZSwgaW50ZWxfY3N0YXRlKTsKPiArCWlmIChuZXdfY3J0Y19zdGF0ZS0+dXBkYXRlX3Bp
cGUpCj4gKwkJaW50ZWxfdXBkYXRlX3BpcGVfY29uZmlnKG9sZF9jcnRjX3N0YXRlLCBuZXdfY3J0
Y19zdGF0ZSk7Cj4gIAllbHNlIGlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID49IDkpCj4gLQkJc2ts
X2RldGFjaF9zY2FsZXJzKGludGVsX2NzdGF0ZSk7Cj4gKwkJc2tsX2RldGFjaF9zY2FsZXJzKG5l
d19jcnRjX3N0YXRlKTsKPiAgCj4gIG91dDoKPiAgCWlmIChkZXZfcHJpdi0+ZGlzcGxheS5hdG9t
aWNfdXBkYXRlX3dhdGVybWFya3MpCj4gLQkJZGV2X3ByaXYtPmRpc3BsYXkuYXRvbWljX3VwZGF0
ZV93YXRlcm1hcmtzKG9sZF9pbnRlbF9zdGF0ZSwKPiAtCQkJCQkJCSAgIGludGVsX2NzdGF0ZSk7
Cj4gKwkJZGV2X3ByaXYtPmRpc3BsYXkuYXRvbWljX3VwZGF0ZV93YXRlcm1hcmtzKHN0YXRlLAo+
ICsJCQkJCQkJICAgbmV3X2NydGNfc3RhdGUpOwo+ICB9Cj4gIAo+ICB2b2lkIGludGVsX2NydGNf
YXJtX2ZpZm9fdW5kZXJydW4oc3RydWN0IGludGVsX2NydGMgKmNydGMsCj4gQEAgLTE0MTIxLDIx
ICsxNDExOCwyMCBAQCB2b2lkIGludGVsX2NydGNfYXJtX2ZpZm9fdW5kZXJydW4oc3RydWN0IGlu
dGVsX2NydGMgKmNydGMsCj4gIAl9Cj4gIH0KPiAgCj4gLXN0YXRpYyB2b2lkIGludGVsX2Zpbmlz
aF9jcnRjX2NvbW1pdChzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gLQkJCQkgICAgIHN0cnVjdCBk
cm1fY3J0Y19zdGF0ZSAqb2xkX2NydGNfc3RhdGUpCj4gK3N0YXRpYyB2b2lkIGludGVsX2Zpbmlz
aF9jcnRjX2NvbW1pdChzdHJ1Y3QgaW50ZWxfYXRvbWljX3N0YXRlICpzdGF0ZSwKPiArCQkJCSAg
ICAgc3RydWN0IGludGVsX2NydGMgKmNydGMpCj4gIHsKPiAtCXN0cnVjdCBpbnRlbF9jcnRjICpp
bnRlbF9jcnRjID0gdG9faW50ZWxfY3J0YyhjcnRjKTsKPiAtCXN0cnVjdCBpbnRlbF9hdG9taWNf
c3RhdGUgKm9sZF9pbnRlbF9zdGF0ZSA9Cj4gLQkJdG9faW50ZWxfYXRvbWljX3N0YXRlKG9sZF9j
cnRjX3N0YXRlLT5zdGF0ZSk7Cj4gKwlzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqb2xkX2NydGNf
c3RhdGUgPQo+ICsJCWludGVsX2F0b21pY19nZXRfb2xkX2NydGNfc3RhdGUoc3RhdGUsIGNydGMp
Owo+ICAJc3RydWN0IGludGVsX2NydGNfc3RhdGUgKm5ld19jcnRjX3N0YXRlID0KPiAtCQlpbnRl
bF9hdG9taWNfZ2V0X25ld19jcnRjX3N0YXRlKG9sZF9pbnRlbF9zdGF0ZSwgaW50ZWxfY3J0Yyk7
Cj4gKwkJaW50ZWxfYXRvbWljX2dldF9uZXdfY3J0Y19zdGF0ZShzdGF0ZSwgY3J0Yyk7Cj4gIAo+
ICAJaW50ZWxfcGlwZV91cGRhdGVfZW5kKG5ld19jcnRjX3N0YXRlKTsKPiAgCj4gIAlpZiAobmV3
X2NydGNfc3RhdGUtPnVwZGF0ZV9waXBlICYmCj4gIAkgICAgIW5lZWRzX21vZGVzZXQoJm5ld19j
cnRjX3N0YXRlLT5iYXNlKSAmJgo+IC0JICAgIG9sZF9jcnRjX3N0YXRlLT5tb2RlLnByaXZhdGVf
ZmxhZ3MgJiBJOTE1X01PREVfRkxBR19JTkhFUklURUQpCj4gLQkJaW50ZWxfY3J0Y19hcm1fZmlm
b191bmRlcnJ1bihpbnRlbF9jcnRjLCBuZXdfY3J0Y19zdGF0ZSk7Cj4gKwkgICAgb2xkX2NydGNf
c3RhdGUtPmJhc2UubW9kZS5wcml2YXRlX2ZsYWdzICYgSTkxNV9NT0RFX0ZMQUdfSU5IRVJJVEVE
KQo+ICsJCWludGVsX2NydGNfYXJtX2ZpZm9fdW5kZXJydW4oY3J0YywgbmV3X2NydGNfc3RhdGUp
Owo+ICB9Cj4gIAo+ICAvKioKPiAtLSAKPiAyLjE5LjEKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50
ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt
Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v
bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4