From mboxrd@z Thu Jan  1 00:00:00 1970
From: Manasi Navare <manasi.d.navare@intel.com>
Subject: Re: [PATCH v2] drm/i915: Nuke drm_crtc_state and use
 intel_atomic_state instead
Date: Mon, 15 Apr 2019 11:15:40 -0700
Message-ID: <20190415181538.GF17858@intel.com>
References: <20190411230254.6357-1-manasi.d.navare@intel.com>
 <20190412212232.13539-1-manasi.d.navare@intel.com>
 <20190415121730.GL3888@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 4D641890C8
 for <intel-gfx@lists.freedesktop.org>; Mon, 15 Apr 2019 18:13:18 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20190415121730.GL3888@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gTW9uLCBBcHIgMTUsIDIwMTkgYXQgMDM6MTc6MzBQTSArMDMwMCwgVmlsbGUgU3lyasOkbMOk
IHdyb3RlOgo+IE9uIEZyaSwgQXByIDEyLCAyMDE5IGF0IDAyOjIyOjMyUE0gLTA3MDAsIE1hbmFz
aSBOYXZhcmUgd3JvdGU6Cj4gPiBUaGlzIGlzIG9uZSBvZiB0aGUgcGF0Y2hlcyB0byBzdGFydCBy
ZXBsYWNpbmcgZHJtIHBvaW50ZXJzCj4gPiBhbmQgdXNlIHRoZSBpbnRlbF9hdG9taWNfc3RhdGUg
YW5kIGludGVsX2NydGMgdG8gZGVyaXZlCj4gPiB0aGUgbmVjZXNzYXJ5IGludGVsIHN0YXRlIHZh
cmlhYmxlcyByZXF1aXJlZCBmb3IgdGhlIGludGVsCj4gPiBtb2Rlc2V0IGZ1bmN0aW9ucy4KPiA+
IAo+ID4gdjI6Cj4gPiAqIEZsaXAgdGhlIGZ1bmN0aW9uIGFyZ3VtZW50cyAoVmlsbGUpCj4gPiAq
IFJlbW92ZSBzb21lIHJlbWFpbmluZyBpbnN0YW5jZXMgb2YgZHJtIHBvaW50ZXJzIChWaWxsZSkK
PiA+ICogVXNlIG9sZF9jcnRjX3N0YXRlIGFuZCBuZXdfY3J0Y19zdGF0ZSAoVmlsbGUpCj4gPiAK
PiA+IFN1Z2dlc3RlZC1ieTogVmlsbGUgU3lyamFsYSA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRl
bC5jb20+Cj4gPiBDYzogVmlsbGUgU3lyamFsYSA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5j
b20+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBNYW5hc2kgTmF2YXJlIDxtYW5hc2kuZC5uYXZhcmVAaW50
ZWwuY29tPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5j
IHwgNjIgKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAy
OSBpbnNlcnRpb25zKCspLCAzMyBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2Ry
aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1
L2ludGVsX2Rpc3BsYXkuYwo+ID4gaW5kZXggZjI5YTM0OGU4ZDcxLi5hYTg0ZjU3Y2Q2NWQgMTAw
NjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+ICsr
KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4gQEAgLTEyNSw4ICsx
MjUsOCBAQCBzdGF0aWMgdm9pZCB2bHZfcHJlcGFyZV9wbGwoc3RydWN0IGludGVsX2NydGMgKmNy
dGMsCj4gPiAgCQkJICAgIGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpwaXBlX2NvbmZp
Zyk7Cj4gPiAgc3RhdGljIHZvaWQgY2h2X3ByZXBhcmVfcGxsKHN0cnVjdCBpbnRlbF9jcnRjICpj
cnRjLAo+ID4gIAkJCSAgICBjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqcGlwZV9jb25m
aWcpOwo+ID4gLXN0YXRpYyB2b2lkIGludGVsX2JlZ2luX2NydGNfY29tbWl0KHN0cnVjdCBkcm1f
Y3J0YyAqLCBzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKik7Cj4gPiAtc3RhdGljIHZvaWQgaW50ZWxf
ZmluaXNoX2NydGNfY29tbWl0KHN0cnVjdCBkcm1fY3J0YyAqLCBzdHJ1Y3QgZHJtX2NydGNfc3Rh
dGUgKik7Cj4gPiArc3RhdGljIHZvaWQgaW50ZWxfYmVnaW5fY3J0Y19jb21taXQoc3RydWN0IGlu
dGVsX2F0b21pY19zdGF0ZSAqLCBzdHJ1Y3QgaW50ZWxfY3J0YyAqKTsKPiA+ICtzdGF0aWMgdm9p
ZCBpbnRlbF9maW5pc2hfY3J0Y19jb21taXQoc3RydWN0IGludGVsX2F0b21pY19zdGF0ZSAqLCBz
dHJ1Y3QgaW50ZWxfY3J0YyAqKTsKPiA+ICBzdGF0aWMgdm9pZCBpbnRlbF9jcnRjX2luaXRfc2Nh
bGVycyhzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywKPiA+ICAJCQkJICAgIHN0cnVjdCBpbnRlbF9j
cnRjX3N0YXRlICpjcnRjX3N0YXRlKTsKPiA+ICBzdGF0aWMgdm9pZCBza3lsYWtlX3BmaXRfZW5h
YmxlKGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlKTsKPiA+IEBAIC0x
MzI3MywxNCArMTMyNzMsMTQgQEAgc3RhdGljIHZvaWQgaW50ZWxfdXBkYXRlX2NydGMoc3RydWN0
IGRybV9jcnRjICpjcnRjLAo+ID4gIAllbHNlIGlmIChuZXdfcGxhbmVfc3RhdGUpCj4gPiAgCQlp
bnRlbF9mYmNfZW5hYmxlKGludGVsX2NydGMsIHBpcGVfY29uZmlnLCBuZXdfcGxhbmVfc3RhdGUp
Owo+ID4gIAo+ID4gLQlpbnRlbF9iZWdpbl9jcnRjX2NvbW1pdChjcnRjLCBvbGRfY3J0Y19zdGF0
ZSk7Cj4gPiArCWludGVsX2JlZ2luX2NydGNfY29tbWl0KHRvX2ludGVsX2F0b21pY19zdGF0ZShz
dGF0ZSksIGludGVsX2NydGMpOwo+ID4gIAo+ID4gIAlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+
PSA5KQo+ID4gIAkJc2tsX3VwZGF0ZV9wbGFuZXNfb25fY3J0Yyh0b19pbnRlbF9hdG9taWNfc3Rh
dGUoc3RhdGUpLCBpbnRlbF9jcnRjKTsKPiA+ICAJZWxzZQo+ID4gIAkJaTl4eF91cGRhdGVfcGxh
bmVzX29uX2NydGModG9faW50ZWxfYXRvbWljX3N0YXRlKHN0YXRlKSwgaW50ZWxfY3J0Yyk7Cj4g
PiAgCj4gPiAtCWludGVsX2ZpbmlzaF9jcnRjX2NvbW1pdChjcnRjLCBvbGRfY3J0Y19zdGF0ZSk7
Cj4gPiArCWludGVsX2ZpbmlzaF9jcnRjX2NvbW1pdCh0b19pbnRlbF9hdG9taWNfc3RhdGUoc3Rh
dGUpLCBpbnRlbF9jcnRjKTsKPiA+ICB9Cj4gPiAgCj4gPiAgc3RhdGljIHZvaWQgaW50ZWxfdXBk
YXRlX2NydGNzKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkKPiA+IEBAIC0xNDA3MCwz
OSArMTQwNzAsMzYgQEAgc2tsX21heF9zY2FsZShjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0
ZSAqY3J0Y19zdGF0ZSwKPiA+ICAJcmV0dXJuIG1heF9zY2FsZTsKPiA+ICB9Cj4gPiAgCj4gPiAt
c3RhdGljIHZvaWQgaW50ZWxfYmVnaW5fY3J0Y19jb21taXQoc3RydWN0IGRybV9jcnRjICpjcnRj
LAo+ID4gLQkJCQkgICAgc3RydWN0IGRybV9jcnRjX3N0YXRlICpvbGRfY3J0Y19zdGF0ZSkKPiA+
ICtzdGF0aWMgdm9pZCBpbnRlbF9iZWdpbl9jcnRjX2NvbW1pdChzdHJ1Y3QgaW50ZWxfYXRvbWlj
X3N0YXRlICpzdGF0ZSwKPiA+ICsJCQkJICAgIHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjKQo+ID4g
IHsKPiA+IC0Jc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGNydGMtPmRldjsKPiA+IC0Jc3RydWN0
IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShkZXYpOwo+ID4gLQlzdHJ1Y3Qg
aW50ZWxfY3J0YyAqaW50ZWxfY3J0YyA9IHRvX2ludGVsX2NydGMoY3J0Yyk7Cj4gPiAtCXN0cnVj
dCBpbnRlbF9jcnRjX3N0YXRlICpvbGRfaW50ZWxfY3N0YXRlID0KPiA+IC0JCXRvX2ludGVsX2Ny
dGNfc3RhdGUob2xkX2NydGNfc3RhdGUpOwo+ID4gLQlzdHJ1Y3QgaW50ZWxfYXRvbWljX3N0YXRl
ICpvbGRfaW50ZWxfc3RhdGUgPQo+ID4gLQkJdG9faW50ZWxfYXRvbWljX3N0YXRlKG9sZF9jcnRj
X3N0YXRlLT5zdGF0ZSk7Cj4gPiAtCXN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICppbnRlbF9jc3Rh
dGUgPQo+ID4gLQkJaW50ZWxfYXRvbWljX2dldF9uZXdfY3J0Y19zdGF0ZShvbGRfaW50ZWxfc3Rh
dGUsIGludGVsX2NydGMpOwo+ID4gLQlib29sIG1vZGVzZXQgPSBuZWVkc19tb2Rlc2V0KCZpbnRl
bF9jc3RhdGUtPmJhc2UpOwo+ID4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYg
PSB0b19pOTE1KGNydGMtPmJhc2UuZGV2KTsKPiA+ICsJc3RydWN0IGludGVsX2NydGNfc3RhdGUg
Km9sZF9jcnRjX3N0YXRlID0KPiA+ICsJCWludGVsX2F0b21pY19nZXRfb2xkX2NydGNfc3RhdGUo
c3RhdGUsCj4gPiArCQkJCQkJY3J0Yyk7Cj4gCj4gUG9pbnRsZXNzIG5ld2xpbmUuCj4gCj4gUmV2
aWV3ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+
CgpUaGFua3MgZm9yIHRoZSByZXZpZXcsIHdpbGwgZml4IHRoZSBwb2ludGxlc3MgbmV3bGluZSBp
biB0aGUgdjMKYW5kIGFkZCB5b3VyIHItYgoKTWFuYXNpCgo+IAo+ID4gKwlzdHJ1Y3QgaW50ZWxf
Y3J0Y19zdGF0ZSAqbmV3X2NydGNfc3RhdGUgPQo+ID4gKwkJaW50ZWxfYXRvbWljX2dldF9uZXdf
Y3J0Y19zdGF0ZShzdGF0ZSwgY3J0Yyk7Cj4gPiArCWJvb2wgbW9kZXNldCA9IG5lZWRzX21vZGVz
ZXQoJm5ld19jcnRjX3N0YXRlLT5iYXNlKTsKPiA+ICAKPiA+ICAJLyogUGVyZm9ybSB2Ymxhbmsg
ZXZhc2lvbiBhcm91bmQgY29tbWl0IG9wZXJhdGlvbiAqLwo+ID4gLQlpbnRlbF9waXBlX3VwZGF0
ZV9zdGFydChpbnRlbF9jc3RhdGUpOwo+ID4gKwlpbnRlbF9waXBlX3VwZGF0ZV9zdGFydChuZXdf
Y3J0Y19zdGF0ZSk7Cj4gPiAgCj4gPiAgCWlmIChtb2Rlc2V0KQo+ID4gIAkJZ290byBvdXQ7Cj4g
PiAgCj4gPiAtCWlmIChpbnRlbF9jc3RhdGUtPmJhc2UuY29sb3JfbWdtdF9jaGFuZ2VkIHx8Cj4g
PiAtCSAgICBpbnRlbF9jc3RhdGUtPnVwZGF0ZV9waXBlKQo+ID4gLQkJaW50ZWxfY29sb3JfY29t
bWl0KGludGVsX2NzdGF0ZSk7Cj4gPiArCWlmIChuZXdfY3J0Y19zdGF0ZS0+YmFzZS5jb2xvcl9t
Z210X2NoYW5nZWQgfHwKPiA+ICsJICAgIG5ld19jcnRjX3N0YXRlLT51cGRhdGVfcGlwZSkKPiA+
ICsJCWludGVsX2NvbG9yX2NvbW1pdChuZXdfY3J0Y19zdGF0ZSk7Cj4gPiAgCj4gPiAtCWlmIChp
bnRlbF9jc3RhdGUtPnVwZGF0ZV9waXBlKQo+ID4gLQkJaW50ZWxfdXBkYXRlX3BpcGVfY29uZmln
KG9sZF9pbnRlbF9jc3RhdGUsIGludGVsX2NzdGF0ZSk7Cj4gPiArCWlmIChuZXdfY3J0Y19zdGF0
ZS0+dXBkYXRlX3BpcGUpCj4gPiArCQlpbnRlbF91cGRhdGVfcGlwZV9jb25maWcob2xkX2NydGNf
c3RhdGUsIG5ld19jcnRjX3N0YXRlKTsKPiA+ICAJZWxzZSBpZiAoSU5URUxfR0VOKGRldl9wcml2
KSA+PSA5KQo+ID4gLQkJc2tsX2RldGFjaF9zY2FsZXJzKGludGVsX2NzdGF0ZSk7Cj4gPiArCQlz
a2xfZGV0YWNoX3NjYWxlcnMobmV3X2NydGNfc3RhdGUpOwo+ID4gIAo+ID4gIG91dDoKPiA+ICAJ
aWYgKGRldl9wcml2LT5kaXNwbGF5LmF0b21pY191cGRhdGVfd2F0ZXJtYXJrcykKPiA+IC0JCWRl
dl9wcml2LT5kaXNwbGF5LmF0b21pY191cGRhdGVfd2F0ZXJtYXJrcyhvbGRfaW50ZWxfc3RhdGUs
Cj4gPiAtCQkJCQkJCSAgIGludGVsX2NzdGF0ZSk7Cj4gPiArCQlkZXZfcHJpdi0+ZGlzcGxheS5h
dG9taWNfdXBkYXRlX3dhdGVybWFya3Moc3RhdGUsCj4gPiArCQkJCQkJCSAgIG5ld19jcnRjX3N0
YXRlKTsKPiA+ICB9Cj4gPiAgCj4gPiAgdm9pZCBpbnRlbF9jcnRjX2FybV9maWZvX3VuZGVycnVu
KHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+ID4gQEAgLTE0MTIxLDIxICsxNDExOCwyMCBAQCB2
b2lkIGludGVsX2NydGNfYXJtX2ZpZm9fdW5kZXJydW4oc3RydWN0IGludGVsX2NydGMgKmNydGMs
Cj4gPiAgCX0KPiA+ICB9Cj4gPiAgCj4gPiAtc3RhdGljIHZvaWQgaW50ZWxfZmluaXNoX2NydGNf
Y29tbWl0KHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiA+IC0JCQkJICAgICBzdHJ1Y3QgZHJtX2Ny
dGNfc3RhdGUgKm9sZF9jcnRjX3N0YXRlKQo+ID4gK3N0YXRpYyB2b2lkIGludGVsX2ZpbmlzaF9j
cnRjX2NvbW1pdChzdHJ1Y3QgaW50ZWxfYXRvbWljX3N0YXRlICpzdGF0ZSwKPiA+ICsJCQkJICAg
ICBzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YykKPiA+ICB7Cj4gPiAtCXN0cnVjdCBpbnRlbF9jcnRj
ICppbnRlbF9jcnRjID0gdG9faW50ZWxfY3J0YyhjcnRjKTsKPiA+IC0Jc3RydWN0IGludGVsX2F0
b21pY19zdGF0ZSAqb2xkX2ludGVsX3N0YXRlID0KPiA+IC0JCXRvX2ludGVsX2F0b21pY19zdGF0
ZShvbGRfY3J0Y19zdGF0ZS0+c3RhdGUpOwo+ID4gKwlzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAq
b2xkX2NydGNfc3RhdGUgPQo+ID4gKwkJaW50ZWxfYXRvbWljX2dldF9vbGRfY3J0Y19zdGF0ZShz
dGF0ZSwgY3J0Yyk7Cj4gPiAgCXN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpuZXdfY3J0Y19zdGF0
ZSA9Cj4gPiAtCQlpbnRlbF9hdG9taWNfZ2V0X25ld19jcnRjX3N0YXRlKG9sZF9pbnRlbF9zdGF0
ZSwgaW50ZWxfY3J0Yyk7Cj4gPiArCQlpbnRlbF9hdG9taWNfZ2V0X25ld19jcnRjX3N0YXRlKHN0
YXRlLCBjcnRjKTsKPiA+ICAKPiA+ICAJaW50ZWxfcGlwZV91cGRhdGVfZW5kKG5ld19jcnRjX3N0
YXRlKTsKPiA+ICAKPiA+ICAJaWYgKG5ld19jcnRjX3N0YXRlLT51cGRhdGVfcGlwZSAmJgo+ID4g
IAkgICAgIW5lZWRzX21vZGVzZXQoJm5ld19jcnRjX3N0YXRlLT5iYXNlKSAmJgo+ID4gLQkgICAg
b2xkX2NydGNfc3RhdGUtPm1vZGUucHJpdmF0ZV9mbGFncyAmIEk5MTVfTU9ERV9GTEFHX0lOSEVS
SVRFRCkKPiA+IC0JCWludGVsX2NydGNfYXJtX2ZpZm9fdW5kZXJydW4oaW50ZWxfY3J0YywgbmV3
X2NydGNfc3RhdGUpOwo+ID4gKwkgICAgb2xkX2NydGNfc3RhdGUtPmJhc2UubW9kZS5wcml2YXRl
X2ZsYWdzICYgSTkxNV9NT0RFX0ZMQUdfSU5IRVJJVEVEKQo+ID4gKwkJaW50ZWxfY3J0Y19hcm1f
Zmlmb191bmRlcnJ1bihjcnRjLCBuZXdfY3J0Y19zdGF0ZSk7Cj4gPiAgfQo+ID4gIAo+ID4gIC8q
Kgo+ID4gLS0gCj4gPiAyLjE5LjEKPiAKPiAtLSAKPiBWaWxsZSBTeXJqw6Rsw6QKPiBJbnRlbApf
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZngg
bWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0
cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=