From mboxrd@z Thu Jan  1 00:00:00 1970
From: Manasi Navare <manasi.d.navare@intel.com>
Subject: Re: [PATCH v3] drm/i915: Nuke drm_crtc_state and use
 intel_atomic_state instead
Date: Mon, 15 Apr 2019 13:02:35 -0700
Message-ID: <20190415200233.GG17858@intel.com>
References: <20190412212232.13539-1-manasi.d.navare@intel.com>
 <20190415182210.13347-1-manasi.d.navare@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by gabe.freedesktop.org (Postfix) with ESMTPS id CF63B8991A
 for <intel-gfx@lists.freedesktop.org>; Mon, 15 Apr 2019 20:00:16 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20190415182210.13347-1-manasi.d.navare@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

UHVzaGVkIHRvIGRpbnEsIHRoYW5rcyBmb3IgdGhlIHJldmlldyEKClJlZ2FyZHMKTWFuYXNpCgpP
biBNb24sIEFwciAxNSwgMjAxOSBhdCAxMToyMjoxMEFNIC0wNzAwLCBNYW5hc2kgTmF2YXJlIHdy
b3RlOgo+IFRoaXMgaXMgb25lIG9mIHRoZSBwYXRjaGVzIHRvIHN0YXJ0IHJlcGxhY2luZyBkcm0g
cG9pbnRlcnMKPiBhbmQgdXNlIHRoZSBpbnRlbF9hdG9taWNfc3RhdGUgYW5kIGludGVsX2NydGMg
dG8gZGVyaXZlCj4gdGhlIG5lY2Vzc2FyeSBpbnRlbCBzdGF0ZSB2YXJpYWJsZXMgcmVxdWlyZWQg
Zm9yIHRoZSBpbnRlbAo+IG1vZGVzZXQgZnVuY3Rpb25zLgo+IAo+IHYzOgo+ICogUmVtb3ZlIHRo
ZSB1bndhbnRlZCBuZXdsaW5lIChWaWxsZSkKPiB2MjoKPiAqIEZsaXAgdGhlIGZ1bmN0aW9uIGFy
Z3VtZW50cyAoVmlsbGUpCj4gKiBSZW1vdmUgc29tZSByZW1haW5pbmcgaW5zdGFuY2VzIG9mIGRy
bSBwb2ludGVycyAoVmlsbGUpCj4gKiBVc2Ugb2xkX2NydGNfc3RhdGUgYW5kIG5ld19jcnRjX3N0
YXRlIChWaWxsZSkKPiAKPiBTdWdnZXN0ZWQtYnk6IFZpbGxlIFN5cmphbGEgPHZpbGxlLnN5cmph
bGFAbGludXguaW50ZWwuY29tPgo+IENjOiBWaWxsZSBTeXJqYWxhIDx2aWxsZS5zeXJqYWxhQGxp
bnV4LmludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBNYW5hc2kgTmF2YXJlIDxtYW5hc2kuZC5u
YXZhcmVAaW50ZWwuY29tPgo+IFJldmlld2VkLWJ5OiBWaWxsZSBTeXJqYWxhIDx2aWxsZS5zeXJq
YWxhQGxpbnV4LmludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf
ZGlzcGxheS5jIHwgNjEgKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hh
bmdlZCwgMjggaW5zZXJ0aW9ucygrKSwgMzMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBh
L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9p
OTE1L2ludGVsX2Rpc3BsYXkuYwo+IGluZGV4IGYyOWEzNDhlOGQ3MS4uYWFmNDRhYjY3NjZmIDEw
MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ICsrKyBi
L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IEBAIC0xMjUsOCArMTI1LDgg
QEAgc3RhdGljIHZvaWQgdmx2X3ByZXBhcmVfcGxsKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+
ICAJCQkgICAgY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKnBpcGVfY29uZmlnKTsKPiAg
c3RhdGljIHZvaWQgY2h2X3ByZXBhcmVfcGxsKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+ICAJ
CQkgICAgY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKnBpcGVfY29uZmlnKTsKPiAtc3Rh
dGljIHZvaWQgaW50ZWxfYmVnaW5fY3J0Y19jb21taXQoc3RydWN0IGRybV9jcnRjICosIHN0cnVj
dCBkcm1fY3J0Y19zdGF0ZSAqKTsKPiAtc3RhdGljIHZvaWQgaW50ZWxfZmluaXNoX2NydGNfY29t
bWl0KHN0cnVjdCBkcm1fY3J0YyAqLCBzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKik7Cj4gK3N0YXRp
YyB2b2lkIGludGVsX2JlZ2luX2NydGNfY29tbWl0KHN0cnVjdCBpbnRlbF9hdG9taWNfc3RhdGUg
Kiwgc3RydWN0IGludGVsX2NydGMgKik7Cj4gK3N0YXRpYyB2b2lkIGludGVsX2ZpbmlzaF9jcnRj
X2NvbW1pdChzdHJ1Y3QgaW50ZWxfYXRvbWljX3N0YXRlICosIHN0cnVjdCBpbnRlbF9jcnRjICop
Owo+ICBzdGF0aWMgdm9pZCBpbnRlbF9jcnRjX2luaXRfc2NhbGVycyhzdHJ1Y3QgaW50ZWxfY3J0
YyAqY3J0YywKPiAgCQkJCSAgICBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSk7
Cj4gIHN0YXRpYyB2b2lkIHNreWxha2VfcGZpdF9lbmFibGUoY29uc3Qgc3RydWN0IGludGVsX2Ny
dGNfc3RhdGUgKmNydGNfc3RhdGUpOwo+IEBAIC0xMzI3MywxNCArMTMyNzMsMTQgQEAgc3RhdGlj
IHZvaWQgaW50ZWxfdXBkYXRlX2NydGMoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ICAJZWxzZSBp
ZiAobmV3X3BsYW5lX3N0YXRlKQo+ICAJCWludGVsX2ZiY19lbmFibGUoaW50ZWxfY3J0YywgcGlw
ZV9jb25maWcsIG5ld19wbGFuZV9zdGF0ZSk7Cj4gIAo+IC0JaW50ZWxfYmVnaW5fY3J0Y19jb21t
aXQoY3J0Yywgb2xkX2NydGNfc3RhdGUpOwo+ICsJaW50ZWxfYmVnaW5fY3J0Y19jb21taXQodG9f
aW50ZWxfYXRvbWljX3N0YXRlKHN0YXRlKSwgaW50ZWxfY3J0Yyk7Cj4gIAo+ICAJaWYgKElOVEVM
X0dFTihkZXZfcHJpdikgPj0gOSkKPiAgCQlza2xfdXBkYXRlX3BsYW5lc19vbl9jcnRjKHRvX2lu
dGVsX2F0b21pY19zdGF0ZShzdGF0ZSksIGludGVsX2NydGMpOwo+ICAJZWxzZQo+ICAJCWk5eHhf
dXBkYXRlX3BsYW5lc19vbl9jcnRjKHRvX2ludGVsX2F0b21pY19zdGF0ZShzdGF0ZSksIGludGVs
X2NydGMpOwo+ICAKPiAtCWludGVsX2ZpbmlzaF9jcnRjX2NvbW1pdChjcnRjLCBvbGRfY3J0Y19z
dGF0ZSk7Cj4gKwlpbnRlbF9maW5pc2hfY3J0Y19jb21taXQodG9faW50ZWxfYXRvbWljX3N0YXRl
KHN0YXRlKSwgaW50ZWxfY3J0Yyk7Cj4gIH0KPiAgCj4gIHN0YXRpYyB2b2lkIGludGVsX3VwZGF0
ZV9jcnRjcyhzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUpCj4gQEAgLTE0MDcwLDM5ICsx
NDA3MCwzNSBAQCBza2xfbWF4X3NjYWxlKGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpj
cnRjX3N0YXRlLAo+ICAJcmV0dXJuIG1heF9zY2FsZTsKPiAgfQo+ICAKPiAtc3RhdGljIHZvaWQg
aW50ZWxfYmVnaW5fY3J0Y19jb21taXQoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+IC0JCQkJICAg
IHN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqb2xkX2NydGNfc3RhdGUpCj4gK3N0YXRpYyB2b2lkIGlu
dGVsX2JlZ2luX2NydGNfY29tbWl0KHN0cnVjdCBpbnRlbF9hdG9taWNfc3RhdGUgKnN0YXRlLAo+
ICsJCQkJICAgIHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjKQo+ICB7Cj4gLQlzdHJ1Y3QgZHJtX2Rl
dmljZSAqZGV2ID0gY3J0Yy0+ZGV2Owo+IC0Jc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w
cml2ID0gdG9faTkxNShkZXYpOwo+IC0Jc3RydWN0IGludGVsX2NydGMgKmludGVsX2NydGMgPSB0
b19pbnRlbF9jcnRjKGNydGMpOwo+IC0Jc3RydWN0IGludGVsX2NydGNfc3RhdGUgKm9sZF9pbnRl
bF9jc3RhdGUgPQo+IC0JCXRvX2ludGVsX2NydGNfc3RhdGUob2xkX2NydGNfc3RhdGUpOwo+IC0J
c3RydWN0IGludGVsX2F0b21pY19zdGF0ZSAqb2xkX2ludGVsX3N0YXRlID0KPiAtCQl0b19pbnRl
bF9hdG9taWNfc3RhdGUob2xkX2NydGNfc3RhdGUtPnN0YXRlKTsKPiAtCXN0cnVjdCBpbnRlbF9j
cnRjX3N0YXRlICppbnRlbF9jc3RhdGUgPQo+IC0JCWludGVsX2F0b21pY19nZXRfbmV3X2NydGNf
c3RhdGUob2xkX2ludGVsX3N0YXRlLCBpbnRlbF9jcnRjKTsKPiAtCWJvb2wgbW9kZXNldCA9IG5l
ZWRzX21vZGVzZXQoJmludGVsX2NzdGF0ZS0+YmFzZSk7Cj4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJp
dmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGNydGMtPmJhc2UuZGV2KTsKPiArCXN0cnVjdCBpbnRl
bF9jcnRjX3N0YXRlICpvbGRfY3J0Y19zdGF0ZSA9Cj4gKwkJaW50ZWxfYXRvbWljX2dldF9vbGRf
Y3J0Y19zdGF0ZShzdGF0ZSwgY3J0Yyk7Cj4gKwlzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqbmV3
X2NydGNfc3RhdGUgPQo+ICsJCWludGVsX2F0b21pY19nZXRfbmV3X2NydGNfc3RhdGUoc3RhdGUs
IGNydGMpOwo+ICsJYm9vbCBtb2Rlc2V0ID0gbmVlZHNfbW9kZXNldCgmbmV3X2NydGNfc3RhdGUt
PmJhc2UpOwo+ICAKPiAgCS8qIFBlcmZvcm0gdmJsYW5rIGV2YXNpb24gYXJvdW5kIGNvbW1pdCBv
cGVyYXRpb24gKi8KPiAtCWludGVsX3BpcGVfdXBkYXRlX3N0YXJ0KGludGVsX2NzdGF0ZSk7Cj4g
KwlpbnRlbF9waXBlX3VwZGF0ZV9zdGFydChuZXdfY3J0Y19zdGF0ZSk7Cj4gIAo+ICAJaWYgKG1v
ZGVzZXQpCj4gIAkJZ290byBvdXQ7Cj4gIAo+IC0JaWYgKGludGVsX2NzdGF0ZS0+YmFzZS5jb2xv
cl9tZ210X2NoYW5nZWQgfHwKPiAtCSAgICBpbnRlbF9jc3RhdGUtPnVwZGF0ZV9waXBlKQo+IC0J
CWludGVsX2NvbG9yX2NvbW1pdChpbnRlbF9jc3RhdGUpOwo+ICsJaWYgKG5ld19jcnRjX3N0YXRl
LT5iYXNlLmNvbG9yX21nbXRfY2hhbmdlZCB8fAo+ICsJICAgIG5ld19jcnRjX3N0YXRlLT51cGRh
dGVfcGlwZSkKPiArCQlpbnRlbF9jb2xvcl9jb21taXQobmV3X2NydGNfc3RhdGUpOwo+ICAKPiAt
CWlmIChpbnRlbF9jc3RhdGUtPnVwZGF0ZV9waXBlKQo+IC0JCWludGVsX3VwZGF0ZV9waXBlX2Nv
bmZpZyhvbGRfaW50ZWxfY3N0YXRlLCBpbnRlbF9jc3RhdGUpOwo+ICsJaWYgKG5ld19jcnRjX3N0
YXRlLT51cGRhdGVfcGlwZSkKPiArCQlpbnRlbF91cGRhdGVfcGlwZV9jb25maWcob2xkX2NydGNf
c3RhdGUsIG5ld19jcnRjX3N0YXRlKTsKPiAgCWVsc2UgaWYgKElOVEVMX0dFTihkZXZfcHJpdikg
Pj0gOSkKPiAtCQlza2xfZGV0YWNoX3NjYWxlcnMoaW50ZWxfY3N0YXRlKTsKPiArCQlza2xfZGV0
YWNoX3NjYWxlcnMobmV3X2NydGNfc3RhdGUpOwo+ICAKPiAgb3V0Ogo+ICAJaWYgKGRldl9wcml2
LT5kaXNwbGF5LmF0b21pY191cGRhdGVfd2F0ZXJtYXJrcykKPiAtCQlkZXZfcHJpdi0+ZGlzcGxh
eS5hdG9taWNfdXBkYXRlX3dhdGVybWFya3Mob2xkX2ludGVsX3N0YXRlLAo+IC0JCQkJCQkJICAg
aW50ZWxfY3N0YXRlKTsKPiArCQlkZXZfcHJpdi0+ZGlzcGxheS5hdG9taWNfdXBkYXRlX3dhdGVy
bWFya3Moc3RhdGUsCj4gKwkJCQkJCQkgICBuZXdfY3J0Y19zdGF0ZSk7Cj4gIH0KPiAgCj4gIHZv
aWQgaW50ZWxfY3J0Y19hcm1fZmlmb191bmRlcnJ1bihzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywK
PiBAQCAtMTQxMjEsMjEgKzE0MTE3LDIwIEBAIHZvaWQgaW50ZWxfY3J0Y19hcm1fZmlmb191bmRl
cnJ1bihzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywKPiAgCX0KPiAgfQo+ICAKPiAtc3RhdGljIHZv
aWQgaW50ZWxfZmluaXNoX2NydGNfY29tbWl0KHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiAtCQkJ
CSAgICAgc3RydWN0IGRybV9jcnRjX3N0YXRlICpvbGRfY3J0Y19zdGF0ZSkKPiArc3RhdGljIHZv
aWQgaW50ZWxfZmluaXNoX2NydGNfY29tbWl0KHN0cnVjdCBpbnRlbF9hdG9taWNfc3RhdGUgKnN0
YXRlLAo+ICsJCQkJICAgICBzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YykKPiAgewo+IC0Jc3RydWN0
IGludGVsX2NydGMgKmludGVsX2NydGMgPSB0b19pbnRlbF9jcnRjKGNydGMpOwo+IC0Jc3RydWN0
IGludGVsX2F0b21pY19zdGF0ZSAqb2xkX2ludGVsX3N0YXRlID0KPiAtCQl0b19pbnRlbF9hdG9t
aWNfc3RhdGUob2xkX2NydGNfc3RhdGUtPnN0YXRlKTsKPiArCXN0cnVjdCBpbnRlbF9jcnRjX3N0
YXRlICpvbGRfY3J0Y19zdGF0ZSA9Cj4gKwkJaW50ZWxfYXRvbWljX2dldF9vbGRfY3J0Y19zdGF0
ZShzdGF0ZSwgY3J0Yyk7Cj4gIAlzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqbmV3X2NydGNfc3Rh
dGUgPQo+IC0JCWludGVsX2F0b21pY19nZXRfbmV3X2NydGNfc3RhdGUob2xkX2ludGVsX3N0YXRl
LCBpbnRlbF9jcnRjKTsKPiArCQlpbnRlbF9hdG9taWNfZ2V0X25ld19jcnRjX3N0YXRlKHN0YXRl
LCBjcnRjKTsKPiAgCj4gIAlpbnRlbF9waXBlX3VwZGF0ZV9lbmQobmV3X2NydGNfc3RhdGUpOwo+
ICAKPiAgCWlmIChuZXdfY3J0Y19zdGF0ZS0+dXBkYXRlX3BpcGUgJiYKPiAgCSAgICAhbmVlZHNf
bW9kZXNldCgmbmV3X2NydGNfc3RhdGUtPmJhc2UpICYmCj4gLQkgICAgb2xkX2NydGNfc3RhdGUt
Pm1vZGUucHJpdmF0ZV9mbGFncyAmIEk5MTVfTU9ERV9GTEFHX0lOSEVSSVRFRCkKPiAtCQlpbnRl
bF9jcnRjX2FybV9maWZvX3VuZGVycnVuKGludGVsX2NydGMsIG5ld19jcnRjX3N0YXRlKTsKPiAr
CSAgICBvbGRfY3J0Y19zdGF0ZS0+YmFzZS5tb2RlLnByaXZhdGVfZmxhZ3MgJiBJOTE1X01PREVf
RkxBR19JTkhFUklURUQpCj4gKwkJaW50ZWxfY3J0Y19hcm1fZmlmb191bmRlcnJ1bihjcnRjLCBu
ZXdfY3J0Y19zdGF0ZSk7Cj4gIH0KPiAgCj4gIC8qKgo+IC0tIAo+IDIuMTkuMQo+IApfX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGlu
ZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl
ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=