From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 08/12] drm/fb-helper: Move out commit code Date: Thu, 18 Apr 2019 10:30:16 +0200 Message-ID: <20190418083016.GS13337@phenom.ffwll.local> References: <20190407165243.54043-1-noralf@tronnes.org> <20190407165243.54043-9-noralf@tronnes.org> <20190416083836.GB13337@phenom.ffwll.local> <0a898190-cff7-9422-eb45-24723113e9fb@tronnes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by gabe.freedesktop.org (Postfix) with ESMTPS id 64A036E0DA for ; Thu, 18 Apr 2019 08:30:21 +0000 (UTC) Received: by mail-ed1-x543.google.com with SMTP id k92so1063544edc.12 for ; Thu, 18 Apr 2019 01:30:21 -0700 (PDT) Content-Disposition: inline In-Reply-To: <0a898190-cff7-9422-eb45-24723113e9fb@tronnes.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBBcHIgMTcsIDIwMTkgYXQgMDc6NTY6MjBQTSArMDIwMCwgTm9yYWxmIFRyw7hubmVz IHdyb3RlOgo+IAo+IAo+IERlbiAxNi4wNC4yMDE5IDEwLjM4LCBza3JldiBEYW5pZWwgVmV0dGVy Ogo+ID4gT24gU3VuLCBBcHIgMDcsIDIwMTkgYXQgMDY6NTI6MzlQTSArMDIwMCwgTm9yYWxmIFRy w7hubmVzIHdyb3RlOgo+ID4+IE1vdmUgdGhlIG1vZGVzZXQgY29tbWl0IGNvZGUgdG8gZHJtX2Ns aWVudF9tb2Rlc2V0Lgo+ID4+IE5vIGNoYW5nZXMgZXhjZXB0IGV4cG9ydGluZyBBUEkuCj4gPj4K PiA+PiB2MjogTW92ZSB0byBkcm1fY2xpZW50X21vZGVzZXQuYyBpbnN0ZWFkIG9mIGRybV9jbGll bnQuYwo+ID4+Cj4gPj4gU2lnbmVkLW9mZi1ieTogTm9yYWxmIFRyw7hubmVzIDxub3JhbGZAdHJv bm5lcy5vcmc+Cj4gPj4gLS0tCj4gPj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fY2xpZW50X21vZGVz ZXQuYyB8IDI4NyArKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAKPiA8c25pcD4KPiAKPiA+ PiAtLyoqCj4gPj4gLSAqIGRybV9jbGllbnRfcGFuZWxfcm90YXRpb24oKSAtIENoZWNrIHBhbmVs IG9yaWVudGF0aW9uCj4gPj4gLSAqIEBtb2Rlc2V0OiBEUk0gbW9kZXNldAo+ID4+IC0gKiBAcm90 YXRpb246IFJldHVybmVkIHJvdGF0aW9uIHZhbHVlCj4gPj4gLSAqCj4gPj4gLSAqIFRoaXMgZnVu Y3Rpb24gY2hlY2tzIGlmIHRoZSBwcmltYXJ5IHBsYW5lIGluIEBtb2Rlc2V0IGNhbiBodyByb3Rh dGUgdG8gbWF0Y2gKPiA+PiAtICogdGhlIHBhbmVsIG9yaWVudGF0aW9uIG9uIGl0cyBjb25uZWN0 b3IuCj4gPj4gLSAqCj4gPj4gLSAqIE5vdGU6IEN1cnJlbnRseSBvbmx5IDAgYW5kIDE4MCBkZWdy ZWVzIGFyZSBzdXBwb3J0ZWQuCj4gPj4gLSAqCj4gPj4gLSAqIFJldHVybjoKPiA+PiAtICogVHJ1 ZSBpZiB0aGUgcGxhbmUgY2FuIGRvIHRoZSByb3RhdGlvbiwgZmFsc2Ugb3RoZXJ3aXNlLgo+ID4+ IC0gKi8KPiA+PiAtYm9vbCBkcm1fY2xpZW50X3BhbmVsX3JvdGF0aW9uKHN0cnVjdCBkcm1fbW9k ZV9zZXQgKm1vZGVzZXQsIHVuc2lnbmVkIGludCAqcm90YXRpb24pCj4gPiAKPiA+IFdoeSBub3Qg c3RhdGljPyBEb2Vzbid0IHNlZW0gdG8gYmUgdXNlZCBieSBhbnl0aGluZyBvdXRzaWRlIG9mCj4g PiBkcm1fY2xpZW50X21vZGVzZXQuYy4KPiA+IAo+IAo+IEl0IGlzIHVzZWQgaW4gZHJtX2ZiX2hl bHBlci5jOmRybV9zZXR1cF9jcnRjc19mYigpIHRvIHNldCB1cCBhbnkKPiByb3RhdGlvbiBhbmQg ZG8gZmJjb24gc3cgcm90YXRpb24gaWYgbmVjZXNzYXJ5LiBDbGllbnRzIHRoYXQgc3VwcG9ydAo+ IHJvdGF0aW9uIG5lZWQgdG8gY2FsbCBpdC4KPiAKPiA+PiAtewo+ID4+IC0Jc3RydWN0IGRybV9j b25uZWN0b3IgKmNvbm5lY3RvciA9IG1vZGVzZXQtPmNvbm5lY3RvcnNbMF07Cj4gPj4gLQlzdHJ1 Y3QgZHJtX3BsYW5lICpwbGFuZSA9IG1vZGVzZXQtPmNydGMtPnByaW1hcnk7Cj4gPj4gLQl1NjQg dmFsaWRfbWFzayA9IDA7Cj4gPj4gLQl1bnNpZ25lZCBpbnQgaTsKPiA+PiAtCj4gPj4gLQlpZiAo IW1vZGVzZXQtPm51bV9jb25uZWN0b3JzKQo+ID4+IC0JCXJldHVybiBmYWxzZTsKPiA+PiAtCj4g Pj4gLQlzd2l0Y2ggKGNvbm5lY3Rvci0+ZGlzcGxheV9pbmZvLnBhbmVsX29yaWVudGF0aW9uKSB7 Cj4gPj4gLQljYXNlIERSTV9NT0RFX1BBTkVMX09SSUVOVEFUSU9OX0JPVFRPTV9VUDoKPiA+PiAt CQkqcm90YXRpb24gPSBEUk1fTU9ERV9ST1RBVEVfMTgwOwo+ID4+IC0JCWJyZWFrOwo+ID4+IC0J Y2FzZSBEUk1fTU9ERV9QQU5FTF9PUklFTlRBVElPTl9MRUZUX1VQOgo+ID4+IC0JCSpyb3RhdGlv biA9IERSTV9NT0RFX1JPVEFURV85MDsKPiA+PiAtCQlicmVhazsKPiA+PiAtCWNhc2UgRFJNX01P REVfUEFORUxfT1JJRU5UQVRJT05fUklHSFRfVVA6Cj4gPj4gLQkJKnJvdGF0aW9uID0gRFJNX01P REVfUk9UQVRFXzI3MDsKPiA+PiAtCQlicmVhazsKPiA+PiAtCWRlZmF1bHQ6Cj4gPj4gLQkJKnJv dGF0aW9uID0gRFJNX01PREVfUk9UQVRFXzA7Cj4gPj4gLQl9Cj4gPj4gLQo+ID4+IC0JLyoKPiA+ PiAtCSAqIFRPRE86IHN1cHBvcnQgOTAgLyAyNzAgZGVncmVlIGhhcmR3YXJlIHJvdGF0aW9uLAo+ ID4+IC0JICogZGVwZW5kaW5nIG9uIHRoZSBoYXJkd2FyZSB0aGlzIG1heSByZXF1aXJlIHRoZSBm cmFtZWJ1ZmZlcgo+ID4+IC0JICogdG8gYmUgaW4gYSBzcGVjaWZpYyB0aWxpbmcgZm9ybWF0Lgo+ ID4+IC0JICovCj4gPj4gLQlpZiAoKnJvdGF0aW9uICE9IERSTV9NT0RFX1JPVEFURV8xODAgfHwg IXBsYW5lLT5yb3RhdGlvbl9wcm9wZXJ0eSkKPiA+PiAtCQlyZXR1cm4gZmFsc2U7Cj4gPj4gLQo+ ID4+IC0JZm9yIChpID0gMDsgaSA8IHBsYW5lLT5yb3RhdGlvbl9wcm9wZXJ0eS0+bnVtX3ZhbHVl czsgaSsrKQo+ID4+IC0JCXZhbGlkX21hc2sgfD0gKDFVTEwgPDwgcGxhbmUtPnJvdGF0aW9uX3By b3BlcnR5LT52YWx1ZXNbaV0pOwo+ID4+IC0KPiA+PiAtCWlmICghKCpyb3RhdGlvbiAmIHZhbGlk X21hc2spKQo+ID4+IC0JCXJldHVybiBmYWxzZTsKPiA+PiAtCj4gPj4gLQlyZXR1cm4gdHJ1ZTsK PiA+PiAtfQo+ID4+IC0KPiAKPiA8c25pcD4KPiAKPiA+PiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9k cm0vZHJtX2NsaWVudC5oIGIvaW5jbHVkZS9kcm0vZHJtX2NsaWVudC5oCj4gPj4gaW5kZXggODU4 YzhiZTcwODcwLi42NGI3MjViMzE4ZjIgMTAwNjQ0Cj4gPj4gLS0tIGEvaW5jbHVkZS9kcm0vZHJt X2NsaWVudC5oCj4gPj4gKysrIGIvaW5jbHVkZS9kcm0vZHJtX2NsaWVudC5oCj4gPj4gQEAgLTE1 NCw2ICsxNTQsMTAgQEAgaW50IGRybV9jbGllbnRfbW9kZXNldF9jcmVhdGUoc3RydWN0IGRybV9j bGllbnRfZGV2ICpjbGllbnQpOwo+ID4+ICB2b2lkIGRybV9jbGllbnRfbW9kZXNldF9mcmVlKHN0 cnVjdCBkcm1fY2xpZW50X2RldiAqY2xpZW50KTsKPiA+PiAgdm9pZCBkcm1fY2xpZW50X21vZGVz ZXRfcmVsZWFzZShzdHJ1Y3QgZHJtX2NsaWVudF9kZXYgKmNsaWVudCk7Cj4gPj4gIHN0cnVjdCBk cm1fbW9kZV9zZXQgKmRybV9jbGllbnRfZmluZF9tb2Rlc2V0KHN0cnVjdCBkcm1fY2xpZW50X2Rl diAqY2xpZW50LCBzdHJ1Y3QgZHJtX2NydGMgKmNydGMpOwo+ID4+ICtib29sIGRybV9jbGllbnRf cGFuZWxfcm90YXRpb24oc3RydWN0IGRybV9tb2RlX3NldCAqbW9kZXNldCwgdW5zaWduZWQgaW50 ICpyb3RhdGlvbik7Cj4gPj4gK2ludCBkcm1fY2xpZW50X21vZGVzZXRfY29tbWl0X2ZvcmNlKHN0 cnVjdCBkcm1fY2xpZW50X2RldiAqY2xpZW50KTsKPiA+IAo+ID4gSSB0aGluayBsYXRlc3QgaGVy ZSB0aGUgX2ZvcmNlIHBvc3RmaXggc3RvcHBlZCBtYWtpbmcgc2Vuc2UuIEl0J3MganVzdCBhCj4g PiBjb21taXQuIEFsc28gSSdtIHdvbmRlcmluZyB3aGV0aGVyIHdlIHNob3VsZG4ndCBwdWxsIHRo ZQo+ID4gbWFzdGVyX2FjcXVpcmVfaW50ZXJuYWwgaW50byB0aGVzZSBoZWxwZXJzIGhlcmUsIHRo ZXJlJ3Mgbm90IHJlYWxseSBhCj4gPiB1c2UtY2FzZSBJIGNhbiB0aGluayBvZiB3aGVyZSB3ZSBz aG91bGQgbm90IGNoZWNrIGZvciBvdGhlciBtYXN0ZXJzLgo+ID4gCj4gCj4gZHJtX21hc3Rlcl9p bnRlcm5hbF9hY3F1aXJlKCkgaXMgdXNlZCBpbiB2YXJpb3VzIHBsYWNlcyBpbiBkcm1fZmJfaGVs cGVyCj4gZm9yIGZ1bmN0aW9ucyB0aGF0IGRvZXNuJ3QgbWFrZSBzZW5zZSB0byBtb3ZlIHRvIGRy bV9jbGllbnQsIGxpa2U6Cj4gLSBkcm1fZmJfaGVscGVyX3NldGNtYXAKPiAtIGRybV9mYl9oZWxw ZXJfaW9jdGwKPiAtIGRybV9mYl9oZWxwZXJfcGFuX2Rpc3BsYXkKClNlZSBkaXNjdXNzaW9uIG9u IHRoZSBlYXJsaWVyIHBhdGNoZXMsIEkgY29tcGxldGVseSBiYWNrdHJhY2tlZCBvbiB0aGlzCmFm dGVyIGJldHRlciB1bmRlcnN0YW5kaW5nIHdoeSB3ZSBuZWVkIF9mb3JjZS4KCkFuZCBleHBvcnRp bmcvdXNpbmcgbWFzdGVyX2FjcXVpcmVfaW50ZXJuYWwgYnkgZHJtX2NsaWVudHMgbWFrZXMgdG90 YWwKc2Vuc2UgdG8gbWUuCi1EYW5pZWwKCj4gCj4gTm9yYWxmLgo+IAo+ID4gT25seSB0d28ga2Vy bmVsIG1vZGVzZXQgcmVxdWVzdHMgd2FudCB0byBpZ25vcmUgbWFzdGVyIHN0YXR1czoKPiA+IC0g ZGVidWcgZW50ZXIvbGVhdmUsIHdoaWNoIGlzIHV0dGVybHkgYnJva2VuIGJ5IGRlc2lnbiAoYW5k IG91dHJpZ2h0Cj4gPiAgIGRpc2FibGUgZm9yIGFueSBhdG9taWMgZHJpdmVyKQo+ID4gLSBwYW5p YyBoYW5kbGluZywgZm9yIHdoaWNoIHdlIG5vdyBoYXZlIGEgcmVhbGx5IG5pY2UgcGxhbiwgcGx1 cyBmaXJzdAo+ID4gICBza2V0Y2hlcyBvZiBhbiBpbXBsZW1lbnRhdGlvbi4KPiA+IAo+ID4gQ2hl ZXJzLCBEYW5pZWwKPiA+IAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIElu dGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwt Z2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==