From mboxrd@z Thu Jan  1 00:00:00 1970
From: Imre Deak <imre.deak@intel.com>
Subject: Re: [PATCH] drm/i915/icl: Fix MG_DP_MODE() register
 programming
Date: Fri, 19 Apr 2019 20:01:47 +0300
Message-ID: <20190419170147.GC972@ideak-desk.fi.intel.com>
References: <20190419071026.32370-1-imre.deak@intel.com>
 <a8e59209982585690e185f83f6cf21be85eb4a14.camel@intel.com>
 <20190419160444.GB972@ideak-desk.fi.intel.com>
 <e5f990ed2258f69bd2b3ed77a86750ed83677d58.camel@intel.com>
Reply-To: imre.deak@intel.com
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 28819892B5
 for <intel-gfx@lists.freedesktop.org>; Fri, 19 Apr 2019 17:01:50 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <e5f990ed2258f69bd2b3ed77a86750ed83677d58.camel@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: "Souza, Jose" <jose.souza@intel.com>
Cc: "De Marchi, Lucas" <lucas.demarchi@intel.com>, "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

T24gRnJpLCBBcHIgMTksIDIwMTkgYXQgMDc6Mjk6MDVQTSArMDMwMCwgU291emEsIEpvc2Ugd3Jv
dGU6Cj4gT24gRnJpLCAyMDE5LTA0LTE5IGF0IDE5OjA0ICswMzAwLCBJbXJlIERlYWsgd3JvdGU6
Cj4gPiBPbiBGcmksIEFwciAxOSwgMjAxOSBhdCAwNzowMjoxMFBNICswMzAwLCBTb3V6YSwgSm9z
ZSB3cm90ZToKPiA+ID4gT24gRnJpLCAyMDE5LTA0LTE5IGF0IDEwOjEwICswMzAwLCBJbXJlIERl
YWsgd3JvdGU6Cj4gPiA+ID4gRml4IHRoZSBvcmRlciBvZiBsYW5lLCBwb3J0IHBhcmFtZXRlcnMg
cGFzc2VkIHRvIHRoZSByZWdpc3Rlcgo+ID4gPiA+IG1hY3JvLgo+ID4gPiA+IAo+ID4gPiA+IE5v
dGUgdGhhdCB0aGlzIHdhcyBhbHJlYWR5IHBhcnRseSBmaXhlZCBieSBjb21taXQKPiA+ID4gPiAz
N2ZjNzg0NWRmN2I2ICgiZHJtL2k5MTU6IENhbGwgTUdfRFBfTU9ERSgpIG1hY3JvIHdpdGggdGhl
IHJpZ2h0Cj4gPiA+ID4gcGFyYW1ldGVycyBvcmRlciIpCj4gPiA+ID4gCj4gPiA+ID4gRml4ZXM6
IDU4MTA2YjdkODE2ZTEgKCJkcm0vaTkxNTogTWFrZSBNRyBQSFkgbWFjcm9zIHNlbWFudGljYWxs
eQo+ID4gPiA+IGNvbnNpc3RlbnQiKQo+ID4gPiA+IENjOiBKb3PDqSBSb2JlcnRvIGRlIFNvdXph
IDxqb3NlLnNvdXphQGludGVsLmNvbT4KPiA+ID4gPiBDYzogTHVjYXMgRGUgTWFyY2hpIDxsdWNh
cy5kZW1hcmNoaUBpbnRlbC5jb20+Cj4gPiA+ID4gQ2M6IEFkaXR5YSBTd2FydXAgPGFkaXR5YS5z
d2FydXBAaW50ZWwuY29tPgo+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IEltcmUgRGVhayA8aW1yZS5k
ZWFrQGludGVsLmNvbT4KPiA+ID4gPiAtLS0KPiA+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUv
aW50ZWxfZGRpLmMgfCAxOCArKysrKysrKy0tLS0tLS0tLS0KPiA+ID4gPiAgMSBmaWxlIGNoYW5n
ZWQsIDggaW5zZXJ0aW9ucygrKSwgMTAgZGVsZXRpb25zKC0pCj4gPiA+ID4gCj4gPiA+ID4gZGlm
ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gPiA+ID4gYi9kcml2
ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+ID4gPiA+IGluZGV4IDI0ZjkxMDZlZmNjNi4u
ZjE4MWMyNmY2MmZkIDEwMDY0NAo+ID4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu
dGVsX2RkaS5jCj4gPiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMK
PiA+ID4gPiBAQCAtMjkwNSwyMSArMjkwNSwyMCBAQCBzdGF0aWMgdm9pZAo+ID4gPiA+IGljbF9l
bmFibGVfcGh5X2Nsb2NrX2dhdGluZyhzdHJ1Y3QgaW50ZWxfZGlnaXRhbF9wb3J0ICpkaWdfcG9y
dCkKPiA+ID4gPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUo
ZGlnX3BvcnQtCj4gPiA+ID4gPiBiYXNlLmJhc2UuZGV2KTsKPiA+ID4gPiAgCWVudW0gcG9ydCBw
b3J0ID0gZGlnX3BvcnQtPmJhc2UucG9ydDsKPiA+ID4gPiAgCWVudW0gdGNfcG9ydCB0Y19wb3J0
ID0gaW50ZWxfcG9ydF90b190YyhkZXZfcHJpdiwgcG9ydCk7Cj4gPiA+ID4gLQlpOTE1X3JlZ190
IG1nX3JlZ3NbMl0gPSB7IE1HX0RQX01PREUoMCwgcG9ydCksIE1HX0RQX01PREUoMSwKPiA+ID4g
PiBwb3J0KSB9Owo+ID4gPiA+ICAJdTMyIHZhbDsKPiA+ID4gPiAtCWludCBpOwo+ID4gPiA+ICsJ
aW50IGxuOwo+ID4gPiA+ICAKPiA+ID4gPiAgCWlmICh0Y19wb3J0ID09IFBPUlRfVENfTk9ORSkK
PiA+ID4gPiAgCQlyZXR1cm47Cj4gPiA+ID4gIAo+ID4gPiA+IC0JZm9yIChpID0gMDsgaSA8IEFS
UkFZX1NJWkUobWdfcmVncyk7IGkrKykgewo+ID4gPiA+IC0JCXZhbCA9IEk5MTVfUkVBRChtZ19y
ZWdzW2ldKTsKPiA+ID4gPiArCWZvciAobG4gPSAwOyBsbiA8IDI7IGxuKyspIHsKPiA+ID4gPiAr
CQl2YWwgPSBJOTE1X1JFQUQoTUdfRFBfTU9ERShsbiwgcG9ydCkpOwo+ID4gPiA+ICAJCXZhbCB8
PSBNR19EUF9NT0RFX0NGR19UUjJQV1JfR0FUSU5HIHwKPiA+ID4gPiAgCQkgICAgICAgTUdfRFBf
TU9ERV9DRkdfVFJQV1JfR0FUSU5HIHwKPiA+ID4gPiAgCQkgICAgICAgTUdfRFBfTU9ERV9DRkdf
Q0xOUFdSX0dBVElORyB8Cj4gPiA+ID4gIAkJICAgICAgIE1HX0RQX01PREVfQ0ZHX0RJR1BXUl9H
QVRJTkcgfAo+ID4gPiA+ICAJCSAgICAgICBNR19EUF9NT0RFX0NGR19HQU9OUFdSX0dBVElORzsK
PiA+ID4gPiAtCQlJOTE1X1dSSVRFKG1nX3JlZ3NbaV0sIHZhbCk7Cj4gPiA+ID4gKwkJSTkxNV9X
UklURShNR19EUF9NT0RFKGxuLCBwb3J0KSwgdmFsKTsKPiA+ID4gPiAgCX0KPiA+ID4gPiAgCj4g
PiA+ID4gIAl2YWwgPSBJOTE1X1JFQUQoTUdfTUlTQ19TVVMwKHRjX3BvcnQpKTsKPiA+ID4gPiBA
QCAtMjkzOCwyMSArMjkzNywyMCBAQCBzdGF0aWMgdm9pZAo+ID4gPiA+IGljbF9kaXNhYmxlX3Bo
eV9jbG9ja19nYXRpbmcoc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydCAqZGlnX3BvcnQpCj4gPiA+
ID4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGRpZ19wb3J0
LQo+ID4gPiA+ID4gYmFzZS5iYXNlLmRldik7Cj4gPiA+ID4gIAllbnVtIHBvcnQgcG9ydCA9IGRp
Z19wb3J0LT5iYXNlLnBvcnQ7Cj4gPiA+ID4gIAllbnVtIHRjX3BvcnQgdGNfcG9ydCA9IGludGVs
X3BvcnRfdG9fdGMoZGV2X3ByaXYsIHBvcnQpOwo+ID4gPiA+IC0JaTkxNV9yZWdfdCBtZ19yZWdz
WzJdID0geyBNR19EUF9NT0RFKHBvcnQsIDApLCBNR19EUF9NT0RFKHBvcnQsCj4gPiA+ID4gMSkg
fTsKPiA+ID4gCj4gPiA+IEkgd291bGQgc3BsaXQgdGhpcyBmaXggZnJvbSB0aGUgY2hhbmdlIGRy
b3BwaW5nIG1nX3JlZ3Mgb3IgYXQgbGVhc3QKPiA+ID4gdGVsbCB0aGF0IHdoaWxlIHlvdSB3ZXJl
IGZpeGluZyBpdCB5b3UgY2hhbmdlZCB0aGUgd2F5IGl0IHJlYWRzCj4gPiA+IGVhY2ggTUdfRFBf
TU9ERSBsaW5lLgo+ID4gCj4gPiBJIGRvbid0IHRoaW5rIGl0J3Mgd29ydGggYSBzZXBhcmF0ZSBw
YXRjaCwgc2luY2UgaXQncyBhIHNtYWxsIGNoYW5nZQo+ID4gYW5kIHF1aXRlIG9idmlvdXMgd2hh
dCBhbmQgaG93IGNoYW5nZWQuIEkgY2FuIGFkZCBhIG5vdGUgdG8gdGhlCj4gPiBjb21taXQKPiA+
IG1lc3NhZ2UgYWJvdXQgbWFraW5nIHRoaW5ncyBzaW1wbGVyLgo+IAo+IEkgc3VnZ2VzdGVkIHNw
bGl0IGJlY2F1c2UgdGhpcyB3aWxsIHByb2JhYmx5IGJlIGJhY2twb3J0ZWQgc28gd291bGQgYmUK
PiBuaWNlIHRvIGJlIGFzIGNsZWFuIGFzIHBvc3NpYmxlIGJ1dCBJJ20gYWxzbyBva2F5IGlmIHlv
dSBhZGQgaXQgdG8gdGhlCj4gY29tbWl0IGRlc2NyaXB0aW9uLgoKTm8gbmVlZCB0byBiYWNrcG9y
dCB0aGlzLCB0aGUgcmVncmVzc2luZyBjb21taXQgd29uJ3QgbWFrZSBpdCB0byA1LjEuCkV2ZW4g
aWYgaXQgaGFkIHRoaXMgZml4IHdvdWxkIHN0aWxsIGdvIHRocm91Z2ggLWZpeGVzIHNpbmNlIHdl
J3JlIHN0aWxsCm9ubHkgaW4gLXJjNSwgYW5kIHNvIHdlIHdvdWxkbid0IG5lZWQgdG8gYmFja3Bv
cnQgYW55dGhpbmcuIFNvIHRoaXMKY2hhbmdlIGFsb25nIHdpdGggdGhlIHJlc3Qgb2YgcmVsYXRl
ZCBtYWNybyBwYXJhbSBzaHVmZmxpbmcgcGF0Y2hlcwp3b24ndCBhcHBlYXIgdW50aWwgNS4yLgoK
Rm9yIHRoZSBmdXR1cmU6IGdpdCBmZXRjaCBzdGFibGU7IGdpdCBmZXRjaCBsaW51cy11cHN0cmVh
bSBmb2xsb3dlZCBieQpnaXQgdGFnIC0tY29udGFpbnMgPHJlZ3Jlc3NpbmcgY29tbWl0PiBtYWtl
cyBpdCBlYXN5IHRvIHNlZSBpZiBzb21ldGhpbmcKbmVlZHMgYmFja3BvcnRpbmcuCgo+IAo+ID4g
Cj4gPiA+IAo+ID4gPiA+ICAJdTMyIHZhbDsKPiA+ID4gPiAtCWludCBpOwo+ID4gPiA+ICsJaW50
IGxuOwo+ID4gPiA+ICAKPiA+ID4gPiAgCWlmICh0Y19wb3J0ID09IFBPUlRfVENfTk9ORSkKPiA+
ID4gPiAgCQlyZXR1cm47Cj4gPiA+ID4gIAo+ID4gPiA+IC0JZm9yIChpID0gMDsgaSA8IEFSUkFZ
X1NJWkUobWdfcmVncyk7IGkrKykgewo+ID4gPiA+IC0JCXZhbCA9IEk5MTVfUkVBRChtZ19yZWdz
W2ldKTsKPiA+ID4gPiArCWZvciAobG4gPSAwOyBsbiA8IDI7IGxuKyspIHsKPiA+ID4gPiArCQl2
YWwgPSBJOTE1X1JFQUQoTUdfRFBfTU9ERShsbiwgcG9ydCkpOwo+ID4gPiA+ICAJCXZhbCAmPSB+
KE1HX0RQX01PREVfQ0ZHX1RSMlBXUl9HQVRJTkcgfAo+ID4gPiA+ICAJCQkgTUdfRFBfTU9ERV9D
RkdfVFJQV1JfR0FUSU5HIHwKPiA+ID4gPiAgCQkJIE1HX0RQX01PREVfQ0ZHX0NMTlBXUl9HQVRJ
TkcgfAo+ID4gPiA+ICAJCQkgTUdfRFBfTU9ERV9DRkdfRElHUFdSX0dBVElORyB8Cj4gPiA+ID4g
IAkJCSBNR19EUF9NT0RFX0NGR19HQU9OUFdSX0dBVElORyk7Cj4gPiA+ID4gLQkJSTkxNV9XUklU
RShtZ19yZWdzW2ldLCB2YWwpOwo+ID4gPiA+ICsJCUk5MTVfV1JJVEUoTUdfRFBfTU9ERShsbiwg
cG9ydCksIHZhbCk7Cj4gPiA+ID4gIAl9Cj4gPiA+ID4gIAo+ID4gPiA+ICAJdmFsID0gSTkxNV9S
RUFEKE1HX01JU0NfU1VTMCh0Y19wb3J0KSk7Cj4gPiAKPiA+IAoKCl9fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50
ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y
Zy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==