From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v8] drm/i915/icl: Fix clockgating issue when using scalers Date: Tue, 23 Apr 2019 21:38:48 +0300 Message-ID: <20190423183848.GF1747@intel.com> References: <20190416141404.GH24299@intel.com> <20190417185901.14833-1-radhakrishna.sripada@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id A69B98958E for ; Tue, 23 Apr 2019 18:38:53 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190417185901.14833-1-radhakrishna.sripada@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Radhakrishna Sripada Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBBcHIgMTcsIDIwMTkgYXQgMTE6NTk6MDFBTSAtMDcwMCwgUmFkaGFrcmlzaG5hIFNy aXBhZGEgd3JvdGU6Cj4gRml4ZXMgdGhlIGNsb2NrLWdhdGluZyBpc3N1ZSB3aGVuIHBpcGUgc2Nh bGluZyBpcyBlbmFibGVkLgo+IChMaW5lYWdlICMyMDA2NjA0MzEyKQo+IAo+IFYyOiBGaXggdHlw byBpbiBoZWFkbGluZShDaHJpcykKPiAgICAgSGFuZGxlIHRoZSBub24gZG91YmxlIGJ1ZmZlcmVk IG5hdHVyZSBvZiB0aGUgcmVnaXN0ZXIoVmlsbGUpCj4gVjM6IEZpeCBjaGVja3BhdGNoIHdhcm5p bmcuIEJBVCBmYWlsdXJlIGZvciBWMiBvbiBnZW4zIGxvb2tzIHVucmVsYXRlZC4KPiBWNDogU3Bs aXQgdGhlIGljbCBhbmQgc2tsIHdhJ3MoVmlsbGUpCj4gVjU6IFNwbGl0IHRoZSBjaGVja3MgZm9y IGljbCBhbmQgc2tsKFZpbGxlKQo+IFY2OiBDb3JyZWN0IHRoZSBmbGlwcGVkIGNoZWNrcyBpbiBp bnRlbF9wcmVfcGxhbmVfdXBkYXRlKFZpbGxlKQo+IFY3OiBVc2UgZW51bSBmb3IgcGlwZSBhbmQg ZXh0ZW5kIHRoZSBXQSBmb3IgcGxhbmUgc2NhbGVycyhWaWxsZSkKPiBWODogRWxpbWluYXRlIHRo ZSByZWR1bmRhbnQgdXNlIG9mIHBjaF9wZml0KFZpbGxlKQo+IAo+IENjOiBDaHJpcyBXaWxzb24g PGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogVmlsbGUgU3lyamFsYSA8dmlsbGUuc3ly amFsYUBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGlu dGVsLmNvbT4KPiBDYzogQ2xpbnQgVGF5bG9yIDxjbGludG9uLmEudGF5bG9yQGludGVsLmNvbT4K PiBDYzogQWRpdHlhIFN3YXJ1cCA8YWRpdHlhLnN3YXJ1cEBpbnRlbC5jb20+Cj4gU2lnbmVkLW9m Zi1ieTogUmFkaGFrcmlzaG5hIFNyaXBhZGEgPHJhZGhha3Jpc2huYS5zcmlwYWRhQGludGVsLmNv bT4KClB1c2hlZCB0byBkaW5xLiBUaGFua3MgZm9yIHRoZSBwYXRjaC4KCj4gLS0tCj4gIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDQwICsrKysrKysrKysrKysrKysrKysr KysrKy0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDM1IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25z KC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXku YyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IGluZGV4IDNiZDQwYTRh NjczOS4uZGJkNzY0MGRlODk1IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXku Ywo+IEBAIC00NzYsNiArNDc2LDcgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBpbnRlbF9saW1pdCBp bnRlbF9saW1pdHNfYnh0ID0gewo+ICAJLnAyID0geyAucDJfc2xvdyA9IDEsIC5wMl9mYXN0ID0g MjAgfSwKPiAgfTsKPiAgCj4gKy8qIFdBIERpc3BsYXkgIzA4Mjc6IEdlbjk6YWxsICovCj4gIHN0 YXRpYyB2b2lkCj4gIHNrbF93YV84Mjcoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 LCBpbnQgcGlwZSwgYm9vbCBlbmFibGUpCj4gIHsKPiBAQCAtNDg5LDYgKzQ5MCwxOSBAQCBza2xf d2FfODI3KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgaW50IHBpcGUsIGJvb2wg ZW5hYmxlKQo+ICAJCQkgICB+KERVUFMxX0dBVElOR19ESVMgfCBEVVBTMl9HQVRJTkdfRElTKSk7 Cj4gIH0KPiAgCj4gKy8qIFdhXzIwMDY2MDQzMTI6aWNsICovCj4gK3N0YXRpYyB2b2lkCj4gK2lj bF93YV9zY2FsZXJjbGtnYXRpbmcoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCBl bnVtIHBpcGUgcGlwZSwKPiArCQkgICAgICAgYm9vbCBlbmFibGUpCj4gK3sKPiArCWlmIChlbmFi bGUpCj4gKwkJSTkxNV9XUklURShDTEtHQVRFX0RJU19QU0wocGlwZSksCj4gKwkJCSAgIEk5MTVf UkVBRChDTEtHQVRFX0RJU19QU0wocGlwZSkpIHwgRFBGUl9HQVRJTkdfRElTKTsKPiArCWVsc2UK PiArCQlJOTE1X1dSSVRFKENMS0dBVEVfRElTX1BTTChwaXBlKSwKPiArCQkJICAgSTkxNV9SRUFE KENMS0dBVEVfRElTX1BTTChwaXBlKSkgJiB+RFBGUl9HQVRJTkdfRElTKTsKPiArfQo+ICsKPiAg c3RhdGljIGJvb2wKPiAgbmVlZHNfbW9kZXNldChjb25zdCBzdHJ1Y3QgZHJtX2NydGNfc3RhdGUg KnN0YXRlKQo+ICB7Cj4gQEAgLTU1MDUsNiArNTUxOSwxNiBAQCBzdGF0aWMgYm9vbCBuZWVkc19u djEyX3dhKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCXJldHVybiBmYWxz ZTsKPiAgfQo+ICAKPiArc3RhdGljIGJvb2wgbmVlZHNfc2NhbGVyY2xrX3dhKHN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiArCQkJICAgICAgIGNvbnN0IHN0cnVjdCBpbnRlbF9j cnRjX3N0YXRlICpjcnRjX3N0YXRlKQo+ICt7Cj4gKwkvKiBXYV8yMDA2NjA0MzEyOmljbCAqLwo+ ICsJaWYgKGNydGNfc3RhdGUtPnNjYWxlcl9zdGF0ZS5zY2FsZXJfdXNlcnMgPiAwICYmIElTX0lD RUxBS0UoZGV2X3ByaXYpKQo+ICsJCXJldHVybiB0cnVlOwo+ICsKPiArCXJldHVybiBmYWxzZTsK PiArfQo+ICsKPiAgc3RhdGljIHZvaWQgaW50ZWxfcG9zdF9wbGFuZV91cGRhdGUoc3RydWN0IGlu dGVsX2NydGNfc3RhdGUgKm9sZF9jcnRjX3N0YXRlKQo+ICB7Cj4gIAlzdHJ1Y3QgaW50ZWxfY3J0 YyAqY3J0YyA9IHRvX2ludGVsX2NydGMob2xkX2NydGNfc3RhdGUtPmJhc2UuY3J0Yyk7Cj4gQEAg LTU1MzgsMTEgKzU1NjIsMTMgQEAgc3RhdGljIHZvaWQgaW50ZWxfcG9zdF9wbGFuZV91cGRhdGUo c3RydWN0IGludGVsX2NydGNfc3RhdGUgKm9sZF9jcnRjX3N0YXRlKQo+ICAJCQlpbnRlbF9wb3N0 X2VuYWJsZV9wcmltYXJ5KCZjcnRjLT5iYXNlLCBwaXBlX2NvbmZpZyk7Cj4gIAl9Cj4gIAo+IC0J LyogRGlzcGxheSBXQSA4MjcgKi8KPiAgCWlmIChuZWVkc19udjEyX3dhKGRldl9wcml2LCBvbGRf Y3J0Y19zdGF0ZSkgJiYKPiAtCSAgICAhbmVlZHNfbnYxMl93YShkZXZfcHJpdiwgcGlwZV9jb25m aWcpKSB7Cj4gKwkgICAgIW5lZWRzX252MTJfd2EoZGV2X3ByaXYsIHBpcGVfY29uZmlnKSkKPiAg CQlza2xfd2FfODI3KGRldl9wcml2LCBjcnRjLT5waXBlLCBmYWxzZSk7Cj4gLQl9Cj4gKwo+ICsJ aWYgKG5lZWRzX3NjYWxlcmNsa193YShkZXZfcHJpdiwgb2xkX2NydGNfc3RhdGUpICYmCj4gKwkg ICAgIW5lZWRzX3NjYWxlcmNsa193YShkZXZfcHJpdiwgcGlwZV9jb25maWcpKQo+ICsJCWljbF93 YV9zY2FsZXJjbGtnYXRpbmcoZGV2X3ByaXYsIGNydGMtPnBpcGUsIGZhbHNlKTsKPiAgfQo+ICAK PiAgc3RhdGljIHZvaWQgaW50ZWxfcHJlX3BsYW5lX3VwZGF0ZShzdHJ1Y3QgaW50ZWxfY3J0Y19z dGF0ZSAqb2xkX2NydGNfc3RhdGUsCj4gQEAgLTU1NzksOSArNTYwNSwxMyBAQCBzdGF0aWMgdm9p ZCBpbnRlbF9wcmVfcGxhbmVfdXBkYXRlKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpvbGRfY3J0 Y19zdGF0ZSwKPiAgCj4gIAkvKiBEaXNwbGF5IFdBIDgyNyAqLwo+ICAJaWYgKCFuZWVkc19udjEy X3dhKGRldl9wcml2LCBvbGRfY3J0Y19zdGF0ZSkgJiYKPiAtCSAgICBuZWVkc19udjEyX3dhKGRl dl9wcml2LCBwaXBlX2NvbmZpZykpIHsKPiArCSAgICBuZWVkc19udjEyX3dhKGRldl9wcml2LCBw aXBlX2NvbmZpZykpCj4gIAkJc2tsX3dhXzgyNyhkZXZfcHJpdiwgY3J0Yy0+cGlwZSwgdHJ1ZSk7 Cj4gLQl9Cj4gKwo+ICsJLyogV2FfMjAwNjYwNDMxMjppY2wgKi8KPiArCWlmICghbmVlZHNfc2Nh bGVyY2xrX3dhKGRldl9wcml2LCBvbGRfY3J0Y19zdGF0ZSkgJiYKPiArCSAgICBuZWVkc19zY2Fs ZXJjbGtfd2EoZGV2X3ByaXYsIHBpcGVfY29uZmlnKSkKPiArCQlpY2xfd2Ffc2NhbGVyY2xrZ2F0 aW5nKGRldl9wcml2LCBjcnRjLT5waXBlLCB0cnVlKTsKPiAgCj4gIAkvKgo+ICAJICogVmJsYW5r IHRpbWUgdXBkYXRlcyBmcm9tIHRoZSBzaGFkb3cgdG8gbGl2ZSBwbGFuZSBjb250cm9sIHJlZ2lz dGVyCj4gLS0gCj4gMi4yMC4wLnJjMi43Lmc5NjU3OThkMWYyOTkKCi0tIApWaWxsZSBTeXJqw6Rs w6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4